46694 2010-09-27 20:52:41 -0700 commit-queue should reject patches that fail to land 2010-09-27 21:45:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth commit-queue eric oldest_to_newest 286034 0 abarth 2010-09-27 20:52:41 -0700 commit-queue should reject patches that fail to land 286035 1 69015 abarth 2010-09-27 20:53:47 -0700 Created attachment 69015 Patch 286050 2 69015 eric 2010-09-27 21:28:31 -0700 Comment on attachment 69015 Patch This is really subtle. This feels like a design error. 286054 3 69015 commit-queue 2010-09-27 21:45:36 -0700 Comment on attachment 69015 Patch Clearing flags on attachment: 69015 Committed r68484: <http://trac.webkit.org/changeset/68484> 286055 4 commit-queue 2010-09-27 21:45:41 -0700 All reviewed patches have been landed. Closing bug. 69015 2010-09-27 20:53:47 -0700 2010-09-27 21:45:35 -0700 Patch bug-46694-20100927205346.patch text/plain 2283 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAwNjcwYTU0NTJiY2M2ODc2OTg0ZjE2YjNjNmMzZThiOTM5OTg0ZGQ1Li45ZWMwYjRk Mjc3YmQ5MTkyZDkzODQ1OTgyODlhYTg0Yzg3MDM1MjI0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMDktMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjb21taXQtcXVldWUgc2hvdWxk IHJlamVjdCBwYXRjaGVzIHRoYXQgZmFpbCB0byBsYW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjY5NAorCisgICAgICAgIFRoaXMgY2FuIGhhcHBl biwgZm9yIGV4YW1wbGUsIGlmIHRoZXJlJ3Mgbm8gcmV2aWV3ZXIuICBXaXRob3V0IHRoaXMKKyAg ICAgICAgcGF0Y2gsIHdlJ2xsIGtlZXAgcmV0cnlpbmcgdGhlIHBhdGNoLgorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9jb21taXRxdWV1ZXRhc2sucHk6CisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9jb21taXRxdWV1ZXRhc2tfdW5pdHRlc3QucHk6CisK IDIwMTAtMDktMjcgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9ib3QvY29tbWl0cXVldWV0YXNrLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL2JvdC9jb21taXRxdWV1ZXRhc2sucHkKaW5kZXggNTAzOTg4NTNiMjEy MTk0NDBjYzM2YjY0NjUxN2QyY2IyZmM0MTY5NC4uYTM0Nzk3MmJmMjZkZjNjMGI5OWVhYWQwM2Uz MmJhYThlNGIzOWUxYiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL2JvdC9jb21taXRxdWV1ZXRhc2sucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS90b29sL2JvdC9jb21taXRxdWV1ZXRhc2sucHkKQEAgLTE1Myw0ICsxNTMsNiBAQCBjbGFz cyBDb21taXRRdWV1ZVRhc2sob2JqZWN0KToKICAgICAgICAgIyBubyBvbmUgaGFzIHNldCBjb21t aXQtcXVldWUtIHNpbmNlIHdlIHN0YXJ0ZWQgd29ya2luZyBvbiB0aGUgcGF0Y2guKQogICAgICAg ICBpZiBub3Qgc2VsZi5fdmFsaWRhdGUoKToKICAgICAgICAgICAgIHJldHVybiBGYWxzZQotICAg ICAgICByZXR1cm4gc2VsZi5fbGFuZCgpCisgICAgICAgIGlmIG5vdCBzZWxmLl9sYW5kKCk6Cisg ICAgICAgICAgICByYWlzZSBzZWxmLl9zY3JpcHRfZXJyb3IKKyAgICAgICAgcmV0dXJuIFRydWUK ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvY29tbWl0 cXVldWV0YXNrX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L2JvdC9jb21taXRxdWV1ZXRhc2tfdW5pdHRlc3QucHkKaW5kZXggNmI3NWRhNDA1MjllZDBlYWZk ODg4ODI1ZmVlYjY5NzVmMWRmZDcwMi4uOGI0NjE0NjAxNjMxMmJkOTkzYTlkNTdlYjc1ZTU4NjU2 Y2M0ZDJhMSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2Jv dC9jb21taXRxdWV1ZXRhc2tfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS90b29sL2JvdC9jb21taXRxdWV1ZXRhc2tfdW5pdHRlc3QucHkKQEAgLTE5MSw0ICsx OTEsNCBAQCBjb21tYW5kX3Bhc3NlZDogc3VjY2Vzc19tZXNzYWdlPSdQYXNzZWQgdGVzdHMnIHBh dGNoPScxOTcnCiBydW5fd2Via2l0X3BhdGNoOiBbJ2xhbmQtYXR0YWNobWVudCcsICctLWZvcmNl LWNsZWFuJywgJy0taWdub3JlLWJ1aWxkZXJzJywgJy0tcXVpZXQnLCAnLS1ub24taW50ZXJhY3Rp dmUnLCAnLS1wYXJlbnQtY29tbWFuZD1jb21taXQtcXVldWUnLCAxOTddCiBjb21tYW5kX2ZhaWxl ZDogZmFpbHVyZV9tZXNzYWdlPSdVbmFibGUgdG8gbGFuZCBwYXRjaCcgc2NyaXB0X2Vycm9yPSdN T0NLIGxhbmQgZmFpbHVyZScgcGF0Y2g9JzE5NycKICIiIgotICAgICAgICBzZWxmLl9ydW5fdGhy b3VnaF90YXNrKGNvbW1pdF9xdWV1ZSwgZXhwZWN0ZWRfc3RkZXJyKQorICAgICAgICBzZWxmLl9y dW5fdGhyb3VnaF90YXNrKGNvbW1pdF9xdWV1ZSwgZXhwZWN0ZWRfc3RkZXJyLCBTY3JpcHRFcnJv cikK