46691 2010-09-27 19:58:47 -0700 [EFL] Use fast malloc for WebKit EFL 2010-10-04 20:38:14 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gyuyoung.kim webkit-unassigned abarth antognolli+webkit commit-queue kenneth leandro lucas.de.marchi tonikitoo oldest_to_newest 286022 0 gyuyoung.kim 2010-09-27 19:58:47 -0700 FastMalloc is to allocate memory quickly. I think we need to use fast malloc as well. 286065 1 69021 gyuyoung.kim 2010-09-27 22:23:00 -0700 Created attachment 69021 Patch 286178 2 lucas.de.marchi 2010-09-28 04:37:44 -0700 Looks good to me. However I wonder how fast it is. Does anyone have some benchmarks? Do other ports use it by default? 286691 3 gyuyoung.kim 2010-09-28 18:41:30 -0700 WebKit-GTK uses the fast malloc. However, android port, brewmp port and HAIKU port don't use it. I don't know if mac port, iphone use the fast malloc. According to QT port guys in seged univ, fast malloc based on TCMalloc is about 2 ~ 4% faster than system malloc. http://webkit.sed.hu/node/23 In addition, the fast malloc is good for multi-thread environment. Because, TCMalloc in the fast malloc has thread local cache per thread. http://goog-perftools.sourceforge.net/doc/tcmalloc.html 286756 4 69021 zoltan 2010-09-29 00:05:52 -0700 Comment on attachment 69021 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69021&action=review Qt, Mac, Gtk, etc. ports use TCmalloc. > cmake/OptionsEfl.cmake:57 > +WEBKIT_FEATURE(ENABLE_FAST_MALLOC "Enable fast memory allocation" DEFAULT ON) It would be better to reflect the switching between system's default allocator and TCmalloc. E.g. Enable TCmalloc instead of system's allocator 286761 5 69166 gyuyoung.kim 2010-09-29 00:19:48 -0700 Created attachment 69166 Patch Ok, I change the description according to your opinion. I also think that this description reflects correct information. 287972 6 gyuyoung.kim 2010-09-30 18:02:51 -0700 Hello Kenneth and Antonio, If you are not busy, could you please review this bug? 289369 7 69166 abarth 2010-10-04 20:38:08 -0700 Comment on attachment 69166 Patch Clearing flags on attachment: 69166 Committed r69060: <http://trac.webkit.org/changeset/69060> 289370 8 abarth 2010-10-04 20:38:14 -0700 All reviewed patches have been landed. Closing bug. 69021 2010-09-27 22:23:00 -0700 2010-09-29 00:19:48 -0700 Patch patch-fast-malloc.txt text/plain 2347 gyuyoung.kim ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyNDY4ZTAxLi43NGIxNWI3 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDktMjcgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRUZMXSBVc2Ug ZmFzdCBtYWxsb2MgZm9yIFdlYktpdCBFRkwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ2NjkxCisKKyAgICAgICAgVXNlIGZhc3QgbWFsbG9jIGZvciBX ZWJLaXQgRUZMIGJlY2F1c2UgdGhlIGZhc3QgbWFsbG9jIGlzIHRvIGFsbG9jYXRlCisgICAgICAg IG1lbW9yeSBxdWlja2x5LgorCisgICAgICAgICogY21ha2UvT3B0aW9uc0VmbC5jbWFrZToKKwog MjAxMC0wOS0yNyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDRjMmUyMjYu LmNkNzBlZjMgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0yNyAgR3l1eW91 bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIFVzZSBmYXN0IG1hbGxvYyBmb3IgV2Vi S2l0IEVGTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDY2OTEKKworICAgICAgICBVc2UgZmFzdCBtYWxsb2MgZm9yIFdlYktpdCBFRkwgYmVjYXVzZSB0 aGUgZmFzdCBtYWxsb2MgaXMgdG8gYWxsb2NhdGUKKyAgICAgICAgbWVtb3J5IHF1aWNrbHkuCisK KyAgICAgICAgKiB3dGYvQ01ha2VMaXN0c0VmbC50eHQ6CisKIDIwMTAtMDktMjcgIEdhdmluIEJh cnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL0NNYWtlTGlzdHNF ZmwudHh0IGIvSmF2YVNjcmlwdENvcmUvd3RmL0NNYWtlTGlzdHNFZmwudHh0CmluZGV4IDZhNzE0 YWUuLmE1MzdkMGYgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9DTWFrZUxpc3RzRWZs LnR4dAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvQ01ha2VMaXN0c0VmbC50eHQKQEAgLTEsNCAr MSwxMCBAQAotQUREX0RFRklOSVRJT05TKC1EVVNFX1NZU1RFTV9NQUxMT0M9MSkKK0lGIChFTkFC TEVfRkFTVF9NQUxMT0MpCisgIExJU1QoQVBQRU5EIFdURl9TT1VSQ0VTCisgICAgVENTeXN0ZW1B bGxvYy5jcHAKKyAgKQorRUxTRSAoKQorICBBRERfREVGSU5JVElPTlMoLURVU0VfU1lTVEVNX01B TExPQz0xKQorRU5ESUYoKQogCiBMSVNUKEFQUEVORCBXVEZfU09VUkNFUwogICAgIGVmbC9NYWlu VGhyZWFkRWZsLmNwcApkaWZmIC0tZ2l0IGEvY21ha2UvT3B0aW9uc0VmbC5jbWFrZSBiL2NtYWtl L09wdGlvbnNFZmwuY21ha2UKaW5kZXggNmI0YzJmNC4uNjkzZGZiMSAxMDA2NDQKLS0tIGEvY21h a2UvT3B0aW9uc0VmbC5jbWFrZQorKysgYi9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC01NCw2 ICs1NCw3IEBAIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9EQVRBR1JJRCAiRW5hYmxlIGRhdGFncmlk IiBERUZBVUxUIE9GRikKIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9EQVRBTElTVCAiRW5hYmxlIGRh dGFsaXN0IiBERUZBVUxUIE9OIEhUTUwpCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVfRE9NX1NUT1JB R0UgIkVuYWJsZSBET00gc3RvcmFnZSIgREVGQVVMVCBPTikKIFdFQktJVF9GRUFUVVJFKEVOQUJM RV9FVkVOVFNPVVJDRSAiRW5hYmxlIGV2ZW50IHNvdXJjZSIgREVGQVVMVCBPTikKK1dFQktJVF9G RUFUVVJFKEVOQUJMRV9GQVNUX01BTExPQyAiRW5hYmxlIGZhc3QgbWVtb3J5IGFsbG9jYXRpb24i IERFRkFVTFQgT04pCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVfRkFTVF9NT0JJTEVfU0NST0xMSU5H ICJFbmFibGUgZmFzdCBtb2JpbGUgc2Nyb2xsaW5nIiBERUZBVUxUIE9OKQogV0VCS0lUX0ZFQVRV UkUoRU5BQkxFX0ZJTFRFUlMgIkVuYWJsZSBTVkcgZmlsdGVycyIgREVGQVVMVCBPTiBTVkcpCiBX RUJLSVRfRkVBVFVSRShFTkFCTEVfR0VPTE9DQVRJT04gIkVuYWJsZSBnZW9sb2NhdGlvbiIgREVG QVVMVCBPRkYpCg== 69166 2010-09-29 00:19:48 -0700 2010-10-04 20:38:08 -0700 Patch patch-fast-malloc.txt text/plain 2363 gyuyoung.kim ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyNDY4ZTAxLi43NGIxNWI3 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDktMjcgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRUZMXSBVc2Ug ZmFzdCBtYWxsb2MgZm9yIFdlYktpdCBFRkwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ2NjkxCisKKyAgICAgICAgVXNlIGZhc3QgbWFsbG9jIGZvciBX ZWJLaXQgRUZMIGJlY2F1c2UgdGhlIGZhc3QgbWFsbG9jIGlzIHRvIGFsbG9jYXRlCisgICAgICAg IG1lbW9yeSBxdWlja2x5LgorCisgICAgICAgICogY21ha2UvT3B0aW9uc0VmbC5jbWFrZToKKwog MjAxMC0wOS0yNyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDRjMmUyMjYu LmNkNzBlZjMgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0yNyAgR3l1eW91 bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIFVzZSBmYXN0IG1hbGxvYyBmb3IgV2Vi S2l0IEVGTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDY2OTEKKworICAgICAgICBVc2UgZmFzdCBtYWxsb2MgZm9yIFdlYktpdCBFRkwgYmVjYXVzZSB0 aGUgZmFzdCBtYWxsb2MgaXMgdG8gYWxsb2NhdGUKKyAgICAgICAgbWVtb3J5IHF1aWNrbHkuCisK KyAgICAgICAgKiB3dGYvQ01ha2VMaXN0c0VmbC50eHQ6CisKIDIwMTAtMDktMjcgIEdhdmluIEJh cnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL0NNYWtlTGlzdHNF ZmwudHh0IGIvSmF2YVNjcmlwdENvcmUvd3RmL0NNYWtlTGlzdHNFZmwudHh0CmluZGV4IDZhNzE0 YWUuLmE1MzdkMGYgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9DTWFrZUxpc3RzRWZs LnR4dAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvQ01ha2VMaXN0c0VmbC50eHQKQEAgLTEsNCAr MSwxMCBAQAotQUREX0RFRklOSVRJT05TKC1EVVNFX1NZU1RFTV9NQUxMT0M9MSkKK0lGIChFTkFC TEVfRkFTVF9NQUxMT0MpCisgIExJU1QoQVBQRU5EIFdURl9TT1VSQ0VTCisgICAgVENTeXN0ZW1B bGxvYy5jcHAKKyAgKQorRUxTRSAoKQorICBBRERfREVGSU5JVElPTlMoLURVU0VfU1lTVEVNX01B TExPQz0xKQorRU5ESUYoKQogCiBMSVNUKEFQUEVORCBXVEZfU09VUkNFUwogICAgIGVmbC9NYWlu VGhyZWFkRWZsLmNwcApkaWZmIC0tZ2l0IGEvY21ha2UvT3B0aW9uc0VmbC5jbWFrZSBiL2NtYWtl L09wdGlvbnNFZmwuY21ha2UKaW5kZXggNmI0YzJmNC4uNWFjMTkyYyAxMDA2NDQKLS0tIGEvY21h a2UvT3B0aW9uc0VmbC5jbWFrZQorKysgYi9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC01NCw2 ICs1NCw3IEBAIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9EQVRBR1JJRCAiRW5hYmxlIGRhdGFncmlk IiBERUZBVUxUIE9GRikKIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9EQVRBTElTVCAiRW5hYmxlIGRh dGFsaXN0IiBERUZBVUxUIE9OIEhUTUwpCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVfRE9NX1NUT1JB R0UgIkVuYWJsZSBET00gc3RvcmFnZSIgREVGQVVMVCBPTikKIFdFQktJVF9GRUFUVVJFKEVOQUJM RV9FVkVOVFNPVVJDRSAiRW5hYmxlIGV2ZW50IHNvdXJjZSIgREVGQVVMVCBPTikKK1dFQktJVF9G RUFUVVJFKEVOQUJMRV9GQVNUX01BTExPQyAiRW5hYmxlIFRDbWFsbG9jIGluc3RlYWQgb2Ygc3lz dGVtJ3MgYWxsb2NhdG9yIiBERUZBVUxUIE9OKQogV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX0ZBU1Rf TU9CSUxFX1NDUk9MTElORyAiRW5hYmxlIGZhc3QgbW9iaWxlIHNjcm9sbGluZyIgREVGQVVMVCBP TikKIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9GSUxURVJTICJFbmFibGUgU1ZHIGZpbHRlcnMiIERF RkFVTFQgT04gU1ZHKQogV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX0dFT0xPQ0FUSU9OICJFbmFibGUg Z2VvbG9jYXRpb24iIERFRkFVTFQgT0ZGKQo=