46689 2010-09-27 19:32:29 -0700 [v8] fast/dom/HTMLElement/class-list.html fails 2010-09-29 14:01:56 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 morrita arv antonm dglazkov japhet morrita tkent oldest_to_newest 286016 0 morrita 2010-09-27 19:32:29 -0700 It's flaky on chromium buildbot. 286087 1 arv 2010-09-27 23:23:30 -0700 I only managed to reproduce this on DRT (it does not happen on TestShell nor Chromium). I should try it on The test tests the following: assert(classList[-1] === undefined); assert(classList[-1] === undefined); However, the second call incorrectly triggers the indexed getter which should return null for UInt32 that are larger than the length - 1. Why this happens on the second call is a mystery to me. I haven't been able to get a debugger attached to DRT. I would really appreciate some help from someone with some V8 binding foo. 286095 2 tkent 2010-09-27 23:38:12 -0700 Is it flaky? It looks 100% fail. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=class-list.html&useWebKitCanary=true 286137 3 antonm 2010-09-28 02:49:32 -0700 (In reply to comment #1) > I only managed to reproduce this on DRT (it does not happen on TestShell nor Chromium). I should try it on > > The test tests the following: > > assert(classList[-1] === undefined); > assert(classList[-1] === undefined); > > However, the second call incorrectly triggers the indexed getter which should return null for UInt32 that are larger than the length - 1. Why this happens on the second call is a mystery to me. I haven't been able to get a debugger attached to DRT. What is the platform? > > I would really appreciate some help from someone with some V8 binding foo. Is it the exact JS code which triggers the problem? v8 might compile different code if the code is in a loop, for example. If you could send a minimal test case in JS with instructions how to run it, I'll try to debug it on my box. I'd try to see (with printf unless there will be found the way to attach a debugger) the whole stack: how v8 invokes the callback (we should go either via runtime or small compiled stub). In any event, Erik, feel free to ping me on IM, I'd be glad to help. 286232 4 69050 arv 2010-09-28 08:01:54 -0700 Created attachment 69050 Test case 286235 5 antonm 2010-09-28 08:04:11 -0700 (In reply to comment #4) > Created an attachment (id=69050) [details] > Test case It looks empty 286237 6 arv 2010-09-28 08:06:49 -0700 This happens on all platforms according to http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=class-list.html&useWebKitCanary=true I only managed to repro this using DRT and it works as expected on TestShell and Chromium (I'm on a Mac). 286238 7 arv 2010-09-28 08:08:30 -0700 (In reply to comment #5) > (In reply to comment #4) > > Created an attachment (id=69050) [details] [details] > > Test case > > It looks empty You need a build from yesterday or you'll see script errors. However I managed to reproduce this with MediaList. I'll add another test that shows the same bug with a media list. 286245 8 69052 arv 2010-09-28 08:11:46 -0700 Created attachment 69052 Another related test This shows that MediaList has the same indexed getter bug in DRT as DOMTokenList. 286855 9 antonm 2010-09-29 07:08:37 -0700 It's actually V8 issue. The cure should be on the way: http://codereview.chromium.org/3520006/show 286903 10 antonm 2010-09-29 09:09:13 -0700 https://code.google.com/p/v8/source/detail?r=5553 committed to bleeding_edge, should reach Chromium ToT early next week (if everything goes smooth). r5554--5556 brings the fix to various v8 branches and should eventually go into Chrome 7 and maybe even Chrome 6. Erik, may you check if this fixes the issue and close the bug if it's the case? 287110 11 arv 2010-09-29 14:01:56 -0700 I verified that the fix works. 69050 2010-09-28 08:01:54 -0700 2010-09-28 08:01:54 -0700 Test case class-list-indexed-getter-bug.html text/html 263 arv PCFET0NUWVBFIGh0bWw+CjxwcmUgaWQ9b3V0PjwvcHJlPgo8c2NyaXB0PgpmdW5jdGlvbiBwcmlu dChzKSB7CiAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ291dCcpLmFwcGVuZENoaWxkKGRvY3Vt ZW50LmNyZWF0ZVRleHROb2RlKHMgKyAnXG4nKSk7Cn0KCnZhciBlbGVtZW50ID0gZG9jdW1lbnQu Y3JlYXRlRWxlbWVudCgnZGl2Jyk7CnByaW50KGVsZW1lbnQuY2xhc3NMaXN0Wy0xXSk7CnByaW50 KGVsZW1lbnQuY2xhc3NMaXN0Wy0xXSk7Cgo8L3NjcmlwdD4= 69052 2010-09-28 08:11:46 -0700 2010-09-28 08:11:46 -0700 Another related test media-list-indexed-getter-bug.html text/html 332 arv PCFET0NUWVBFIGh0bWw+CjxzdHlsZT48L3N0eWxlPgoKPHA+VGhpcyBzaG91bGQgcHJpbnQgdW5k ZWZpbmVkIGFuZCB1bmRlZmluZWQuPC9wPgo8aHI+Cgo8cHJlIGlkPW91dD48L3ByZT4KPHNjcmlw dD4KZnVuY3Rpb24gcHJpbnQocykgewogIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdvdXQnKS5h cHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZShzICsgJ1xuJykpOwp9Cgp2YXIgc3R5 bGVTaGVldCA9IGRvY3VtZW50LnN0eWxlU2hlZXRzWzBdOwpwcmludChzdHlsZVNoZWV0Lm1lZGlh Wy0xXSk7CnByaW50KHN0eWxlU2hlZXQubWVkaWFbLTFdKTsKCjwvc2NyaXB0Pgo=