46681 2010-09-27 17:25:40 -0700 Fix possible illegal float values in AudioParam 2010-09-28 10:31:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 crogers webkit-unassigned cmarrin commit-queue dglazkov eric.carlson jamesr jer.noble kbr simon.fraser oldest_to_newest 285941 0 crogers 2010-09-27 17:25:40 -0700 Fix possible illegal float values in AudioParam 285943 1 68997 crogers 2010-09-27 17:27:54 -0700 Created attachment 68997 Patch 286236 2 68997 kbr 2010-09-28 08:06:25 -0700 Comment on attachment 68997 Patch Looks OK. I wonder about the spec text indicating that an exception is raised if the value is outside the min and max values, and about whether the value should be set to 0.0 if NaN or +/-Inf come in. 286326 3 crogers 2010-09-28 10:09:33 -0700 I think ultimately we'll want to raise an exception (but not set the value to 0). But for now, this is much better protection than we previously had. 286351 4 68997 commit-queue 2010-09-28 10:31:42 -0700 Comment on attachment 68997 Patch Clearing flags on attachment: 68997 Committed r68535: <http://trac.webkit.org/changeset/68535> 286352 5 commit-queue 2010-09-28 10:31:48 -0700 All reviewed patches have been landed. Closing bug. 68997 2010-09-27 17:27:54 -0700 2010-09-28 10:31:42 -0700 Patch bug-46681-20100927172753.patch text/plain 1301 crogers SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODQ1NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMjcgIENocmlzIFJvZ2VycyAgPGNyb2dlcnNAZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggcG9zc2libGUgaWxsZWdhbCBmbG9hdCB2YWx1ZXMgaW4gQXVkaW9QYXJhbQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY2ODEKKworICAgICAgICBO byBuZXcgdGVzdHMgc2luY2UgYXVkaW8gQVBJIGlzIG5vdCB5ZXQgaW1wbGVtZW50ZWQuCisKKyAg ICAgICAgKiB3ZWJhdWRpby9BdWRpb1BhcmFtLmg6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb1Bh cmFtOjpzZXRWYWx1ZSk6CisKIDIwMTAtMDktMjcgIFZpY3RvcmlhIEtpcnN0ICA8dnJrQGdvb2ds ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmFtZXMgUm9iaW5zb24uCkluZGV4OiBXZWJD b3JlL3dlYmF1ZGlvL0F1ZGlvUGFyYW0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3dlYmF1ZGlv L0F1ZGlvUGFyYW0uaAkocmV2aXNpb24gNjY5NDApCisrKyBXZWJDb3JlL3dlYmF1ZGlvL0F1ZGlv UGFyYW0uaAkod29ya2luZyBjb3B5KQpAQCAtNjAsNyArNjAsMTQgQEAgcHVibGljOgogICAgIH0K IAogICAgIGZsb2F0IHZhbHVlKCkgY29uc3QgeyByZXR1cm4gc3RhdGljX2Nhc3Q8ZmxvYXQ+KG1f dmFsdWUpOyB9Ci0gICAgdm9pZCBzZXRWYWx1ZShmbG9hdCB2YWx1ZSkgeyBtX3ZhbHVlID0gdmFs dWU7IH0KKyAgICAKKyAgICB2b2lkIHNldFZhbHVlKGZsb2F0IHZhbHVlKQorICAgIHsKKyAgICAg ICAgLy8gQ2hlY2sgYWdhaW5zdCBKYXZhU2NyaXB0IGdpdmluZyB1cyBib2d1cyBmbG9hdGluZy1w b2ludCB2YWx1ZXMuCisgICAgICAgIC8vIERvbid0IEFTU0VSVCwgc2luY2UgdGhpcyBjYW4gaGFw cGVuIGlmIHNvbWVib2R5IHdyaXRlcyBiYWQgSlMuCisgICAgICAgIGlmICghaXNuYW4odmFsdWUp ICYmICFpc2luZih2YWx1ZSkpCisgICAgICAgICAgICBtX3ZhbHVlID0gdmFsdWU7CisgICAgfQog CiAgICAgU3RyaW5nIG5hbWUoKSBjb25zdCB7IHJldHVybiBtX25hbWU7IH0KIAo=