46674 2010-09-27 16:50:12 -0700 queue-status should report when the patch was last locked to a queue 2010-09-27 17:14:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth aroben oldest_to_newest 285899 0 eric 2010-09-27 16:50:12 -0700 queue-status should report when the patch was last locked to a queue 285901 1 68991 eric 2010-09-27 16:53:01 -0700 Created attachment 68991 Patch 285902 2 eric 2010-09-27 16:53:40 -0700 We really need testing for more of this code. I'm not sure how to wire QueueStatusServer into webkitpy, but I can try. 285918 3 68991 abarth 2010-09-27 17:02:34 -0700 Comment on attachment 68991 Patch ok 285929 4 eric 2010-09-27 17:14:43 -0700 Committed r68453: <http://trac.webkit.org/changeset/68453> 68991 2010-09-27 16:53:01 -0700 2010-09-27 17:02:34 -0700 Patch bug-46674-20100927165259.patch text/plain 6639 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlYmI0ODFhODMwNGJmMTZiZjhkYTEyNzBmYWNjN2NhYjBmMGYzMzU1Li5kMTQ3Y2I3 MzYxNGFmNTFkODgxODZjNzliM2RjNDQwOTYyZGYyOTViIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUgQEAK IDIwMTAtMDktMjcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHF1ZXVlLXN0YXR1cyBzaG91bGQg cmVwb3J0IHdoZW4gdGhlIHBhdGNoIHdhcyBsYXN0IGxvY2tlZCB0byBhIHF1ZXVlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjY3NAorCisgICAgICAg IFRoaXMgaXNuJ3QgbmVjZXNzYXJpbHkgdGhlIGJlc3Qgd2F5IHRvIGV4cG9zZSB0aGlzIGluZm9y bWF0aW9uCisgICAgICAgIGJ1dCBoYXZpbmcgdGhpcyBhY2Nlc3NpYmxlIHZpYSB0aGUgd2ViIGlu dGVyZmFjZSBpcyB2ZXJ5CisgICAgICAgIHVzZWZ1bCB1bnRpbCB3ZSBjb21lIHVwIHdpdGggYSBu aWNlciB3YXkgdG8gZGlzcGxheSB0aGlzLgorCisgICAgICAgIEkgYWxzbyBjbGVhbmVkIHVwIHRo ZSBjb2RlIGluIGFjdGl2ZXdvcmtpdGVtcy5weSBhIGxpdHRsZQorICAgICAgICB0byB1c2UgbGlz dCBjb21wcmVoZW5zaW9ucyBhbmQgdG8gaGF2ZSB0aGUgY29kZSB3b3JrIHdpdGgKKyAgICAgICAg cGFpcnMgaW5zdGVhZCBvZiB0d28gbGlzdHMgYXQgb25jZS4gIEV2ZW50dWFsbHkgSSB0aGluayB0 aG9zZQorICAgICAgICBpdGVtL3RpbWUgcGFpcnMgbmVlZCB0byBiZSB0aGVpciBvd24gbGl0dGxl IGhlbHBlciBjbGFzcy4KKworICAgICAgICAqIFF1ZXVlU3RhdHVzU2VydmVyL2hhbmRsZXJzL3F1 ZXVlc3RhdHVzLnB5OgorICAgICAgICAqIFF1ZXVlU3RhdHVzU2VydmVyL21vZGVsL2FjdGl2ZXdv cmtpdGVtcy5weToKKyAgICAgICAgKiBRdWV1ZVN0YXR1c1NlcnZlci90ZW1wbGF0ZXMvcXVldWVz dGF0dXMuaHRtbDoKKworMjAxMC0wOS0yNyAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+ CisKICAgICAgICAgUmV2aWV3ZWQgYnkgSmFtZXMgUm9iaW5zb24uCiAKICAgICAgICAgc3RhcnQt Y29tbWl0LXF1ZXVlIHNob3VsZCBhYm9ydCBhbnkgcmViYXNlcyBpbiBwcm9ncmVzcwpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvaGFuZGxlcnMvcXVldWVzdGF0dXMu cHkgYi9XZWJLaXRUb29scy9RdWV1ZVN0YXR1c1NlcnZlci9oYW5kbGVycy9xdWV1ZXN0YXR1cy5w eQppbmRleCBmNzYxNTdkN2M4MzVmMTAwZDRiZjgwMTFjM2E4NTVlNTdiMmE0NTAzLi4wMjU5YzM3 MWE1NDFmZTY1MjliZDMxNGM2NWI5NTc1NjJiYjgzODgwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9RdWV1ZVN0YXR1c1NlcnZlci9oYW5kbGVycy9xdWV1ZXN0YXR1cy5weQorKysgYi9XZWJLaXRU b29scy9RdWV1ZVN0YXR1c1NlcnZlci9oYW5kbGVycy9xdWV1ZXN0YXR1cy5weQpAQCAtMzEsMjQg KzMxLDI3IEBAIGZyb20gZ29vZ2xlLmFwcGVuZ2luZS5leHQud2ViYXBwIGltcG9ydCB0ZW1wbGF0 ZQogCiBmcm9tIG1vZGVsLnF1ZXVlcyBpbXBvcnQgcXVldWVzLCBkaXNwbGF5X25hbWVfZm9yX3F1 ZXVlCiBmcm9tIG1vZGVsLndvcmtpdGVtcyBpbXBvcnQgV29ya0l0ZW1zCitmcm9tIG1vZGVsLmFj dGl2ZXdvcmtpdGVtcyBpbXBvcnQgQWN0aXZlV29ya0l0ZW1zCiAKIGZyb20gbW9kZWwgaW1wb3J0 IHF1ZXVlc3RhdHVzCiAKIAogY2xhc3MgUXVldWVTdGF0dXMod2ViYXBwLlJlcXVlc3RIYW5kbGVy KToKLSAgICBkZWYgX3Jvd3NfZm9yX3dvcmtfaXRlbXMoc2VsZiwgd29ya19pdGVtcyk6Ci0gICAg ICAgIGlmIG5vdCB3b3JrX2l0ZW1zOgorICAgIGRlZiBfcm93c19mb3Jfd29ya19pdGVtcyhzZWxm LCBxdWV1ZWRfaXRlbXMsIGFjdGl2ZV9pdGVtcyk6CisgICAgICAgIGlmIG5vdCBxdWV1ZWRfaXRl bXM6CiAgICAgICAgICAgICByZXR1cm4gW10KICAgICAgICAgcm93cyA9IFtdCi0gICAgICAgIGZv ciBpdGVtX2lkIGluIHdvcmtfaXRlbXMuaXRlbV9pZHM6CisgICAgICAgIGZvciBpdGVtX2lkIGlu IHF1ZXVlZF9pdGVtcy5pdGVtX2lkczoKICAgICAgICAgICAgIHJvd3MuYXBwZW5kKHsKICAgICAg ICAgICAgICAgICAiYXR0YWNobWVudF9pZCI6IGl0ZW1faWQsCiAgICAgICAgICAgICAgICAgImJ1 Z19pZCI6IDEsCisgICAgICAgICAgICAgICAgImxvY2tfdGltZSI6IGFjdGl2ZV9pdGVtcyBhbmQg YWN0aXZlX2l0ZW1zLnRpbWVfZm9yX2l0ZW0oaXRlbV9pZCksCiAgICAgICAgICAgICB9KQogICAg ICAgICByZXR1cm4gcm93cwogCiAgICAgZGVmIGdldChzZWxmLCBxdWV1ZV9uYW1lKToKLSAgICAg ICAgd29ya19pdGVtcyA9IFdvcmtJdGVtcy5hbGwoKS5maWx0ZXIoInF1ZXVlX25hbWUgPSIsIHF1 ZXVlX25hbWUpLmdldCgpCisgICAgICAgIHF1ZXVlZF9pdGVtcyA9IFdvcmtJdGVtcy5hbGwoKS5m aWx0ZXIoInF1ZXVlX25hbWUgPSIsIHF1ZXVlX25hbWUpLmdldCgpCisgICAgICAgIGFjdGl2ZV9p dGVtcyA9IEFjdGl2ZVdvcmtJdGVtcy5hbGwoKS5maWx0ZXIoInF1ZXVlX25hbWUgPSIsIHF1ZXVl X25hbWUpLmdldCgpCiAgICAgICAgIHN0YXR1c2VzID0gcXVldWVzdGF0dXMuUXVldWVTdGF0dXMu YWxsKCkuZmlsdGVyKCJxdWV1ZV9uYW1lID0iLCBxdWV1ZV9uYW1lKS5vcmRlcigiLWRhdGUiKS5m ZXRjaCgxNSkKIAogICAgICAgICBzdGF0dXNfZ3JvdXBzID0gW10KQEAgLTY3LDcgKzcwLDcgQEAg Y2xhc3MgUXVldWVTdGF0dXMod2ViYXBwLlJlcXVlc3RIYW5kbGVyKToKIAogICAgICAgICB0ZW1w bGF0ZV92YWx1ZXMgPSB7CiAgICAgICAgICAgICAiZGlzcGxheV9xdWV1ZV9uYW1lIjogZGlzcGxh eV9uYW1lX2Zvcl9xdWV1ZShxdWV1ZV9uYW1lKSwKLSAgICAgICAgICAgICJ3b3JrX2l0ZW1fcm93 cyI6IHNlbGYuX3Jvd3NfZm9yX3dvcmtfaXRlbXMod29ya19pdGVtcyksCisgICAgICAgICAgICAi d29ya19pdGVtX3Jvd3MiOiBzZWxmLl9yb3dzX2Zvcl93b3JrX2l0ZW1zKHF1ZXVlZF9pdGVtcywg YWN0aXZlX2l0ZW1zKSwKICAgICAgICAgICAgICJzdGF0dXNfZ3JvdXBzIjogc3RhdHVzX2dyb3Vw cywKICAgICAgICAgfQogICAgICAgICBzZWxmLnJlc3BvbnNlLm91dC53cml0ZSh0ZW1wbGF0ZS5y ZW5kZXIoInRlbXBsYXRlcy9xdWV1ZXN0YXR1cy5odG1sIiwgdGVtcGxhdGVfdmFsdWVzKSkKZGlm ZiAtLWdpdCBhL1dlYktpdFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL21vZGVsL2FjdGl2ZXdvcmtp dGVtcy5weSBiL1dlYktpdFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL21vZGVsL2FjdGl2ZXdvcmtp dGVtcy5weQppbmRleCBlMjRlNmNhNDhiMTMyYjk0NzE4Y2QxMzYxNzM4NjVjZjE3NzFlNDU4Li4z OTk5YzkyOTViNTBmMTM5MjFiMDUwMDMzOGQxZDMwMGJkYTY5Mjg4IDEwMDY0NAotLS0gYS9XZWJL aXRUb29scy9RdWV1ZVN0YXR1c1NlcnZlci9tb2RlbC9hY3RpdmV3b3JraXRlbXMucHkKKysrIGIv V2ViS2l0VG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvbW9kZWwvYWN0aXZld29ya2l0ZW1zLnB5CkBA IC0yOCw3ICsyOCw3IEBACiAKIGZyb20gZ29vZ2xlLmFwcGVuZ2luZS5leHQgaW1wb3J0IGRiCiAK LWZyb20gZGF0ZXRpbWUgaW1wb3J0IHRpbWVkZWx0YQorZnJvbSBkYXRldGltZSBpbXBvcnQgdGlt ZWRlbHRhLCBkYXRldGltZQogaW1wb3J0IHRpbWUKIAogCkBAIC0zOCwyMSArMzgsMzUgQEAgY2xh c3MgQWN0aXZlV29ya0l0ZW1zKGRiLk1vZGVsKToKICAgICBpdGVtX2RhdGVzID0gZGIuTGlzdFBy b3BlcnR5KGZsb2F0KQogICAgIGRhdGUgPSBkYi5EYXRlVGltZVByb3BlcnR5KGF1dG9fbm93X2Fk ZD1UcnVlKQogCisgICAgIyBUaGUgaWQvZGF0ZSBwYWlycyBzaG91bGQgcHJvYmFibHkganVzdCBi ZSB0aGVpciBvd24gY2xhc3MuCisgICAgZGVmIF9pdGVtX3RpbWVfcGFpcnMoc2VsZik6CisgICAg ICAgIHJldHVybiB6aXAoc2VsZi5pdGVtX2lkcywgc2VsZi5pdGVtX2RhdGVzKQorCisgICAgZGVm IF9zZXRfaXRlbV90aW1lX3BhaXJzKHNlbGYsIHBhaXJzKToKKyAgICAgICAgaWYgbm90IHBhaXJz OgorICAgICAgICAgICAgc2VsZi5pdGVtX2lkcyA9IFtdCisgICAgICAgICAgICBzZWxmLml0ZW1f ZGF0ZXMgPSBbXQorICAgICAgICAgICAgcmV0dXJuCisgICAgICAgIHNlbGYuaXRlbV9pZHMsIHNl bGYuaXRlbV9kYXRlcyA9IHppcCgqcGFpcnMpCisKKyAgICBkZWYgX2FwcGVuZF9pdGVtX3RpbWVf cGFpcihzZWxmLCBwYWlyKToKKyAgICAgICAgc2VsZi5pdGVtX2lkcy5hcHBlbmQocGFpclswXSkK KyAgICAgICAgc2VsZi5pdGVtX2RhdGVzLmFwcGVuZChwYWlyWzFdKQorCiAgICAgZGVmIGRlYWN0 aXZhdGVfZXhwaXJlZChzZWxmLCBub3cpOgogICAgICAgICBvbmVfaG91cl9hZ28gPSB0aW1lLm1r dGltZSgobm93IC0gdGltZWRlbHRhKG1pbnV0ZXM9NjApKS50aW1ldHVwbGUoKSkKLSAgICAgICAg bm9uZXhwaXJlZF9pdGVtX2lkcyA9IFtdCi0gICAgICAgIG5vbmV4cGlyZWRfaXRlbV9kYXRlcyA9 IFtdCi0gICAgICAgIGZvciBpIGluIHJhbmdlKGxlbihzZWxmLml0ZW1faWRzKSk6Ci0gICAgICAg ICAgICBpZiBzZWxmLml0ZW1fZGF0ZXNbaV0gPiBvbmVfaG91cl9hZ286Ci0gICAgICAgICAgICAg ICAgbm9uZXhwaXJlZF9pdGVtX2lkcy5hcHBlbmQoc2VsZi5pdGVtX2lkc1tpXSkKLSAgICAgICAg ICAgICAgICBub25leHBpcmVkX2l0ZW1fZGF0ZXMuYXBwZW5kKHNlbGYuaXRlbV9kYXRlc1tpXSkK LSAgICAgICAgc2VsZi5pdGVtX2lkcyA9IG5vbmV4cGlyZWRfaXRlbV9pZHMKLSAgICAgICAgc2Vs Zi5pdGVtX2RhdGVzID0gbm9uZXhwaXJlZF9pdGVtX2RhdGVzCisgICAgICAgIG5vbmV4cGlyZWRf cGFpcnMgPSBbcGFpciBmb3IgcGFpciBpbiBzZWxmLl9pdGVtX3RpbWVfcGFpcnMoKSBpZiBwYWly WzFdID4gb25lX2hvdXJfYWdvXQorICAgICAgICBzZWxmLl9zZXRfaXRlbV90aW1lX3BhaXJzKG5v bmV4cGlyZWRfcGFpcnMpCiAKICAgICBkZWYgbmV4dF9pdGVtKHNlbGYsIHdvcmtfaXRlbV9pZHMs IG5vdyk6CiAgICAgICAgIGZvciBpdGVtX2lkIGluIHdvcmtfaXRlbV9pZHM6CiAgICAgICAgICAg ICBpZiBpdGVtX2lkIG5vdCBpbiBzZWxmLml0ZW1faWRzOgotICAgICAgICAgICAgICAgIHNlbGYu aXRlbV9pZHMuYXBwZW5kKGl0ZW1faWQpCi0gICAgICAgICAgICAgICAgc2VsZi5pdGVtX2RhdGVz LmFwcGVuZCh0aW1lLm1rdGltZShub3cudGltZXR1cGxlKCkpKQorICAgICAgICAgICAgICAgIHNl bGYuX2FwcGVuZF9pdGVtX3RpbWVfcGFpcihbaXRlbV9pZCwgdGltZS5ta3RpbWUobm93LnRpbWV0 dXBsZSgpKV0pCiAgICAgICAgICAgICAgICAgcmV0dXJuIGl0ZW1faWQKICAgICAgICAgcmV0dXJu IE5vbmUKKworICAgIGRlZiB0aW1lX2Zvcl9pdGVtKHNlbGYsIGl0ZW1faWQpOgorICAgICAgICBm b3IgYWN0aXZlX2l0ZW1faWQsIHRpbWUgaW4gc2VsZi5faXRlbV90aW1lX3BhaXJzKCk6CisgICAg ICAgICAgICBpZiBhY3RpdmVfaXRlbV9pZCA9PSBpdGVtX2lkOgorICAgICAgICAgICAgICAgIHJl dHVybiBkYXRldGltZS5mcm9tdGltZXN0YW1wKHRpbWUpCisgICAgICAgIHJldHVybiBOb25lCmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9RdWV1ZVN0YXR1c1NlcnZlci90ZW1wbGF0ZXMvcXVldWVz dGF0dXMuaHRtbCBiL1dlYktpdFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL3RlbXBsYXRlcy9xdWV1 ZXN0YXR1cy5odG1sCmluZGV4IGQyZDcyYzc0MDU3OGNmNDZhZTg3MzIwMjE5OWFhZWQ0NmYyMjA3 NTUuLjRkNzk3YmJkMzVkZjE5NmQ0NjU5NjkzMmU2MjM1NDc1OTY2ZWYxNzEgMTAwNjQ0Ci0tLSBh L1dlYktpdFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL3RlbXBsYXRlcy9xdWV1ZXN0YXR1cy5odG1s CisrKyBiL1dlYktpdFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL3RlbXBsYXRlcy9xdWV1ZXN0YXR1 cy5odG1sCkBAIC00MiwxMyArNDIsMjAgQEAKIAogPGgzPlBhdGNoZXMgaW4gcXVldWU8L2gzPgog PHRhYmxlPgotICAgIDx0cj48dGg+UG9zaXRpb248L3RoPjx0aD5QYXRjaDwvdGg+PC90cj4KKyAg ICA8dHI+PHRoPlBvc2l0aW9uPC90aD48dGg+UGF0Y2g8L3RoPjx0aD5MYXN0IEFjdGl2aXR5PC90 aD48L3RyPgogICAgIHslIGZvciByb3cgaW4gd29ya19pdGVtX3Jvd3MgJX0KICAgICA8dHI+CiAg ICAgICAgIDx0ZD4je3sgZm9ybG9vcC5jb3VudGVyIH19PC90ZD4KICAgICAgICAgPHRkPgogICAg ICAgICAgIHt7IHJvdy5hdHRhY2htZW50X2lkfGZvcmNlX2VzY2FwZXx3ZWJraXRfYXR0YWNobWVu dF9pZHxzYWZlIH19CiAgICAgICAgIDwvdGQ+CisgICAgICAgIDx0ZD4KKyAgICAgICAgICAgIHsl IGlmIHJvdy5sb2NrX3RpbWUgJX0KKyAgICAgICAgICAgICAgICB7eyByb3cubG9ja190aW1lfHRp bWVzaW5jZSB9fSBhZ28KKyAgICAgICAgICAgIHslIGVsc2UgJX0KKyAgICAgICAgICAgICAgICBu ZXZlcgorICAgICAgICAgICAgeyUgZW5kaWYgJX0KKyAgICAgICAgPC90ZD4KICAgICA8L3RyPgog ICAgIHslIGVuZGZvciAlfQogPC90YWJsZT4K