46670 2010-09-27 16:08:04 -0700 check-webkit-style should check for explicit constructors. 2013-03-13 20:13:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED INVALID P2 Minor --- 1 levin levin abarth oldest_to_newest 285846 0 levin 2010-09-27 16:08:04 -0700 Based on this thread: https://lists.webkit.org/pipermail/webkit-dev/2010-May/012873.html 285854 1 68987 levin 2010-09-27 16:11:46 -0700 Created attachment 68987 Patch 285858 2 68987 darin 2010-09-27 16:15:51 -0700 Comment on attachment 68987 Patch This doesn’t seem like a style rule to me. 285861 3 levin 2010-09-27 16:24:43 -0700 (In reply to comment #2) > (From update of attachment 68987 [details]) > This doesn’t seem like a style rule to me. So you don't believe that this should be flagged in general. I've noticed some folks noting this in reviews for patches, and in general it seems like a good practice to mark single argument constructors as explicit unless there is a good reason to do otherwise. It seemed in keeping with this comment: https://lists.webkit.org/pipermail/webkit-dev/2010-May/012876.html In fairness, this comment https://lists.webkit.org/pipermail/webkit-dev/2010-May/012881.html seemed to suggest a lot more modest use of explicit. 286422 4 68987 levin 2010-09-28 11:59:58 -0700 Comment on attachment 68987 Patch Withdrawn for now. 68987 2010-09-27 16:11:46 -0700 2010-09-28 11:59:57 -0700 Patch bug-46670-20100927161145.patch text/plain 5289 levin ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5N2E5YThiNmVjZjlhZjU4OGM3MDc4OGJjMjE5NzE5NWI0MzQ5ZWM4Li40NTk3MDFl ZmFiNTA1MmYxOWYzZGYxNWIzMDk4NzJjYjAxN2UzNjIxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMDktMjcgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHls ZSBzaG91bGQgY2hlY2sgZm9yIGV4cGxpY2l0IGNvbnN0cnVjdG9ycy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2NjcwCisKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHk6IEVuYWJsZSB0aGUgZXhwbGljaXQgdGVzdC4K KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weTogQ2hhbmdl IHRoZSB3YXJuaW5nIHRleHQgdG8gbWF0Y2ggV2ViS2l0J3MgZ3VpZGVsaW5lLgorICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OiBGaXggdGhl IHVuaXQgdGVzdCBkdWUgdG8gdGhlIHRleHQgY2hhbmdlLgorCiAyMDEwLTA5LTE3ICBNYXJ0aW4g Um9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBP bGl2ZXIgSHVudC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY2hlY2tlci5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl ci5weQppbmRleCBmOGVlZmE0NDAxYTg0OTg4MmFlNjAxYTg4OThjZGNkYzFiYjFlZTUxLi4wZTg1 NDhmNDg2ZDg2MDNlNTk2NWUzYWYxMjdlMTNiNTIxYTU5YTEzIDEwMDY0NAotLS0gYS9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKKysrIGIvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CkBAIC04MCw3ICs4MCw2IEBAIF9CQVNF X0ZJTFRFUl9SVUxFUyA9IFsKICAgICAnLXJ1bnRpbWUvYXJyYXlzJywgICMgdmFyaWFibGUgbGVu Z3RoIGFycmF5CiAgICAgJy1ydW50aW1lL2Nhc3RpbmcnLAogICAgICctcnVudGltZS9zaXplb2Yn LAotICAgICctcnVudGltZS9leHBsaWNpdCcsICAjIGV4cGxpY2l0CiAgICAgJy1ydW50aW1lL3Zp cnR1YWwnLCAgIyB2aXJ0dWFsIGR0b3IKICAgICAnLXJ1bnRpbWUvcHJpbnRmJywKICAgICAnLXJ1 bnRpbWUvdGhyZWFkc2FmZV9mbicsCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CmluZGV4IGY4ZWJlZmYyMGIzZTJlZmY4YzNlY2U4MDFj ZWM5YmVlNjhkMWY5NWQuLmU5MThhYjUzZTMyNWI1ODZmMzNkZmEyNDRkMGU4ODA5MzE0ZTIyOGQg MTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwLnB5CkBAIC0xMDAyLDcgKzEwMDIsOSBAQCBkZWYgY2hlY2tfZm9yX25vbl9zdGFuZGFyZF9j b25zdHJ1Y3RzKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwKICAgICAgICAgYW5kIG5vdCBtYXRj aChyJyhjb25zdFxzKyk/JXNccyomJyAlIHJlLmVzY2FwZShiYXNlX2NsYXNzbmFtZSksCiAgICAg ICAgICAgICAgICAgICAgICAgYXJncy5ncm91cCgxKS5zdHJpcCgpKSk6CiAgICAgICAgIGVycm9y KGxpbmVfbnVtYmVyLCAncnVudGltZS9leHBsaWNpdCcsIDUsCi0gICAgICAgICAgICAgICdTaW5n bGUtYXJndW1lbnQgY29uc3RydWN0b3JzIHNob3VsZCBiZSBtYXJrZWQgZXhwbGljaXQuJykKKyAg ICAgICAgICAgICAgJ0ZyZXF1ZW50bHksIHNpbmdsZS1hcmd1bWVudCBjb25zdHJ1Y3RvcnMgc2hv dWxkIGJlIG1hcmtlZCAnCisgICAgICAgICAgICAgICdleHBsaWNpdCAoaHR0cHM6Ly9saXN0cy53 ZWJraXQub3JnL3BpcGVybWFpbC93ZWJraXQtZGV2LzIwMTAtTWF5JworICAgICAgICAgICAgICAn LzAxMjg4MS5odG1sKS4nKQogCiAgICAgIyBMb29rIGZvciBtZXRob2RzIGRlY2xhcmVkIHZpcnR1 YWwuCiAgICAgaWYgc2VhcmNoKHInXGJ2aXJ0dWFsXGInLCBsaW5lKToKZGlmZiAtLWdpdCBhL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5 IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRl c3QucHkKaW5kZXggMmY1NDMwNWUwMTEyMWFhYThiZWVhZGYyNzQ2NTY2YjEwODVhY2VlYS4uZmJj ODU2OTc0N2I3ZGI4MWMwMDA2Y2RkZTNkYmVmMzQzZTJhYzRkMiAxMDA2NDQKLS0tIGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKKysr IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRl c3QucHkKQEAgLTcyNSw0OSArNzI1LDQ3IEBAIGNsYXNzIENwcFN0eWxlVGVzdChDcHBTdHlsZVRl c3RCYXNlKToKIAogICAgICMgVGVzdCBub24tZXhwbGljaXQgc2luZ2xlLWFyZ3VtZW50IGNvbnN0 cnVjdG9ycwogICAgIGRlZiB0ZXN0X2V4cGxpY2l0X3NpbmdsZV9hcmd1bWVudF9jb25zdHJ1Y3Rv cnMoc2VsZik6CisgICAgICAgIGV4cGxpY2l0X3dhcm5pbmcgPSAoJ0ZyZXF1ZW50bHksIHNpbmds ZS1hcmd1bWVudCBjb25zdHJ1Y3RvcnMgc2hvdWxkIGJlJworICAgICAgICAgICAgICAgICAgICAg ICAgICAgICcgbWFya2VkIGV4cGxpY2l0IChodHRwczovL2xpc3RzLndlYmtpdC5vcmcvcGlwZXJt YScKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAnaWwvd2Via2l0LWRldi8yMDEwLU1heS8w MTI4ODEuaHRtbCkuICAnCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ1tydW50aW1lL2V4 cGxpY2l0XSBbNV0nKQogICAgICAgICAjIG1pc3NpbmcgZXhwbGljaXQgaXMgYmFkCiAgICAgICAg IHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKICAgICAgICAgICAgICcnJ2NsYXNzIEZvbyB7 CiAgICAgICAgICAgICAgICAgIEZvbyhpbnQgZik7CiAgICAgICAgICAgICAgICB9OycnJywKLSAg ICAgICAgICAgICdTaW5nbGUtYXJndW1lbnQgY29uc3RydWN0b3JzIHNob3VsZCBiZSBtYXJrZWQg ZXhwbGljaXQuJwotICAgICAgICAgICAgJyAgW3J1bnRpbWUvZXhwbGljaXRdIFs1XScpCisgICAg ICAgICAgICBleHBsaWNpdF93YXJuaW5nKQogICAgICAgICAjIG1pc3NpbmcgZXhwbGljaXQgaXMg YmFkLCBldmVuIHdpdGggd2hpdGVzcGFjZQogICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5l X2xpbnQoCiAgICAgICAgICAgICAnJydjbGFzcyBGb28gewogICAgICAgICAgICAgICAgICBGb28g KGludCBmKTsKICAgICAgICAgICAgICAgIH07JycnLAogICAgICAgICAgICAgWydFeHRyYSBzcGFj ZSBiZWZvcmUgKCBpbiBmdW5jdGlvbiBjYWxsICBbd2hpdGVzcGFjZS9wYXJlbnNdIFs0XScsCi0g ICAgICAgICAgICAgJ1NpbmdsZS1hcmd1bWVudCBjb25zdHJ1Y3RvcnMgc2hvdWxkIGJlIG1hcmtl ZCBleHBsaWNpdC4nCi0gICAgICAgICAgICAgJyAgW3J1bnRpbWUvZXhwbGljaXRdIFs1XSddKQor ICAgICAgICAgICAgIGV4cGxpY2l0X3dhcm5pbmddKQogICAgICAgICAjIG1pc3NpbmcgZXhwbGlj aXQsIHdpdGggZGlzdHJhY3RpbmcgY29tbWVudCwgaXMgc3RpbGwgYmFkCiAgICAgICAgIHNlbGYu YXNzZXJ0X211bHRpX2xpbmVfbGludCgKICAgICAgICAgICAgICcnJ2NsYXNzIEZvbyB7CiAgICAg ICAgICAgICAgICAgIEZvbyhpbnQgZik7IC8vIHNpbXBsZXIgdGhhbiBGb28oYmxhcmdoLCBibGFy ZykKICAgICAgICAgICAgICAgIH07JycnLAotICAgICAgICAgICAgJ1NpbmdsZS1hcmd1bWVudCBj b25zdHJ1Y3RvcnMgc2hvdWxkIGJlIG1hcmtlZCBleHBsaWNpdC4nCi0gICAgICAgICAgICAnICBb cnVudGltZS9leHBsaWNpdF0gWzVdJykKKyAgICAgICAgICAgIGV4cGxpY2l0X3dhcm5pbmcpCiAg ICAgICAgICMgbWlzc2luZyBleHBsaWNpdCwgd2l0aCBxdWFsaWZpZWQgY2xhc3NuYW1lCiAgICAg ICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKICAgICAgICAgICAgICcnJ2NsYXNzIFF1 YWxpZmllcjo6QW5vdGhlck9uZTo6Rm9vIHsKICAgICAgICAgICAgICAgICAgRm9vKGludCBmKTsK ICAgICAgICAgICAgICAgIH07JycnLAotICAgICAgICAgICAgJ1NpbmdsZS1hcmd1bWVudCBjb25z dHJ1Y3RvcnMgc2hvdWxkIGJlIG1hcmtlZCBleHBsaWNpdC4nCi0gICAgICAgICAgICAnICBbcnVu dGltZS9leHBsaWNpdF0gWzVdJykKKyAgICAgICAgICAgIGV4cGxpY2l0X3dhcm5pbmcpCiAgICAg ICAgICMgc3RydWN0cyBhcmUgY2F1Z2h0IGFzIHdlbGwuCiAgICAgICAgIHNlbGYuYXNzZXJ0X211 bHRpX2xpbmVfbGludCgKICAgICAgICAgICAgICcnJ3N0cnVjdCBGb28gewogICAgICAgICAgICAg ICAgICBGb28oaW50IGYpOwogICAgICAgICAgICAgICAgfTsnJycsCi0gICAgICAgICAgICAnU2lu Z2xlLWFyZ3VtZW50IGNvbnN0cnVjdG9ycyBzaG91bGQgYmUgbWFya2VkIGV4cGxpY2l0LicKLSAg ICAgICAgICAgICcgIFtydW50aW1lL2V4cGxpY2l0XSBbNV0nKQorICAgICAgICAgICAgZXhwbGlj aXRfd2FybmluZykKICAgICAgICAgIyBUZW1wbGF0aXplZCBjbGFzc2VzIGFyZSBjYXVnaHQgYXMg d2VsbC4KICAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAogICAgICAgICAgICAg JycndGVtcGxhdGU8dHlwZW5hbWUgVD4gY2xhc3MgRm9vIHsKICAgICAgICAgICAgICAgICAgRm9v KGludCBmKTsKICAgICAgICAgICAgICAgIH07JycnLAotICAgICAgICAgICAgJ1NpbmdsZS1hcmd1 bWVudCBjb25zdHJ1Y3RvcnMgc2hvdWxkIGJlIG1hcmtlZCBleHBsaWNpdC4nCi0gICAgICAgICAg ICAnICBbcnVudGltZS9leHBsaWNpdF0gWzVdJykKKyAgICAgICAgICAgIGV4cGxpY2l0X3dhcm5p bmcpCiAgICAgICAgICMgcHJvcGVyIHN0eWxlIGlzIG9rYXkKICAgICAgICAgc2VsZi5hc3NlcnRf bXVsdGlfbGluZV9saW50KAogICAgICAgICAgICAgJycnY2xhc3MgRm9vIHsK