46651 2010-09-27 14:15:10 -0700 [chromium] fix detection of missing fonts on DRT 2010-09-27 17:06:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony evan tkent oldest_to_newest 285736 0 tony 2010-09-27 14:15:10 -0700 [chromium] fix detection of missing fonts on DRT 285740 1 68956 tony 2010-09-27 14:18:09 -0700 Created attachment 68956 Patch 285747 2 tony 2010-09-27 14:26:16 -0700 This doesn't impact the tests running, but it makes the error message less confusing. 285813 3 evan 2010-09-27 15:39:02 -0700 LGTM 285897 4 68956 levin 2010-09-27 16:50:04 -0700 Comment on attachment 68956 Patch I'm reluctant to set cq+ on this because it is is a chromium gtk only change, and you can commit changes. The cq does not error catching for you here so setting cq+ just means that this may get landed when you aren't around and if it has problems, someone else has to work it out. So I'll leave setting cq+ for you to do if/when you think it is prudent. 285905 5 68956 tony 2010-09-27 16:54:33 -0700 Comment on attachment 68956 Patch No worries. I will land manually and watch the tree. I wasn't sure if the r+ would happen when I wasn't around. 285921 6 tony 2010-09-27 17:06:30 -0700 Committed r68451: <http://trac.webkit.org/changeset/68451> 68956 2010-09-27 14:18:09 -0700 2010-09-27 16:54:32 -0700 Patch bug-46651-20100927141814.patch text/plain 2514 tony ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhYzNjYzM1N2IyNTA0Y2U0NWZlMmMwMzZlMDcxYjhmNDEyNzM0MWM2Li5jZWQ5ODAy MTgyMmE0ZmFlYzI2OTk3MmNmYWFhZjdjOTkwMTYzMGI1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDktMjcgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIGZpeCBkZXRl Y3Rpb24gb2YgbWlzc2luZyBmb250cyBvbiBEUlQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2NjUxCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9j aHJvbWl1bS9UZXN0U2hlbGxHdGsuY3BwOgorICAgICAgICAoc2V0dXBGb250Y29uZmlnKTogIE9u bHkgcHJpbnQgYW4gZXJyb3IgbWVzc2FnZSBpZiBsb2hpdCBpc24ndCBmb3VuZCBpbiBib3RoIGxv Y2F0aW9ucy4KKwogMjAxMC0wOS0xOCAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxp YS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhIFNpbHZhLgpkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsR3Rr LmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbEd0ay5j cHAKaW5kZXggNjA0MDhiOTQwOWJlNWYwOWFjZTk1ZjkxZTUxMTdhODE5Y2M2MTdhMi4uMWNmN2M1 NjBkN2Y4OTliYTA2MWM0YmU3ZGM5ZGI1ZmUzNzQ4ZWRlOSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsR3RrLmNwcAorKysgYi9XZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGxHdGsuY3BwCkBAIC0xMzQsMjIg KzEzNCwyMyBAQCBzdGF0aWMgdm9pZCBzZXR1cEZvbnRjb25maWcoKQogICAgIC8vIGZldyBsYXlv dXQgdGVzdHMuCiAgICAgc3RhdGljIGNvbnN0IGNoYXIqIGNvbnN0IG9wdGlvbmFsRm9udHNbXSA9 IHsKICAgICAgICAgIi91c3Ivc2hhcmUvZm9udHMvdHJ1ZXR5cGUvdHRmLWx1Y2lkYS9MdWNpZGFT YW5zUmVndWxhci50dGYiLAotCi0gICAgICAgIC8vIFRoaXMgZm9udCBjaGFuZ2VkIHBhdGhzIGFj cm9zcyBVYnVudHUgcmVsZWFzZXMuCiAgICAgICAgICIvdXNyL3NoYXJlL2ZvbnRzL3RydWV0eXBl L3R0Zi1pbmRpYy1mb250cy1jb3JlL2xvaGl0X3BhLnR0ZiIsCi0gICAgICAgICIvdXNyL3NoYXJl L2ZvbnRzL3RydWV0eXBlL3R0Zi1wdW5qYWJpLWZvbnRzL2xvaGl0X3BhLnR0ZiIsCiAgICAgfTsK ICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGFycmF5c2l6ZShvcHRpb25hbEZvbnRzKTsgKytp KSB7CiAgICAgICAgIGNvbnN0IGNoYXIqIGZvbnQgPSBvcHRpb25hbEZvbnRzW2ldOworCisgICAg ICAgIC8vIFRoaXMgZm9udCBjaGFuZ2VkIHBhdGhzIGFjcm9zcyBVYnVudHUgcmVsZWFzZXMsIHNv IHRyeSBjaGVja2luZyBpbiBib3RoIGxvY2F0aW9ucy4KKyAgICAgICAgaWYgKCFzdHJjbXAoZm9u dCwgIi91c3Ivc2hhcmUvZm9udHMvdHJ1ZXR5cGUvdHRmLWluZGljLWZvbnRzLWNvcmUvbG9oaXRf cGEudHRmIikKKyAgICAgICAgICAgICYmIGFjY2Vzcyhmb250LCBSX09LKSA8IDApCisgICAgICAg ICAgICBmb250ID0gIi91c3Ivc2hhcmUvZm9udHMvdHJ1ZXR5cGUvdHRmLXB1bmphYmktZm9udHMv bG9oaXRfcGEudHRmIjsKKwogICAgICAgICBpZiAoYWNjZXNzKGZvbnQsIFJfT0spIDwgMCkgewog ICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICJZb3UgYXJlIG1pc3NpbmcgJXMuIFdpdGhvdXQg dGhpcywgc29tZSBsYXlvdXQgdGVzdHMgbWF5IGZhaWwuICIKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAiU2VlIGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC9jaHJvbWl1bS93aWtpL0xpbnV4 QnVpbGRJbnN0cnVjdGlvbnNQcmVyZXF1aXNpdGVzICIKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAiZm9yIG1vcmUuXG4iLCBmb250KTsKLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAg IGlmICghRmNDb25maWdBcHBGb250QWRkRmlsZShmb250Y2ZnLCAoRmNDaGFyOCAqKSBmb250KSkg ewotICAgICAgICAgICAgICAgIGZwcmludGYoc3RkZXJyLCAiRmFpbGVkIHRvIGxvYWQgZm9udCAl c1xuIiwgZm9udCk7Ci0gICAgICAgICAgICAgICAgZXhpdCgxKTsKLSAgICAgICAgICAgIH0KKyAg ICAgICAgfSBlbHNlIGlmICghRmNDb25maWdBcHBGb250QWRkRmlsZShmb250Y2ZnLCAoRmNDaGFy OCAqKSBmb250KSkgeworICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICJGYWlsZWQgdG8gbG9h ZCBmb250ICVzXG4iLCBmb250KTsKKyAgICAgICAgICAgIGV4aXQoMSk7CiAgICAgICAgIH0KICAg ICB9CiAK