46634 2010-09-27 11:10:14 -0700 webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console 2010-09-27 15:43:01 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue dpranke mihaip oldest_to_newest 285587 0 eric 2010-09-27 11:10:14 -0700 webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console Should use OutputCapture instead. See outputcapture.py (or other unittest examples. test_prompt_with_list (webkitpy.common.system.user_unittest.UserTest) ... title 1. foo 2. bar title 1. foo 2. bar title 1. foo 2. bar title 1. foo 2. bar title 1. foo 2. bar title 1. foo 2. bar title 1. foo 2. bar title 1. foo 2. bar ok 285619 1 68935 mihaip 2010-09-27 11:32:44 -0700 Created attachment 68935 Patch 285628 2 68935 abarth 2010-09-27 11:36:29 -0700 Comment on attachment 68935 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68935&action=review > WebKitTools/Scripts/webkitpy/common/system/user_unittest.py:56 > + # Don't care about output. Why not assert that the output is correct? 285630 3 68935 eric 2010-09-27 11:37:35 -0700 Comment on attachment 68935 Patch Seems OK. We could care about the output. assert_outputs will return the value of the function it calls. The comment should probably say "Other tests cover output, this test only checks parsing behavior" or similar. I guess I should implement __enter__ and __exit__ for OutputCapture so we can use it with "with" 285645 4 68938 mihaip 2010-09-27 11:50:49 -0700 Created attachment 68938 Patch 285650 5 68938 eric 2010-09-27 11:54:16 -0700 Comment on attachment 68938 Patch LGTM! THanks. 285654 6 68938 commit-queue 2010-09-27 11:56:41 -0700 Comment on attachment 68938 Patch Rejecting patch 68938 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 68938]" exit_code: 2 Cleaning working directory Updating working directory Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Full output: http://queues.webkit.org/results/4131015 285817 7 68938 commit-queue 2010-09-27 15:42:55 -0700 Comment on attachment 68938 Patch Clearing flags on attachment: 68938 Committed r68432: <http://trac.webkit.org/changeset/68432> 285818 8 commit-queue 2010-09-27 15:43:01 -0700 All reviewed patches have been landed. Closing bug. 68935 2010-09-27 11:32:44 -0700 2010-09-27 11:50:45 -0700 Patch bug-46634-20100927113243.patch text/plain 2007 mihaip ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2MDY1Y2QwOGU4MzBlYWVlNTcwM2NiZjQwZTQ1MmE5NTU4MTlkNzZkLi40NWYxNmNi ODdkNzBmOWRkMGQyM2M4ZTg4M2JlMjNlNzNhYWFmZDQ3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMDktMjcgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgd2Via2l0cHkuY29t bW9uLnN5c3RlbS51c2VyX3VuaXR0ZXN0LlVzZXJUZXN0LnRlc3RfcHJvbXB0X3dpdGhfbGlzdCBz cGFtcyB0aGUgY29uc29sZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDY2MzQKKyAgICAgICAgCisgICAgICAgIFVzZSBPdXRwdXRDYXB0dXJlIHRvIHBy ZXZlbnQgY29uc29sZSBzcGFtLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24v c3lzdGVtL3VzZXJfdW5pdHRlc3QucHk6CisKIDIwMTAtMDktMjYgIE1paGFpIFBhcnBhcml0YSAg PG1paGFpcEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2phbiBWYWZhaS4K ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS91 c2VyX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lz dGVtL3VzZXJfdW5pdHRlc3QucHkKaW5kZXggYTQ5NjQyMTZmNWNmMDVlM2MyM2NiZGI2NDg2Y2Ey NWM3ODdkZDAwMy4uMzVhY2ZmNjRkODBhMzBkN2UwMjYwMWE1MTQ5ZmNjMTQ4YjA2YzQ2YSAxMDA2 NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3VzZXJf dW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lz dGVtL3VzZXJfdW5pdHRlc3QucHkKQEAgLTI4LDYgKzI4LDcgQEAKIAogaW1wb3J0IHVuaXR0ZXN0 CiAKK2Zyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5vdXRwdXRjYXB0dXJlIGltcG9ydCBPdXRw dXRDYXB0dXJlCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0udXNlciBpbXBvcnQgVXNlcgog CiBjbGFzcyBVc2VyVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CkBAIC01MiwxMSArNTMsMTcgQEAg Y2xhc3MgVXNlclRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogCiAgICAgZGVmIHRlc3RfcHJvbXB0 X3dpdGhfbGlzdChzZWxmKToKICAgICAgICAgZGVmIHJ1bl9wcm9tcHRfdGVzdChvcHRpb25zLCBp bnB1dHMsIGV4cGVjdGVkX3Jlc3VsdCwgY2FuX2Nob29zZV9tdWx0aXBsZT1GYWxzZSk6CisgICAg ICAgICAgICAjIERvbid0IGNhcmUgYWJvdXQgb3V0cHV0LgorICAgICAgICAgICAgb3V0cHV0X2Nh cHR1cmUgPSBPdXRwdXRDYXB0dXJlKCkKKyAgICAgICAgICAgIG91dHB1dF9jYXB0dXJlLmNhcHR1 cmVfb3V0cHV0KCkKKwogICAgICAgICAgICAgZGVmIG1vY2tfcmF3X2lucHV0KG1lc3NhZ2UpOgog ICAgICAgICAgICAgICAgIHJldHVybiBpbnB1dHMucG9wKDApCiAgICAgICAgICAgICBzZWxmLmFz c2VydEVxdWFsKFVzZXIucHJvbXB0X3dpdGhfbGlzdCgidGl0bGUiLCBvcHRpb25zLCBjYW5fY2hv b3NlX211bHRpcGxlPWNhbl9jaG9vc2VfbXVsdGlwbGUsIHJhd19pbnB1dD1tb2NrX3Jhd19pbnB1 dCksIGV4cGVjdGVkX3Jlc3VsdCkKICAgICAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwobGVuKGlu cHV0cyksIDApCiAKKyAgICAgICAgICAgIG91dHB1dF9jYXB0dXJlLnJlc3RvcmVfb3V0cHV0KCkK KwogICAgICAgICBydW5fcHJvbXB0X3Rlc3QoWyJmb28iLCAiYmFyIl0sIFsiMSJdLCAiZm9vIikK ICAgICAgICAgcnVuX3Byb21wdF90ZXN0KFsiZm9vIiwgImJhciJdLCBbImJhZGlucHV0IiwgIjIi XSwgImJhciIpCiAK 68938 2010-09-27 11:50:49 -0700 2010-09-27 15:42:55 -0700 Patch bug-46634-20100927115047.patch text/plain 3685 mihaip ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2MDY1Y2QwOGU4MzBlYWVlNTcwM2NiZjQwZTQ1MmE5NTU4MTlkNzZkLi4yODQ4ZTQw Y2RjNDU4ZjgwNjEzZjkzYjgwMmYzMzlhYzJhZWViNWUyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDktMjcgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgd2Via2l0cHkuY29t bW9uLnN5c3RlbS51c2VyX3VuaXR0ZXN0LlVzZXJUZXN0LnRlc3RfcHJvbXB0X3dpdGhfbGlzdCBz cGFtcyB0aGUgY29uc29sZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDY2MzQKKyAgICAgICAgCisgICAgICAgIFVzZSBPdXRwdXRDYXB0dXJlIHRvIHBy ZXZlbnQgY29uc29sZSBzcGFtIChhbmQgYWxzbyBjaGVjayBmb3IgZXhwZWN0ZWQKKyAgICAgICAg b3V0cHV0KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS91c2Vy X3VuaXR0ZXN0LnB5OgorCiAyMDEwLTA5LTI2ICBNaWhhaSBQYXJwYXJpdGEgIDxtaWhhaXBAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9qYW4gVmFmYWkuCmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vdXNlcl91bml0dGVz dC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS91c2VyX3Vu aXR0ZXN0LnB5CmluZGV4IGE0OTY0MjE2ZjVjZjA1ZTNjMjNjYmRiNjQ4NmNhMjVjNzg3ZGQwMDMu LjIzYjU0NmY5ZWFiYjMzM2Q5ZGRkZDRkNjhjMzE1MDUyZDEzMzBiNmQgMTAwNjQ0Ci0tLSBhL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS91c2VyX3VuaXR0ZXN0LnB5 CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS91c2VyX3Vu aXR0ZXN0LnB5CkBAIC0yOCw2ICsyOCw3IEBACiAKIGltcG9ydCB1bml0dGVzdAogCitmcm9tIHdl YmtpdHB5LmNvbW1vbi5zeXN0ZW0ub3V0cHV0Y2FwdHVyZSBpbXBvcnQgT3V0cHV0Q2FwdHVyZQog ZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLnVzZXIgaW1wb3J0IFVzZXIKIAogY2xhc3MgVXNl clRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgpAQCAtNTEsMjEgKzUyLDI4IEBAIGNsYXNzIFVzZXJU ZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChVc2VyLnBy b21wdCgiaW5wdXQiLCByZXBlYXQ9c2VsZi5yZXBlYXRzUmVtYWluaW5nLCByYXdfaW5wdXQ9bW9j a19yYXdfaW5wdXQpLCBOb25lKQogCiAgICAgZGVmIHRlc3RfcHJvbXB0X3dpdGhfbGlzdChzZWxm KToKLSAgICAgICAgZGVmIHJ1bl9wcm9tcHRfdGVzdChvcHRpb25zLCBpbnB1dHMsIGV4cGVjdGVk X3Jlc3VsdCwgY2FuX2Nob29zZV9tdWx0aXBsZT1GYWxzZSk6CisgICAgICAgIGRlZiBydW5fcHJv bXB0X3Rlc3QoaW5wdXRzLCBleHBlY3RlZF9yZXN1bHQsIGNhbl9jaG9vc2VfbXVsdGlwbGU9RmFs c2UpOgogICAgICAgICAgICAgZGVmIG1vY2tfcmF3X2lucHV0KG1lc3NhZ2UpOgogICAgICAgICAg ICAgICAgIHJldHVybiBpbnB1dHMucG9wKDApCi0gICAgICAgICAgICBzZWxmLmFzc2VydEVxdWFs KFVzZXIucHJvbXB0X3dpdGhfbGlzdCgidGl0bGUiLCBvcHRpb25zLCBjYW5fY2hvb3NlX211bHRp cGxlPWNhbl9jaG9vc2VfbXVsdGlwbGUsIHJhd19pbnB1dD1tb2NrX3Jhd19pbnB1dCksIGV4cGVj dGVkX3Jlc3VsdCkKKyAgICAgICAgICAgIG91dHB1dF9jYXB0dXJlID0gT3V0cHV0Q2FwdHVyZSgp CisgICAgICAgICAgICBhY3R1YWxfcmVzdWx0ID0gb3V0cHV0X2NhcHR1cmUuYXNzZXJ0X291dHB1 dHMoCisgICAgICAgICAgICAgICAgc2VsZiwKKyAgICAgICAgICAgICAgICBVc2VyLnByb21wdF93 aXRoX2xpc3QsCisgICAgICAgICAgICAgICAgYXJncz1bInRpdGxlIiwgWyJmb28iLCAiYmFyIl1d LAorICAgICAgICAgICAgICAgIGt3YXJncz17ImNhbl9jaG9vc2VfbXVsdGlwbGUiOiBjYW5fY2hv b3NlX211bHRpcGxlLCAicmF3X2lucHV0IjogbW9ja19yYXdfaW5wdXR9LAorICAgICAgICAgICAg ICAgIGV4cGVjdGVkX3N0ZG91dD0idGl0bGVcbiAxLiBmb29cbiAyLiBiYXJcbiIpCisgICAgICAg ICAgICBzZWxmLmFzc2VydEVxdWFsKGFjdHVhbF9yZXN1bHQsIGV4cGVjdGVkX3Jlc3VsdCkKICAg ICAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwobGVuKGlucHV0cyksIDApCiAKLSAgICAgICAgcnVu X3Byb21wdF90ZXN0KFsiZm9vIiwgImJhciJdLCBbIjEiXSwgImZvbyIpCi0gICAgICAgIHJ1bl9w cm9tcHRfdGVzdChbImZvbyIsICJiYXIiXSwgWyJiYWRpbnB1dCIsICIyIl0sICJiYXIiKQorICAg ICAgICBydW5fcHJvbXB0X3Rlc3QoWyIxIl0sICJmb28iKQorICAgICAgICBydW5fcHJvbXB0X3Rl c3QoWyJiYWRpbnB1dCIsICIyIl0sICJiYXIiKQogCi0gICAgICAgIHJ1bl9wcm9tcHRfdGVzdChb ImZvbyIsICJiYXIiXSwgWyIxLDIiXSwgWyJmb28iLCAiYmFyIl0sIGNhbl9jaG9vc2VfbXVsdGlw bGU9VHJ1ZSkKLSAgICAgICAgcnVuX3Byb21wdF90ZXN0KFsiZm9vIiwgImJhciJdLCBbIiAgMSwg IDIgICAiXSwgWyJmb28iLCAiYmFyIl0sIGNhbl9jaG9vc2VfbXVsdGlwbGU9VHJ1ZSkKLSAgICAg ICAgcnVuX3Byb21wdF90ZXN0KFsiZm9vIiwgImJhciJdLCBbImFsbCJdLCBbImZvbyIsICJiYXIi XSwgY2FuX2Nob29zZV9tdWx0aXBsZT1UcnVlKQotICAgICAgICBydW5fcHJvbXB0X3Rlc3QoWyJm b28iLCAiYmFyIl0sIFsiIl0sIFsiZm9vIiwgImJhciJdLCBjYW5fY2hvb3NlX211bHRpcGxlPVRy dWUpCi0gICAgICAgIHJ1bl9wcm9tcHRfdGVzdChbImZvbyIsICJiYXIiXSwgWyIgICJdLCBbImZv byIsICJiYXIiXSwgY2FuX2Nob29zZV9tdWx0aXBsZT1UcnVlKQotICAgICAgICBydW5fcHJvbXB0 X3Rlc3QoWyJmb28iLCAiYmFyIl0sIFsiYmFkaW5wdXQiLCAiYWxsIl0sIFsiZm9vIiwgImJhciJd LCBjYW5fY2hvb3NlX211bHRpcGxlPVRydWUpCisgICAgICAgIHJ1bl9wcm9tcHRfdGVzdChbIjEs MiJdLCBbImZvbyIsICJiYXIiXSwgY2FuX2Nob29zZV9tdWx0aXBsZT1UcnVlKQorICAgICAgICBy dW5fcHJvbXB0X3Rlc3QoWyIgIDEsICAyICAgIl0sIFsiZm9vIiwgImJhciJdLCBjYW5fY2hvb3Nl X211bHRpcGxlPVRydWUpCisgICAgICAgIHJ1bl9wcm9tcHRfdGVzdChbImFsbCJdLCBbImZvbyIs ICJiYXIiXSwgY2FuX2Nob29zZV9tdWx0aXBsZT1UcnVlKQorICAgICAgICBydW5fcHJvbXB0X3Rl c3QoWyIiXSwgWyJmb28iLCAiYmFyIl0sIGNhbl9jaG9vc2VfbXVsdGlwbGU9VHJ1ZSkKKyAgICAg ICAgcnVuX3Byb21wdF90ZXN0KFsiICAiXSwgWyJmb28iLCAiYmFyIl0sIGNhbl9jaG9vc2VfbXVs dGlwbGU9VHJ1ZSkKKyAgICAgICAgcnVuX3Byb21wdF90ZXN0KFsiYmFkaW5wdXQiLCAiYWxsIl0s IFsiZm9vIiwgImJhciJdLCBjYW5fY2hvb3NlX211bHRpcGxlPVRydWUpCiAKIGlmIF9fbmFtZV9f ID09ICdfX21haW5fXyc6CiAgICAgdW5pdHRlc3QubWFpbigpCg==