<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>46630</bug_id>
          
          <creation_ts>2010-09-27 09:36:40 -0700</creation_ts>
          <short_desc>[GTK] use ENABLE(GLIB_SUPPORT)</short_desc>
          <delta_ts>2010-09-27 12:04:14 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Philippe Normand">pnormand</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>eric</cc>
    
    <cc>mrobinson</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>285502</commentid>
    <comment_count>0</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-09-27 09:36:40 -0700</bug_when>
    <thetext>For GObject-related conditional includes we currently check PLATFORM(GTK) although GObject is used by other port(s) like EFL that have a ENABLE(GLIB_SUPPORT). Switching to that will simplify code for ports willing to use GObject in the future.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>285528</commentid>
    <comment_count>1</comment_count>
      <attachid>68923</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-09-27 10:12:44 -0700</bug_when>
    <thetext>Created attachment 68923
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>285537</commentid>
    <comment_count>2</comment_count>
      <attachid>68923</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-09-27 10:26:54 -0700</bug_when>
    <thetext>Comment on attachment 68923
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68923&amp;action=review

&gt; ChangeLog:8
&gt; +        [GTK] use ENABLE(GLIB_SUPPORT)
&gt; +        https://bugs.webkit.org/show_bug.cgi?id=46630
&gt; +
&gt; +        * GNUmakefile.am: Enabled the GLIB_SUPPORT define.

We should have a bit more here about why this is a good thing. Something like &quot;Enabling GLIB_SUPPORT on all ports that use GLib will simplify checks.&quot;

&gt; JavaScriptCore/ChangeLog:9
&gt; +        is explicitely enabled.

Small typo here explicitely versus explicitly.

&gt; JavaScriptCore/wtf/Platform.h:1130
&gt; -#if PLATFORM(GTK) || (PLATFORM(EFL) &amp;&amp; ENABLE(GLIB_SUPPORT))
&gt; +#if ENABLE(GLIB_SUPPORT)

I like this simplification.

&gt; WebCore/platform/graphics/cairo/FontPlatformDataFreeType.cpp:114
&gt; -#if !PLATFORM(EFL) || ENABLE(GLIB_SUPPORT)
&gt; +#if ENABLE(GLIB_SUPPORT)
&gt;      if (GdkScreen* screen = gdk_screen_get_default())
&gt; -gdk_screen_get_font_options(screen);
&gt; +        gdk_screen_get_font_options(screen);

This doesn&apos;t seem right to me. The macro doesn&apos;t only implies GLib, not GDK. :/ Perhaps it would be better to define a series of PLATFORM macros like PLATFORM(GLIB) and PLATFORM(GDK) which are more precise about what&apos;s enabled.

&gt; WebCore/platform/graphics/cairo/FontPlatformDataFreeType.cpp:149
&gt; -#if !PLATFORM(EFL) || ENABLE(GLIB_SUPPORT)
&gt; +#if ENABLE(GLIB_SUPPORT)
&gt;      if (GdkScreen* screen = gdk_screen_get_default())
&gt;          options = gdk_screen_get_font_options(screen);

Same issue here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>285540</commentid>
    <comment_count>3</comment_count>
      <attachid>68925</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-09-27 10:32:11 -0700</bug_when>
    <thetext>Created attachment 68925
updated patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>285547</commentid>
    <comment_count>4</comment_count>
      <attachid>68925</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-09-27 10:37:15 -0700</bug_when>
    <thetext>Comment on attachment 68925
updated patch

Great. As I mentioned to Philippe via Jabber, we&apos;re probably going to remove the GDK-specific stuff from FontPlatformDataFreeType soon, so we can avoid the issue of adding a GDK-specific flag for now. I think I&apos;d still like to see this transformed into either USE(GLIB) or PLATFORM(GLIB) in a later patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>285548</commentid>
    <comment_count>5</comment_count>
      <attachid>68926</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-09-27 10:37:50 -0700</bug_when>
    <thetext>Created attachment 68926
updated patch

:)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>285549</commentid>
    <comment_count>6</comment_count>
      <attachid>68927</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-09-27 10:38:18 -0700</bug_when>
    <thetext>Created attachment 68927
updated patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>285554</commentid>
    <comment_count>7</comment_count>
      <attachid>68927</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-09-27 10:41:57 -0700</bug_when>
    <thetext>Comment on attachment 68927
updated patch

Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>285577</commentid>
    <comment_count>8</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-09-27 10:55:55 -0700</bug_when>
    <thetext>Committed r68405: &lt;http://trac.webkit.org/changeset/68405&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>285658</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-09-27 12:04:14 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/68405 might have broken GTK Linux 64-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/68403
http://trac.webkit.org/changeset/68404
http://trac.webkit.org/changeset/68405
http://trac.webkit.org/changeset/68406</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>68923</attachid>
            <date>2010-09-27 10:12:44 -0700</date>
            <delta_ts>2010-09-27 10:32:11 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>proposed-patch.patch</filename>
            <type>text/plain</type>
            <size>4625</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSA3NGE2YTM2MTc2M2RjNTQzNDFkYTY4MTVmNTYwZjdhNjU1NDE5ZGYxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBNb24sIDI3IFNlcCAyMDEwIDE5OjEzOjE3ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g
cHJvcG9zZWQgcGF0Y2gKCi0tLQogQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgfCAgICA5ICsrKysrKysrKwogR05VbWFrZWZpbGUuYW0gICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICAzICsrLQogSmF2YVNjcmlwdENvcmUvQ2hh
bmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEwICsrKysrKysrKysKIEphdmFT
Y3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oICAgICAgICAgICAgICAgICAgICAgIHwgICAgMiArLQog
V2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEz
ICsrKysrKysrKysrKysKIC4uLi9ncmFwaGljcy9jYWlyby9Gb250UGxhdGZvcm1EYXRhRnJlZVR5
cGUuY3BwICAgIHwgICAgOCArKysrLS0tLQogNiBmaWxlcyBjaGFuZ2VkLCAzOSBpbnNlcnRpb25z
KCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwpp
bmRleCA0NzFmMTk2Li5iMWI4MjBjIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdl
TG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDktMjcgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9y
bWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIFtHVEtdIHVzZSBFTkFCTEUoR0xJQl9TVVBQT1JUKQorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY2MzAKKworICAgICAgICAqIEdOVW1h
a2VmaWxlLmFtOiBFbmFibGVkIHRoZSBHTElCX1NVUFBPUlQgZGVmaW5lLgorCiAyMDEwLTA5LTI0
ICBSb21haW4gUG9rcnp5d2thICA8cm9tYWluQGtkYWIuY29tPgogCiAgICAgICAgIFJldmlld2Vk
IGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvR05VbWFrZWZpbGUuYW0gYi9HTlVtYWtl
ZmlsZS5hbQppbmRleCBjNzY5ZGIyLi4yYTg2NmNkIDEwMDY0NAotLS0gYS9HTlVtYWtlZmlsZS5h
bQorKysgYi9HTlVtYWtlZmlsZS5hbQpAQCAtOTEsNyArOTEsOCBAQCBnbG9iYWxfY3BwZmxhZ3Mg
Kz0gXAogCS1XZm9ybWF0IC1XZm9ybWF0LXNlY3VyaXR5IC1Xbm8tZm9ybWF0LXkyayAtV3VuZGVm
IFwKIAktV21pc3NpbmctZm9ybWF0LWF0dHJpYnV0ZSAtV3BvaW50ZXItYXJpdGggLVd3cml0ZS1z
dHJpbmdzIFwKIAktV25vLXVudXNlZC1wYXJhbWV0ZXIgLVduby1wYXJlbnRoZXNlcyBcCi0JLWZu
by1leGNlcHRpb25zCisJLWZuby1leGNlcHRpb25zIC1ERU5BQkxFX0dMSUJfU1VQUE9SVD0xCisK
IAogZ2xvYmFsX2N4eGZsYWdzICs9IFwKIAkkKFNZTUJPTF9WSVNJQklMSVRZX0lOTElORVMpIFwK
ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No
YW5nZUxvZwppbmRleCBiYTQyNGI4Li5kYmJlMzRmIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg
QEAKKzIwMTAtMDktMjcgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIHVz
ZSBFTkFCTEUoR0xJQl9TVVBQT1JUKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9NDY2MzAKKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOiBJbmNsdWRl
IEdUeXBlZGVmcy5oIG9ubHkgaWYgZ2xpYiBzdXBwb3J0CisgICAgICAgIGlzIGV4cGxpY2l0ZWx5
IGVuYWJsZWQuCisKIDIwMTAtMDktMjUgIEhvbGdlciBIYW5zIFBldGVyIEZyZXl0aGVyICA8aG9s
Z2VyQG1vaWppLW1vYmlsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4K
ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oIGIvSmF2YVNjcmlwdENv
cmUvd3RmL1BsYXRmb3JtLmgKaW5kZXggZjUwY2FiNC4uOWY5N2ZhOSAxMDA2NDQKLS0tIGEvSmF2
YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRm
b3JtLmgKQEAgLTExMjcsNyArMTEyNyw3IEBACiAjZGVmaW5lIEVOQUJMRV9CUkFOQ0hfQ09NUEFD
VElPTiAxCiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKEdUSykgfHwgKFBMQVRGT1JNKEVGTCkgJiYg
RU5BQkxFKEdMSUJfU1VQUE9SVCkpCisjaWYgRU5BQkxFKEdMSUJfU1VQUE9SVCkKICNpbmNsdWRl
ICJHVHlwZWRlZnMuaCIKICNlbmRpZgogCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBi
L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDBhNDE3YjIuLmI2M2UyMzkgMTAwNjQ0Ci0tLSBhL1dl
YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK
KzIwMTAtMDktMjcgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIHVzZSBF
TkFCTEUoR0xJQl9TVVBQT1JUKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9NDY2MzAKKworICAgICAgICBDaGVja2luZyBnbGliIHN1cHBvcnQgaXMgZW5v
dWdoIG5vdyB0aGF0IHRoZSBHVEsgcG9ydAorICAgICAgICBhbHNvIHVzZXMgdGhlIEdMSUJfU1VQ
UE9SVCBkZWZpbmUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Gb250UGxh
dGZvcm1EYXRhRnJlZVR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udFBsYXRmb3JtRGF0
YTo6Rm9udFBsYXRmb3JtRGF0YSk6CisKIDIwMTAtMDktMjcgIMSwc21haWwgRMO2bm1leiAgPGlz
bWFpbEBuYW10cmFjLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpk
aWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Gb250UGxhdGZvcm1E
YXRhRnJlZVR5cGUuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Gb250UGxh
dGZvcm1EYXRhRnJlZVR5cGUuY3BwCmluZGV4IDc5Njg5NjYuLjhmNGRkMDcgMTAwNjQ0Ci0tLSBh
L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vRm9udFBsYXRmb3JtRGF0YUZyZWVUeXBl
LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ZvbnRQbGF0Zm9ybURh
dGFGcmVlVHlwZS5jcHAKQEAgLTMyLDcgKzMyLDcgQEAKICNpbmNsdWRlIDxjYWlyby1mdC5oPgog
I2luY2x1ZGUgPGNhaXJvLmg+CiAjaW5jbHVkZSA8Zm9udGNvbmZpZy9mY2ZyZWV0eXBlLmg+Ci0j
aWYgIVBMQVRGT1JNKEVGTCkgfHwgRU5BQkxFKEdMSUJfU1VQUE9SVCkKKyNpZiBFTkFCTEUoR0xJ
Ql9TVVBQT1JUKQogI2luY2x1ZGUgPGdkay9nZGsuaD4KICNlbmRpZgogCkBAIC0xMDksOSArMTA5
LDkgQEAgRm9udFBsYXRmb3JtRGF0YTo6Rm9udFBsYXRmb3JtRGF0YShjb25zdCBGb250RGVzY3Jp
cHRpb24mIGZvbnREZXNjcmlwdGlvbiwgY29uc3QKICAgICBjYWlyb19tYXRyaXhfaW5pdF9zY2Fs
ZSgmZm9udE1hdHJpeCwgZm9udERlc2NyaXB0aW9uLmNvbXB1dGVkUGl4ZWxTaXplKCksIGZvbnRE
ZXNjcmlwdGlvbi5jb21wdXRlZFBpeGVsU2l6ZSgpKTsKICAgICBjYWlyb19tYXRyaXhfaW5pdF9p
ZGVudGl0eSgmY3RtKTsKIAotI2lmICFQTEFURk9STShFRkwpIHx8IEVOQUJMRShHTElCX1NVUFBP
UlQpCisjaWYgRU5BQkxFKEdMSUJfU1VQUE9SVCkKICAgICBpZiAoR2RrU2NyZWVuKiBzY3JlZW4g
PSBnZGtfc2NyZWVuX2dldF9kZWZhdWx0KCkpCi1nZGtfc2NyZWVuX2dldF9mb250X29wdGlvbnMo
c2NyZWVuKTsKKyAgICAgICAgZ2RrX3NjcmVlbl9nZXRfZm9udF9vcHRpb25zKHNjcmVlbik7CiAj
ZW5kaWYKIAogICAgIC8vIGdka19zY3JlZW5fZ2V0X2ZvbnRfb3B0aW9ucygpIHJldHVybnMgTlVM
TCBpZiBubyBkZWZhdWx0IG9wdGlvbnMgYXJlCkBAIC0xNDQsNyArMTQ0LDcgQEAgRm9udFBsYXRm
b3JtRGF0YTo6Rm9udFBsYXRmb3JtRGF0YShjYWlyb19mb250X2ZhY2VfdCogZm9udEZhY2UsIGZs
b2F0IHNpemUsIGJvb2wKICAgICBzdGF0aWMgY29uc3QgY2Fpcm9fZm9udF9vcHRpb25zX3QqIGRl
ZmF1bHRPcHRpb25zID0gY2Fpcm9fZm9udF9vcHRpb25zX2NyZWF0ZSgpOwogICAgIGNvbnN0IGNh
aXJvX2ZvbnRfb3B0aW9uc190KiBvcHRpb25zID0gTlVMTDsKIAotI2lmICFQTEFURk9STShFRkwp
IHx8IEVOQUJMRShHTElCX1NVUFBPUlQpCisjaWYgRU5BQkxFKEdMSUJfU1VQUE9SVCkKICAgICBp
ZiAoR2RrU2NyZWVuKiBzY3JlZW4gPSBnZGtfc2NyZWVuX2dldF9kZWZhdWx0KCkpCiAgICAgICAg
IG9wdGlvbnMgPSBnZGtfc2NyZWVuX2dldF9mb250X29wdGlvbnMoc2NyZWVuKTsKICNlbmRpZgot
LSAKMS43LjE=
</data>
<flag name="review"
          id="58516"
          type_id="1"
          status="-"
          setter="mrobinson"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>68925</attachid>
            <date>2010-09-27 10:32:11 -0700</date>
            <delta_ts>2010-09-27 10:37:50 -0700</delta_ts>
            <desc>updated patch</desc>
            <filename>updated-patch.patch</filename>
            <type>text/plain</type>
            <size>2259</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSAwNmJiOGRjZGZmMzhhNDgxZjE0MzA5ZTNhNDUxMGFhNGI2MTAzMTM1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBNb24sIDI3IFNlcCAyMDEwIDE5OjMyOjQ0ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g
dXBkYXRlZCBwYXRjaAoKLS0tCiBDaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICB8ICAgIDkg
KysrKysrKysrCiBHTlVtYWtlZmlsZS5hbSAgICAgICAgICAgICAgICB8ICAgIDMgKystCiBKYXZh
U2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICB8ICAgMTAgKysrKysrKysrKwogSmF2YVNjcmlwdENv
cmUvd3RmL1BsYXRmb3JtLmggfCAgICAyICstCiA0IGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlv
bnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9n
CmluZGV4IDQ3MWYxOTYuLmIxYjgyMGMgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFu
Z2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wOS0yNyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBu
b3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgW0dUS10gdXNlIEVOQUJMRShHTElCX1NVUFBPUlQpCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjYzMAorCisgICAgICAgICogR05V
bWFrZWZpbGUuYW06IEVuYWJsZWQgdGhlIEdMSUJfU1VQUE9SVCBkZWZpbmUuCisKIDIwMTAtMDkt
MjQgIFJvbWFpbiBQb2tyenl3a2EgIDxyb21haW5Aa2RhYi5jb20+CiAKICAgICAgICAgUmV2aWV3
ZWQgYnkgU2ltb24gSGF1c21hbm4uCmRpZmYgLS1naXQgYS9HTlVtYWtlZmlsZS5hbSBiL0dOVW1h
a2VmaWxlLmFtCmluZGV4IGM3NjlkYjIuLjJhODY2Y2QgMTAwNjQ0Ci0tLSBhL0dOVW1ha2VmaWxl
LmFtCisrKyBiL0dOVW1ha2VmaWxlLmFtCkBAIC05MSw3ICs5MSw4IEBAIGdsb2JhbF9jcHBmbGFn
cyArPSBcCiAJLVdmb3JtYXQgLVdmb3JtYXQtc2VjdXJpdHkgLVduby1mb3JtYXQteTJrIC1XdW5k
ZWYgXAogCS1XbWlzc2luZy1mb3JtYXQtYXR0cmlidXRlIC1XcG9pbnRlci1hcml0aCAtV3dyaXRl
LXN0cmluZ3MgXAogCS1Xbm8tdW51c2VkLXBhcmFtZXRlciAtV25vLXBhcmVudGhlc2VzIFwKLQkt
Zm5vLWV4Y2VwdGlvbnMKKwktZm5vLWV4Y2VwdGlvbnMgLURFTkFCTEVfR0xJQl9TVVBQT1JUPTEK
KwogCiBnbG9iYWxfY3h4ZmxhZ3MgKz0gXAogCSQoU1lNQk9MX1ZJU0lCSUxJVFlfSU5MSU5FUykg
XApkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvSmF2YVNjcmlwdENvcmUv
Q2hhbmdlTG9nCmluZGV4IGJhNDI0YjguLmRiYmUzNGYgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZworKysgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx
MyBAQAorMjAxMC0wOS0yNyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10g
dXNlIEVOQUJMRShHTElCX1NVUFBPUlQpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD00NjYzMAorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6IEluY2x1
ZGUgR1R5cGVkZWZzLmggb25seSBpZiBnbGliIHN1cHBvcnQKKyAgICAgICAgaXMgZXhwbGljaXRl
bHkgZW5hYmxlZC4KKwogMjAxMC0wOS0yNSAgSG9sZ2VyIEhhbnMgUGV0ZXIgRnJleXRoZXIgIDxo
b2xnZXJAbW9pamktbW9iaWxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRo
LgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmggYi9KYXZhU2NyaXB0
Q29yZS93dGYvUGxhdGZvcm0uaAppbmRleCBmNTBjYWI0Li45Zjk3ZmE5IDEwMDY0NAotLS0gYS9K
YXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvUGxh
dGZvcm0uaApAQCAtMTEyNyw3ICsxMTI3LDcgQEAKICNkZWZpbmUgRU5BQkxFX0JSQU5DSF9DT01Q
QUNUSU9OIDEKICNlbmRpZgogCi0jaWYgUExBVEZPUk0oR1RLKSB8fCAoUExBVEZPUk0oRUZMKSAm
JiBFTkFCTEUoR0xJQl9TVVBQT1JUKSkKKyNpZiBFTkFCTEUoR0xJQl9TVVBQT1JUKQogI2luY2x1
ZGUgIkdUeXBlZGVmcy5oIgogI2VuZGlmCiAKLS0gCjEuNy4x
</data>
<flag name="review"
          id="58520"
          type_id="1"
          status="+"
          setter="mrobinson"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>68926</attachid>
            <date>2010-09-27 10:37:50 -0700</date>
            <delta_ts>2010-09-27 10:38:18 -0700</delta_ts>
            <desc>updated patch</desc>
            <filename>updated-patch.patch</filename>
            <type>text/plain</type>
            <size>2350</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSAyMzg0MzM2ZjcwMTE2MmQzYzVmZTQ4OTUyNzY2MzM1OGRkYjJkNTJiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBNb24sIDI3IFNlcCAyMDEwIDE5OjMyOjQ0ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g
dXBkYXRlZCBwYXRjaAoKLS0tCiBDaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICB8ICAgMTIg
KysrKysrKysrKysrCiBHTlVtYWtlZmlsZS5hbSAgICAgICAgICAgICAgICB8ICAgIDMgKystCiBK
YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICB8ICAgMTAgKysrKysrKysrKwogSmF2YVNjcmlw
dENvcmUvd3RmL1BsYXRmb3JtLmggfCAgICAyICstCiA0IGZpbGVzIGNoYW5nZWQsIDI1IGluc2Vy
dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdl
TG9nCmluZGV4IDQ3MWYxOTYuLjcyMmJmY2QgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9D
aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0yNyAgUGhpbGlwcGUgTm9ybWFuZCAg
PHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgW0dUS10gdXNlIEVOQUJMRShHTElCX1NVUFBPUlQpCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjYzMAorCisgICAgICAgIEVu
YWJsaW5nIEdMSUJfU1VQUE9SVCBvbiBhbGwgcG9ydHMgdGhhdCB1c2UgR0xpYiB0byBzaW1wbGlm
eQorICAgICAgICBjaGVja3MuCisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbTogRW5hYmxlZCB0
aGUgR0xJQl9TVVBQT1JUIGRlZmluZS4KKwogMjAxMC0wOS0yNCAgUm9tYWluIFBva3J6eXdrYSAg
PHJvbWFpbkBrZGFiLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4K
ZGlmZiAtLWdpdCBhL0dOVW1ha2VmaWxlLmFtIGIvR05VbWFrZWZpbGUuYW0KaW5kZXggYzc2OWRi
Mi4uMmE4NjZjZCAxMDA2NDQKLS0tIGEvR05VbWFrZWZpbGUuYW0KKysrIGIvR05VbWFrZWZpbGUu
YW0KQEAgLTkxLDcgKzkxLDggQEAgZ2xvYmFsX2NwcGZsYWdzICs9IFwKIAktV2Zvcm1hdCAtV2Zv
cm1hdC1zZWN1cml0eSAtV25vLWZvcm1hdC15MmsgLVd1bmRlZiBcCiAJLVdtaXNzaW5nLWZvcm1h
dC1hdHRyaWJ1dGUgLVdwb2ludGVyLWFyaXRoIC1Xd3JpdGUtc3RyaW5ncyBcCiAJLVduby11bnVz
ZWQtcGFyYW1ldGVyIC1Xbm8tcGFyZW50aGVzZXMgXAotCS1mbm8tZXhjZXB0aW9ucworCS1mbm8t
ZXhjZXB0aW9ucyAtREVOQUJMRV9HTElCX1NVUFBPUlQ9MQorCiAKIGdsb2JhbF9jeHhmbGFncyAr
PSBcCiAJJChTWU1CT0xfVklTSUJJTElUWV9JTkxJTkVTKSBcCmRpZmYgLS1naXQgYS9KYXZhU2Ny
aXB0Q29yZS9DaGFuZ2VMb2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggYmE0MjRi
OC4uZjBjMzkwMCAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0ph
dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA5LTI3ICBQaGls
aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSB1c2UgRU5BQkxFKEdMSUJfU1VQUE9S
VCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2NjMw
CisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDogSW5jbHVkZSBHVHlwZWRlZnMuaCBvbmx5IGlm
IGdsaWIgc3VwcG9ydAorICAgICAgICBpcyBleHBsaWNpdGx5IGVuYWJsZWQuCisKIDIwMTAtMDkt
MjUgIEhvbGdlciBIYW5zIFBldGVyIEZyZXl0aGVyICA8aG9sZ2VyQG1vaWppLW1vYmlsZS5jb20+
CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL0phdmFTY3Jp
cHRDb3JlL3d0Zi9QbGF0Zm9ybS5oIGIvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKaW5k
ZXggZjUwY2FiNC4uOWY5N2ZhOSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRm
b3JtLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKQEAgLTExMjcsNyArMTEy
Nyw3IEBACiAjZGVmaW5lIEVOQUJMRV9CUkFOQ0hfQ09NUEFDVElPTiAxCiAjZW5kaWYKIAotI2lm
IFBMQVRGT1JNKEdUSykgfHwgKFBMQVRGT1JNKEVGTCkgJiYgRU5BQkxFKEdMSUJfU1VQUE9SVCkp
CisjaWYgRU5BQkxFKEdMSUJfU1VQUE9SVCkKICNpbmNsdWRlICJHVHlwZWRlZnMuaCIKICNlbmRp
ZgogCi0tIAoxLjcuMQ==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>68927</attachid>
            <date>2010-09-27 10:38:18 -0700</date>
            <delta_ts>2010-09-27 10:41:57 -0700</delta_ts>
            <desc>updated patch</desc>
            <filename>updated-patch.patch</filename>
            <type>text/plain</type>
            <size>2350</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSAyMzg0MzM2ZjcwMTE2MmQzYzVmZTQ4OTUyNzY2MzM1OGRkYjJkNTJiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBNb24sIDI3IFNlcCAyMDEwIDE5OjMyOjQ0ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g
dXBkYXRlZCBwYXRjaAoKLS0tCiBDaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICB8ICAgMTIg
KysrKysrKysrKysrCiBHTlVtYWtlZmlsZS5hbSAgICAgICAgICAgICAgICB8ICAgIDMgKystCiBK
YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICB8ICAgMTAgKysrKysrKysrKwogSmF2YVNjcmlw
dENvcmUvd3RmL1BsYXRmb3JtLmggfCAgICAyICstCiA0IGZpbGVzIGNoYW5nZWQsIDI1IGluc2Vy
dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdl
TG9nCmluZGV4IDQ3MWYxOTYuLjcyMmJmY2QgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9D
aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0yNyAgUGhpbGlwcGUgTm9ybWFuZCAg
PHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgW0dUS10gdXNlIEVOQUJMRShHTElCX1NVUFBPUlQpCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjYzMAorCisgICAgICAgIEVu
YWJsaW5nIEdMSUJfU1VQUE9SVCBvbiBhbGwgcG9ydHMgdGhhdCB1c2UgR0xpYiB0byBzaW1wbGlm
eQorICAgICAgICBjaGVja3MuCisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbTogRW5hYmxlZCB0
aGUgR0xJQl9TVVBQT1JUIGRlZmluZS4KKwogMjAxMC0wOS0yNCAgUm9tYWluIFBva3J6eXdrYSAg
PHJvbWFpbkBrZGFiLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4K
ZGlmZiAtLWdpdCBhL0dOVW1ha2VmaWxlLmFtIGIvR05VbWFrZWZpbGUuYW0KaW5kZXggYzc2OWRi
Mi4uMmE4NjZjZCAxMDA2NDQKLS0tIGEvR05VbWFrZWZpbGUuYW0KKysrIGIvR05VbWFrZWZpbGUu
YW0KQEAgLTkxLDcgKzkxLDggQEAgZ2xvYmFsX2NwcGZsYWdzICs9IFwKIAktV2Zvcm1hdCAtV2Zv
cm1hdC1zZWN1cml0eSAtV25vLWZvcm1hdC15MmsgLVd1bmRlZiBcCiAJLVdtaXNzaW5nLWZvcm1h
dC1hdHRyaWJ1dGUgLVdwb2ludGVyLWFyaXRoIC1Xd3JpdGUtc3RyaW5ncyBcCiAJLVduby11bnVz
ZWQtcGFyYW1ldGVyIC1Xbm8tcGFyZW50aGVzZXMgXAotCS1mbm8tZXhjZXB0aW9ucworCS1mbm8t
ZXhjZXB0aW9ucyAtREVOQUJMRV9HTElCX1NVUFBPUlQ9MQorCiAKIGdsb2JhbF9jeHhmbGFncyAr
PSBcCiAJJChTWU1CT0xfVklTSUJJTElUWV9JTkxJTkVTKSBcCmRpZmYgLS1naXQgYS9KYXZhU2Ny
aXB0Q29yZS9DaGFuZ2VMb2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggYmE0MjRi
OC4uZjBjMzkwMCAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0ph
dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA5LTI3ICBQaGls
aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSB1c2UgRU5BQkxFKEdMSUJfU1VQUE9S
VCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2NjMw
CisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDogSW5jbHVkZSBHVHlwZWRlZnMuaCBvbmx5IGlm
IGdsaWIgc3VwcG9ydAorICAgICAgICBpcyBleHBsaWNpdGx5IGVuYWJsZWQuCisKIDIwMTAtMDkt
MjUgIEhvbGdlciBIYW5zIFBldGVyIEZyZXl0aGVyICA8aG9sZ2VyQG1vaWppLW1vYmlsZS5jb20+
CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL0phdmFTY3Jp
cHRDb3JlL3d0Zi9QbGF0Zm9ybS5oIGIvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKaW5k
ZXggZjUwY2FiNC4uOWY5N2ZhOSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRm
b3JtLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKQEAgLTExMjcsNyArMTEy
Nyw3IEBACiAjZGVmaW5lIEVOQUJMRV9CUkFOQ0hfQ09NUEFDVElPTiAxCiAjZW5kaWYKIAotI2lm
IFBMQVRGT1JNKEdUSykgfHwgKFBMQVRGT1JNKEVGTCkgJiYgRU5BQkxFKEdMSUJfU1VQUE9SVCkp
CisjaWYgRU5BQkxFKEdMSUJfU1VQUE9SVCkKICNpbmNsdWRlICJHVHlwZWRlZnMuaCIKICNlbmRp
ZgogCi0tIAoxLjcuMQ==
</data>
<flag name="review"
          id="58522"
          type_id="1"
          status="+"
          setter="mrobinson"
    />
          </attachment>
      

    </bug>

</bugzilla>