46621 2010-09-27 07:24:48 -0700 [Qt] Make generate-forwarding-headers.pl aware of moved headers 2010-09-27 11:36:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 1 abecsi abecsi abecsi commit-queue eric ossy oldest_to_newest 285444 0 abecsi 2010-09-27 07:24:48 -0700 Changeset http://trac.webkit.org/changeset/68357 revealed an incremental build issue: if headers are moved the script does not regenerate the corresponding forwarding headers. Make generate-forwarding-headers.pl more robust by checking the content of existing forwarding headers and regenerating them if they do not contain what's expected. 285445 1 68907 abecsi 2010-09-27 07:28:43 -0700 Created attachment 68907 proposed patch 285595 2 68907 ossy 2010-09-27 11:15:02 -0700 Comment on attachment 68907 proposed patch It will make WebKit2 build system more robust without any needless forwarding header regeneration and performace regression. Great fix, r=me. 285598 3 68907 commit-queue 2010-09-27 11:15:56 -0700 Comment on attachment 68907 proposed patch Rejecting patch 68907 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 68907]" exit_code: 2 Cleaning working directory Updating working directory Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Full output: http://queues.webkit.org/results/4074123 285614 4 68907 ossy 2010-09-27 11:27:02 -0700 Comment on attachment 68907 proposed patch Clearing flags on attachment: 68907 Committed r68409: <http://trac.webkit.org/changeset/68409> 285615 5 ossy 2010-09-27 11:27:11 -0700 All reviewed patches have been landed. Closing bug. 285618 6 eric 2010-09-27 11:32:29 -0700 False rejection. Bug in the queue. One of the cluster nodes seems stuck. 285627 7 abecsi 2010-09-27 11:36:25 -0700 (In reply to comment #4) > (From update of attachment 68907 [details]) > Clearing flags on attachment: 68907 > > Committed r68409: <http://trac.webkit.org/changeset/68409> Thanks, Ossy for landing it. 68907 2010-09-27 07:28:43 -0700 2010-09-27 11:27:02 -0700 proposed patch patch.diff text/plain 1982 abecsi ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg YWNhYmVmYy4uMmYwN2Y1MSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wOS0yNyAgQW5kcmFzIEJlY3Np ICA8YWJlY3NpQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW1F0XSBNYWtlIGdlbmVyYXRlLWZvcndhcmRpbmctaGVhZGVycy5wbCBh d2FyZSBvZiBtb3ZlZCBoZWFkZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00NjYyMQorCisgICAgICAgICogZ2VuZXJhdGUtZm9yd2FyZGluZy1oZWFk ZXJzLnBsOgorCiAyMDEwLTA5LTI3ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAog ICAgICAgICBEb24ndCBkb3VibGUtZnJlZSBDRVJUX0NPTlRFWFRzIHdoZW4gY29weWluZyBQbGF0 Zm9ybUNlcnRpZmljYXRlSW5mb3MKZGlmZiAtLWdpdCBhL1dlYktpdDIvZ2VuZXJhdGUtZm9yd2Fy ZGluZy1oZWFkZXJzLnBsIGIvV2ViS2l0Mi9nZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGwK aW5kZXggNmE3NzljMi4uZTgzNmZhNCAxMDA3NTUKLS0tIGEvV2ViS2l0Mi9nZW5lcmF0ZS1mb3J3 YXJkaW5nLWhlYWRlcnMucGwKKysrIGIvV2ViS2l0Mi9nZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRl cnMucGwKQEAgLTgxLDEyICs4MSwxNyBAQCBzdWIgY29sbGVjdEZhbWV3b3JrSGVhZGVyUGF0aHMg ewogc3ViIGNyZWF0ZUZvcndhcmRpbmdIZWFkZXJzRm9yRnJhbWV3b3JrIHsKICAgICBmb3JlYWNo IG15ICRoZWFkZXIgKEBmcmFtZXdvcmtIZWFkZXJzKSB7CiAgICAgICAgIG15ICRmb3J3YXJkaW5n SGVhZGVyUGF0aCA9IEZpbGU6OlNwZWMtPmNhdGZpbGUoJG91dHB1dERpcmVjdG9yeSwgJGZyYW1l d29yaywgYmFzZW5hbWUoJGhlYWRlcikpOwotICAgICAgICBpZiAoISAtZSAkZm9yd2FyZGluZ0hl YWRlclBhdGgpIHsKLSAgICAgICAgICAgIHByaW50ICJbQ3JlYXRlIGZvcndhcmRpbmcgaGVhZGVy IGZvciAkZnJhbWV3b3JrLyRoZWFkZXJdXG4iOwotICAgICAgICAgICAgb3BlbihGT1JXQVJESU5H X0hFQURFUiwgIj4kZm9yd2FyZGluZ0hlYWRlclBhdGgiKSBvciBkaWUgIkNvdWxkIG5vdCBvcGVu ICRmb3J3YXJkaW5nSGVhZGVyUGF0aC5cbiI7Ci0gICAgICAgICAgICBwcmludCBGT1JXQVJESU5H X0hFQURFUiAiI2luY2x1ZGUgXCIkaGVhZGVyXCJcbiI7CisgICAgICAgIG15ICRleHBlY3RlZElu Y2x1ZGVTdGF0ZW1lbnQgPSAiI2luY2x1ZGUgXCIkaGVhZGVyXCIiOworICAgICAgICBteSAkZm91 bmRJbmNsdWRlU3RhdGVtZW50ID0gMDsKKyAgICAgICAgJGZvdW5kSW5jbHVkZVN0YXRlbWVudCA9 IDxFWElTVElOR19IRUFERVI+IGlmIG9wZW4oRVhJU1RJTkdfSEVBREVSLCAiPCRmb3J3YXJkaW5n SGVhZGVyUGF0aCIpOworICAgICAgICBjaG9tcCgkZm91bmRJbmNsdWRlU3RhdGVtZW50KTsKKyAg ICAgICAgaWYgKCEgJGZvdW5kSW5jbHVkZVN0YXRlbWVudCB8fCAkZm91bmRJbmNsdWRlU3RhdGVt ZW50IG5lICRleHBlY3RlZEluY2x1ZGVTdGF0ZW1lbnQpIHsKKyAgICAgICAgICAgIHByaW50ICJb Q3JlYXRpbmcgZm9yd2FyZGluZyBoZWFkZXIgZm9yICRmcmFtZXdvcmsvJGhlYWRlcl1cbiI7Cisg ICAgICAgICAgICBvcGVuKEZPUldBUkRJTkdfSEVBREVSLCAiPiRmb3J3YXJkaW5nSGVhZGVyUGF0 aCIpIG9yIGRpZSAiQ291bGQgbm90IG9wZW4gJGZvcndhcmRpbmdIZWFkZXJQYXRoLiI7CisgICAg ICAgICAgICBwcmludCBGT1JXQVJESU5HX0hFQURFUiAiJGV4cGVjdGVkSW5jbHVkZVN0YXRlbWVu dFxuIjsKICAgICAgICAgICAgIGNsb3NlKEZPUldBUkRJTkdfSEVBREVSKTsKICAgICAgICAgfQor ICAgICAgICBjbG9zZShFWElTVElOR19IRUFERVIpOwogICAgIH0KIH0KIAo=