46598 2010-09-26 18:41:30 -0700 [GTK][DRT] Implement LayoutTestController::nodesFromRect 2010-11-11 22:21:10 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tonikitoo webkit-unassigned commit-queue gustavo joone mrobinson tonikitoo oldest_to_newest 285232 0 tonikitoo 2010-09-26 18:41:30 -0700 fast/dom/nodesFromRect-based.html was skipped by bug 46492. Needs to implement LayoutTestController::nodesFromRect so unskip. Mac has its implementation from bug 46480. 308316 1 73689 joone 2010-11-11 18:15:16 -0800 Created attachment 73689 Proposed patch1 I added nodesFromRect in DRT. 308357 2 tonikitoo 2010-11-11 21:03:42 -0800 Why does not this unskip the other nodesFromRect test? 308377 3 73689 commit-queue 2010-11-11 22:21:04 -0800 Comment on attachment 73689 Proposed patch1 Clearing flags on attachment: 73689 Committed r71888: <http://trac.webkit.org/changeset/71888> 308378 4 commit-queue 2010-11-11 22:21:10 -0800 All reviewed patches have been landed. Closing bug. 73689 2010-11-11 18:15:16 -0800 2010-11-11 22:21:04 -0800 Proposed patch1 nodesFromRect.diff text/plain 5583 joone ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyMWUzZmUxLi41ZTY4NGQxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTEt MTIgIEpvb25lIEh1ciAgPGpvb25lQGtsZHAub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdW0RSVF0gSW1wbGVtZW50IExheW91dFRlc3RD b250cm9sbGVyOjpub2Rlc0Zyb21SZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00NjU5OAorCisgICAgICAgIFVuc2tpcCBmYXN0L2RvbS9ub2Rlc0Zy b21SZWN0LWJhc2ljLmh0bWwgb24gR3RrKy4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lw cGVkOgorCiAyMDEwLTExLTEwICBaaGVueWFvIE1vICA8em1vQGdvb2dsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSdXNzZWxsLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZApp bmRleCAyM2E2YjA0Li4xN2MyYzhlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9n dGsvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZApAQCAtNTYy NSw4ICs1NjI1LDcgQEAgZmFzdC9wYXJzZXIvcHJlLWh0bWw1LXBhcnNlci1xdWlya3MuaHRtbAog IyBGaWxlU3lzdGVtIEFQSSBpcyBub3Qgc3VwcG9ydGVkLgogZmFzdC9maWxlc3lzdGVtCiAKLSMg TGF5b3V0VGVzdENvbnRyb2xsZXI6Om5vZGVzRnJvbVJlY3QgaXMgbm90IHN1cHBvcnRlZC4KLWZh c3QvZG9tL25vZGVzRnJvbVJlY3QtYmFzaWMuaHRtbAorIyBOZWVkcyBtb3JlIGludmVzdGlnYXRp b24gbGlrZSBRVAogZmFzdC9kb20vbm9kZXNGcm9tUmVjdC1saW5rcy1hbmQtdGV4dC5odG1sCiBm YXN0L2RvbS9ub2Rlc0Zyb21SZWN0LWlubmVyLWRvY3VtZW50cy5odG1sCiAKZGlmZiAtLWdpdCBh L1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggNmQ5YTY1 Mi4uYzFkN2UyYyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0 L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMS0xMiAgSm9vbmUgSHVyICA8 am9vbmVAa2xkcC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW0dUS11bRFJUXSBJbXBsZW1lbnQgTGF5b3V0VGVzdENvbnRyb2xsZXI6Om5vZGVz RnJvbVJlY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ2NTk4CisKKyAgICAgICAgU3VwcG9ydCBub2Rlc0Zyb21SZWN0IGluIERSVAorCisgICAgICAg ICogV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmNwcDoKKyAgICAgICAg KER1bXBSZW5kZXJUcmVlU3VwcG9ydEd0azo6bm9kZXNGcm9tUmVjdCk6IEFkZGVkLgorICAgICAg ICAqIFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5oOgorCiAyMDEwLTEx LTA4ICBOaWNvbGFzIER1ZnJlc25lICA8bmljb2xhcy5kdWZyZXNuZUBjb2xsYWJvcmEuY28udWs+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvV2Vi S2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuY3BwIGIvV2Vi S2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuY3BwCmluZGV4 IDgyOTYyMDYuLmYyMzdlOWQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQv RHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmNwcAorKysgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBw b3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5jcHAKQEAgLTE5LDkgKzE5LDE3IEBACiAjaW5j bHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmgiCiAK LSNpbmNsdWRlICJ3ZWJraXR3ZWJ2aWV3LmgiCisjaW5jbHVkZSAiQVBJQ2FzdC5oIgorI2luY2x1 ZGUgIkRvY3VtZW50LmgiCisjaW5jbHVkZSAiSlNEb2N1bWVudC5oIgorI2luY2x1ZGUgIkpTTG9j ay5oIgorI2luY2x1ZGUgIkpTTm9kZUxpc3QuaCIKKyNpbmNsdWRlICJKU1ZhbHVlLmgiCisjaW5j bHVkZSAiTm9kZUxpc3QuaCIKICNpbmNsdWRlICJ3ZWJraXRwcml2YXRlLmgiCisjaW5jbHVkZSAi d2Via2l0d2Vidmlldy5oIgogCit1c2luZyBuYW1lc3BhY2UgSlNDOwogdXNpbmcgbmFtZXNwYWNl IFdlYkNvcmU7CiAKIGJvb2wgRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrOjpzX2RydFJ1biA9IGZh bHNlOwpAQCAtNTQsMyArNjIsMTggQEAgYm9vbCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6Omxp bmtzSW5jbHVkZWRJbkZvY3VzQ2hhaW4oKQogICAgIHJldHVybiBzX2xpbmtzSW5jbHVkZWRJblRh YkNoYWluOwogfQogCitKU1ZhbHVlUmVmIER1bXBSZW5kZXJUcmVlU3VwcG9ydEd0azo6bm9kZXNG cm9tUmVjdChKU0NvbnRleHRSZWYgY29udGV4dCwgSlNWYWx1ZVJlZiB2YWx1ZSwgaW50IHgsIGlu dCB5LCB1bnNpZ25lZCB0b3AsIHVuc2lnbmVkIHJpZ2h0LCB1bnNpZ25lZCBib3R0b20sIHVuc2ln bmVkIGxlZnQsIGJvb2wgaWdub3JlQ2xpcHBpbmcpCit7CisgICAgSlNMb2NrIGxvY2soU2lsZW5j ZUFzc2VydGlvbnNPbmx5KTsKKyAgICBFeGVjU3RhdGUqIGV4ZWMgPSB0b0pTKGNvbnRleHQpOwor ICAgIGlmICghdmFsdWUpCisgICAgICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVmaW5lZChjb250 ZXh0KTsKKyAgICBKU1ZhbHVlIGpzVmFsdWUgPSB0b0pTKGV4ZWMsIHZhbHVlKTsKKyAgICBpZiAo IWpzVmFsdWUuaW5oZXJpdHMoJkpTRG9jdW1lbnQ6OnNfaW5mbykpCisgICAgICAgcmV0dXJuIEpT VmFsdWVNYWtlVW5kZWZpbmVkKGNvbnRleHQpOworCisgICAgSlNEb2N1bWVudCoganNEb2N1bWVu dCA9IHN0YXRpY19jYXN0PEpTRG9jdW1lbnQqPihhc09iamVjdChqc1ZhbHVlKSk7CisgICAgRG9j dW1lbnQqIGRvY3VtZW50ID0ganNEb2N1bWVudC0+aW1wbCgpOworICAgIFJlZlB0cjxOb2RlTGlz dD4gbm9kZXMgPSBkb2N1bWVudC0+bm9kZXNGcm9tUmVjdCh4LCB5LCB0b3AsIHJpZ2h0LCBib3R0 b20sIGxlZnQsIGlnbm9yZUNsaXBwaW5nKTsKKyAgICByZXR1cm4gdG9SZWYoZXhlYywgdG9KUyhl eGVjLCBqc0RvY3VtZW50LT5nbG9iYWxPYmplY3QoKSwgbm9kZXMuZ2V0KCkpKTsKK30KZGlmZiAt LWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3Rr LmggYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5o CmluZGV4IDViNDk0ZmYuLjE3ZTlmNmQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvV2ViQ29yZVN1 cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmgKKysrIGIvV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuaApAQCAtMTksNiArMTksOCBAQAogI2lm bmRlZiBEdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGtfaAogI2RlZmluZSBEdW1wUmVuZGVyVHJlZVN1 cHBvcnRHdGtfaAogCisjaW5jbHVkZSAiSlNTdHJpbmdSZWYuaCIKKwogY2xhc3MgRHVtcFJlbmRl clRyZWVTdXBwb3J0R3RrIHsKIAogcHVibGljOgpAQCAtMzAsNiArMzIsNyBAQCBwdWJsaWM6CiAK ICAgICBzdGF0aWMgdm9pZCBzZXRMaW5rc0luY2x1ZGVkSW5Gb2N1c0NoYWluKGJvb2wpOwogICAg IHN0YXRpYyBib29sIGxpbmtzSW5jbHVkZWRJbkZvY3VzQ2hhaW4oKTsKKyAgICBzdGF0aWMgSlNW YWx1ZVJlZiBub2Rlc0Zyb21SZWN0KEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU1ZhbHVlUmVmIHZh bHVlLCBpbnQgeCwgaW50IHksIHVuc2lnbmVkIHRvcCwgdW5zaWduZWQgcmlnaHQsIHVuc2lnbmVk IGJvdHRvbSwgdW5zaWduZWQgbGVmdCwgYm9vbCBpZ25vcmVDbGlwcGluZyk7CiAKIHByaXZhdGU6 CiAgICAgc3RhdGljIGJvb2wgc19kcnRSdW47CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9DaGFu Z2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggN2M4YzVkYS4uODA4MTNlMiAxMDA2 NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTExLTEyICBKb29uZSBIdXIgIDxqb29uZUBrbGRwLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RL XVtEUlRdIEltcGxlbWVudCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6bm9kZXNGcm9tUmVjdAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY1OTgKKworICAg ICAgICBTdXBwb3J0IG5vZGVzRnJvbVJlY3QgaW4gRFJUCisKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsuY3BwOgorICAgICAgICAoTGF5b3V0VGVz dENvbnRyb2xsZXI6Om5vZGVzRnJvbVJlY3QpOgorCiAyMDEwLTExLTExICBEaXJrIFByYW5rZSAg PGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4u CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENv bnRyb2xsZXJHdGsuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0xheW91dFRl c3RDb250cm9sbGVyR3RrLmNwcAppbmRleCBhYjcwYTNlLi4zOWZiMTE2IDEwMDY0NAotLS0gYS9X ZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsuY3Bw CisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJvbGxl ckd0ay5jcHAKQEAgLTE0MCw4ICsxNDAsNyBAQCBKU1ZhbHVlUmVmIExheW91dFRlc3RDb250cm9s bGVyOjpjb21wdXRlZFN0eWxlSW5jbHVkaW5nVmlzaXRlZEluZm8oSlNDb250ZXh0UmVmCiAKIEpT VmFsdWVSZWYgTGF5b3V0VGVzdENvbnRyb2xsZXI6Om5vZGVzRnJvbVJlY3QoSlNDb250ZXh0UmVm IGNvbnRleHQsIEpTVmFsdWVSZWYgdmFsdWUsIGludCB4LCBpbnQgeSwgdW5zaWduZWQgdG9wLCB1 bnNpZ25lZCByaWdodCwgdW5zaWduZWQgYm90dG9tLCB1bnNpZ25lZCBsZWZ0LCBib29sIGlnbm9y ZUNsaXBwaW5nKQogewotICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQgdGhpcy4KLSAgICByZXR1cm4g SlNWYWx1ZU1ha2VVbmRlZmluZWQoY29udGV4dCk7CisgICAgcmV0dXJuIER1bXBSZW5kZXJUcmVl U3VwcG9ydEd0azo6bm9kZXNGcm9tUmVjdChjb250ZXh0LCB2YWx1ZSwgeCwgeSwgdG9wLCByaWdo dCwgYm90dG9tLCBsZWZ0LCBpZ25vcmVDbGlwcGluZyk7CiB9CiAKIEpTUmV0YWluUHRyPEpTU3Ry aW5nUmVmPiBMYXlvdXRUZXN0Q29udHJvbGxlcjo6bGF5ZXJUcmVlQXNUZXh0KCkgY29uc3QK