46573 2010-09-25 14:16:51 -0700 REGRESSION: charset="utf-8" (with quotes) doesn't work 2010-12-12 00:06:58 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED InRadar, Regression P1 Normal --- 1 max ap abarth alice.barraclough ap commit-queue eric webkit.review.bot oldest_to_newest 285050 0 max 2010-09-25 14:16:51 -0700 Beginning with r64889, any html code received from XHR is incorrectly interpreted against latin1, ignoring the "charset="utf-8"'directive in Content-Type. The last well behaving release is r64816 This bug have been there years ago and corrected. BTW. I'm pretty sure I already reported this bug (I mean with this very release information) but can't find it anymore. 285085 1 ap 2010-09-25 21:56:32 -0700 Could you please provide an example page, or a reduced test case? Does this page work in Firefox? The only suspicious change in this range is one where we made charset name parsing more strict. If a resource used something weird like "utf_8" or "u-t-f-8", then we'd no longer treat it as utf-8. But common forms are all supposed to work. 285104 2 max 2010-09-26 04:18:40 -0700 Alexey, The test page was working in Firefox. Nevertheless, your comment directed me to the point. I was serving the header as: Content-type: text/html; charset="utf-8" rather than : Content-type: text/html; charset=utf-8 Notice that the encoding was a quoted string in the faulty page. The Content-type specification (http://www.w3.org/Protocols/rfc1341/4_Content-Type.html) allows quoted strings for parameter values, but I'm not sure the specific charset parameter does. Maybe not. So, it's up to you to decide if the parsing is indeed too strict. Should we allow quoted strings there? Beside, you may close the bug. 285123 3 ap 2010-09-26 10:19:34 -0700 Thank you, this is certainly a bug. It's not even limited to XMLHttpRequest, in fact. Technically, the bug is in closed source networking code used by WebKit, but we'll need to add a workaround. 285124 4 ap 2010-09-26 10:20:33 -0700 <rdar://problem/8479389> 320456 5 76270 ap 2010-12-10 15:38:08 -0800 Created attachment 76270 proposed fix Firefox also seems to support single quotes, but IE doesn't. RFC 2616 also seems to only allow double quotes. 320552 6 76270 commit-queue 2010-12-10 19:31:54 -0800 Comment on attachment 76270 proposed fix Rejecting attachment 76270 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: /CommitQueue/WebKitBuild/WebKit.build/Debug/WebKit.build/Objects-normal/x86_64/WebPluginContainerCheck.o /Projects/CommitQueue/WebKit/mac/Plugins/WebPluginContainerCheck.mm normal x86_64 objective-c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebKit.build/Debug/WebKit.build/Objects-normal/x86_64/WebTextCompletionController.o /Projects/CommitQueue/WebKit/mac/WebView/WebTextCompletionController.mm normal x86_64 objective-c++ com.apple.compilers.gcc.4_2 (27 failures) Full output: http://queues.webkit.org/results/6900032 320566 7 76270 ap 2010-12-10 20:56:11 -0800 Comment on attachment 76270 proposed fix What? 320572 8 eric 2010-12-10 21:01:12 -0800 This machine is having trouble with XCode. It's unclear why. I'll see if I can blow some caches or something. 320592 9 76270 webkit.review.bot 2010-12-10 22:15:37 -0800 Comment on attachment 76270 proposed fix Clearing flags on attachment: 76270 Committed r73836: <http://trac.webkit.org/changeset/73836> 320593 10 webkit.review.bot 2010-12-10 22:15:42 -0800 All reviewed patches have been landed. Closing bug. 320607 11 webkit.review.bot 2010-12-10 22:47:26 -0800 http://trac.webkit.org/changeset/73836 might have broken Leopard Intel Release (Build) and Leopard Intel Debug (Build) 320615 12 ap 2010-12-10 23:22:33 -0800 What? Fixed the build in r73844. 320760 13 ap 2010-12-12 00:06:58 -0800 I was obviously asleep at the wheel, and made a change to ResourceResponseCFNet.cpp instead of a Mac version. Thanks Alice for fixing it properly! 76270 2010-12-10 15:38:08 -0800 2010-12-10 22:15:36 -0800 proposed fix StripQuotes.txt text/plain 4941 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MzgxMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMTItMTAgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2NTczCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS84NDc5Mzg5PiBSRUdSRVNTSU9OOiBjaGFyc2V0PSJ1dGYtOCIgKHdpdGgg cXVvdGVzKSBkb2Vzbid0IHdvcmsKKworICAgICAgICBUZXN0OiBodHRwL3Rlc3RzL21pbWUvcXVv dGVkLWNoYXJzZXQucGhwCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNl UmVzcG9uc2VDRk5ldC5jcHA6IChXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlOjpwbGF0Zm9ybUxh enlJbml0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZVJlc3BvbnNl TWFjLm1tOiAoV2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZTo6cGxhdGZvcm1MYXp5SW5pdCk6Cisg ICAgICAgIFdvcmsgYXJvdW5kIGEgQ0ZOZXR3b3JrIGlzc3VlLCBzdHJpcCBxdW90ZXMgaWYgdGhl eSBhcmUgcHJlc2VudC4KKwogMjAxMC0xMi0xMCAgS2VubmV0aCBSdXNzZWxsICA8a2JyQGdvb2ds ZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYW5vdGhlciBidWlsZCBmaXguICNpbmNsdWRl IDx3dGYvVW51c2VkUGFyYW0uaD4gbmVlZGVkCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY2YvUmVzb3VyY2VSZXNwb25zZUNGTmV0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VSZXNwb25zZUNGTmV0LmNwcAkocmV2aXNpb24gNzM0 NDkpCisrKyBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VSZXNwb25zZUNGTmV0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzksNiArNzksMTEgQEAgdm9pZCBSZXNvdXJjZVJlc3Bv bnNlOjpwbGF0Zm9ybUxhenlJbml0KAogICAgIG1fZXhwZWN0ZWRDb250ZW50TGVuZ3RoID0gQ0ZV UkxSZXNwb25zZUdldEV4cGVjdGVkQ29udGVudExlbmd0aChtX2NmUmVzcG9uc2UuZ2V0KCkpOwog ICAgIG1fdGV4dEVuY29kaW5nTmFtZSA9IENGVVJMUmVzcG9uc2VHZXRUZXh0RW5jb2RpbmdOYW1l KG1fY2ZSZXNwb25zZS5nZXQoKSk7CiAKKyAgICAvLyBXb3JrYXJvdW5kIGZvciA8cmRhcjovL3By b2JsZW0vODc1NzA4OD4sIGNhbiBiZSByZW1vdmVkIG9uY2UgdGhhdCBpcyBmaXhlZC4KKyAgICB1 bnNpZ25lZCB0ZXh0RW5jb2RpbmdOYW1lTGVuZ3RoID0gbV90ZXh0RW5jb2RpbmdOYW1lLmxlbmd0 aCgpOworICAgIGlmICh0ZXh0RW5jb2RpbmdOYW1lTGVuZ3RoID49IDIgJiYgbV90ZXh0RW5jb2Rp bmdOYW1lWzBdID09ICciJyAmJiBtX3RleHRFbmNvZGluZ05hbWVbdGV4dEVuY29kaW5nTmFtZUxl bmd0aCAtIDFdID09ICciJykKKyAgICAgICAgbV90ZXh0RW5jb2RpbmdOYW1lID0gbV90ZXh0RW5j b2RpbmdOYW1lLnN1YnN0cmluZygxLCB0ZXh0RW5jb2RpbmdOYW1lTGVuZ3RoIC0gMik7CisKICAg ICBtX2xhc3RNb2RpZmllZERhdGUgPSB0b1RpbWVUKENGVVJMUmVzcG9uc2VHZXRMYXN0TW9kaWZp ZWREYXRlKG1fY2ZSZXNwb25zZS5nZXQoKSkpOwogCiAgICAgUmV0YWluUHRyPENGU3RyaW5nUmVm PiBzdWdnZXN0ZWRGaWxlbmFtZShBZG9wdENGLCBDRlVSTFJlc3BvbnNlQ29weVN1Z2dlc3RlZEZp bGVuYW1lKG1fY2ZSZXNwb25zZS5nZXQoKSkpOwpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL21hYy9SZXNvdXJjZVJlc3BvbnNlTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VSZXNwb25zZU1hYy5tbQkocmV2aXNpb24gNzM0NDkp CisrKyBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlUmVzcG9uc2VNYWMubW0J KHdvcmtpbmcgY29weSkKQEAgLTc0LDYgKzc0LDEyIEBAIHZvaWQgUmVzb3VyY2VSZXNwb25zZTo6 cGxhdGZvcm1MYXp5SW5pdCgKICAgICBtX21pbWVUeXBlID0gW21fbnNSZXNwb25zZS5nZXQoKSBN SU1FVHlwZV07CiAgICAgbV9leHBlY3RlZENvbnRlbnRMZW5ndGggPSBbbV9uc1Jlc3BvbnNlLmdl dCgpIGV4cGVjdGVkQ29udGVudExlbmd0aF07CiAgICAgbV90ZXh0RW5jb2RpbmdOYW1lID0gW21f bnNSZXNwb25zZS5nZXQoKSB0ZXh0RW5jb2RpbmdOYW1lXTsKKworICAgIC8vIFdvcmthcm91bmQg Zm9yIDxyZGFyOi8vcHJvYmxlbS84NzU3MDg4PiwgY2FuIGJlIHJlbW92ZWQgb25jZSB0aGF0IGlz IGZpeGVkLgorICAgIHVuc2lnbmVkIHRleHRFbmNvZGluZ05hbWVMZW5ndGggPSBtX3RleHRFbmNv ZGluZ05hbWUubGVuZ3RoKCk7CisgICAgaWYgKHRleHRFbmNvZGluZ05hbWVMZW5ndGggPj0gMiAm JiBtX3RleHRFbmNvZGluZ05hbWVbMF0gPT0gJyInICYmIG1fdGV4dEVuY29kaW5nTmFtZVt0ZXh0 RW5jb2RpbmdOYW1lTGVuZ3RoIC0gMV0gPT0gJyInKQorICAgICAgICBtX3RleHRFbmNvZGluZ05h bWUgPSBtX3RleHRFbmNvZGluZ05hbWUuc3Vic3RyaW5nKDEsIHRleHRFbmNvZGluZ05hbWVMZW5n dGggLSAyKTsKKwogICAgIG1fc3VnZ2VzdGVkRmlsZW5hbWUgPSBbbV9uc1Jlc3BvbnNlLmdldCgp IHN1Z2dlc3RlZEZpbGVuYW1lXTsKICAgICAKICAgICBpZiAoW21fbnNSZXNwb25zZS5nZXQoKSBp c0tpbmRPZkNsYXNzOltOU0hUVFBVUkxSZXNwb25zZSBjbGFzc11dKSB7CkluZGV4OiBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZp c2lvbiA3MzgxMSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDEzIEBACisyMDEwLTEyLTEwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjU3MworICAgICAgICA8cmRh cjovL3Byb2JsZW0vODQ3OTM4OT4gUkVHUkVTU0lPTjogY2hhcnNldD0idXRmLTgiICh3aXRoIHF1 b3RlcykgZG9lc24ndCB3b3JrCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL21pbWUvcXVvdGVkLWNo YXJzZXQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL21pbWUvcXVv dGVkLWNoYXJzZXQucGhwOiBBZGRlZC4KKwogMjAxMC0xMi0xMCAgTWloYWkgUGFycGFyaXRhICA8 bWloYWlwQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIENocm9taXVtIHRlc3Qg ZXhwZWN0YXRpb24gdXBkYXRlLgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taW1lL3F1 b3RlZC1jaGFyc2V0LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRw L3Rlc3RzL21pbWUvcXVvdGVkLWNoYXJzZXQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysg TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taW1lL3F1b3RlZC1jaGFyc2V0LWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKQEAgLTAsMCArMSwzIEBACitTaG91bGQgc2F5IFNVQ0NFU1M6IFNV0KHQodCV U1MKKworVGhlIGxhdHRlciBoYXMgc29tZSBDeXJpbGxpYyBjaGFyYWN0ZXJzIHRoYXQgbG9vayBs aWtlIExhdGluIG9uZXMuIFRoaXMgdGVzdCB2ZXJpZmllcyB0aGF0IGRlY29kaW5nIGlzIGNvcnJl Y3RseSBwZXJmb3JtZWQuCgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9odHRwL3Rl c3RzL21pbWUvcXVvdGVkLWNoYXJzZXQtZXhwZWN0ZWQudHh0Cl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQWRkZWQ6IHN2 bjptaW1lLXR5cGUKICAgKyB0ZXh0L3BsYWluCkFkZGVkOiBzdm46ZW9sLXN0eWxlCiAgICsgbmF0 aXZlCgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taW1lL3F1b3RlZC1jaGFyc2V0LnBo cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pbWUvcXVvdGVkLWNoYXJz ZXQucGhwCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taW1lL3F1b3Rl ZC1jaGFyc2V0LnBocAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMiBAQAorPD9waHAKKyAgICBo ZWFkZXIoJ0NvbnRlbnQtdHlwZTogdGV4dC9odG1sOyBjaGFyc2V0PSJrb2k4LXIiJyk7Cis/Pgor Cis8cD5TaG91bGQgc2F5IFNVQ0NFU1M6IFNV8/PlU1M8L3A+Cis8cD5UaGUgbGF0dGVyIGhhcyBz b21lIEN5cmlsbGljIGNoYXJhY3RlcnMgdGhhdCBsb29rIGxpa2UgTGF0aW4gb25lcy4gVGhpcyB0 ZXN0IHZlcmlmaWVzIHRoYXQgZGVjb2RpbmcKK2lzIGNvcnJlY3RseSBwZXJmb3JtZWQuPC9wPgor Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cis8L3NjcmlwdD4K