46571 2010-09-25 11:44:03 -0700 [jsc] Document the op_strcat opcode 2010-11-09 07:05:40 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zecke zecke oldest_to_newest 285043 0 68836 zecke 2010-09-25 11:44:03 -0700 Created attachment 68836 Patch strcat is currentlty lacking a documentation, attempt to document the semantic based on other comments. 285279 1 68836 abarth 2010-09-26 21:10:56 -0700 Comment on attachment 68836 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68836&action=review > JavaScriptCore/ChangeLog:7 > + Need a short description and bug URL (OOPS!) You're supposed to fill out this part of the ChangeLog. :) > JavaScriptCore/interpreter/Interpreter.cpp:4255 > + consurctor, and puts the result in register dst. consurctor => constructor 285380 2 zecke 2010-09-27 02:39:14 -0700 Landed in r68379. Thanks for the review! 68836 2010-09-25 11:44:03 -0700 2010-09-26 21:10:56 -0700 Patch 20100926024401.patch text/plain 1443 zecke ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBlNDQ4YzM3NjFhMTM1OWQxOGI0OWM2MTM2NDJjNTFjYzI5NzIxYzhhLi5k NDk4N2E1MzlhMGUxZTdlODY0ZTEzYzBhY2Q0Mzk3MWU4NDQ2YmVkIDEwMDY0NAotLS0gYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTAtMDktMjUgIEhvbGdlciBIYW5zIFBldGVyIEZyZXl0aGVyICA8aG9s Z2VyQG1vaWppLW1vYmlsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAganNjOiBEb2N1bWVudCB0aGUgc3RyY2F0IG9wY29kZS4KKworICAgICAg ICBOZWVkIGEgc2hvcnQgZGVzY3JpcHRpb24gYW5kIGJ1ZyBVUkwgKE9PUFMhKQorCisgICAgICAg ICogaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwOgorICAgICAgICAoSlNDOjpJbnRlcnByZXRl cjo6cHJpdmF0ZUV4ZWN1dGUpOgorCiAyMDEwLTA5LTIxICBIb2xnZXIgSGFucyBQZXRlciBGcmV5 dGhlciAgPGhvbGdlckBtb2lqaS1tb2JpbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50 ZXJwcmV0ZXIuY3BwIGIvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3Bw CmluZGV4IGY4YWJjNmE4MDM2ODIzMDQwNTU5NTRhOGVmMjM5OGQyZmY2Nzg0NzMuLjhiZGUyZTNl MzgxODI0ZDg3MzUyYTcwNDRhOTI2NWUwMTBjMDc5YWIgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRD b3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS9pbnRl cnByZXRlci9JbnRlcnByZXRlci5jcHAKQEAgLTQyNDksNiArNDI0OSwxNCBAQCBza2lwX2lkX2N1 c3RvbV9zZWxmOgogICAgICAgICBnb3RvIHZtX3Rocm93OwogICAgIH0KICAgICBERUZJTkVfT1BD T0RFKG9wX3N0cmNhdCkgeworCS8qIHN0cmNhdCBkc3Qocikgc3JjKHIpIGNvdW50KG4pCisKKwkg ICBDb25zdHJ1Y3QgYSBuZXcgU3RyaW5nIGluc3RhbmNlIHVzaW5nIHRoZSBvcmlnaW5hbAorCSAg IGNvbnN1cmN0b3IsIGFuZCBwdXRzIHRoZSByZXN1bHQgaW4gcmVnaXN0ZXIgZHN0LgorCSAgIFRo ZSBzdHJpbmcgd2lsbCBiZSB0aGUgcmVzdWx0IG9mIGNvbmNhdGVuYXRpbmcgY291bnQKKwkgICBz dHJpbmdzIHdpdGggdmFsdWVzIHRha2VuIGZyb20gcmVnaXN0ZXJzIHN0YXJ0aW5nIGF0CisJICAg cmVnaXN0ZXIgc3JjLgorCSovCiAgICAgICAgIGludCBkc3QgPSB2UENbMV0udS5vcGVyYW5kOwog ICAgICAgICBpbnQgc3JjID0gdlBDWzJdLnUub3BlcmFuZDsKICAgICAgICAgaW50IGNvdW50ID0g dlBDWzNdLnUub3BlcmFuZDsK