46548 2010-09-24 20:12:38 -0700 [Qt] GraphicsContext::setLineDash() should scale dashOffset to penWidth 2010-09-25 09:25:28 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED http://www.carto.net/svg/samples/animated_bustrack.shtml Qt, QtTriaged P2 Normal --- 1 kling webkit-unassigned abarth ariya.hidayat eric rhodovan.u-szeged webkit.review.bot oldest_to_newest 284930 0 kling 2010-09-24 20:12:38 -0700 Qt's setLineDash() currently scales the dash array to the painter's penWidth, but not the dashOffset. This causes incorrect rendering of http://www.carto.net/svg/samples/animated_bustrack.shtml The problem is also exposed by (at least) one in-tree layout test: - svg/custom/js-repaint-rect-on-path-with-stroke.svg 284933 1 68805 kling 2010-09-24 20:16:25 -0700 Created attachment 68805 Proposed patch 285006 2 68805 kling 2010-09-25 08:44:26 -0700 Comment on attachment 68805 Proposed patch Clearing flags on attachment: 68805 Committed r68331: <http://trac.webkit.org/changeset/68331> 285007 3 kling 2010-09-25 08:44:35 -0700 All reviewed patches have been landed. Closing bug. 285015 4 webkit.review.bot 2010-09-25 09:10:39 -0700 http://trac.webkit.org/changeset/68331 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/68329 http://trac.webkit.org/changeset/68330 http://trac.webkit.org/changeset/68331 285021 5 kling 2010-09-25 09:25:28 -0700 (In reply to comment #4) > http://trac.webkit.org/changeset/68331 might have totally b0rken Qt Linux Release Fixed with <http://trac.webkit.org/changeset/68332> :) 68805 2010-09-24 20:16:25 -0700 2010-09-25 08:44:25 -0700 Proposed patch bug-46548.diff text/plain 1380 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2NhNTYwMi4uMDNiNDc0NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wOS0yNCAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gR3JhcGhpY3NDb250ZXh0OjpzZXRMaW5lRGFzaCgp IHNob3VsZCBzY2FsZSBkYXNoT2Zmc2V0IHRvIHBlbldpZHRoCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjU0OAorCisgICAgICAgIEZpeGVzIGluY29y cmVjdCByZW5kZXJpbmcgb2YgPGh0dHA6Ly93d3cuY2FydG8ubmV0L3N2Zy9zYW1wbGVzL2FuaW1h dGVkX2J1c3RyYWNrLnNodG1sPgorCisgICAgICAgIFRoaXMgaXMgY292ZXJlZCBieSBleGlzdGlu ZyBsYXlvdXQgdGVzdHMgd2hpY2ggbmVlZCB0byBiZSByZWJhc2VsaW5lZC4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dFF0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6c2V0TGluZURhc2gpOgorCiAyMDEwLTA5LTI0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dy YXBoaWNzQ29udGV4dFF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhp Y3NDb250ZXh0UXQuY3BwCmluZGV4IDczZWNlZmIuLjdlNGFmNDAgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwCisrKyBiL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwCkBAIC0xMDAyLDcg KzEwMDIsNyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6c2V0TGluZURhc2goY29uc3QgRGFzaEFy cmF5JiBkYXNoZXMsIGZsb2F0IGRhc2hPZmZzZXQpCiAgICAgICAgICAgICBwYXR0ZXJuLmFwcGVu ZChkYXNoZXNbaSAlIGRhc2hMZW5ndGhdIC8gcGVuV2lkdGgpOwogCiAgICAgICAgIHBlbi5zZXRE YXNoUGF0dGVybihwYXR0ZXJuKTsKLSAgICAgICAgcGVuLnNldERhc2hPZmZzZXQoZGFzaE9mZnNl dCk7CisgICAgICAgIHBlbi5zZXREYXNoT2Zmc2V0KGRhc2hPZmZzZXQgLyBwZW5XaWR0aCk7CiAg ICAgfSBlbHNlCiAgICAgICAgIHBlbi5zZXRTdHlsZShRdDo6U29saWRMaW5lKTsKICAgICBwLT5z ZXRQZW4ocGVuKTsK