46538 2010-09-24 16:40:41 -0700 Canvas: Crash when setting a font with size in 'ex' units 2010-09-28 07:30:33 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) All All RESOLVED FIXED http://samples.msdn.microsoft.com/ietestcenter/html5/canvas/canvas-text-font-002.htm P1 Normal --- 46581 1 kling webkit-unassigned abarth alex ap commit-queue eric gustavo heldercorreia jhanssen mdelaney7 mrobinson webkit.review.bot xan.lopez oldest_to_newest 284847 0 kling 2010-09-24 16:40:41 -0700 This test on the IE9 test center reveals a bug in WebKit: http://samples.msdn.microsoft.com/ietestcenter/html5/canvas/canvas-text-font-002.htm The problem is in CSSPrimitiveValue::computeLengthDouble() which assumes the passed-in style has a usable font(). 285061 1 ap 2010-09-25 16:13:25 -0700 Not a regression from Safari 5.0.2, but crashing on an ietestcenter test is not good. 285066 2 mitz 2010-09-25 16:32:30 -0700 I think this can be fixed by calling newStyle->font().update() after setting the font description on the newStyle. 285115 3 68848 kling 2010-09-26 08:23:12 -0700 Created attachment 68848 Proposed patch Patch using mitz's suggestion. 285131 4 68848 kling 2010-09-26 10:39:42 -0700 Comment on attachment 68848 Proposed patch Clearing flags on attachment: 68848 Committed r68343: <http://trac.webkit.org/changeset/68343> 285132 5 kling 2010-09-26 10:39:52 -0700 All reviewed patches have been landed. Closing bug. 285136 6 webkit.review.bot 2010-09-26 11:15:01 -0700 http://trac.webkit.org/changeset/68343 might have broken GTK Linux 32-bit Release 285153 7 kling 2010-09-26 12:31:03 -0700 Reopening since this broke GTK+. 285362 8 kling 2010-09-27 01:22:29 -0700 CC'ing GTK+ people for a look.. 285407 9 68898 kling 2010-09-27 05:04:57 -0700 Created attachment 68898 Proposed patch v2 Essentially the same patch, except do the update() even if !canvas()->computedStyle() (I guess if the element isn't attached to the document.) Tested on Qt and GTK+. 285593 10 68898 commit-queue 2010-09-27 11:13:24 -0700 Comment on attachment 68898 Proposed patch v2 Rejecting patch 68898 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 68898]" exit_code: 2 Cleaning working directory Updating working directory Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Full output: http://queues.webkit.org/results/4033166 285617 11 68898 eric 2010-09-27 11:32:21 -0700 Comment on attachment 68898 Proposed patch v2 False rejection. Bug in the queue. One of the cluster nodes seems stuck. 285666 12 68898 commit-queue 2010-09-27 12:13:37 -0700 Comment on attachment 68898 Proposed patch v2 Rejecting patch 68898 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 68898]" exit_code: 2 Cleaning working directory Updating working directory Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Full output: http://queues.webkit.org/results/4074125 285677 13 68898 eric 2010-09-27 12:30:00 -0700 Comment on attachment 68898 Proposed patch v2 One of the cq nodes is misbehaving. It should right itself shortly. I can't access it to manually reboot it at this time. 285696 14 68898 commit-queue 2010-09-27 13:14:50 -0700 Comment on attachment 68898 Proposed patch v2 Rejecting patch 68898 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 68898]" exit_code: 2 Cleaning working directory Updating working directory Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Full output: http://queues.webkit.org/results/4066158 285697 15 eric 2010-09-27 13:15:57 -0700 Sorry. Will wait until I know the CQ node is healthy again. 285706 16 68898 eric 2010-09-27 13:26:13 -0700 Comment on attachment 68898 Proposed patch v2 I repaired one of them just now. Git got very upset by some test rebaselinings this morning. It was failing to update. 285990 17 68898 eric 2010-09-27 18:51:58 -0700 Comment on attachment 68898 Proposed patch v2 Please leave the string "Reviewed by NOBODY (OOPS!)." in your ChangeLog if you want this to be handled by the commit-queue. 286214 18 kling 2010-09-28 07:25:51 -0700 Committed r68513: <http://trac.webkit.org/changeset/68513> 286215 19 68898 kling 2010-09-28 07:30:33 -0700 Comment on attachment 68898 Proposed patch v2 > Please leave the string "Reviewed by NOBODY (OOPS!)." in your ChangeLog if you want this to be handled by the commit-queue. D'oh! Thanks Eric. 68848 2010-09-26 08:23:12 -0700 2010-09-27 05:04:57 -0700 Proposed patch bug-46538.diff text/plain 4274 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlNmE4NGM0Li41MWI1ZmM3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDkt MjYgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYW52YXM6IENyYXNoIHdoZW4g c2V0dGluZyBhIGZvbnQgd2l0aCBzaXplIGluICdleCcgdW5pdHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2NTM4CisKKyAgICAgICAgKiBmYXN0L2Nh bnZhcy9jYW52YXMtZm9udC1leC11bml0cy1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAg ICAgICAqIGZhc3QvY2FudmFzL2NhbnZhcy1mb250LWV4LXVuaXRzLWNyYXNoLmh0bWw6IEFkZGVk LgorICAgICAgICAqIGZhc3QvY2FudmFzL3NjcmlwdC10ZXN0cy9jYW52YXMtZm9udC1leC11bml0 cy1jcmFzaC5qczogQWRkZWQuCisKIDIwMTAtMDktMjYgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtZm9udC1leC11bml0cy1jcmFzaC1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtZm9udC1leC11bml0 cy1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4u NDgzMDlmNAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZh cy1mb250LWV4LXVuaXRzLWNyYXNoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEwIEBACitUZXN0 IHRoYXQgc2V0dGluZyBhIGZvbnQgd2l0aCBzaXplIGluICdleCcgdW5pdHMgZG9lc24ndCBjcmFz aC4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdl cywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgY3R4LmZvbnQgPSAnNWV4 IHNhbnMtc2VyaWYnOyBjdHguZm9udCBpcyAnNWV4IHNhbnMtc2VyaWYnCitQQVNTIHN1Y2Nlc3Nm dWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLWZvbnQtZXgtdW5pdHMtY3Jhc2guaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1mb250LWV4LXVuaXRzLWNyYXNoLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uOTFmOTIxNQotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1mb250LWV4LXVuaXRzLWNyYXNoLmh0bWwK QEAgLTAsMCArMSwxMyBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRN TC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4v anMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNv dXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBpZD0i ZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdCBzcmM9 InNjcmlwdC10ZXN0cy9jYW52YXMtZm9udC1leC11bml0cy1jcmFzaC5qcyI+PC9zY3JpcHQ+Cis8 c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8 L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9zY3Jp cHQtdGVzdHMvY2FudmFzLWZvbnQtZXgtdW5pdHMtY3Jhc2guanMgYi9MYXlvdXRUZXN0cy9mYXN0 L2NhbnZhcy9zY3JpcHQtdGVzdHMvY2FudmFzLWZvbnQtZXgtdW5pdHMtY3Jhc2guanMKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNTIwMThlZAotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3NjcmlwdC10ZXN0cy9jYW52YXMtZm9udC1leC11bml0 cy1jcmFzaC5qcwpAQCAtMCwwICsxLDggQEAKK2Rlc2NyaXB0aW9uKCJUZXN0IHRoYXQgc2V0dGlu ZyBhIGZvbnQgd2l0aCBzaXplIGluICdleCcgdW5pdHMgZG9lc24ndCBjcmFzaC4iKTsKKworY3R4 ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnY2FudmFzJykuZ2V0Q29udGV4dCgnMmQnKTsKKwor Y3R4LmZvbnQgPSAiNWV4IHNhbnMtc2VyaWYiOworc2hvdWxkQmUoImN0eC5mb250ID0gJzVleCBz YW5zLXNlcmlmJzsgY3R4LmZvbnQiLCAiJzVleCBzYW5zLXNlcmlmJyIpOworCit2YXIgc3VjY2Vz c2Z1bGx5UGFyc2VkID0gdHJ1ZTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggYjYwZjdjMy4uNTFmYmZiNCAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAx MC0wOS0yNiAgQW5kcmVhcyBLbGluZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbnZhczogQ3Jhc2gg d2hlbiBzZXR0aW5nIGEgZm9udCB3aXRoIHNpemUgaW4gJ2V4JyB1bml0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY1MzgKKworICAgICAgICB1cGRh dGUoKSB0aGUgc3R5bGUncyBmb250IGFmdGVyIHNldHRpbmcgdGhlIHN0eWxlJ3MgZm9udCBkZXNj cmlwdGlvbi4KKyAgICAgICAgTmVlZGVkIGJlY2F1c2UgQ1NTUHJpbWl0aXZlVmFsdWU6OmNvbXB1 dGVMZW5ndGhEb3VibGUoKSBsYXRlciBhc3N1bWVzCisgICAgICAgIHRoYXQgdGhlIHN0eWxlJ3Mg Zm9udCBpcyBwcm9wZXJseSBpbml0aWFsaXplZCAoZm9yIHhIZWlnaHQoKS4pCisKKyAgICAgICAg Rml4ZXMgY3Jhc2ggb24gSUUgdGVzdCBjZW50ZXIncyBjYW52YXMtdGV4dC1mb250LTAwMiB0ZXN0 LgorCisgICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6c2V0Rm9udCk6CisK IDIwMTAtMDktMjYgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvY2Fu dmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAgYi9XZWJDb3JlL2h0bWwvY2FudmFzL0Nh bnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKaW5kZXggMTM0YWI2Ny4uYWIyZDNiYSAxMDA2NDQK LS0tIGEvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCisr KyBiL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcApAQCAt MTY5MCw4ICsxNjkwLDEwIEBAIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpzZXRGb250 KGNvbnN0IFN0cmluZyYgbmV3Rm9udCkKICAgICAvLyBNYXAgdGhlIDxjYW52YXM+IGZvbnQgaW50 byB0aGUgdGV4dCBzdHlsZS4gSWYgdGhlIGZvbnQgdXNlcyBrZXl3b3JkcyBsaWtlIGxhcmdlci9z bWFsbGVyLCB0aGVzZSB3aWxsIHdvcmsKICAgICAvLyByZWxhdGl2ZSB0byB0aGUgY2FudmFzLgog ICAgIFJlZlB0cjxSZW5kZXJTdHlsZT4gbmV3U3R5bGUgPSBSZW5kZXJTdHlsZTo6Y3JlYXRlKCk7 Ci0gICAgaWYgKFJlbmRlclN0eWxlKiBjb21wdXRlZFN0eWxlID0gY2FudmFzKCktPmNvbXB1dGVk U3R5bGUoKSkKKyAgICBpZiAoUmVuZGVyU3R5bGUqIGNvbXB1dGVkU3R5bGUgPSBjYW52YXMoKS0+ Y29tcHV0ZWRTdHlsZSgpKSB7CiAgICAgICAgIG5ld1N0eWxlLT5zZXRGb250RGVzY3JpcHRpb24o Y29tcHV0ZWRTdHlsZS0+Zm9udERlc2NyaXB0aW9uKCkpOworICAgICAgICBuZXdTdHlsZS0+Zm9u dCgpLnVwZGF0ZShuZXdTdHlsZS0+Zm9udCgpLmZvbnRTZWxlY3RvcigpKTsKKyAgICB9CiAKICAg ICAvLyBOb3cgbWFwIHRoZSBmb250IHByb3BlcnR5IGludG8gdGhlIHN0eWxlLgogICAgIENTU1N0 eWxlU2VsZWN0b3IqIHN0eWxlU2VsZWN0b3IgPSBjYW52YXMoKS0+c3R5bGVTZWxlY3RvcigpOwo= 68898 2010-09-27 05:04:57 -0700 2010-09-28 07:30:33 -0700 Proposed patch v2 bug-46538-v2.diff text/plain 1629 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODQ4NzI0Yi4uMDE3NGUzMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOSBAQAogMjAxMC0wOS0yNyAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgogCisgICAgICAgIENhbnZhczogQ3Jhc2ggd2hl biBzZXR0aW5nIGEgZm9udCB3aXRoIHNpemUgaW4gJ2V4JyB1bml0cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY1MzgKKworICAgICAgICB1cGRhdGUo KSB0aGUgc3R5bGUncyBmb250IGFmdGVyIHNldHRpbmcgdGhlIHN0eWxlJ3MgZm9udCBkZXNjcmlw dGlvbi4KKyAgICAgICAgTmVlZGVkIGJlY2F1c2UgQ1NTUHJpbWl0aXZlVmFsdWU6OmNvbXB1dGVM ZW5ndGhEb3VibGUoKSBsYXRlciBhc3N1bWVzCisgICAgICAgIHRoYXQgdGhlIHN0eWxlJ3MgZm9u dCBpcyBwcm9wZXJseSBpbml0aWFsaXplZCAoZm9yIHhIZWlnaHQoKS4pCisKKyAgICAgICAgRml4 ZXMgY3Jhc2ggb24gSUUgdGVzdCBjZW50ZXIncyBjYW52YXMtdGV4dC1mb250LTAwMiB0ZXN0Lgor CisgICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6c2V0Rm9udCk6CisKKzIw MTAtMDktMjcgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKwogICAg ICAgICBSdWJiZXItc3RhbXBlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KIAogICAg ICAgICBbUXRdIDMyLWJpdCBGbGFzaCBjcmFzaGVzIG9uIHJlcGVhdGVkIFNldFdpbmRvdyBjYWxs cwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0 MkQuY3BwIGIvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3Bw CmluZGV4IDEzNGFiNjcuLmVmY2U5YjAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9jYW52YXMv Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAorKysgYi9XZWJDb3JlL2h0bWwvY2FudmFzL0Nh bnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKQEAgLTE2OTIsNiArMTY5Miw3IEBAIHZvaWQgQ2Fu dmFzUmVuZGVyaW5nQ29udGV4dDJEOjpzZXRGb250KGNvbnN0IFN0cmluZyYgbmV3Rm9udCkKICAg ICBSZWZQdHI8UmVuZGVyU3R5bGU+IG5ld1N0eWxlID0gUmVuZGVyU3R5bGU6OmNyZWF0ZSgpOwog ICAgIGlmIChSZW5kZXJTdHlsZSogY29tcHV0ZWRTdHlsZSA9IGNhbnZhcygpLT5jb21wdXRlZFN0 eWxlKCkpCiAgICAgICAgIG5ld1N0eWxlLT5zZXRGb250RGVzY3JpcHRpb24oY29tcHV0ZWRTdHls ZS0+Zm9udERlc2NyaXB0aW9uKCkpOworICAgIG5ld1N0eWxlLT5mb250KCkudXBkYXRlKG5ld1N0 eWxlLT5mb250KCkuZm9udFNlbGVjdG9yKCkpOwogCiAgICAgLy8gTm93IG1hcCB0aGUgZm9udCBw cm9wZXJ0eSBpbnRvIHRoZSBzdHlsZS4KICAgICBDU1NTdHlsZVNlbGVjdG9yKiBzdHlsZVNlbGVj dG9yID0gY2FudmFzKCktPnN0eWxlU2VsZWN0b3IoKTsK