46537 2010-09-24 16:26:49 -0700 SVG: Avoid calling pow() in genericParseNumber() unless necessary 2010-09-26 10:46:56 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED FIXED Performance P2 Normal --- 1 kling webkit-unassigned commit-queue mdelaney7 zimmermann oldest_to_newest 284834 0 kling 2010-09-24 16:26:49 -0700 We don't need to call pow() if there's no exponent. 0.4% speedup on <http://themaninblue.com/experiment/AnimationBenchmark/svg/> 284837 1 68787 kling 2010-09-24 16:28:13 -0700 Created attachment 68787 Proposed patch 284844 2 68787 kenneth 2010-09-24 16:36:58 -0700 Comment on attachment 68787 Proposed patch Nice ! 284913 3 68787 commit-queue 2010-09-24 18:57:24 -0700 Comment on attachment 68787 Proposed patch Clearing flags on attachment: 68787 Committed r68321: <http://trac.webkit.org/changeset/68321> 284914 4 commit-queue 2010-09-24 18:57:29 -0700 All reviewed patches have been landed. Closing bug. 285130 5 mdelaney7 2010-09-26 10:37:01 -0700 Just out of curiosity, how were you able to accurately/reliably measure a 0.4% speedup? Did you instrument the fps meter from that test to display some sort of longer run - and thus more steady - average? 285135 6 kling 2010-09-26 10:46:56 -0700 (In reply to comment #5) > Just out of curiosity, how were you able to accurately/reliably measure a 0.4% speedup? Did you instrument the fps meter from that test to display some sort of longer run - and thus more steady - average? Using an internal tool that runs something for X frames and measures wall/CPU time spent. Also, testing on a slow device helps a lot with the stability of timings. 68787 2010-09-24 16:28:13 -0700 2010-09-24 18:57:24 -0700 Proposed patch bug-46537.diff text/plain 1274 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDkzZjQ4ZC4uNWNkZDMwZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0yNCAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFNWRzogQXZvaWQgY2FsbGluZyBwb3coKSBpbiBnZW5lcmlj UGFyc2VOdW1iZXIoKSB1bmxlc3MgbmVjZXNzYXJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjUzNworCisgICAgICAgIDAuNCUgc3BlZWR1cCBvbiA8 aHR0cDovL3RoZW1hbmluYmx1ZS5jb20vZXhwZXJpbWVudC9BbmltYXRpb25CZW5jaG1hcmsvc3Zn Lz4KKworICAgICAgICAqIHN2Zy9TVkdQYXJzZXJVdGlsaXRpZXMuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Z2VuZXJpY1BhcnNlTnVtYmVyKTogT25seSBjYWxsIHBvdygpIHdoZW4gd2UgaGF2ZSBh biBleHBvbmVudC4KKwogMjAxMC0wOS0yNCAgTHVpeiBBZ29zdGluaSAgPGx1aXouYWdvc3RpbmlA b3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlz dGlhbnNlbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvc3ZnL1NWR1BhcnNlclV0aWxpdGllcy5jcHAg Yi9XZWJDb3JlL3N2Zy9TVkdQYXJzZXJVdGlsaXRpZXMuY3BwCmluZGV4IGI4YjZkODUuLmMzN2Qy MDcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvc3ZnL1NWR1BhcnNlclV0aWxpdGllcy5jcHAKKysrIGIv V2ViQ29yZS9zdmcvU1ZHUGFyc2VyVXRpbGl0aWVzLmNwcApAQCAtMTEzLDcgKzExMywxMCBAQCB0 ZW1wbGF0ZSA8dHlwZW5hbWUgRmxvYXRUeXBlPiBzdGF0aWMgYm9vbCBnZW5lcmljUGFyc2VOdW1i ZXIoY29uc3QgVUNoYXIqJiBwdHIsCiAgICAgfQogCiAgICAgbnVtYmVyID0gaW50ZWdlciArIGRl Y2ltYWw7Ci0gICAgbnVtYmVyICo9IHNpZ24gKiBzdGF0aWNfY2FzdDxGbG9hdFR5cGU+KHBvdygx MC4wLCBleHBzaWduICogZXhwb25lbnQpKTsKKyAgICBudW1iZXIgKj0gc2lnbjsKKworICAgIGlm IChleHBvbmVudCkKKyAgICAgICAgbnVtYmVyICo9IHN0YXRpY19jYXN0PEZsb2F0VHlwZT4ocG93 KDEwLjAsIGV4cHNpZ24gKiBleHBvbmVudCkpOwogCiAgICAgaWYgKHN0YXJ0ID09IHB0cikKICAg ICAgICAgcmV0dXJuIGZhbHNlOwo=