46531 2010-09-24 15:32:24 -0700 Autocorrection panel is shown at incorrect location when WebView is scrolled. 2010-09-28 11:48:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 jiapu.mail webkit-unassigned commit-queue mitz simon.fraser oldest_to_newest 284769 0 jiapu.mail 2010-09-24 15:32:24 -0700 <rdar://problem/8455376> When the size of WebView is larger than the containing view (i.e. the scroll bar is shown). The correction panel ends up showing the bubble outside of the window. Because the coordinate used for displaying the panel is in the page's system not the view's. 285688 1 68945 jiapu.mail 2010-09-27 12:56:31 -0700 Created attachment 68945 Proposed patch (v1) 286069 2 68945 mitz 2010-09-27 22:31:20 -0700 Comment on attachment 68945 Proposed patch (v1) View in context: https://bugs.webkit.org/attachment.cgi?id=68945&action=review > WebCore/editing/Editor.cpp:2719 > + RefPtr<ClientRect> clientRect = rangeToReplace->getBoundingClientRect(); I don’t think getBoundingClientRect() is appropriate here. It is high-level DOM API which calls updateLayoutIgnorePendingStylesheets() and creates a DOM object (ClientRect) which you don’t need for the client interface. I think you should call getBorderAndTextQuads() directly to get a vector of quads in view coordinates. 286340 3 69067 jiapu.mail 2010-09-28 10:24:52 -0700 Created attachment 69067 Proposed patch (v2) Revised per comment #2. 286413 4 69067 commit-queue 2010-09-28 11:48:20 -0700 Comment on attachment 69067 Proposed patch (v2) Clearing flags on attachment: 69067 Committed r68547: <http://trac.webkit.org/changeset/68547> 286414 5 commit-queue 2010-09-28 11:48:26 -0700 All reviewed patches have been landed. Closing bug. 68945 2010-09-27 12:56:31 -0700 2010-09-28 10:24:52 -0700 Proposed patch (v1) webkit_bug46531.patch text/plain 3350 jiapu.mail SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODQwNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDktMjcgIEppYSBQdSAgPGpwdUBhcHBsZS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXV0b2NvcnJlY3Rp b24gcGFuZWwgaXMgc2hvd24gYXQgaW5jb3JyZWN0IGxvY2F0aW9uIHdoZW4gV2ViVmlldyBpcyBz Y3JvbGxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ2NTMxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NDU1Mzc2PgorCisgICAgICAgICogZWRp dGluZy9FZGl0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjptYXJrQWxsTWlzc3Bl bGxpbmdzQW5kQmFkR3JhbW1hckluUmFuZ2VzKTogVXNlIFJhbmdlOjpnZXRCb3VuZGluZ0NsaWVu dFJlY3QoKQorICAgICAgICAgIGluc3RlYWQgb2YgUmFuZ2U6OnRleHRRdWFkcygpLgorCisgICAg ICAgICogcGFnZS9FZGl0b3JDbGllbnQuaDogQWRkZWQgY29tbWVudCB0byBjbGFyaWZ5IHVzYWdl IG9mIHNob3dDb3JyZWN0aW9uUGFuZWwoKS4KKwogMjAxMC0wOS0yNyAgUGhpbGlwcGUgTm9ybWFu ZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJv Ymluc29uLgpJbmRleDogV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAJKHJldmlzaW9uIDY4NDA1KQorKysgV2ViQ29yZS9l ZGl0aW5nL0VkaXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM2LDYgKzM2LDcgQEAKICNpbmNs dWRlICJDU1NTdHlsZVNlbGVjdG9yLmgiCiAjaW5jbHVkZSAiQ1NTVmFsdWVLZXl3b3Jkcy5oIgog I2luY2x1ZGUgIkNoYXJhY3Rlck5hbWVzLmgiCisjaW5jbHVkZSAiQ2xpZW50UmVjdC5oIgogI2lu Y2x1ZGUgIkNsaXBib2FyZEV2ZW50LmgiCiAjaW5jbHVkZSAiQ29tcG9zaXRpb25FdmVudC5oIgog I2luY2x1ZGUgIkNyZWF0ZUxpbmtDb21tYW5kLmgiCkBAIC0yNzE1LDEyICsyNzE2LDggQEAgdm9p ZCBFZGl0b3I6Om1hcmtBbGxNaXNzcGVsbGluZ3NBbmRCYWRHcgogI2lmIFBMQVRGT1JNKE1BQykg JiYgIWRlZmluZWQoQlVJTERJTkdfT05fVElHRVIpICYmICFkZWZpbmVkKEJVSUxESU5HX09OX0xF T1BBUkQpICYmICFkZWZpbmVkKEJVSUxESU5HX09OX1NOT1dfTEVPUEFSRCkKICAgICAgICAgICAg ICAgICAgICAgaWYgKHNob3VsZFNob3dDb3JyZWN0aW9uUGFuZWwgJiYgcmVzdWx0TG9jYXRpb24g KyByZXN1bHRMZW5ndGggPT0gc3BlbGxpbmdSYW5nZUVuZE9mZnNldCAmJiByZXN1bHQtPnR5cGUg PT0gVGV4dENoZWNraW5nVHlwZUNvcnJlY3Rpb24pIHsKICAgICAgICAgICAgICAgICAgICAgICAg IC8vIFdlIG9ubHkgc2hvdyB0aGUgY29ycmVjdGlvbiBwYW5lbCBvbiB0aGUgbGFzdCB3b3JkLgot ICAgICAgICAgICAgICAgICAgICAgICAgVmVjdG9yPEZsb2F0UXVhZD4gdGV4dFF1YWRzOwotICAg ICAgICAgICAgICAgICAgICAgICAgcmFuZ2VUb1JlcGxhY2UtPnRleHRRdWFkcyh0ZXh0UXVhZHMp OwotICAgICAgICAgICAgICAgICAgICAgICAgVmVjdG9yPEZsb2F0UXVhZD46OmNvbnN0X2l0ZXJh dG9yIGVuZCA9IHRleHRRdWFkcy5lbmQoKTsKLSAgICAgICAgICAgICAgICAgICAgICAgIEZsb2F0 UmVjdCB0b3RhbEJvdW5kaW5nQm94OwotICAgICAgICAgICAgICAgICAgICAgICAgZm9yIChWZWN0 b3I8RmxvYXRRdWFkPjo6Y29uc3RfaXRlcmF0b3IgaXQgPSB0ZXh0UXVhZHMuYmVnaW4oKTsgaXQg PCBlbmQ7ICsraXQpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgdG90YWxCb3VuZGluZ0Jv eC51bml0ZShpdC0+Ym91bmRpbmdCb3goKSk7CisgICAgICAgICAgICAgICAgICAgICAgICBSZWZQ dHI8Q2xpZW50UmVjdD4gY2xpZW50UmVjdCA9IHJhbmdlVG9SZXBsYWNlLT5nZXRCb3VuZGluZ0Ns aWVudFJlY3QoKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIEZsb2F0UmVjdCB0b3RhbEJvdW5k aW5nQm94KGNsaWVudFJlY3QtPmxlZnQoKSwgY2xpZW50UmVjdC0+dG9wKCksIGNsaWVudFJlY3Qt PndpZHRoKCksIGNsaWVudFJlY3QtPmhlaWdodCgpKTsKICAgICAgICAgICAgICAgICAgICAgICAg IG1fcmFuZ2VUb0JlUmVwbGFjZWRCeUNvcnJlY3Rpb24gPSByYW5nZVRvUmVwbGFjZTsKICAgICAg ICAgICAgICAgICAgICAgICAgIG1fc3RyaW5nVG9CZVJlcGxhY2VkQnlDb3JyZWN0aW9uID0gcmVw bGFjZWRTdHJpbmc7CiAgICAgICAgICAgICAgICAgICAgICAgICBjbGllbnQoKS0+c2hvd0NvcnJl Y3Rpb25QYW5lbCh0b3RhbEJvdW5kaW5nQm94LCBtX3N0cmluZ1RvQmVSZXBsYWNlZEJ5Q29ycmVj dGlvbiwgcmVzdWx0LT5yZXBsYWNlbWVudCwgdGhpcyk7CkluZGV4OiBXZWJDb3JlL3BhZ2UvRWRp dG9yQ2xpZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0VkaXRvckNsaWVudC5oCShy ZXZpc2lvbiA2ODQwNSkKKysrIFdlYkNvcmUvcGFnZS9FZGl0b3JDbGllbnQuaAkod29ya2luZyBj b3B5KQpAQCAtMTg5LDYgKzE4OSw3IEBAIHB1YmxpYzoKICNlbmRpZgogCiAjaWYgUExBVEZPUk0o TUFDKSAmJiAhZGVmaW5lZChCVUlMRElOR19PTl9USUdFUikgJiYgIWRlZmluZWQoQlVJTERJTkdf T05fTEVPUEFSRCkgJiYgIWRlZmluZWQoQlVJTERJTkdfT05fU05PV19MRU9QQVJEKQorICAgIC8v IFRoZSBjb29yZGluYXRlIG9mIGJvdW5kaW5nQm94T2ZSZXBsYWNlZFN0cmluZyBzaG91bGQgYmUg cmVsYXRpdmUgdG8gdGhlIHRvcC1sZWZ0IGNvcm5lciBvZiBjbGllbnQgdmlldy4KICAgICB2aXJ0 dWFsIHZvaWQgc2hvd0NvcnJlY3Rpb25QYW5lbChjb25zdCBGbG9hdFJlY3QmIGJvdW5kaW5nQm94 T2ZSZXBsYWNlZFN0cmluZywgY29uc3QgU3RyaW5nJiByZXBsYWNlZFN0cmluZywgY29uc3QgU3Ry aW5nJiByZXBsYWNtZW50U3RyaW5nLCBFZGl0b3IqKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGRp c21pc3NDb3JyZWN0aW9uUGFuZWwoYm9vbCBjb3JyZWN0aW9uQWNjZXB0ZWQpID0gMDsKICAgICB2 aXJ0dWFsIGJvb2wgaXNTaG93aW5nQ29ycmVjdGlvblBhbmVsKCkgPSAwOwo= 69067 2010-09-28 10:24:52 -0700 2010-09-28 11:48:20 -0700 Proposed patch (v2) webkit_bug46531.patch text/plain 2622 jiapu.mail SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODUyNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDktMjggIEppYSBQdSAgPGpwdUBhcHBsZS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXV0b2NvcnJlY3Rp b24gcGFuZWwgaXMgc2hvd24gYXQgaW5jb3JyZWN0IGxvY2F0aW9uIHdoZW4gV2ViVmlldyBpcyBz Y3JvbGxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ2NTMxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NDU1Mzc2PgorCisgICAgICAgICogZG9t L1JhbmdlLmg6IE1ha2UgZ2V0Qm9yZGVyQW5kVGV4dFF1YWRzKCkgcHVibGljIHNvIHRoYXQgaXQg Y2FuIGJlIHVzZWQgYnkgRWRpdG9yLgorICAgICAgICAqIGVkaXRpbmcvRWRpdG9yLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6bWFya0FsbE1pc3NwZWxsaW5nc0FuZEJhZEdyYW1tYXJJ blJhbmdlcyk6IFJlcGxhY2VkIGNhbGwgdG8gdGV4dFF1YWRzKCkKKyAgICAgICAgICB3aXRoIGdl dEJvcmRlckFuZFRleHRRdWFkcygpLgorCiAyMDEwLTA5LTI4ICBUb3IgQXJuZSBWZXN0YsO4ICA8 dG9yLmFybmUudmVzdGJvQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFz IEtsaW5nLgpJbmRleDogV2ViQ29yZS9kb20vUmFuZ2UuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L2RvbS9SYW5nZS5oCShyZXZpc2lvbiA2ODUyNikKKysrIFdlYkNvcmUvZG9tL1JhbmdlLmgJKHdv cmtpbmcgY29weSkKQEAgLTEwOSw2ICsxMDksNyBAQCBwdWJsaWM6CiAgICAgdm9pZCB0ZXh0UmVj dHMoVmVjdG9yPEludFJlY3Q+JiwgYm9vbCB1c2VTZWxlY3Rpb25IZWlnaHQgPSBmYWxzZSk7CiAg ICAgLy8gVHJhbnNmb3JtLWZyaWVuZGx5CiAgICAgdm9pZCB0ZXh0UXVhZHMoVmVjdG9yPEZsb2F0 UXVhZD4mLCBib29sIHVzZVNlbGVjdGlvbkhlaWdodCA9IGZhbHNlKTsKKyAgICB2b2lkIGdldEJv cmRlckFuZFRleHRRdWFkcyhWZWN0b3I8RmxvYXRRdWFkPiYpIGNvbnN0OwogCiAgICAgdm9pZCBu b2RlQ2hpbGRyZW5DaGFuZ2VkKENvbnRhaW5lck5vZGUqKTsKICAgICB2b2lkIG5vZGVDaGlsZHJl bldpbGxCZVJlbW92ZWQoQ29udGFpbmVyTm9kZSopOwpAQCAtMTQ3LDggKzE0OCw2IEBAIHByaXZh dGU6CiAgICAgZW51bSBBY3Rpb25UeXBlIHsgREVMRVRFX0NPTlRFTlRTLCBFWFRSQUNUX0NPTlRF TlRTLCBDTE9ORV9DT05URU5UUyB9OwogICAgIFBhc3NSZWZQdHI8RG9jdW1lbnRGcmFnbWVudD4g cHJvY2Vzc0NvbnRlbnRzKEFjdGlvblR5cGUsIEV4Y2VwdGlvbkNvZGUmKTsKIAotICAgIHZvaWQg Z2V0Qm9yZGVyQW5kVGV4dFF1YWRzKFZlY3RvcjxGbG9hdFF1YWQ+JikgY29uc3Q7Ci0KICAgICBS ZWZQdHI8RG9jdW1lbnQ+IG1fb3duZXJEb2N1bWVudDsKICAgICBSYW5nZUJvdW5kYXJ5UG9pbnQg bV9zdGFydDsKICAgICBSYW5nZUJvdW5kYXJ5UG9pbnQgbV9lbmQ7CkluZGV4OiBXZWJDb3JlL2Vk aXRpbmcvRWRpdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNw cAkocmV2aXNpb24gNjg1MjYpCisrKyBXZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMjcxNiw3ICsyNzE2LDcgQEAgdm9pZCBFZGl0b3I6Om1hcmtBbGxNaXNzcGVs bGluZ3NBbmRCYWRHcgogICAgICAgICAgICAgICAgICAgICBpZiAoc2hvdWxkU2hvd0NvcnJlY3Rp b25QYW5lbCAmJiByZXN1bHRMb2NhdGlvbiArIHJlc3VsdExlbmd0aCA9PSBzcGVsbGluZ1Jhbmdl RW5kT2Zmc2V0ICYmIHJlc3VsdC0+dHlwZSA9PSBUZXh0Q2hlY2tpbmdUeXBlQ29ycmVjdGlvbikg ewogICAgICAgICAgICAgICAgICAgICAgICAgLy8gV2Ugb25seSBzaG93IHRoZSBjb3JyZWN0aW9u IHBhbmVsIG9uIHRoZSBsYXN0IHdvcmQuCiAgICAgICAgICAgICAgICAgICAgICAgICBWZWN0b3I8 RmxvYXRRdWFkPiB0ZXh0UXVhZHM7Ci0gICAgICAgICAgICAgICAgICAgICAgICByYW5nZVRvUmVw bGFjZS0+dGV4dFF1YWRzKHRleHRRdWFkcyk7CisgICAgICAgICAgICAgICAgICAgICAgICByYW5n ZVRvUmVwbGFjZS0+Z2V0Qm9yZGVyQW5kVGV4dFF1YWRzKHRleHRRdWFkcyk7CiAgICAgICAgICAg ICAgICAgICAgICAgICBWZWN0b3I8RmxvYXRRdWFkPjo6Y29uc3RfaXRlcmF0b3IgZW5kID0gdGV4 dFF1YWRzLmVuZCgpOwogICAgICAgICAgICAgICAgICAgICAgICAgRmxvYXRSZWN0IHRvdGFsQm91 bmRpbmdCb3g7CiAgICAgICAgICAgICAgICAgICAgICAgICBmb3IgKFZlY3RvcjxGbG9hdFF1YWQ+ Ojpjb25zdF9pdGVyYXRvciBpdCA9IHRleHRRdWFkcy5iZWdpbigpOyBpdCA8IGVuZDsgKytpdCkK