46526 2010-09-24 15:23:45 -0700 [chromium] remove unused gtk WebScreenInfoFactory 2010-09-27 11:49:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony agl fishd oldest_to_newest 284759 0 tony 2010-09-24 15:23:45 -0700 [chromium] remove unused gtk WebScreenInfoFactory 284762 1 68768 tony 2010-09-24 15:24:26 -0700 Created attachment 68768 Patch 284786 2 tony 2010-09-24 15:45:54 -0700 Looks like we stopped using this file a long time ago: http://codereview.chromium.org/67145 285219 3 68768 tkent 2010-09-26 18:09:58 -0700 Comment on attachment 68768 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68768&action=review Please be careful of applying ChangeLog diff. > WebKit/chromium/WebKit.gyp:-280 > - 'public/win/WebScreenInfoFactory.h', This change is unrelated. But it's ok. 285643 4 tony 2010-09-27 11:49:40 -0700 Committed r68410: <http://trac.webkit.org/changeset/68410> 68768 2010-09-24 15:24:26 -0700 2010-09-26 18:09:58 -0700 Patch bug-46526-20100924152429.patch text/plain 6402 tony ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDQxNmNhMzE3YzdkZTFkMzY5MDdkNjk1OTU4ZWZjMWIxYmE1M2QyNmIu LjUwZDM0MmUzMzRkOWQzZDRhNmU0OGUzODBkNThmYmE0OTI0NzE2NTcgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSw1ICsxLDE4IEBACiAyMDEwLTA5LTI0ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5v cmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2No cm9taXVtXSByZW1vdmUgdW51c2VkIGd0ayBXZWJTY3JlZW5JbmZvRmFjdG9yeQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY1MjYKKworICAgICAgICBB RkFJQ1QgdGhlc2UgZmlsZXMgYXJlbid0IHJlZmVyZW5jZWQgaW4gY29kZSBvciBieSBneXAuCisK KyAgICAgICAgKiBXZWJLaXQuZ3lwOgorICAgICAgICAqIHB1YmxpYy9ndGsvV2ViU2NyZWVuSW5m b0ZhY3RvcnkuaDogUmVtb3ZlZC4KKyAgICAgICAgKiBzcmMvZ3RrL1dlYlNjcmVlbkluZm9GYWN0 b3J5LmNwcDogUmVtb3ZlZC4KKworMjAxMC0wOS0yNCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21p dW0ub3JnPgorCiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeCBjaHJvbWl1bSBjb21waWxlIGFmdGVy IHI2ODI3NiB3aGljaCByZW5hbWVkCiAgICAgICAgIFJlbmRlcio6Om1pblByZWZXaWR0aCB0byBt aW5QcmVmZXJyZWRMb2dpY2FsV2lkdGguCiAKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9X ZWJLaXQuZ3lwIGIvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAKaW5kZXggNDhmOWRiOGZhNjJm OWJlMzk0NzczZDJhMTBmOWMyMmQ5YjIwY2VkNC4uZjQ0N2Q0MjVmNjdiZmVmYzA3YjJjOTg2MGVk NWJjYzgwZGYxYmIyNCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAKKysr IGIvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAKQEAgLTI3Nyw3ICsyNzcsNiBAQAogICAgICAg ICAgICAgICAgICdwdWJsaWMvd2luL1dlYklucHV0RXZlbnRGYWN0b3J5LmgnLAogICAgICAgICAg ICAgICAgICdwdWJsaWMvd2luL1dlYlNhbmRib3hTdXBwb3J0LmgnLAogICAgICAgICAgICAgICAg ICdwdWJsaWMvd2luL1dlYlNjcmVlbkluZm9GYWN0b3J5LmgnLAotICAgICAgICAgICAgICAgICdw dWJsaWMvd2luL1dlYlNjcmVlbkluZm9GYWN0b3J5LmgnLAogICAgICAgICAgICAgICAgICdzcmMv QXBwbGljYXRpb25DYWNoZUhvc3QuY3BwJywKICAgICAgICAgICAgICAgICAnc3JjL0FwcGxpY2F0 aW9uQ2FjaGVIb3N0SW50ZXJuYWwuaCcsCiAgICAgICAgICAgICAgICAgJ3NyYy9Bc3NlcnRNYXRj aGluZ0VudW1zLmNwcCcsCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL2d0ay9X ZWJTY3JlZW5JbmZvRmFjdG9yeS5oIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9ndGsvV2ViU2Ny ZWVuSW5mb0ZhY3RvcnkuaApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggYzk2NDc0MTY0 NWQ4YjNlMzgzMWI2MjBlNGUxZjZhOTVlNmIwYTA0Ni4uMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMAotLS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL2d0ay9XZWJTY3Jl ZW5JbmZvRmFjdG9yeS5oCisrKyAvZGV2L251bGwKQEAgLTEsNDkgKzAsMCBAQAotLyoKLSAqIENv cHlyaWdodCAoQykgMjAwOSBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgotICoKLSAq IFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGgg b3Igd2l0aG91dAotICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQg dGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQotICogbWV0OgotICoKLSAqICAgICAqIFJlZGlz dHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0 Ci0gKiBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRp c2NsYWltZXIuCi0gKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCBy ZXByb2R1Y2UgdGhlIGFib3ZlCi0gKiBjb3B5cmlnaHQgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29u ZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyCi0gKiBpbiB0aGUgZG9jdW1lbnRh dGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlCi0gKiBkaXN0cmli dXRpb24uCi0gKiAgICAgKiBOZWl0aGVyIHRoZSBuYW1lIG9mIEdvb2dsZSBJbmMuIG5vciB0aGUg bmFtZXMgb2YgaXRzCi0gKiBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBw cm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQotICogdGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNw ZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4KLSAqCi0gKiBUSElTIFNPRlRXQVJFIElT IFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCi0gKiAi QVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywg QlVUIE5PVAotICogTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFO VEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCi0gKiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElT Q0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlSSUdIVAotICogT1dORVIgT1IgQ09O VFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUws Ci0gKiBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVE SU5HLCBCVVQgTk9UCi0gKiBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdP T0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwKLSAqIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJV U0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWQotICogVEhFT1JZ IE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1Ig VE9SVAotICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBB TlkgV0FZIE9VVCBPRiBUSEUgVVNFCi0gKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklT RUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgotICovCi0KLSNpZm5kZWYgV2Vi U2NyZWVuSW5mb0ZhY3RvcnlfaAotI2RlZmluZSBXZWJTY3JlZW5JbmZvRmFjdG9yeV9oCi0KLSNp bmNsdWRlICIuLi9XZWJDb21tb24uaCIKLQotdHlwZWRlZiBzdHJ1Y3QgX0d0a1dpZGdldCBHdGtX aWRnZXQ7Ci0KLW5hbWVzcGFjZSBXZWJLaXQgewotCi1zdHJ1Y3QgV2ViU2NyZWVuSW5mbzsKLQot Y2xhc3MgV2ViU2NyZWVuSW5mb0ZhY3RvcnkgewotcHVibGljOgotICAgIFdFQktJVF9BUEkgc3Rh dGljIFdlYlNjcmVlbkluZm8gc2NyZWVuSW5mbyhHdGtXaWRnZXQqKTsKLX07Ci0KLX0gLy8gbmFt ZXNwYWNlIFdlYktpdAotCi0jZW5kaWYKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMv Z3RrL1dlYlNjcmVlbkluZm9GYWN0b3J5LmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvZ3RrL1dl YlNjcmVlbkluZm9GYWN0b3J5LmNwcApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDgx ZGFhMjVkMTM0YjEwZjQ2OWM3MDE2YjgxNzhlYTE2ZGE2MzhhZS4uMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL2d0ay9XZWJT Y3JlZW5JbmZvRmFjdG9yeS5jcHAKKysrIC9kZXYvbnVsbApAQCAtMSw2MiArMCwwIEBACi0vKgot ICogQ29weXJpZ2h0IChDKSAyMDA5IEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCi0g KiAKLSAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMs IHdpdGggb3Igd2l0aG91dAotICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVk IHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQotICogbWV0OgotICogCi0gKiAgICAg KiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNv cHlyaWdodAotICogbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxv d2luZyBkaXNjbGFpbWVyLgotICogICAgICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3Jt IG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQotICogY29weXJpZ2h0IG5vdGljZSwgdGhpcyBsaXN0 IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgotICogaW4gdGhlIGRv Y3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZQotICog ZGlzdHJpYnV0aW9uLgotICogICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBu b3IgdGhlIG5hbWVzIG9mIGl0cwotICogY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9y c2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20KLSAqIHRoaXMgc29mdHdhcmUgd2l0 aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24uCi0gKiAKLSAqIFRISVMgU09G VFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJTIEFORCBDT05UUklCVVRP UlMKLSAqICJBUyBJUyIgQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5D TFVESU5HLCBCVVQgTk9UCi0gKiBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9G IE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IKLSAqIEEgUEFSVElDVUxBUiBQVVJQT1NF IEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUCi0gKiBPV05F UiBPUiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5D SURFTlRBTCwKLSAqIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VT IChJTkNMVURJTkcsIEJVVCBOT1QKLSAqIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNU SVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLAotICogREFUQSwgT1IgUFJPRklU UzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZCi0g KiBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklM SVRZLCBPUiBUT1JUCi0gKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklT SU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKLSAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4g SUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCi0gKi8KLQotI2lu Y2x1ZGUgImNvbmZpZy5oIgotI2luY2x1ZGUgIldlYlNjcmVlbkluZm9GYWN0b3J5LmgiCi0KLSNp bmNsdWRlICJXZWJTY3JlZW5JbmZvLmgiCi0jaW5jbHVkZSA8Z3RrL2d0ay5oPgotCi1uYW1lc3Bh Y2UgV2ViS2l0IHsKLQotV2ViU2NyZWVuSW5mbyBXZWJTY3JlZW5JbmZvRmFjdG9yeTo6c2NyZWVu SW5mbyhHdGtXaWRnZXQqIHdpZGdldCkKLXsKLSAgICBXZWJTY3JlZW5JbmZvIHJlc3VsdHM7Ci0g ICAgcmVzdWx0cy5kZXB0aCA9IDMyOwotICAgIHJlc3VsdHMuZGVwdGhQZXJDb21wb25lbnQgPSA4 OwotICAgIHJlc3VsdHMuaXNNb25vY2hyb21lID0gZmFsc2U7Ci0KLSAgICBpZiAoIXdpZGdldCkK LSAgICAgICAgcmV0dXJuIHJlc3VsdHM7Ci0KLSAgICBHZGtTY3JlZW4qIHNjcmVlbiA9IGd0a193 aWRnZXRfZ2V0X3NjcmVlbih3aWRnZXQpOwotCi0gICAgcmVzdWx0cy5yZWN0ID0gV2ViUmVjdCgK LSAgICAgICAgMCwgMCwgZ2RrX3NjcmVlbl9nZXRfd2lkdGgoc2NyZWVuKSwgZ2RrX3NjcmVlbl9n ZXRfaGVpZ2h0KHNjcmVlbikpOwotCi0gICAgLy8gSSBkb24ndCBrbm93IG9mIGEgd2F5IHRvIHF1 ZXJ5IHRoZSAibWF4aW1pemUiIHNpemUgb2YgdGhlIHdpbmRvdyAoZS5nLgotICAgIC8vIHNjcmVl biBzaXplIGxlc3Mgc2lkZWJhcnMgZXRjKSBzaW5jZSB0aGlzIGlzIHNvbWV0aGluZyB3aGljaCBv bmx5IHRoZQotICAgIC8vIHdpbmRvdyBtYW5hZ2VyIGtub3dzLgotICAgIHJlc3VsdHMuYXZhaWxh YmxlUmVjdCA9IHJlc3VsdHMucmVjdDsKLQotICAgIHJldHVybiByZXN1bHRzOwotfQotCi19IC8v IG5hbWVzcGFjZSBXZWJLaXQK