46525 2010-09-24 15:18:06 -0700 When animations are paused, play-state can cause them to be unpaused. 2010-11-02 13:48:29 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 46945 1 simon.fraser cmarrin simon.fraser oldest_to_newest 284756 0 simon.fraser 2010-09-24 15:18:06 -0700 Load LayoutTests/animations/play-state.html, and just after the animation starts, pause animations. Note how the animations automatically resume when play-state changes. 284757 1 simon.fraser 2010-09-24 15:18:37 -0700 <rdar://problem/8476959> 303481 2 72698 cmarrin 2010-11-02 11:00:51 -0700 Created attachment 72698 Patch 303494 3 72698 simon.fraser 2010-11-02 11:12:06 -0700 Comment on attachment 72698 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72698&action=review > WebCore/ChangeLog:10 > + "running" and not suspended. Likewise pauses animation when either > + flag is in the right state, There's an incomplete sentence here. > WebCore/page/animation/AnimationBase.cpp:1214 > + bool wantToBePaused = playState == AnimPlayStatePaused || m_compAnim->suspended(); 'wantToBePaused' confuses me. "shouldBePaused", or just "pause" perhaps? > LayoutTests/animations/play-state-suspend.html:83 > + runAnimationTest(expectedValues, setTimers, null, true); Please annotate the parameters, or use variables to make the purposes of 'null' and 'true' clear. 303624 4 cmarrin 2010-11-02 13:48:29 -0700 Made changes suggested by Simon and landed in http://trac.webkit.org/changeset/71161 72698 2010-11-02 11:00:51 -0700 2010-11-02 11:12:06 -0700 Patch bug-46525-20101102110051.patch text/plain 7192 cmarrin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTEzMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTEtMDIgIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdo ZW4gYW5pbWF0aW9ucyBhcmUgcGF1c2VkLCBwbGF5LXN0YXRlIGNhbiBjYXVzZSB0aGVtIHRvIGJl IHVucGF1c2VkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDY1MjUKKworICAgICAgICBDaGFuZ2VkIHVwZGF0ZVBsYXlTdGF0ZSgpIHRvIG9ubHkgdW5w YXVzZSB3aGVuIGJvdGggcGxheVN0YXRlIGlzIAorICAgICAgICAicnVubmluZyIgYW5kIG5vdCBz dXNwZW5kZWQuIExpa2V3aXNlIHBhdXNlcyBhbmltYXRpb24gd2hlbiBlaXRoZXIKKyAgICAgICAg ZmxhZyBpcyBpbiB0aGUgcmlnaHQgc3RhdGUsCisKKyAgICAgICAgVGVzdDogYW5pbWF0aW9ucy9w bGF5LXN0YXRlLXN1c3BlbmQuaHRtbAorCisgICAgICAgICogcGFnZS9hbmltYXRpb24vQW5pbWF0 aW9uQmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBbmltYXRpb25CYXNlOjp1cGRhdGVQbGF5 U3RhdGUpOgorCiAyMDEwLTExLTAyICBDaHJpcyBNYXJyaW4gIDxjbWFycmluQGFwcGxlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJbmRleDogV2ViQ29yZS9wYWdlL2Fu aW1hdGlvbi9BbmltYXRpb25CYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvYW5p bWF0aW9uL0FuaW1hdGlvbkJhc2UuY3BwCShyZXZpc2lvbiA3MTEyNSkKKysrIFdlYkNvcmUvcGFn ZS9hbmltYXRpb24vQW5pbWF0aW9uQmFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyMDgsOSAr MTIwOCwxNSBAQCB2b2lkIEFuaW1hdGlvbkJhc2U6OmZpcmVBbmltYXRpb25FdmVudHNJCiAKIHZv aWQgQW5pbWF0aW9uQmFzZTo6dXBkYXRlUGxheVN0YXRlKEVBbmltUGxheVN0YXRlIHBsYXlTdGF0 ZSkKIHsKLSAgICBib29sIHJ1biA9IHBsYXlTdGF0ZSA9PSBBbmltUGxheVN0YXRlUGxheWluZzsK LSAgICBpZiAocGF1c2VkKCkgPT0gcnVuIHx8IGlzTmV3KCkpCi0gICAgICAgIHVwZGF0ZVN0YXRl TWFjaGluZShydW4gPyBBbmltYXRpb25TdGF0ZUlucHV0UGxheVN0YXRlUnVubmluZyA6IEFuaW1h dGlvblN0YXRlSW5wdXRQbGF5U3RhdGVQYXVzZWQsIC0xKTsKKyAgICAvLyBXaGVuIHdlIGdldCBo ZXJlLCB3ZSBjYW4gaGF2ZSBvbmUgb2YgNCBkZXNpcmVkIHN0YXRlczogcnVubmluZywgcGF1c2Vk LCBzdXNwZW5kZWQsIHBhdXNlZCAmIHN1c3BlbmRlZC4KKyAgICAvLyBUaGUgc3RhdGUgbWFjaGlu ZSBjYW4gYmUgaW4gb25lIG9mIHR3byBzdGF0ZXM6IHJ1bm5pbmcsIHBhdXNlZC4KKyAgICAvLyBT ZXQgdGhlIHN0YXRlIG1hY2hpbmUgdG8gdGhlIGRlc2lyZWQgc3RhdGUuCisgICAgYm9vbCB3YW50 VG9CZVBhdXNlZCA9IHBsYXlTdGF0ZSA9PSBBbmltUGxheVN0YXRlUGF1c2VkIHx8IG1fY29tcEFu aW0tPnN1c3BlbmRlZCgpOworICAgIAorICAgIGlmICh3YW50VG9CZVBhdXNlZCA9PSBwYXVzZWQo KSAmJiAhaXNOZXcoKSkKKyAgICAgICAgcmV0dXJuOworICAgIAorICAgIHVwZGF0ZVN0YXRlTWFj aGluZSh3YW50VG9CZVBhdXNlZCA/ICBBbmltYXRpb25TdGF0ZUlucHV0UGxheVN0YXRlUGF1c2Vk IDogQW5pbWF0aW9uU3RhdGVJbnB1dFBsYXlTdGF0ZVJ1bm5pbmcsIC0xKTsKIH0KIAogZG91Ymxl IEFuaW1hdGlvbkJhc2U6OnRpbWVUb05leHRTZXJ2aWNlKCkKSW5kZXg6IExheW91dFRlc3RzL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDcx MTMwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTYgQEAKKzIwMTAtMTEtMDIgIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gYW5pbWF0 aW9ucyBhcmUgcGF1c2VkLCBwbGF5LXN0YXRlIGNhbiBjYXVzZSB0aGVtIHRvIGJlIHVucGF1c2Vk LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY1MjUK KworICAgICAgICBUZXN0cyB0aGF0IGFuaW1hdGlvbiBzdGF5cyBwYXVzZWQgd2hlbiBzZXR0aW5n IHBsYXktc3RhdGUgdG8gInJ1bm5pbmciCisgICAgICAgIGJ1dCBhbmltYXRpb25zIGFyZSBzdXNw ZW5kZWQuCisKKyAgICAgICAgKiBhbmltYXRpb25zL3BsYXktc3RhdGUtc3VzcGVuZC1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGFuaW1hdGlvbnMvcGxheS1zdGF0ZS1zdXNwZW5kLmh0 bWw6IEFkZGVkLgorCiAyMDEwLTExLTAyICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4K IAogICAgICAgICBTa2lwIGFub3RoZXIgdGVzdCB0aGF0IGZhaWxzIGluIFdlYktpdDIKSW5kZXg6 IExheW91dFRlc3RzL2FuaW1hdGlvbnMvcGxheS1zdGF0ZS1zdXNwZW5kLWV4cGVjdGVkLnR4dAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hbmltYXRpb25zL3BsYXktc3RhdGUtc3VzcGVuZC1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9hbmltYXRpb25zL3BsYXkt c3RhdGUtc3VzcGVuZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTEgQEAK K1RoaXMgdGVzdCBtYWtlcyBzdXJlIGEgcGxheS1zdGF0ZSBjaGFuZ2UgaW4gYW4gYW5pbWF0aW9u IGR1cmluZyBzdXNwZW5kIGRvZXMgbm90IHJlc3VtZSB0aGUgYW5pbWF0aW9uLgorCitQQVNTIC0g IndlYmtpdFRyYW5zZm9ybSIgcHJvcGVydHkgZm9yICJib3gxIiBlbGVtZW50IGF0IDAuNTVzIHNh dyBzb21ldGhpbmcgY2xvc2UgdG86IDEsMCwwLDEsMTAwLDAKK1BBU1MgLSAibGVmdCIgcHJvcGVy dHkgZm9yICJib3gyIiBlbGVtZW50IGF0IDAuNTVzIHNhdyBzb21ldGhpbmcgY2xvc2UgdG86IDEw MAorUEFTUyAtICJ3ZWJraXRUcmFuc2Zvcm0iIHByb3BlcnR5IGZvciAiYm94MSIgZWxlbWVudCBh dCAwLjY1cyBzYXcgc29tZXRoaW5nIGNsb3NlIHRvOiAxLDAsMCwxLDEwMCwwCitQQVNTIC0gImxl ZnQiIHByb3BlcnR5IGZvciAiYm94MiIgZWxlbWVudCBhdCAwLjY1cyBzYXcgc29tZXRoaW5nIGNs b3NlIHRvOiAxMDAKK1BBU1MgLSAid2Via2l0VHJhbnNmb3JtIiBwcm9wZXJ0eSBmb3IgImJveDEi IGVsZW1lbnQgYXQgMC43NXMgc2F3IHNvbWV0aGluZyBjbG9zZSB0bzogMSwwLDAsMSwxMDAsMAor UEFTUyAtICJsZWZ0IiBwcm9wZXJ0eSBmb3IgImJveDIiIGVsZW1lbnQgYXQgMC43NXMgc2F3IHNv bWV0aGluZyBjbG9zZSB0bzogMTAwCitQQVNTIC0gIndlYmtpdFRyYW5zZm9ybSIgcHJvcGVydHkg Zm9yICJib3gxIiBlbGVtZW50IGF0IDFzIHNhdyBzb21ldGhpbmcgY2xvc2UgdG86IDEsMCwwLDEs MTQwLDAKK1BBU1MgLSAibGVmdCIgcHJvcGVydHkgZm9yICJib3gyIiBlbGVtZW50IGF0IDFzIHNh dyBzb21ldGhpbmcgY2xvc2UgdG86IDE0MAorCkluZGV4OiBMYXlvdXRUZXN0cy9hbmltYXRpb25z L3BsYXktc3RhdGUtc3VzcGVuZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2FuaW1h dGlvbnMvcGxheS1zdGF0ZS1zdXNwZW5kLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9hbmltYXRpb25zL3BsYXktc3RhdGUtc3VzcGVuZC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCww ICsxLDk3IEBACis8IURPQ1RZUEUgaHRtbCBQVUJMSUMgIi0vL1czQy8vRFREIEhUTUwgNC4wMSBU cmFuc2l0aW9uYWwvL0VOIiAiaHR0cDovL3d3dy53My5vcmcvVFIvaHRtbDQvbG9vc2UuZHRkIj4K KzxodG1sIGxhbmc9ImVuIj4KKzxoZWFkPgorICA8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5 cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsgY2hhcnNldD11dGYtOCI+CisgIDx0aXRsZT5UZXN0IG9m IC13ZWJraXQtYW5pbWF0aW9uLXBsYXktc3RhdGUgaW50ZXJhY3Rpbmcgd2l0aCBzdXNwZW5kQW5p bWF0aW9uPC90aXRsZT4KKyAgPHN0eWxlIHR5cGU9InRleHQvY3NzIiBtZWRpYT0ic2NyZWVuIj4K KyAgICAjYm94MSB7CisgICAgICBoZWlnaHQ6IDEwMHB4OworICAgICAgd2lkdGg6IDEwMHB4Owor ICAgICAgYmFja2dyb3VuZC1jb2xvcjogYmx1ZTsKKyAgICAgIG1hcmdpbjogMDsKKyAgICAgIC13 ZWJraXQtYW5pbWF0aW9uLWR1cmF0aW9uOiAyczsKKyAgICAgIC13ZWJraXQtYW5pbWF0aW9uLXRp bWluZy1mdW5jdGlvbjogbGluZWFyOworICAgICAgLXdlYmtpdC1hbmltYXRpb24tbmFtZTogIm1v dmUxIjsKKyAgICAgIC13ZWJraXQtYW5pbWF0aW9uLXBsYXktc3RhdGU6IHJ1bm5pbmc7CisgICAg fQorICAgIEAtd2Via2l0LWtleWZyYW1lcyAibW92ZTEiIHsKKyAgICAgICAgZnJvbSB7IC13ZWJr aXQtdHJhbnNmb3JtOiB0cmFuc2xhdGVYKDApOyB9CisgICAgICAgIHRvICAgeyAtd2Via2l0LXRy YW5zZm9ybTogdHJhbnNsYXRlWCg0MDBweCk7IH0KKyAgICB9CisgICAgI2JveDIgeworICAgICAg cG9zaXRpb246YWJzb2x1dGU7CisgICAgICB0b3A6IDI2MHB4OworICAgICAgaGVpZ2h0OiAxMDBw eDsKKyAgICAgIHdpZHRoOiAxMDBweDsKKyAgICAgIGJhY2tncm91bmQtY29sb3I6IHJlZDsKKyAg ICAgIC13ZWJraXQtYW5pbWF0aW9uLWR1cmF0aW9uOiAyczsKKyAgICAgIC13ZWJraXQtYW5pbWF0 aW9uLXRpbWluZy1mdW5jdGlvbjogbGluZWFyOworICAgICAgLXdlYmtpdC1hbmltYXRpb24tbmFt ZTogIm1vdmUyIjsKKyAgICB9CisgICAgQC13ZWJraXQta2V5ZnJhbWVzICJtb3ZlMiIgeworICAg ICAgICBmcm9tIHsgbGVmdDogMDsgfQorICAgICAgICB0byAgIHsgbGVmdDogNDAwcHg7IH0KKyAg ICB9CisgIDwvc3R5bGU+CisgIDxzY3JpcHQgc3JjPSJhbmltYXRpb24tdGVzdC1oZWxwZXJzLmpz IiB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIGNoYXJzZXQ9InV0Zi04Ij48L3NjcmlwdD4KKyAgPHNj cmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIGNoYXJzZXQ9InV0Zi04Ij4KKyAgICAKKyAgICBj b25zdCBleHBlY3RlZFZhbHVlcyA9IFsKKyAgICAgIC8vIFthbmltYXRpb24tbmFtZSwgdGltZSwg ZWxlbWVudC1pZCwgcHJvcGVydHksIGV4cGVjdGVkLXZhbHVlLCB0b2xlcmFuY2VdCisgICAgICBb Im1vdmUxIiwgMC41NSwgImJveDEiLCAid2Via2l0VHJhbnNmb3JtIiwgWzEsMCwwLDEsMTAwLDBd LCAxNV0sCisgICAgICBbIm1vdmUxIiwgMC42NSwgImJveDEiLCAid2Via2l0VHJhbnNmb3JtIiwg WzEsMCwwLDEsMTAwLDBdLCAxNV0sCisgICAgICBbIm1vdmUxIiwgMC43NSwgImJveDEiLCAid2Vi a2l0VHJhbnNmb3JtIiwgWzEsMCwwLDEsMTAwLDBdLCAxNV0sCisgICAgICBbIm1vdmUxIiwgMSwg ICAgImJveDEiLCAid2Via2l0VHJhbnNmb3JtIiwgWzEsMCwwLDEsMTQwLDBdLCAyMF0sCisgICAg ICBbIm1vdmUyIiwgMC41NSwgImJveDIiLCAibGVmdCIsIDEwMCwgMTVdLAorICAgICAgWyJtb3Zl MiIsIDAuNjUsICJib3gyIiwgImxlZnQiLCAxMDAsIDE1XSwKKyAgICAgIFsibW92ZTIiLCAwLjc1 LCAiYm94MiIsICJsZWZ0IiwgMTAwLCAxNV0sCisgICAgICBbIm1vdmUyIiwgMSwgICAgImJveDIi LCAibGVmdCIsIDE0MCwgMjBdLAorICAgIF07CisgICAgCisgICAgZnVuY3Rpb24gcGF1c2UoKQor ICAgIHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImJveDEiKS5zdHlsZS53ZWJr aXRBbmltYXRpb25QbGF5U3RhdGUgPSAicGF1c2VkIjsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoImJveDIiKS5zdHlsZS53ZWJraXRBbmltYXRpb25QbGF5U3RhdGUgPSAicGF1c2Vk IjsKKyAgICB9CisKKyAgICBmdW5jdGlvbiBzdXNwZW5kKCkKKyAgICB7CisgICAgICAgIGlmICh3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5zdXNwZW5kQW5pbWF0aW9ucygpOworICAgIH0KKworICAgIGZ1bmN0aW9uIHVucGF1c2Uo KQorICAgIHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImJveDEiKS5zdHlsZS53 ZWJraXRBbmltYXRpb25QbGF5U3RhdGUgPSAicnVubmluZyI7CisgICAgICAgIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJib3gyIikuc3R5bGUud2Via2l0QW5pbWF0aW9uUGxheVN0YXRlID0gInJ1 bm5pbmciOworICAgIH0KKworICAgIGZ1bmN0aW9uIHJlc3VtZSgpCisgICAgeworICAgICAgICBp ZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIucmVzdW1lQW5pbWF0aW9ucygpOworICAgIH0KKworICAgIGZ1bmN0aW9uIHNldFRp bWVycygpCisgICAgeworICAgICAgICBzZXRUaW1lb3V0KHBhdXNlLCA1MDApOworICAgICAgICBz ZXRUaW1lb3V0KHN1c3BlbmQsIDYwMCk7CisgICAgICAgIHNldFRpbWVvdXQodW5wYXVzZSwgNzAw KTsKKyAgICAgICAgc2V0VGltZW91dChyZXN1bWUsIDgwMCk7CisgICAgfQorICAgIAorICAgIHJ1 bkFuaW1hdGlvblRlc3QoZXhwZWN0ZWRWYWx1ZXMsIHNldFRpbWVycywgbnVsbCwgdHJ1ZSk7Cisg ICAgCisgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cD4KK1RoaXMgdGVzdCBtYWtlcyBz dXJlIGEgcGxheS1zdGF0ZSBjaGFuZ2UgaW4gYW4gYW5pbWF0aW9uIGR1cmluZyBzdXNwZW5kIGRv ZXMgbm90IHJlc3VtZSB0aGUgYW5pbWF0aW9uLgorPGRpdiBpZD0iYm94MSI+Cis8L2Rpdj4KKzxk aXYgaWQ9ImJveDIiPgorPC9kaXY+Cis8ZGl2IGlkPSJyZXN1bHQiPgorPC9kaXY+Cis8L2JvZHk+ Cis8L2h0bWw+Cg==