<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>46518</bug_id>
          
          <creation_ts>2010-09-24 14:48:12 -0700</creation_ts>
          <short_desc>need access info from WebInputEvent</short_desc>
          <delta_ts>2010-12-20 22:41:20 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit API</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>wjia</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>brettw</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>fishd</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>wjia</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>284720</commentid>
    <comment_count>0</comment_count>
    <who name="">wjia</who>
    <bug_when>2010-09-24 14:48:12 -0700</bug_when>
    <thetext>KeyboardEvent doesn&apos;t include all info we need.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>284744</commentid>
    <comment_count>1</comment_count>
      <attachid>68763</attachid>
    <who name="">wjia</who>
    <bug_when>2010-09-24 15:03:09 -0700</bug_when>
    <thetext>Created attachment 68763
obtain WebKeyboardEvent from saved current version</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>284814</commentid>
    <comment_count>2</comment_count>
      <attachid>68782</attachid>
    <who name="">wjia</who>
    <bug_when>2010-09-24 16:13:22 -0700</bug_when>
    <thetext>Created attachment 68782
added missing header file</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>285820</commentid>
    <comment_count>3</comment_count>
    <who name="Brett Wilson (Google)">brettw</who>
    <bug_when>2010-09-27 15:45:19 -0700</bug_when>
    <thetext>This looks fine to me, but I&apos;m not a reviewer. I&apos;ve pinged fishd.

I was originally thinking we could call currentInputEvent in the Pepper event code, but this change is probably more robust.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>286906</commentid>
    <comment_count>4</comment_count>
      <attachid>68782</attachid>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2010-09-29 09:20:48 -0700</bug_when>
    <thetext>Comment on attachment 68782
added missing header file

View in context: https://bugs.webkit.org/attachment.cgi?id=68782&amp;action=review

I think the plan, which I originally suggested to Brett, is flawed.  It is not
sufficient to rely on currentInputEvent like this.

&gt; WebKit/chromium/src/WebPluginContainerImpl.cpp:449
&gt; +        static_cast&lt;const WebKeyboardEvent*&gt;(WebViewImpl::currentInputEvent());

I think this will crash if JavaScript on the page programmatically generates a KeyboardEvent.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>286909</commentid>
    <comment_count>5</comment_count>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2010-09-29 09:23:35 -0700</bug_when>
    <thetext>If currentInputEvent() is null, then we should just use the WebKeyboardEvent generated from the WebCore::KeyboardEvent.  Otherwise, we should still use the generated WebKeyboardEvent but merge in any additional modifiers from currentInputEvent().</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>287137</commentid>
    <comment_count>6</comment_count>
      <attachid>69253</attachid>
    <who name="">wjia</who>
    <bug_when>2010-09-29 14:53:06 -0700</bug_when>
    <thetext>Created attachment 69253
resotre info from currentInputEvent only when it exists

WebKeyboardEvent is restored to be created from KeyboardEvent. Key state (of lock keys) is retrieved from currentInputEvent only when it exists.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>287410</commentid>
    <comment_count>7</comment_count>
      <attachid>69253</attachid>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2010-09-30 00:30:01 -0700</bug_when>
    <thetext>Comment on attachment 69253
resotre info from currentInputEvent only when it exists

View in context: https://bugs.webkit.org/attachment.cgi?id=69253&amp;action=review

&gt; WebKit/chromium/ChangeLog:5
&gt; +        Need access info direct from WebInputEvent.

please insert a link to this bug report here.

also, please revise the description of this change to better reflect what is
being done in the code.

&gt; WebKit/chromium/src/WebPluginContainerImpl.cpp:450
&gt; +        static_cast&lt;const WebKeyboardEvent*&gt;(WebViewImpl::currentInputEvent());

how do you know that this is a WebKeyboardEvent?

&gt; WebKit/chromium/src/WebPluginContainerImpl.cpp:453
&gt; +    if (currentInputEvent) {

Should you also validate that the currentInputEvent is a WebKeyboardEvent?  During
the dispatch of another type of event, JS might dispatch a synthetic KeyboardEvent.

in the future, please remember to set the &apos;?&apos; flag on the &quot;review&quot; field when
attaching your patch.  Otherwise, people won&apos;t know to look at your patch for
review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>287943</commentid>
    <comment_count>8</comment_count>
      <attachid>69399</attachid>
    <who name="">wjia</who>
    <bug_when>2010-09-30 17:08:38 -0700</bug_when>
    <thetext>Created attachment 69399
retrieving lock key state only when stashed event is keyboard event; update Changelog;

Actually, the type checking of stashed event is not really needed since modifiers&apos; capsLock and numLock bits will not be set for events except keyboardEvent. I just add it for safety.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>287948</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-09-30 17:17:27 -0700</bug_when>
    <thetext>Attachment 69399 did not pass style-queue:

Failed to run &quot;[&apos;WebKitTools/Scripts/check-webkit-style&apos;]&quot; exit_code: 1
WebKit/chromium/src/WebPluginContainerImpl.cpp:452:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>287977</commentid>
    <comment_count>10</comment_count>
      <attachid>69408</attachid>
    <who name="">wjia</who>
    <bug_when>2010-09-30 18:12:51 -0700</bug_when>
    <thetext>Created attachment 69408
 retrieving lock key state only when stashed event is keyboard event; update Changelog; fix webkit type checking;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>288071</commentid>
    <comment_count>11</comment_count>
      <attachid>69408</attachid>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2010-09-30 23:18:43 -0700</bug_when>
    <thetext>Comment on attachment 69408
 retrieving lock key state only when stashed event is keyboard event; update Changelog; fix webkit type checking;

R=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>288088</commentid>
    <comment_count>12</comment_count>
      <attachid>69408</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-10-01 00:13:09 -0700</bug_when>
    <thetext>Comment on attachment 69408
 retrieving lock key state only when stashed event is keyboard event; update Changelog; fix webkit type checking;

Rejecting patch 69408 from commit-queue.

Failed to run &quot;[&apos;./WebKitTools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;build-and-test&apos;, &apos;--no-clean&apos;, &apos;--no-update&apos;, &apos;--test&apos;, &apos;--quiet&apos;, &apos;--non-interactive&apos;]&quot; exit_code: 2
Last 500 characters of output:
l.
Files=14, Tests=304,  1 wallclock secs ( 0.63 cusr +  0.14 csys =  0.77 CPU)
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default&apos;.
Running tests from /Users/abarth/git/webkit-queue/LayoutTests
Testing 21431 test cases.
http/tests/navigation/ping-same-origin.html -&gt; failed

Exiting early after 1 failures. 20749 tests run.
425.18s total testing time

20748 test cases (99%) succeeded
1 test case (&lt;1%) had incorrect layout
33 test cases (&lt;1%) had stderr output

Full output: http://queues.webkit.org/results/4229037</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>288101</commentid>
    <comment_count>13</comment_count>
      <attachid>69408</attachid>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2010-10-01 00:54:39 -0700</bug_when>
    <thetext>Comment on attachment 69408
 retrieving lock key state only when stashed event is keyboard event; update Changelog; fix webkit type checking;

Let&apos;s try the commit queue once more.  That test is flaky.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>288112</commentid>
    <comment_count>14</comment_count>
      <attachid>69408</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-10-01 01:07:08 -0700</bug_when>
    <thetext>Comment on attachment 69408
 retrieving lock key state only when stashed event is keyboard event; update Changelog; fix webkit type checking;

Rejecting patch 69408 from commit-queue.

Failed to run &quot;[&apos;./WebKitTools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;apply-attachment&apos;, &apos;--force-clean&apos;, &apos;--non-interactive&apos;, &apos;--quiet&apos;, 69408]&quot; exit_code: 2
Cleaning working directory
Updating working directory
Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=69408&amp;action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=46518&amp;ctype=xml
Processing 1 patch from 1 bug.
Processing patch 69408 from bug 46518.
Failed to run &quot;[u&apos;/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply&apos;, u&apos;--reviewer&apos;, u&apos;Darin Fisher&apos;, u&apos;--force&apos;]&quot; exit_code: 1

Full output: http://queues.webkit.org/results/4241009</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>288269</commentid>
    <comment_count>15</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-10-01 09:04:56 -0700</bug_when>
    <thetext>Patch failed to apply.  working on fixing the output in those cases now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>294237</commentid>
    <comment_count>16</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-10-14 11:37:17 -0700</bug_when>
    <thetext>This needs an updated patch which applies to tip of tree.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>294342</commentid>
    <comment_count>17</comment_count>
      <attachid>70774</attachid>
    <who name="">wjia</who>
    <bug_when>2010-10-14 13:51:42 -0700</bug_when>
    <thetext>Created attachment 70774
update the patch to tip of tree</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>294383</commentid>
    <comment_count>18</comment_count>
      <attachid>70780</attachid>
    <who name="">wjia</who>
    <bug_when>2010-10-14 14:47:35 -0700</bug_when>
    <thetext>Created attachment 70780
retrieve modifiers after ctrl-c is handled

I found this problem when updating the patch to tip of the tree. Please review again. Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>294386</commentid>
    <comment_count>19</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-10-14 14:50:56 -0700</bug_when>
    <thetext>Attachment 70780 did not pass style-queue:

Failed to run &quot;[&apos;WebKitTools/Scripts/check-webkit-style&apos;]&quot; exit_code: 1
WebKit/chromium/src/WebPluginContainerImpl.cpp:475:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>294390</commentid>
    <comment_count>20</comment_count>
      <attachid>70784</attachid>
    <who name="">wjia</who>
    <bug_when>2010-10-14 15:02:31 -0700</bug_when>
    <thetext>Created attachment 70784
update to tip of tree, retrieve modifiers after ctrl-c is handled, fix webkit style checking</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>294599</commentid>
    <comment_count>21</comment_count>
      <attachid>70784</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-10-14 23:33:55 -0700</bug_when>
    <thetext>Comment on attachment 70784
update to tip of tree, retrieve modifiers after ctrl-c is handled, fix webkit style checking

Clearing flags on attachment: 70784

Committed r69840: &lt;http://trac.webkit.org/changeset/69840&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>324814</commentid>
    <comment_count>22</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-12-20 22:41:20 -0800</bug_when>
    <thetext>Please use webkit-patch upload to upload patches so that old patches get obsoleted when you upload new ones.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>68763</attachid>
            <date>2010-09-24 15:03:09 -0700</date>
            <delta_ts>2010-09-29 09:21:21 -0700</delta_ts>
            <desc>obtain WebKeyboardEvent from saved current version</desc>
            <filename>patch.txt</filename>
            <type>text/plain</type>
            <size>2103</size>
            <attacher>wjia</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjgyOTApCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh
bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDktMjQgIFdlaSBK
aWEgIDx3amlhQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBOZWVkIGFjY2VzcyBpbmZvIGRpcmVjdCBmcm9tIFdlYklucHV0RXZl
bnQuCisKKyAgICAgICAgKiBzcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHA6CisgICAgICAg
IChXZWJLaXQ6OldlYlBsdWdpbkNvbnRhaW5lckltcGw6OmhhbmRsZUtleWJvYXJkRXZlbnQpOgor
CiAyMDEwLTA5LTI0ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg
VW5yZXZpZXdlZCwgZml4IGNocm9taXVtIGNvbXBpbGUgYWZ0ZXIgcjY4Mjc2IHdoaWNoIHJlbmFt
ZWQKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHAK
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBs
LmNwcAkocmV2aXNpb24gNjgyOTApCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNv
bnRhaW5lckltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NDQsMTcgKzQ0NCwxOCBAQCB2b2lk
IFdlYlBsdWdpbkNvbnRhaW5lckltcGw6OmhhbmRsZVdoZWVsCiAKIHZvaWQgV2ViUGx1Z2luQ29u
dGFpbmVySW1wbDo6aGFuZGxlS2V5Ym9hcmRFdmVudChLZXlib2FyZEV2ZW50KiBldmVudCkKIHsK
LSAgICBXZWJLZXlib2FyZEV2ZW50QnVpbGRlciB3ZWJFdmVudCgqZXZlbnQpOwotICAgIGlmICh3
ZWJFdmVudC50eXBlID09IFdlYklucHV0RXZlbnQ6OlVuZGVmaW5lZCkKKyAgICBjb25zdCBXZWJL
ZXlib2FyZEV2ZW50KiB3ZWJFdmVudCA9CisgICAgICAgIHN0YXRpY19jYXN0PGNvbnN0IFdlYktl
eWJvYXJkRXZlbnQqPihXZWJWaWV3SW1wbDo6Y3VycmVudElucHV0RXZlbnQoKSk7CisgICAgaWYg
KHdlYkV2ZW50LT50eXBlID09IFdlYklucHV0RXZlbnQ6OlVuZGVmaW5lZCkKICAgICAgICAgcmV0
dXJuOwogCi0gICAgaWYgKHdlYkV2ZW50LnR5cGUgPT0gV2ViSW5wdXRFdmVudDo6S2V5RG93bikg
eworICAgIGlmICh3ZWJFdmVudC0+dHlwZSA9PSBXZWJJbnB1dEV2ZW50OjpLZXlEb3duKSB7CiAj
aWYgZGVmaW5lZChPU19NQUNPU1gpCi0gICAgICAgIGlmICh3ZWJFdmVudC5tb2RpZmllcnMgPT0g
V2ViSW5wdXRFdmVudDo6TWV0YUtleQorICAgICAgICBpZiAod2ViRXZlbnQtPm1vZGlmaWVycyA9
PSBXZWJJbnB1dEV2ZW50OjpNZXRhS2V5CiAjZWxzZQotICAgICAgICBpZiAod2ViRXZlbnQubW9k
aWZpZXJzID09IFdlYklucHV0RXZlbnQ6OkNvbnRyb2xLZXkKKyAgICAgICAgaWYgKHdlYkV2ZW50
LT5tb2RpZmllcnMgPT0gV2ViSW5wdXRFdmVudDo6Q29udHJvbEtleQogI2VuZGlmCi0gICAgICAg
ICAgICAmJiB3ZWJFdmVudC53aW5kb3dzS2V5Q29kZSA9PSBWS0VZX0MpIHsKKyAgICAgICAgICAg
ICYmIHdlYkV2ZW50LT53aW5kb3dzS2V5Q29kZSA9PSBWS0VZX0MpIHsKICAgICAgICAgICAgIGNv
cHkoKTsKICAgICAgICAgICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgpOwogICAgICAgICAg
ICAgcmV0dXJuOwpAQCAtNDYyLDcgKzQ2Myw3IEBAIHZvaWQgV2ViUGx1Z2luQ29udGFpbmVySW1w
bDo6aGFuZGxlS2V5Ym8KICAgICB9CiAKICAgICBXZWJDdXJzb3JJbmZvIGN1cnNvckluZm87Ci0g
ICAgaWYgKG1fd2ViUGx1Z2luLT5oYW5kbGVJbnB1dEV2ZW50KHdlYkV2ZW50LCBjdXJzb3JJbmZv
KSkKKyAgICBpZiAobV93ZWJQbHVnaW4tPmhhbmRsZUlucHV0RXZlbnQoKndlYkV2ZW50LCBjdXJz
b3JJbmZvKSkKICAgICAgICAgZXZlbnQtPnNldERlZmF1bHRIYW5kbGVkKCk7CiB9CiAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>68782</attachid>
            <date>2010-09-24 16:13:22 -0700</date>
            <delta_ts>2010-09-29 09:20:48 -0700</delta_ts>
            <desc>added missing header file</desc>
            <filename>patch.txt</filename>
            <type>text/plain</type>
            <size>2290</size>
            <attacher>wjia</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjgyOTApCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh
bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDktMjQgIFdlaSBK
aWEgIDx3amlhQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBOZWVkIGFjY2VzcyBpbmZvIGRpcmVjdCBmcm9tIFdlYklucHV0RXZl
bnQuCisKKyAgICAgICAgKiBzcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHA6CisgICAgICAg
IChXZWJLaXQ6OldlYlBsdWdpbkNvbnRhaW5lckltcGw6OmhhbmRsZUtleWJvYXJkRXZlbnQpOgor
CiAyMDEwLTA5LTI0ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg
VW5yZXZpZXdlZCwgZml4IGNocm9taXVtIGNvbXBpbGUgYWZ0ZXIgcjY4Mjc2IHdoaWNoIHJlbmFt
ZWQKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHAK
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBs
LmNwcAkocmV2aXNpb24gNjgyOTApCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNv
bnRhaW5lckltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OCw2ICs0OCw3IEBACiAjaW5jbHVk
ZSAiV2ViVVJMRXJyb3IuaCIKICNpbmNsdWRlICJXZWJVUkxSZXF1ZXN0LmgiCiAjaW5jbHVkZSAi
V2ViVmVjdG9yLmgiCisjaW5jbHVkZSAiV2ViVmlld0ltcGwuaCIKICNpbmNsdWRlICJXcmFwcGVk
UmVzb3VyY2VSZXNwb25zZS5oIgogCiAjaW5jbHVkZSAiRXZlbnROYW1lcy5oIgpAQCAtNDQ0LDE3
ICs0NDUsMTggQEAgdm9pZCBXZWJQbHVnaW5Db250YWluZXJJbXBsOjpoYW5kbGVXaGVlbAogCiB2
b2lkIFdlYlBsdWdpbkNvbnRhaW5lckltcGw6OmhhbmRsZUtleWJvYXJkRXZlbnQoS2V5Ym9hcmRF
dmVudCogZXZlbnQpCiB7Ci0gICAgV2ViS2V5Ym9hcmRFdmVudEJ1aWxkZXIgd2ViRXZlbnQoKmV2
ZW50KTsKLSAgICBpZiAod2ViRXZlbnQudHlwZSA9PSBXZWJJbnB1dEV2ZW50OjpVbmRlZmluZWQp
CisgICAgY29uc3QgV2ViS2V5Ym9hcmRFdmVudCogd2ViRXZlbnQgPQorICAgICAgICBzdGF0aWNf
Y2FzdDxjb25zdCBXZWJLZXlib2FyZEV2ZW50Kj4oV2ViVmlld0ltcGw6OmN1cnJlbnRJbnB1dEV2
ZW50KCkpOworICAgIGlmICh3ZWJFdmVudC0+dHlwZSA9PSBXZWJJbnB1dEV2ZW50OjpVbmRlZmlu
ZWQpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmICh3ZWJFdmVudC50eXBlID09IFdlYklucHV0
RXZlbnQ6OktleURvd24pIHsKKyAgICBpZiAod2ViRXZlbnQtPnR5cGUgPT0gV2ViSW5wdXRFdmVu
dDo6S2V5RG93bikgewogI2lmIGRlZmluZWQoT1NfTUFDT1NYKQotICAgICAgICBpZiAod2ViRXZl
bnQubW9kaWZpZXJzID09IFdlYklucHV0RXZlbnQ6Ok1ldGFLZXkKKyAgICAgICAgaWYgKHdlYkV2
ZW50LT5tb2RpZmllcnMgPT0gV2ViSW5wdXRFdmVudDo6TWV0YUtleQogI2Vsc2UKLSAgICAgICAg
aWYgKHdlYkV2ZW50Lm1vZGlmaWVycyA9PSBXZWJJbnB1dEV2ZW50OjpDb250cm9sS2V5CisgICAg
ICAgIGlmICh3ZWJFdmVudC0+bW9kaWZpZXJzID09IFdlYklucHV0RXZlbnQ6OkNvbnRyb2xLZXkK
ICNlbmRpZgotICAgICAgICAgICAgJiYgd2ViRXZlbnQud2luZG93c0tleUNvZGUgPT0gVktFWV9D
KSB7CisgICAgICAgICAgICAmJiB3ZWJFdmVudC0+d2luZG93c0tleUNvZGUgPT0gVktFWV9DKSB7
CiAgICAgICAgICAgICBjb3B5KCk7CiAgICAgICAgICAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRs
ZWQoKTsKICAgICAgICAgICAgIHJldHVybjsKQEAgLTQ2Miw3ICs0NjQsNyBAQCB2b2lkIFdlYlBs
dWdpbkNvbnRhaW5lckltcGw6OmhhbmRsZUtleWJvCiAgICAgfQogCiAgICAgV2ViQ3Vyc29ySW5m
byBjdXJzb3JJbmZvOwotICAgIGlmIChtX3dlYlBsdWdpbi0+aGFuZGxlSW5wdXRFdmVudCh3ZWJF
dmVudCwgY3Vyc29ySW5mbykpCisgICAgaWYgKG1fd2ViUGx1Z2luLT5oYW5kbGVJbnB1dEV2ZW50
KCp3ZWJFdmVudCwgY3Vyc29ySW5mbykpCiAgICAgICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxl
ZCgpOwogfQogCg==
</data>
<flag name="review"
          id="58850"
          type_id="1"
          status="-"
          setter="fishd"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>69253</attachid>
            <date>2010-09-29 14:53:06 -0700</date>
            <delta_ts>2010-09-30 00:30:01 -0700</delta_ts>
            <desc>resotre info from currentInputEvent only when it exists</desc>
            <filename>WebPluginContainer.diff</filename>
            <type>text/plain</type>
            <size>1614</size>
            <attacher>wjia</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjg2ODQpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh
bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDktMjkgIFdlaSBK
aWEgIDx3amlhQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBOZWVkIGFjY2VzcyBpbmZvIGRpcmVjdCBmcm9tIFdlYklucHV0RXZl
bnQuCisKKyAgICAgICAgKiBzcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHA6CisgICAgICAg
IChXZWJLaXQ6OldlYlBsdWdpbkNvbnRhaW5lckltcGw6OmhhbmRsZUtleWJvYXJkRXZlbnQpOgor
CiAyMDEwLTA5LTI5ICBLaW51a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KIAogICAg
ICAgICBVbnJldmlld2VkLCBhZGRpbmcgb25lIG1vcmUgbWlzc2luZyBjaGFuZ2UgZnJvbSB0aGUg
bGFzdCBwYXRjaC4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVy
SW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250
YWluZXJJbXBsLmNwcAkocmV2aXNpb24gNjg2ODQpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dl
YlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OCw2ICs0OCw3IEBA
CiAjaW5jbHVkZSAiV2ViVVJMRXJyb3IuaCIKICNpbmNsdWRlICJXZWJVUkxSZXF1ZXN0LmgiCiAj
aW5jbHVkZSAiV2ViVmVjdG9yLmgiCisjaW5jbHVkZSAiV2ViVmlld0ltcGwuaCIKICNpbmNsdWRl
ICJXcmFwcGVkUmVzb3VyY2VSZXNwb25zZS5oIgogCiAjaW5jbHVkZSAiRXZlbnROYW1lcy5oIgpA
QCAtNDQ1LDYgKzQ0NiwxNSBAQCB2b2lkIFdlYlBsdWdpbkNvbnRhaW5lckltcGw6OmhhbmRsZVdo
ZWVsCiB2b2lkIFdlYlBsdWdpbkNvbnRhaW5lckltcGw6OmhhbmRsZUtleWJvYXJkRXZlbnQoS2V5
Ym9hcmRFdmVudCogZXZlbnQpCiB7CiAgICAgV2ViS2V5Ym9hcmRFdmVudEJ1aWxkZXIgd2ViRXZl
bnQoKmV2ZW50KTsKKyAgICBjb25zdCBXZWJLZXlib2FyZEV2ZW50KiBjdXJyZW50SW5wdXRFdmVu
dCA9CisgICAgICAgIHN0YXRpY19jYXN0PGNvbnN0IFdlYktleWJvYXJkRXZlbnQqPihXZWJWaWV3
SW1wbDo6Y3VycmVudElucHV0RXZlbnQoKSk7CisKKyAgICAvLyBDb3B5IHN0YXNoZWQgaW5mbyBv
dmVyLgorICAgIGlmIChjdXJyZW50SW5wdXRFdmVudCkgeworICAgICAgICB3ZWJFdmVudC5tb2Rp
ZmllcnMgfD0gY3VycmVudElucHV0RXZlbnQtPm1vZGlmaWVycyAmCisgICAgICAgICAgICAoV2Vi
SW5wdXRFdmVudDo6Q2Fwc0xvY2tPbiB8IFdlYklucHV0RXZlbnQ6Ok51bUxvY2tPbik7CisgICAg
fQorCiAgICAgaWYgKHdlYkV2ZW50LnR5cGUgPT0gV2ViSW5wdXRFdmVudDo6VW5kZWZpbmVkKQog
ICAgICAgICByZXR1cm47CiAK
</data>
<flag name="review"
          id="58986"
          type_id="1"
          status="-"
          setter="fishd"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>69399</attachid>
            <date>2010-09-30 17:08:38 -0700</date>
            <delta_ts>2010-09-30 18:12:51 -0700</delta_ts>
            <desc>retrieving lock key state only when stashed event is keyboard event; update Changelog;</desc>
            <filename>WebPluginContainer.diff</filename>
            <type>text/plain</type>
            <size>1921</size>
            <attacher>wjia</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjg4NTMpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh
bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDktMjkgIFdlaSBK
aWEgIDx3amlhQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBSZXRyaWV2ZSBpbmZvIG9mIGxvY2sga2V5cyBmcm9tIHN0YXNoZWQg
Y3VycmVudElucHV0RXZlbnQgd2hpY2gKKyAgICAgICAgaXMgc3RvcmVkIGJ5IGNocm9taXVtIHdo
ZW4gaXQgcGFzc2VzIGlucHV0IGV2ZW50IHRvIFdlYkNvcmUuCisgICAgICAgIFJldHJpZXZpbmcg
b25seSB3aGVuIHN0YXNoZWQgZXZlbnQgaXMgYSBrZXlib2FyZCBldmVudCwgd2hpY2gKKyAgICAg
ICAgbWVhbnMgc3ludGhldGljIEtleWJvYXJkRXZlbnQgaW5oZXJpdHMgbG9jayBrZXkgc3RhdGUg
ZnJvbSByZWFsCisgICAgICAgIGtleWJvYXJkIGV2ZW50LgorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY1MTgKKworICAgICAgICAqIHNyYy9XZWJQbHVn
aW5Db250YWluZXJJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGx1Z2luQ29udGFpbmVy
SW1wbDo6aGFuZGxlS2V5Ym9hcmRFdmVudCk6CisKIDIwMTAtMDktMzAgIEFsZXhleSBNYXJpbmlj
aGV2ICA8YW1hcmluaWNoZXZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IENo
cmlzIE1hcnJpbi4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVy
SW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250
YWluZXJJbXBsLmNwcAkocmV2aXNpb24gNjg4NTMpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dl
YlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OCw2ICs0OCw3IEBA
CiAjaW5jbHVkZSAiV2ViVVJMRXJyb3IuaCIKICNpbmNsdWRlICJXZWJVUkxSZXF1ZXN0LmgiCiAj
aW5jbHVkZSAiV2ViVmVjdG9yLmgiCisjaW5jbHVkZSAiV2ViVmlld0ltcGwuaCIKICNpbmNsdWRl
ICJXcmFwcGVkUmVzb3VyY2VSZXNwb25zZS5oIgogCiAjaW5jbHVkZSAiRXZlbnROYW1lcy5oIgpA
QCAtNDQ1LDYgKzQ0NiwxNSBAQCB2b2lkIFdlYlBsdWdpbkNvbnRhaW5lckltcGw6OmhhbmRsZVdo
ZWVsCiB2b2lkIFdlYlBsdWdpbkNvbnRhaW5lckltcGw6OmhhbmRsZUtleWJvYXJkRXZlbnQoS2V5
Ym9hcmRFdmVudCogZXZlbnQpCiB7CiAgICAgV2ViS2V5Ym9hcmRFdmVudEJ1aWxkZXIgd2ViRXZl
bnQoKmV2ZW50KTsKKyAgICBjb25zdCBXZWJJbnB1dEV2ZW50KiBjdXJyZW50SW5wdXRFdmVudCA9
IFdlYlZpZXdJbXBsOjpjdXJyZW50SW5wdXRFdmVudCgpOworCisgICAgLy8gQ29weSBzdGFzaGVk
IGluZm8gb3Zlci4KKyAgICBpZiAoY3VycmVudElucHV0RXZlbnQgJiYKKyAgICAgICAgV2ViSW5w
dXRFdmVudDo6aXNLZXlib2FyZEV2ZW50VHlwZShjdXJyZW50SW5wdXRFdmVudC0+dHlwZSkpIHsK
KyAgICAgICAgd2ViRXZlbnQubW9kaWZpZXJzIHw9IGN1cnJlbnRJbnB1dEV2ZW50LT5tb2RpZmll
cnMgJgorICAgICAgICAgICAgKFdlYklucHV0RXZlbnQ6OkNhcHNMb2NrT24gfCBXZWJJbnB1dEV2
ZW50OjpOdW1Mb2NrT24pOworICAgIH0KKwogICAgIGlmICh3ZWJFdmVudC50eXBlID09IFdlYklu
cHV0RXZlbnQ6OlVuZGVmaW5lZCkKICAgICAgICAgcmV0dXJuOwogCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>69408</attachid>
            <date>2010-09-30 18:12:51 -0700</date>
            <delta_ts>2010-10-01 01:07:08 -0700</delta_ts>
            <desc> retrieving lock key state only when stashed event is keyboard event; update Changelog; fix webkit type checking;</desc>
            <filename>WebPluginContainer.diff</filename>
            <type>text/plain</type>
            <size>1921</size>
            <attacher>wjia</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjg4NTMpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh
bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDktMjkgIFdlaSBK
aWEgIDx3amlhQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBSZXRyaWV2ZSBpbmZvIG9mIGxvY2sga2V5cyBmcm9tIHN0YXNoZWQg
Y3VycmVudElucHV0RXZlbnQgd2hpY2gKKyAgICAgICAgaXMgc3RvcmVkIGJ5IGNocm9taXVtIHdo
ZW4gaXQgcGFzc2VzIGlucHV0IGV2ZW50IHRvIFdlYkNvcmUuCisgICAgICAgIFJldHJpZXZpbmcg
b25seSB3aGVuIHN0YXNoZWQgZXZlbnQgaXMgYSBrZXlib2FyZCBldmVudCwgd2hpY2gKKyAgICAg
ICAgbWVhbnMgc3ludGhldGljIEtleWJvYXJkRXZlbnQgaW5oZXJpdHMgbG9jayBrZXkgc3RhdGUg
ZnJvbSByZWFsCisgICAgICAgIGtleWJvYXJkIGV2ZW50LgorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY1MTgKKworICAgICAgICAqIHNyYy9XZWJQbHVn
aW5Db250YWluZXJJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGx1Z2luQ29udGFpbmVy
SW1wbDo6aGFuZGxlS2V5Ym9hcmRFdmVudCk6CisKIDIwMTAtMDktMzAgIEFsZXhleSBNYXJpbmlj
aGV2ICA8YW1hcmluaWNoZXZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IENo
cmlzIE1hcnJpbi4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVy
SW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250
YWluZXJJbXBsLmNwcAkocmV2aXNpb24gNjg4NTMpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dl
YlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OCw2ICs0OCw3IEBA
CiAjaW5jbHVkZSAiV2ViVVJMRXJyb3IuaCIKICNpbmNsdWRlICJXZWJVUkxSZXF1ZXN0LmgiCiAj
aW5jbHVkZSAiV2ViVmVjdG9yLmgiCisjaW5jbHVkZSAiV2ViVmlld0ltcGwuaCIKICNpbmNsdWRl
ICJXcmFwcGVkUmVzb3VyY2VSZXNwb25zZS5oIgogCiAjaW5jbHVkZSAiRXZlbnROYW1lcy5oIgpA
QCAtNDQ1LDYgKzQ0NiwxNSBAQCB2b2lkIFdlYlBsdWdpbkNvbnRhaW5lckltcGw6OmhhbmRsZVdo
ZWVsCiB2b2lkIFdlYlBsdWdpbkNvbnRhaW5lckltcGw6OmhhbmRsZUtleWJvYXJkRXZlbnQoS2V5
Ym9hcmRFdmVudCogZXZlbnQpCiB7CiAgICAgV2ViS2V5Ym9hcmRFdmVudEJ1aWxkZXIgd2ViRXZl
bnQoKmV2ZW50KTsKKyAgICBjb25zdCBXZWJJbnB1dEV2ZW50KiBjdXJyZW50SW5wdXRFdmVudCA9
IFdlYlZpZXdJbXBsOjpjdXJyZW50SW5wdXRFdmVudCgpOworCisgICAgLy8gQ29weSBzdGFzaGVk
IGluZm8gb3Zlci4KKyAgICBpZiAoY3VycmVudElucHV0RXZlbnQKKyAgICAgICAgJiYgV2ViSW5w
dXRFdmVudDo6aXNLZXlib2FyZEV2ZW50VHlwZShjdXJyZW50SW5wdXRFdmVudC0+dHlwZSkpIHsK
KyAgICAgICAgd2ViRXZlbnQubW9kaWZpZXJzIHw9IGN1cnJlbnRJbnB1dEV2ZW50LT5tb2RpZmll
cnMgJgorICAgICAgICAgICAgKFdlYklucHV0RXZlbnQ6OkNhcHNMb2NrT24gfCBXZWJJbnB1dEV2
ZW50OjpOdW1Mb2NrT24pOworICAgIH0KKwogICAgIGlmICh3ZWJFdmVudC50eXBlID09IFdlYklu
cHV0RXZlbnQ6OlVuZGVmaW5lZCkKICAgICAgICAgcmV0dXJuOwogCg==
</data>
<flag name="review"
          id="59104"
          type_id="1"
          status="+"
          setter="fishd"
    />
    <flag name="commit-queue"
          id="59126"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>70774</attachid>
            <date>2010-10-14 13:51:42 -0700</date>
            <delta_ts>2010-10-14 14:47:35 -0700</delta_ts>
            <desc>update the patch to tip of tree</desc>
            <filename>WebPluginContainerImpl.diff</filename>
            <type>text/plain</type>
            <size>1720</size>
            <attacher>wjia</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjk3ODQpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh
bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMTAtMTQgIFdlaSBK
aWEgIDx3amlhQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNo
ZXIuCisKKyAgICAgICAgUmV0cmlldmUgaW5mbyBvZiBsb2NrIGtleXMgZnJvbSBzdGFzaGVkIGN1
cnJlbnRJbnB1dEV2ZW50IHdoaWNoCisgICAgICAgIGlzIHN0b3JlZCBieSBjaHJvbWl1bSB3aGVu
IGl0IHBhc3NlcyBpbnB1dCBldmVudCB0byBXZWJDb3JlLgorICAgICAgICBSZXRyaWV2aW5nIG9u
bHkgd2hlbiBzdGFzaGVkIGV2ZW50IGlzIGEga2V5Ym9hcmQgZXZlbnQsIHdoaWNoCisgICAgICAg
IG1lYW5zIHN5bnRoZXRpYyBLZXlib2FyZEV2ZW50IGluaGVyaXRzIGxvY2sga2V5IHN0YXRlIGZy
b20gcmVhbAorICAgICAgICBrZXlib2FyZCBldmVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2NTE4CisKKyAgICAgICAgKiBzcmMvV2ViUGx1Z2lu
Q29udGFpbmVySW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBsdWdpbkNvbnRhaW5lcklt
cGw6OmhhbmRsZUtleWJvYXJkRXZlbnQpOgorCiAyMDEwLTEwLTEzICBLaW51a28gWWFzdWRhICA8
a2ludWtvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKaWFuIExpLgpJbmRl
eDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcAo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCShy
ZXZpc2lvbiA2OTc4NCkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVy
SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ1Miw2ICs0NTIsMTYgQEAgdm9pZCBXZWJQbHVn
aW5Db250YWluZXJJbXBsOjpoYW5kbGVXaGVlbAogdm9pZCBXZWJQbHVnaW5Db250YWluZXJJbXBs
OjpoYW5kbGVLZXlib2FyZEV2ZW50KEtleWJvYXJkRXZlbnQqIGV2ZW50KQogewogICAgIFdlYktl
eWJvYXJkRXZlbnRCdWlsZGVyIHdlYkV2ZW50KCpldmVudCk7CisgICAgY29uc3QgV2ViSW5wdXRF
dmVudCogY3VycmVudElucHV0RXZlbnQgPSBXZWJWaWV3SW1wbDo6Y3VycmVudElucHV0RXZlbnQo
KTsKKworICAgIC8vIENvcHkgc3Rhc2hlZCBpbmZvIG92ZXIuCisgICAgaWYgKGN1cnJlbnRJbnB1
dEV2ZW50ICYmCisgICAgICAgIFdlYklucHV0RXZlbnQ6OmlzS2V5Ym9hcmRFdmVudFR5cGUoY3Vy
cmVudElucHV0RXZlbnQtPnR5cGUpKSB7CisgICAgICAgIHdlYkV2ZW50Lm1vZGlmaWVycyB8PSBj
dXJyZW50SW5wdXRFdmVudC0+bW9kaWZpZXJzICYKKyAgICAgICAgICAgIChXZWJJbnB1dEV2ZW50
OjpDYXBzTG9ja09uIHwgV2ViSW5wdXRFdmVudDo6TnVtTG9ja09uKTsKKyAgICB9CisKKwogICAg
IGlmICh3ZWJFdmVudC50eXBlID09IFdlYklucHV0RXZlbnQ6OlVuZGVmaW5lZCkKICAgICAgICAg
cmV0dXJuOwogCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>70780</attachid>
            <date>2010-10-14 14:47:35 -0700</date>
            <delta_ts>2010-10-14 15:02:31 -0700</delta_ts>
            <desc>retrieve modifiers after ctrl-c is handled</desc>
            <filename>WebPluginContainerImpl.diff</filename>
            <type>text/plain</type>
            <size>1752</size>
            <attacher>wjia</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjk3ODQpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh
bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMTAtMTQgIFdlaSBK
aWEgIDx3amlhQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNo
ZXIuCisKKyAgICAgICAgUmV0cmlldmUgaW5mbyBvZiBsb2NrIGtleXMgZnJvbSBzdGFzaGVkIGN1
cnJlbnRJbnB1dEV2ZW50IHdoaWNoCisgICAgICAgIGlzIHN0b3JlZCBieSBjaHJvbWl1bSB3aGVu
IGl0IHBhc3NlcyBpbnB1dCBldmVudCB0byBXZWJDb3JlLgorICAgICAgICBSZXRyaWV2aW5nIG9u
bHkgd2hlbiBzdGFzaGVkIGV2ZW50IGlzIGEga2V5Ym9hcmQgZXZlbnQsIHdoaWNoCisgICAgICAg
IG1lYW5zIHN5bnRoZXRpYyBLZXlib2FyZEV2ZW50IGluaGVyaXRzIGxvY2sga2V5IHN0YXRlIGZy
b20gcmVhbAorICAgICAgICBrZXlib2FyZCBldmVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2NTE4CisKKyAgICAgICAgKiBzcmMvV2ViUGx1Z2lu
Q29udGFpbmVySW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBsdWdpbkNvbnRhaW5lcklt
cGw6OmhhbmRsZUtleWJvYXJkRXZlbnQpOgorCiAyMDEwLTEwLTEzICBLaW51a28gWWFzdWRhICA8
a2ludWtvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKaWFuIExpLgpJbmRl
eDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcAo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCShy
ZXZpc2lvbiA2OTc4NCkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVy
SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ2OCw2ICs0NjgsMTYgQEAgdm9pZCBXZWJQbHVn
aW5Db250YWluZXJJbXBsOjpoYW5kbGVLZXlibwogICAgICAgICB9CiAgICAgfQogCisgICAgY29u
c3QgV2ViSW5wdXRFdmVudCogY3VycmVudElucHV0RXZlbnQgPSBXZWJWaWV3SW1wbDo6Y3VycmVu
dElucHV0RXZlbnQoKTsKKworICAgIC8vIENvcHkgc3Rhc2hlZCBpbmZvIG92ZXIsIGFuZCBvbmx5
IGNvcHkgaGVyZSBpbiBvcmRlciBub3QgdG8gaW50ZXJmZXJlCisgICAgLy8gdGhlIGN0cmwtYyBs
b2dpYyBhYm92ZS4KKyAgICBpZiAoY3VycmVudElucHV0RXZlbnQgJiYKKyAgICAgICAgV2ViSW5w
dXRFdmVudDo6aXNLZXlib2FyZEV2ZW50VHlwZShjdXJyZW50SW5wdXRFdmVudC0+dHlwZSkpIHsK
KyAgICAgICAgd2ViRXZlbnQubW9kaWZpZXJzIHw9IGN1cnJlbnRJbnB1dEV2ZW50LT5tb2RpZmll
cnMgJgorICAgICAgICAgICAgKFdlYklucHV0RXZlbnQ6OkNhcHNMb2NrT24gfCBXZWJJbnB1dEV2
ZW50OjpOdW1Mb2NrT24pOworICAgIH0KKwogICAgIFdlYkN1cnNvckluZm8gY3Vyc29ySW5mbzsK
ICAgICBpZiAobV93ZWJQbHVnaW4tPmhhbmRsZUlucHV0RXZlbnQod2ViRXZlbnQsIGN1cnNvcklu
Zm8pKQogICAgICAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>70784</attachid>
            <date>2010-10-14 15:02:31 -0700</date>
            <delta_ts>2010-10-14 23:33:55 -0700</delta_ts>
            <desc>update to tip of tree, retrieve modifiers after ctrl-c is handled, fix webkit style checking</desc>
            <filename>WebPluginContainerImpl.diff</filename>
            <type>text/plain</type>
            <size>1752</size>
            <attacher>wjia</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjk3ODQpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh
bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMTAtMTQgIFdlaSBK
aWEgIDx3amlhQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNo
ZXIuCisKKyAgICAgICAgUmV0cmlldmUgaW5mbyBvZiBsb2NrIGtleXMgZnJvbSBzdGFzaGVkIGN1
cnJlbnRJbnB1dEV2ZW50IHdoaWNoCisgICAgICAgIGlzIHN0b3JlZCBieSBjaHJvbWl1bSB3aGVu
IGl0IHBhc3NlcyBpbnB1dCBldmVudCB0byBXZWJDb3JlLgorICAgICAgICBSZXRyaWV2aW5nIG9u
bHkgd2hlbiBzdGFzaGVkIGV2ZW50IGlzIGEga2V5Ym9hcmQgZXZlbnQsIHdoaWNoCisgICAgICAg
IG1lYW5zIHN5bnRoZXRpYyBLZXlib2FyZEV2ZW50IGluaGVyaXRzIGxvY2sga2V5IHN0YXRlIGZy
b20gcmVhbAorICAgICAgICBrZXlib2FyZCBldmVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2NTE4CisKKyAgICAgICAgKiBzcmMvV2ViUGx1Z2lu
Q29udGFpbmVySW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBsdWdpbkNvbnRhaW5lcklt
cGw6OmhhbmRsZUtleWJvYXJkRXZlbnQpOgorCiAyMDEwLTEwLTEzICBLaW51a28gWWFzdWRhICA8
a2ludWtvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKaWFuIExpLgpJbmRl
eDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcAo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCShy
ZXZpc2lvbiA2OTc4NCkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVy
SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ2OCw2ICs0NjgsMTYgQEAgdm9pZCBXZWJQbHVn
aW5Db250YWluZXJJbXBsOjpoYW5kbGVLZXlibwogICAgICAgICB9CiAgICAgfQogCisgICAgY29u
c3QgV2ViSW5wdXRFdmVudCogY3VycmVudElucHV0RXZlbnQgPSBXZWJWaWV3SW1wbDo6Y3VycmVu
dElucHV0RXZlbnQoKTsKKworICAgIC8vIENvcHkgc3Rhc2hlZCBpbmZvIG92ZXIsIGFuZCBvbmx5
IGNvcHkgaGVyZSBpbiBvcmRlciBub3QgdG8gaW50ZXJmZXJlCisgICAgLy8gdGhlIGN0cmwtYyBs
b2dpYyBhYm92ZS4KKyAgICBpZiAoY3VycmVudElucHV0RXZlbnQKKyAgICAgICAgJiYgV2ViSW5w
dXRFdmVudDo6aXNLZXlib2FyZEV2ZW50VHlwZShjdXJyZW50SW5wdXRFdmVudC0+dHlwZSkpIHsK
KyAgICAgICAgd2ViRXZlbnQubW9kaWZpZXJzIHw9IGN1cnJlbnRJbnB1dEV2ZW50LT5tb2RpZmll
cnMgJgorICAgICAgICAgICAgKFdlYklucHV0RXZlbnQ6OkNhcHNMb2NrT24gfCBXZWJJbnB1dEV2
ZW50OjpOdW1Mb2NrT24pOworICAgIH0KKwogICAgIFdlYkN1cnNvckluZm8gY3Vyc29ySW5mbzsK
ICAgICBpZiAobV93ZWJQbHVnaW4tPmhhbmRsZUlucHV0RXZlbnQod2ViRXZlbnQsIGN1cnNvcklu
Zm8pKQogICAgICAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>