46514 2010-09-24 14:29:35 -0700 Add WTF::StringHasher::createBlobHash 2010-09-26 22:28:32 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 paroga paroga commit-queue oldest_to_newest 284705 0 paroga 2010-09-24 14:29:35 -0700 see patch 284712 1 68751 paroga 2010-09-24 14:37:36 -0700 Created attachment 68751 Patch 285298 2 68751 abarth 2010-09-26 21:47:57 -0700 Comment on attachment 68751 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68751&action=review Holy copy/paste code batman. > JavaScriptCore/wtf/StringHashFunctions.h:139 > + COMPILE_ASSERT(!(length % 4), length_must_be_a_multible_of_four); multible => multiple 285320 3 68751 commit-queue 2010-09-26 22:28:27 -0700 Comment on attachment 68751 Patch Clearing flags on attachment: 68751 Committed r68369: <http://trac.webkit.org/changeset/68369> 285321 4 commit-queue 2010-09-26 22:28:32 -0700 All reviewed patches have been landed. Closing bug. 68751 2010-09-24 14:37:36 -0700 2010-09-26 22:28:27 -0700 Patch bug-46514.patch text/plain 5477 paroga ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBkYzM4OWQzLi5mMmM2YWUxIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTAtMDktMjQgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIFdURjo6 U3RyaW5nSGFzaGVyOjpjcmVhdGVCbG9iSGFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY1MTQKKworICAgICAgICBBZGQgdGhpcyBmdW5jdGlvbiBm b3IgaGFzaGluZyBGb3JtRWxlbWVudEtleSBhbmQgUXVhbGlmaWVkTmFtZUNvbXBvbmVudHMuCisK KyAgICAgICAgKiB3dGYvU3RyaW5nSGFzaEZ1bmN0aW9ucy5oOgorICAgICAgICAoV1RGOjpTdHJp bmdIYXNoZXI6OmNyZWF0ZUJsb2JIYXNoKToKKwogMjAxMC0wOS0yNCAgUGF0cmljayBHYW5zdGVy ZXIgIDxwYXJvZ2FAcGFyb2dhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHYXZpbiBCYXJy YWNsb3VnaC4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9TdHJpbmdIYXNoRnVuY3Rp b25zLmggYi9KYXZhU2NyaXB0Q29yZS93dGYvU3RyaW5nSGFzaEZ1bmN0aW9ucy5oCmluZGV4IDY0 OTg4Y2IuLmViYTViNDYgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9TdHJpbmdIYXNo RnVuY3Rpb25zLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL1N0cmluZ0hhc2hGdW5jdGlvbnMu aApAQCAtMTM0LDYgKzEzNCwxMiBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBjcmVhdGVIYXNo PFQsIGRlZmF1bHRDb3ZlcnRlcj4oZGF0YSk7CiAgICAgfQogCisgICAgdGVtcGxhdGU8c2l6ZV90 IGxlbmd0aD4gc3RhdGljIGlubGluZSB1bnNpZ25lZCBjcmVhdGVCbG9iSGFzaChjb25zdCB2b2lk KiBkYXRhKQorICAgIHsKKyAgICAgICAgQ09NUElMRV9BU1NFUlQoIShsZW5ndGggJSA0KSwgbGVu Z3RoX211c3RfYmVfYV9tdWx0aWJsZV9vZl9mb3VyKTsKKyAgICAgICAgcmV0dXJuIGNyZWF0ZUhh c2g8VUNoYXI+KHN0YXRpY19jYXN0PGNvbnN0IFVDaGFyKj4oZGF0YSksIGxlbmd0aCAvIHNpemVv ZihVQ2hhcikpOworICAgIH0KKwogcHJpdmF0ZToKICAgICBzdGF0aWMgaW5saW5lIFVDaGFyIGRl ZmF1bHRDb3ZlcnRlcihVQ2hhciBjaCkKICAgICB7CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGU0MGQxNjcuLjg3Zjk0MzUgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTggQEAKKzIwMTAtMDktMjQgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIFdU Rjo6U3RyaW5nSGFzaGVyOjpjcmVhdGVCbG9iSGFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY1MTQKKworICAgICAgICBBZGQgdGhpcyBmdW5jdGlv biBmb3IgaGFzaGluZyBGb3JtRWxlbWVudEtleSBhbmQgUXVhbGlmaWVkTmFtZUNvbXBvbmVudHMu CisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9ybUVs ZW1lbnRLZXlIYXNoOjpoYXNoKToKKyAgICAgICAgKiBkb20vUXVhbGlmaWVkTmFtZS5oOgorICAg ICAgICAoV2ViQ29yZTo6aGFzaENvbXBvbmVudHMpOgorICAgICAgICAoV2ViQ29yZTo6UXVhbGlm aWVkTmFtZUhhc2g6Omhhc2gpOgorCiAyMDEwLTA5LTI0ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4 IDIxYTczZDcuLjQyM2FmNzYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAor KysgYi9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTQyNzYsMzcgKzQyNzYsOSBAQCB2b2lk IEZvcm1FbGVtZW50S2V5OjpkZXJlZigpIGNvbnN0CiAgICAgICAgIHR5cGUoKS0+ZGVyZWYoKTsK IH0KIAotdW5zaWduZWQgRm9ybUVsZW1lbnRLZXlIYXNoOjpoYXNoKGNvbnN0IEZvcm1FbGVtZW50 S2V5JiBrKQordW5zaWduZWQgRm9ybUVsZW1lbnRLZXlIYXNoOjpoYXNoKGNvbnN0IEZvcm1FbGVt ZW50S2V5JiBrZXkpCiB7Ci0gICAgQVNTRVJUKHNpemVvZihrKSAlIChzaXplb2YodWludDE2X3Qp ICogMikgPT0gMCk7Ci0KLSAgICB1bnNpZ25lZCBsID0gc2l6ZW9mKGspIC8gKHNpemVvZih1aW50 MTZfdCkgKiAyKTsKLSAgICBjb25zdCB1aW50MTZfdCogcyA9IHJlaW50ZXJwcmV0X2Nhc3Q8Y29u c3QgdWludDE2X3QqPigmayk7Ci0gICAgdWludDMyX3QgaGFzaCA9IFdURjo6c3RyaW5nSGFzaGlu Z1N0YXJ0VmFsdWU7Ci0KLSAgICAvLyBNYWluIGxvb3AKLSAgICBmb3IgKDsgbCA+IDA7IGwtLSkg ewotICAgICAgICBoYXNoICs9IHNbMF07Ci0gICAgICAgIHVpbnQzMl90IHRtcCA9IChzWzFdIDw8 IDExKSBeIGhhc2g7Ci0gICAgICAgIGhhc2ggPSAoaGFzaCA8PCAxNikgXiB0bXA7Ci0gICAgICAg IHMgKz0gMjsKLSAgICAgICAgaGFzaCArPSBoYXNoID4+IDExOwotICAgIH0KLSAgICAgICAgCi0g ICAgLy8gRm9yY2UgImF2YWxhbmNoaW5nIiBvZiBmaW5hbCAxMjcgYml0cwotICAgIGhhc2ggXj0g aGFzaCA8PCAzOwotICAgIGhhc2ggKz0gaGFzaCA+PiA1OwotICAgIGhhc2ggXj0gaGFzaCA8PCAy OwotICAgIGhhc2ggKz0gaGFzaCA+PiAxNTsKLSAgICBoYXNoIF49IGhhc2ggPDwgMTA7Ci0KLSAg ICAvLyB0aGlzIGF2b2lkcyBldmVyIHJldHVybmluZyBhIGhhc2ggY29kZSBvZiAwLCBzaW5jZSB0 aGF0IGlzIHVzZWQgdG8KLSAgICAvLyBzaWduYWwgImhhc2ggbm90IGNvbXB1dGVkIHlldCIsIHVz aW5nIGEgdmFsdWUgdGhhdCBpcyBsaWtlbHkgdG8gYmUKLSAgICAvLyBlZmZlY3RpdmVseSB0aGUg c2FtZSBhcyAwIHdoZW4gdGhlIGxvdyBiaXRzIGFyZSBtYXNrZWQKLSAgICBpZiAoIWhhc2gpCi0g ICAgICAgIGhhc2ggPSAweDgwMDAwMDAwOwotCi0gICAgcmV0dXJuIGhhc2g7CisgICAgcmV0dXJu IFdURjo6U3RyaW5nSGFzaGVyOjpjcmVhdGVCbG9iSGFzaDxzaXplb2YoRm9ybUVsZW1lbnRLZXkp Pigma2V5KTsKIH0KIAogdm9pZCBEb2N1bWVudDo6c2V0SWNvblVSTChjb25zdCBTdHJpbmcmIGlj b25VUkwsIGNvbnN0IFN0cmluZyYgdHlwZSkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL1F1YWxp ZmllZE5hbWUuaCBiL1dlYkNvcmUvZG9tL1F1YWxpZmllZE5hbWUuaAppbmRleCBlZTkwNDA4Li4y ZGE4ZjBjIDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9RdWFsaWZpZWROYW1lLmgKKysrIGIvV2Vi Q29yZS9kb20vUXVhbGlmaWVkTmFtZS5oCkBAIC0xMTIsNTIgKzExMiwyNCBAQCBpbmxpbmUgYm9v bCBvcGVyYXRvciE9KGNvbnN0IFF1YWxpZmllZE5hbWUmIHEsIGNvbnN0IEF0b21pY1N0cmluZyYg YSkgeyByZXR1cm4gYQogCiBpbmxpbmUgdW5zaWduZWQgaGFzaENvbXBvbmVudHMoY29uc3QgUXVh bGlmaWVkTmFtZUNvbXBvbmVudHMmIGJ1ZikKIHsKLSAgICBBU1NFUlQoc2l6ZW9mKFF1YWxpZmll ZE5hbWVDb21wb25lbnRzKSAlIChzaXplb2YodWludDE2X3QpICogMikgPT0gMCk7Ci0gICAgCi0g ICAgdW5zaWduZWQgbCA9IHNpemVvZihRdWFsaWZpZWROYW1lQ29tcG9uZW50cykgLyAoc2l6ZW9m KHVpbnQxNl90KSAqIDIpOwotICAgIGNvbnN0IHVpbnQxNl90KiBzID0gcmVpbnRlcnByZXRfY2Fz dDxjb25zdCB1aW50MTZfdCo+KCZidWYpOwotICAgIHVpbnQzMl90IGhhc2ggPSBXVEY6OnN0cmlu Z0hhc2hpbmdTdGFydFZhbHVlOwotICAgIAotICAgIC8vIE1haW4gbG9vcAotICAgIGZvciAoOyBs ID4gMDsgbC0tKSB7Ci0gICAgICAgIGhhc2ggKz0gc1swXTsKLSAgICAgICAgdWludDMyX3QgdG1w ID0gKHNbMV0gPDwgMTEpIF4gaGFzaDsKLSAgICAgICAgaGFzaCA9IChoYXNoIDw8IDE2KSBeIHRt cDsKLSAgICAgICAgcyArPSAyOwotICAgICAgICBoYXNoICs9IGhhc2ggPj4gMTE7Ci0gICAgfQot ICAgIAotICAgIC8vIEZvcmNlICJhdmFsYW5jaGluZyIgb2YgZmluYWwgMTI3IGJpdHMKLSAgICBo YXNoIF49IGhhc2ggPDwgMzsKLSAgICBoYXNoICs9IGhhc2ggPj4gNTsKLSAgICBoYXNoIF49IGhh c2ggPDwgMjsKLSAgICBoYXNoICs9IGhhc2ggPj4gMTU7Ci0gICAgaGFzaCBePSBoYXNoIDw8IDEw OwotICAgIAotICAgIC8vIHRoaXMgYXZvaWRzIGV2ZXIgcmV0dXJuaW5nIGEgaGFzaCBjb2RlIG9m IDAsIHNpbmNlIHRoYXQgaXMgdXNlZCB0bwotICAgIC8vIHNpZ25hbCAiaGFzaCBub3QgY29tcHV0 ZWQgeWV0IiwgdXNpbmcgYSB2YWx1ZSB0aGF0IGlzIGxpa2VseSB0byBiZQotICAgIC8vIGVmZmVj dGl2ZWx5IHRoZSBzYW1lIGFzIDAgd2hlbiB0aGUgbG93IGJpdHMgYXJlIG1hc2tlZAotICAgIGlm IChoYXNoID09IDApCi0gICAgICAgIGhhc2ggPSAweDgwMDAwMDAwOwotICAgIAotICAgIHJldHVy biBoYXNoOworICAgIHJldHVybiBXVEY6OlN0cmluZ0hhc2hlcjo6Y3JlYXRlQmxvYkhhc2g8c2l6 ZW9mKFF1YWxpZmllZE5hbWVDb21wb25lbnRzKT4oJmJ1Zik7CiB9Ci0gICAgCisKIHN0cnVjdCBR dWFsaWZpZWROYW1lSGFzaCB7CiAgICAgc3RhdGljIHVuc2lnbmVkIGhhc2goY29uc3QgUXVhbGlm aWVkTmFtZSYgbmFtZSkgeyByZXR1cm4gaGFzaChuYW1lLmltcGwoKSk7IH0KLSAgICAKKwogICAg IHN0YXRpYyB1bnNpZ25lZCBoYXNoKGNvbnN0IFF1YWxpZmllZE5hbWU6OlF1YWxpZmllZE5hbWVJ bXBsKiBuYW1lKSAKLSAgICB7ICAgIAorICAgIHsKICAgICAgICAgUXVhbGlmaWVkTmFtZUNvbXBv bmVudHMgYyA9IHsgbmFtZS0+bV9wcmVmaXguaW1wbCgpLCBuYW1lLT5tX2xvY2FsTmFtZS5pbXBs KCksIG5hbWUtPm1fbmFtZXNwYWNlLmltcGwoKSB9OwogICAgICAgICByZXR1cm4gaGFzaENvbXBv bmVudHMoYyk7CiAgICAgfQotICAgIAorCiAgICAgc3RhdGljIGJvb2wgZXF1YWwoY29uc3QgUXVh bGlmaWVkTmFtZSYgYSwgY29uc3QgUXVhbGlmaWVkTmFtZSYgYikgeyByZXR1cm4gYSA9PSBiOyB9 CiAgICAgc3RhdGljIGJvb2wgZXF1YWwoY29uc3QgUXVhbGlmaWVkTmFtZTo6UXVhbGlmaWVkTmFt ZUltcGwqIGEsIGNvbnN0IFF1YWxpZmllZE5hbWU6OlF1YWxpZmllZE5hbWVJbXBsKiBiKSB7IHJl dHVybiBhID09IGI7IH0KLSAgICAKKwogICAgIHN0YXRpYyBjb25zdCBib29sIHNhZmVUb0NvbXBh cmVUb0VtcHR5T3JEZWxldGVkID0gZmFsc2U7CiB9OwotICAgIAorCiB9CiAKIG5hbWVzcGFjZSBX VEYgewo=