46510 2010-09-24 14:14:26 -0700 WebPageProxy has a bunch of duplicated WebPageCreationParameters code 2010-09-24 15:14:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 44428 1 aroben aroben andersca sam oldest_to_newest 284686 0 aroben 2010-09-24 14:14:26 -0700 WebPageProxy has a bunch of duplicated WebPageCreationParameters code 284687 1 68744 aroben 2010-09-24 14:15:22 -0700 Created attachment 68744 Patch 284752 2 aroben 2010-09-24 15:14:48 -0700 Committed r68297: <http://trac.webkit.org/changeset/68297> 68744 2010-09-24 14:15:22 -0700 2010-09-24 14:25:42 -0700 Patch bug-46510-20100924171544.patch text/plain 4546 aroben ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg MjI1MjhkN2RhZjgzMTNhZjRhYWQwNDUwOTFkOTYxZjMzZjljNmNjZC4uNmEzZTU3MjNjYWVlOTYw MWIwMTQ5OTczNTViYzdjZmVmZmRlNWQ1OSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNCBAQAogMjAxMC0wOS0yNCAgQWRh bSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKKyAgICAgICAgQWRkIFdlYlBhZ2VQcm94eTo6 Y3JlYXRpb25QYXJhbWV0ZXJzCisKKyAgICAgICAgRml4ZXMgPGh0dHA6Ly93ZWJraXQub3JnL2Iv NDY1MTA+IFdlYlBhZ2VQcm94eSBoYXMgYSBidW5jaCBvZgorICAgICAgICBkdXBsaWNhdGVkIFdl YlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMgY29kZQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6aW5pdGlhbGl6ZVdlYlBhZ2UpOgorICAgICAgICAo V2ViS2l0OjpXZWJQYWdlUHJveHk6OnJlaW5pdGlhbGl6ZVdlYlBhZ2UpOgorICAgICAgICAoV2Vi S2l0OjpXZWJQYWdlUHJveHk6OmRpZFJlY2VpdmVTeW5jTWVzc2FnZSk6CisgICAgICAgIFVzZSBj cmVhdGlvblBhcmFtZXRlcnMuCisKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpjcmVh dGlvblBhcmFtZXRlcnMpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaDoKKyAg ICAgICAgQWRkZWQgY3JlYXRpb25QYXJhbWV0ZXJzLgorCisyMDEwLTA5LTI0ICBBZGFtIFJvYmVu ICA8YXJvYmVuQGFwcGxlLmNvbT4KKwogICAgICAgICBNYWtlIFdlYlBhZ2U6OmNyZWF0ZSB0YWtl IGEgV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVyIHN0cnVjdAogCiAgICAgICAgIEl0IG9ubHkgbWFr ZXMgc2Vuc2UsIGFmdGVyIGFsbC4KZGlmZiAtLWdpdCBhL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5jcHAgYi9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IDQ3 NTdkODI1Y2MyZmMzNGJmMjJkZDUzMjY0MGM2MzA0MTY5YzM5ZTQuLjliYTUxNmNhZWNhY2QyY2Q2 OTExMDM5YTQ4MTFmYTNjM2Q2YmZkOTAgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5jcHAKKysrIGIvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApA QCAtMTU1LDExICsxNTUsNyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6aW5pdGlhbGl6ZVdlYlBhZ2Uo Y29uc3QgSW50U2l6ZSYgc2l6ZSkKIAogICAgIEFTU0VSVChtX2RyYXdpbmdBcmVhKTsKIAotICAg IFdlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMgcGFyYW1ldGVyczsKLSAgICBwYXJhbWV0ZXJzLnZp ZXdTaXplID0gc2l6ZTsKLSAgICBwYXJhbWV0ZXJzLnN0b3JlID0gcGFnZU5hbWVzcGFjZSgpLT5j b250ZXh0KCktPnByZWZlcmVuY2VzKCktPnN0b3JlKCk7Ci0gICAgcGFyYW1ldGVycy5kcmF3aW5n QXJlYUluZm8gPSBtX2RyYXdpbmdBcmVhLT5pbmZvKCk7Ci0gICAgcHJvY2VzcygpLT5zZW5kKFdl YlByb2Nlc3NNZXNzYWdlOjpDcmVhdGUsIG1fcGFnZUlELCBDb3JlSVBDOjpJbihwYXJhbWV0ZXJz KSk7CisgICAgcHJvY2VzcygpLT5zZW5kKFdlYlByb2Nlc3NNZXNzYWdlOjpDcmVhdGUsIG1fcGFn ZUlELCBDb3JlSVBDOjpJbihjcmVhdGlvblBhcmFtZXRlcnMoc2l6ZSkpKTsKIH0KIAogdm9pZCBX ZWJQYWdlUHJveHk6OnJlaW5pdGlhbGl6ZVdlYlBhZ2UoY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYg c2l6ZSkKQEAgLTE2OSwxMSArMTY1LDcgQEAgdm9pZCBXZWJQYWdlUHJveHk6OnJlaW5pdGlhbGl6 ZVdlYlBhZ2UoY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYgc2l6ZSkKIAogICAgIEFTU0VSVChtX2Ry YXdpbmdBcmVhKTsKIAotICAgIFdlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMgcGFyYW1ldGVyczsK LSAgICBwYXJhbWV0ZXJzLnZpZXdTaXplID0gc2l6ZTsKLSAgICBwYXJhbWV0ZXJzLnN0b3JlID0g cGFnZU5hbWVzcGFjZSgpLT5jb250ZXh0KCktPnByZWZlcmVuY2VzKCktPnN0b3JlKCk7Ci0gICAg cGFyYW1ldGVycy5kcmF3aW5nQXJlYUluZm8gPSBtX2RyYXdpbmdBcmVhLT5pbmZvKCk7Ci0gICAg cHJvY2VzcygpLT5zZW5kKFdlYlByb2Nlc3NNZXNzYWdlOjpDcmVhdGUsIG1fcGFnZUlELCBDb3Jl SVBDOjpJbihwYXJhbWV0ZXJzKSk7CisgICAgcHJvY2VzcygpLT5zZW5kKFdlYlByb2Nlc3NNZXNz YWdlOjpDcmVhdGUsIG1fcGFnZUlELCBDb3JlSVBDOjpJbihjcmVhdGlvblBhcmFtZXRlcnMoc2l6 ZSkpKTsKIH0KIAogdm9pZCBXZWJQYWdlUHJveHk6OmNsb3NlKCkKQEAgLTg5Myw5ICs4ODUsNyBA QCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGlkUmVjZWl2ZVN5bmNNZXNzYWdlKENvcmVJUEM6OkNvbm5l Y3Rpb24qIGNvbm5lY3Rpb24sIENvcmVJUAogICAgICAgICAgICAgV2ViUGFnZUNyZWF0aW9uUGFy YW1ldGVycyBwYXJhbWV0ZXJzOwogICAgICAgICAgICAgaWYgKG5ld1BhZ2UpIHsKICAgICAgICAg ICAgICAgICAvLyBGSVhNRTogUGFzcyB0aGUgcmVhbCBzaXplLgotICAgICAgICAgICAgICAgIHBh cmFtZXRlcnMudmlld1NpemUgPSBJbnRTaXplKDEwMCwgMTAwKTsKLSAgICAgICAgICAgICAgICBw YXJhbWV0ZXJzLnN0b3JlID0gbmV3UGFnZS0+cGFnZU5hbWVzcGFjZSgpLT5jb250ZXh0KCktPnBy ZWZlcmVuY2VzKCktPnN0b3JlKCk7Ci0gICAgICAgICAgICAgICAgcGFyYW1ldGVycy5kcmF3aW5n QXJlYUluZm8gPSBuZXdQYWdlLT5kcmF3aW5nQXJlYSgpLT5pbmZvKCk7CisgICAgICAgICAgICAg ICAgcGFyYW1ldGVycyA9IG5ld1BhZ2UtPmNyZWF0aW9uUGFyYW1ldGVycyhJbnRTaXplKDEwMCwg MTAwKSk7CiAgICAgICAgICAgICAgICAgcmVwbHktPmVuY29kZShDb3JlSVBDOjpJbihuZXdQYWdl LT5wYWdlSUQoKSwgcGFyYW1ldGVycykpOwogICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAg ICAgICAgICByZXBseS0+ZW5jb2RlKENvcmVJUEM6OkluKHN0YXRpY19jYXN0PHVpbnQ2NF90Pigw KSwgcGFyYW1ldGVycykpOwpAQCAtMTM1NCw2ICsxMzQ0LDE1IEBAIHZvaWQgV2ViUGFnZVByb3h5 Ojpwcm9jZXNzRGlkUmV2aXZlKCkKICAgICBtX3BhZ2VDbGllbnQtPnByb2Nlc3NEaWRSZXZpdmUo KTsKIH0KIAorV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycyBXZWJQYWdlUHJveHk6OmNyZWF0aW9u UGFyYW1ldGVycyhjb25zdCBJbnRTaXplJiBzaXplKSBjb25zdAoreworICAgIFdlYlBhZ2VDcmVh dGlvblBhcmFtZXRlcnMgcGFyYW1ldGVyczsKKyAgICBwYXJhbWV0ZXJzLnZpZXdTaXplID0gc2l6 ZTsKKyAgICBwYXJhbWV0ZXJzLnN0b3JlID0gcGFnZU5hbWVzcGFjZSgpLT5jb250ZXh0KCktPnBy ZWZlcmVuY2VzKCktPnN0b3JlKCk7CisgICAgcGFyYW1ldGVycy5kcmF3aW5nQXJlYUluZm8gPSBt X2RyYXdpbmdBcmVhLT5pbmZvKCk7CisgICAgcmV0dXJuIHBhcmFtZXRlcnM7Cit9CisKICNpZiBV U0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiB2b2lkIFdlYlBhZ2VQcm94eTo6ZGlkRW50ZXJB Y2NlbGVyYXRlZENvbXBvc2l0aW5nKCkKIHsKZGlmZiAtLWdpdCBhL1dlYktpdDIvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5oIGIvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKaW5kZXgg OTE2MzVlYjY3MDBlM2NmNTBkNjI1NDAyNDdlYTk5YzU1MzIwNzJkZC4uOTgwMjlhYTBiZDhmMzg3 MDVlNTQwMWQ5YzgzYzg1MmQ2Y2YyYmViZCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmgKKysrIGIvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKQEAg LTc2LDYgKzc2LDcgQEAgY2xhc3MgV2ViUHJvY2Vzc1Byb3h5OwogY2xhc3MgV2ViVVJMUmVxdWVz dDsKIGNsYXNzIFdlYldoZWVsRXZlbnQ7CiBzdHJ1Y3QgV2ViTmF2aWdhdGlvbkRhdGFTdG9yZTsK K3N0cnVjdCBXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzOwogCiB0eXBlZGVmIEdlbmVyaWNDYWxs YmFjazxXS1N0cmluZ1JlZiwgU3RyaW5nSW1wbCo+IEZyYW1lU291cmNlQ2FsbGJhY2s7CiB0eXBl ZGVmIEdlbmVyaWNDYWxsYmFjazxXS1N0cmluZ1JlZiwgU3RyaW5nSW1wbCo+IFJlbmRlclRyZWVF eHRlcm5hbFJlcHJlc2VudGF0aW9uQ2FsbGJhY2s7CkBAIC0yNjAsNiArMjYxLDggQEAgcHJpdmF0 ZToKICAgICB2b2lkIGRpZEdldFJlbmRlclRyZWVFeHRlcm5hbFJlcHJlc2VudGF0aW9uKGNvbnN0 IFN0cmluZyYsIHVpbnQ2NF90KTsKICAgICB2b2lkIGRpZEdldFNvdXJjZUZvckZyYW1lKGNvbnN0 IFN0cmluZyYsIHVpbnQ2NF90KTsKIAorICAgIFdlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMgY3Jl YXRpb25QYXJhbWV0ZXJzKGNvbnN0IFdlYkNvcmU6OkludFNpemUmKSBjb25zdDsKKwogI2lmIFVT RShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICB2b2lkIGRpZENoYW5nZUFjY2VsZXJhdGVk Q29tcG9zaXRpbmcoYm9vbCBjb21wb3NpdGluZyk7CiAjZW5kaWYgICAgCg==