46499 2010-09-24 12:47:10 -0700 REGRESSION(63307): SVG elements fail to re-render 2011-05-22 10:35:05 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Regression P1 Normal --- 42245 1 evan.w.adams zimmermann abarth ap eric jamesr krit mdelaney7 ossy simon.fraser webkit.review.bot zimmermann oldest_to_newest 284633 0 evan.w.adams 2010-09-24 12:47:10 -0700 This is recent regression. I'm seeing this in Chrome on both MacOS and Linux. I have an SVG shape that blinks. The first time it displays is fine and the first time it is hidden is also fine. After that it never displays again. I've attached a simple reproducible test case. It involves having two shapes in a group. Removing the non-blinking shape makes things work. Commenting out the stroke attribute of the non-blinking shape makes things work, although, that appears to be a red-herring. Changing the size of the non-blinking shape makes it so commenting out the stroke attribute no long fixes things. 284634 1 68734 evan.w.adams 2010-09-24 12:49:16 -0700 Created attachment 68734 Reproduces the bug; has two SVG shapes and a timer to blink one of them. 285743 2 simon.fraser 2010-09-27 14:20:34 -0700 What's the regression window? 285766 3 68965 jamesr 2010-09-27 14:54:40 -0700 Created attachment 68965 smaller reduction Slightly smaller reduction. Looks like the path isn't generating a repaint invalidation. Passes in safari 5.0.1 285772 4 68734 jamesr 2010-09-27 14:58:29 -0700 Comment on attachment 68734 Reproduces the bug; has two SVG shapes and a timer to blink one of them. This testcase is still useful - the one I posted requires the HTML5 tree builder as it uses inline <svg> and doesn't work in older WebKits. 285788 5 jamesr 2010-09-27 15:05:29 -0700 Regression range from the nightlies is r63285 - 63355. I strongly suspect that http://trac.webkit.org/changeset/63307 is the culprit here. 285792 6 jamesr 2010-09-27 15:13:05 -0700 Local revert confirms that patch is wrong. Tsk, tsk. Will revert and add a new repaint test. 285867 7 68989 jamesr 2010-09-27 16:31:50 -0700 Created attachment 68989 Patch 285871 8 68989 jamesr 2010-09-27 16:38:28 -0700 Comment on attachment 68989 Patch Clearing flags on attachment: 68989 Committed r68444: <http://trac.webkit.org/changeset/68444> 285872 9 jamesr 2010-09-27 16:38:33 -0700 All reviewed patches have been landed. Closing bug. 285938 10 webkit.review.bot 2010-09-27 17:21:25 -0700 http://trac.webkit.org/changeset/68444 might have broken Leopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/68441 http://trac.webkit.org/changeset/68442 http://trac.webkit.org/changeset/68443 http://trac.webkit.org/changeset/68444 http://trac.webkit.org/changeset/68445 286081 11 ossy 2010-09-27 23:06:30 -0700 (In reply to comment #10) > http://trac.webkit.org/changeset/68444 might have broken Leopard Intel Release (Tests) > The following changes are on the blame list: > http://trac.webkit.org/changeset/68441 > http://trac.webkit.org/changeset/68442 > http://trac.webkit.org/changeset/68443 > http://trac.webkit.org/changeset/68444 > http://trac.webkit.org/changeset/68445 And Qt bot of course... Qt specific expected file updated in http://trac.webkit.org/changeset/68489 286089 12 zimmermann 2010-09-27 23:27:24 -0700 (In reply to comment #6) > Local revert confirms that patch is wrong. Tsk, tsk. Will revert and add a new repaint test. I'd strongly prefer if you could give the orignal patch author a chance to answer, before reverting. The patch is still correct, it just means that display changes aren't causing relayouts anymore. It should be investigated, rather than reverting the patch. :( 286093 13 eric 2010-09-27 23:33:15 -0700 In defense of James's actions (which I was not involved with): it's pretty standard policy to revert regressions. It was unfortunate he hadn't updated the original bug, but it's also possible he was about to and I just beat him to it. I think it was pretty awesome that he landed a layout test at the same time to prevent any possible future regression. You should feel free to roll back in your patch as soon as it doesn't regress. Not repainting SVGs is a pretty major regression and I'm glad this was resolved promptly, rollout or otherwise. Looking forward to seeing your original patch land again! 286098 14 krit 2010-09-27 23:44:38 -0700 (In reply to comment #13) > In defense of James's actions (which I was not involved with): it's pretty standard policy to revert regressions. It was unfortunate he hadn't updated the original bug, but it's also possible he was about to and I just beat him to it. I know this policy, but sometime it can be better to fix it with a second patch instead of rolling out everything. Sure, this patch caused a repaint regression, but now we have a performance regression. And it was also the policy to inform the original author before rolling out anything, to give the author the time to fix it. There was no chance for Niko to answer to James comment because of the time shift. 286099 15 zimmermann 2010-09-27 23:50:09 -0700 (In reply to comment #13) > In defense of James's actions (which I was not involved with): it's pretty standard policy to revert regressions. It was unfortunate he hadn't updated the original bug, but it's also possible he was about to and I just beat him to it. Sure, but when planning to revert a patch, the author should be given a chance to comment first. It's not that we're releasing a new Safari/Chrome tomorrow, then it would have been fine IMHO. > > I think it was pretty awesome that he landed a layout test at the same time to prevent any possible future regression. The layout test is flawed. It's timing dependant: a test with two 50ms timeouts, always cries for a better solution. It's also in the wrong directory: svg/in-html would be the place to put new HTML5+SVG regression tests. > You should feel free to roll back in your patch as soon as it doesn't regress. Not repainting SVGs is a pretty major regression and I'm glad this was resolved promptly, rollout or otherwise. It's only not repainting display changes, there's not a general repaint problem (of course, not repainting display changes is a pretty major bug). > > Looking forward to seeing your original patch land again! Definately. 286110 16 jamesr 2010-09-28 00:18:45 -0700 Hi folks, Naturally, I always prefer to ping a patch author before reverting if possible, but in this case it wasn't. Given that the original patch was an incorrect perf optimization that caused a serious correctness regression reverting was an easy choice. As for the test the setTimeouts are less than ideal and you are welcome to improve the test. It does test what it sets out to and I think fast/repaint is a fine place to put a repaint test. 286123 17 zimmermann 2010-09-28 01:20:04 -0700 (In reply to comment #16) > Hi folks, > > Naturally, I always prefer to ping a patch author before reverting if possible, but in this case it wasn't. Given that the original patch was an incorrect perf optimization that caused a serious correctness regression reverting was an easy choice. It was not incorrect. Your revert hides the fact, that we're not dealing display attribute changes correct for SVG renderers. > As for the test the setTimeouts are less than ideal and you are welcome to improve the test. It does test what it sets out to and I think fast/repaint is a fine place to put a repaint test. I prefer to give that kind of feedback as review feedback, and you could improve your test, before landing. To summarize: I don't like the attitude that's being shown here. 286393 18 eric 2010-09-28 11:21:05 -0700 I think WildFox and jamesr need to go hug in #webkit. krit can join the love-fest if he so choses. :) 286550 19 jamesr 2010-09-28 14:52:28 -0700 I'm sorry you feel that way. The revision this patch reverted added no regression test, which usually means that no change in behavior is intended. The layout test portion was reviewed by Simon who I think is more than qualified to review repaint tests. I think the best overall way to reduce issues like this is to increase test coverage so that regressions are noticed sooner (preferably during development and before landing). 288672 20 69571 zimmermann 2010-10-02 03:23:32 -0700 Created attachment 69571 Patch The real problem with RenderStyle::diff() is fixed in trunk, revert james workaround. His patch remains, and works with this patch as well. 288673 21 69571 krit 2010-10-02 03:43:19 -0700 Comment on attachment 69571 Patch Found another regression in http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObject/animate-elem-31-t.html with this patch. Niko investigates... 336994 22 ap 2011-01-19 17:50:39 -0800 What's the status of this bug? When opening "smaller reduction", I see a green square in ToT, but a blank page in Safari 5 and in Firefox. What's right? 407676 23 krit 2011-05-22 10:35:05 -0700 (In reply to comment #22) > What's the status of this bug? When opening "smaller reduction", I see a green square in ToT, but a blank page in Safari 5 and in Firefox. What's right? The original regression is fixed. The result on Safari 5 and Opera is blank, because both do not support HTML5. And Firefox has the same behavior like WebKit trunk, a green rect at the end of the animation. 68734 2010-09-24 12:49:16 -0700 2010-10-02 03:23:32 -0700 Reproduces the bug; has two SVG shapes and a timer to blink one of them. WebKitSvgBug.html text/html 2151 evan.w.adams PGh0bWw+CjxoZWFkPgo8bWV0YSBodHRwLWVxdWl2PSdYLVVBLUNvbXBhdGlibGUnIGNvbnRlbnQ9 J2Nocm9tZT0xOyc+Cjx0aXRsZT5MYWNrIG9mIHJlLXJlbmRlcmluZyBidWc8L3RpdGxlPgoKPHNj cmlwdCB0eXBlPSd0ZXh0L2phdmFzY3JpcHQnPgp2YXIgU1ZHX05TID0gJ2h0dHA6Ly93d3cudzMu b3JnLzIwMDAvc3ZnJzsKdmFyIGJsaW5rZXI7CnZhciBibGlua2VyRGlzcGxheWVkID0gdHJ1ZTsK Ci8qCiAqIFRlc3QgY2FzZSBmb3IgdGhlIGJ1ZyB3aGVyZSBhIGJsaW5raW5nIFNWRyBzaGFwZSBk b2VzIG5vdAogKiBhcHBlYXIgYWZ0ZXIgdGhlIGZpcnN0IGRpc3BsYXkuCiAqLwpmdW5jdGlvbiB0 ZXN0KCkgewoKICAvLyBDcmVhdGUgdGhlIFNWRyByb290CiAgdmFyIHdvcmtzcGFjZSA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCd3b3Jrc3BhY2UnKTsKICB2YXIgc3ZnUm9vdCA9IGNyZWF0ZUVs ZW1lbnQoJ3N2ZycpOwogIHN2Z1Jvb3Quc2V0QXR0cmlidXRlKCd3aWR0aCcsICc3OTdweCcpOwog IHN2Z1Jvb3Quc2V0QXR0cmlidXRlKCdoZWlnaHQnLCAnNzA1Jyk7CiAgd29ya3NwYWNlLmFwcGVu ZENoaWxkKHN2Z1Jvb3QpOwoKICB2YXIgZyA9IGNyZWF0ZUVsZW1lbnQoJ2cnKTsKICBzdmdSb290 LmFwcGVuZENoaWxkKGcpOwoKICB2YXIgcmVjdCA9IGNyZWF0ZUVsZW1lbnQoJ3BhdGgnKTsKICAv LyBDb21tZW50IG91dCB0aGlzIGxpbmUgYW5kIGV2ZXJ5dGhpbmcgd29ya3MganVzdCBmaW5lLCBo b3dldmVyLAogIC8vIGNoYW5naW5nIHRoZSBjb29yZHMgb2YgdGhlIHBhdGggYmVsb3cgYnkgcmVw bGFjaW5nIGFsbCB0aGUgMjAwcyAKICAvLyB3aXRoIDI1MHMgYW5kIHRoZW4gY29tbWVudGluZyBv dXQgdGhpcyBsaW5lIG5vIGxvbmdlciBmaXhlcyB0aGUKICAvLyBwcm9ibGVtLgogIC8vCiAgLy8g Q29tbWVudGluZyBvdXQgdGhpcyByZWN0IGVudGlyZWx5IGNhdXNlcyB0aGluZ3MgdG8gd29yayBj b3JyZWN0bHkuCiAgcmVjdC5zZXRBdHRyaWJ1dGUoJ3N0cm9rZScsICcjMDAwMDAwJyk7CiAgcmVj dC5zZXRBdHRyaWJ1dGUoJ3N0cm9rZS1vcGFjaXR5JywgJzEnKTsKICByZWN0LnNldEF0dHJpYnV0 ZSgnc3Ryb2tlLXdpZHRoJywgJzEnKTsKICByZWN0LnNldEF0dHJpYnV0ZSgnZmlsbCcsICcjRERE REREJyk7CiAgcmVjdC5zZXRBdHRyaWJ1dGUoJ2ZpbGwtb3BhY2l0eScsICcxJyk7CiAgcmVjdC5z ZXRBdHRyaWJ1dGUoJ2QnLCAnTSA1MCA1MCBMIDUwIDIwMCAyMDAgMjAwIDIwMCA1MCBaJyk7CiAg Ly8gcmVjdC5zZXRBdHRyaWJ1dGUoJ2QnLCAnTSA1MCA1MCBMIDUwIDI1MCAyNTAgMjUwIDI1MCA1 MCBaJyk7CiAgZy5hcHBlbmRDaGlsZChyZWN0KTsKCiAgLy8gVGhlIGJsaW5raW5nIHNoYXBlCiAg YmxpbmtlciA9IGNyZWF0ZUVsZW1lbnQoJ3BhdGgnKTsKICBibGlua2VyLnNldEF0dHJpYnV0ZSgn c3Ryb2tlJywgJyMwMDAwMDAnKTsKICBibGlua2VyLnNldEF0dHJpYnV0ZSgnc3Ryb2tlLW9wYWNp dHknLCAnMScpOwogIGJsaW5rZXIuc2V0QXR0cmlidXRlKCdzdHJva2Utd2lkdGgnLCAnMScpOwog IGJsaW5rZXIuc2V0QXR0cmlidXRlKCdmaWxsJywgJyNGRkZGMDAnKTsKICBibGlua2VyLnNldEF0 dHJpYnV0ZSgnZmlsbC1vcGFjaXR5JywgJzEnKTsKICBibGlua2VyLnNldEF0dHJpYnV0ZSgnZCcs ICdNIDEwMCAxMDAgTCAxMDAgMjAwIDIwMCAyMDAgMjAwIDEwMCBaJyk7CiAgZy5hcHBlbmRDaGls ZChibGlua2VyKTsKCiAgd2luZG93LnNldEludGVydmFsKG9uVGltZXJUaWNrLCA1MDApOwp9Cgpm dW5jdGlvbiBjcmVhdGVFbGVtZW50KHR5cGUpIHsKICByZXR1cm4gZG9jdW1lbnQuY3JlYXRlRWxl bWVudE5TKFNWR19OUywgdHlwZSk7Cn0KCmZ1bmN0aW9uIG9uVGltZXJUaWNrKCkgewogIGJsaW5r ZXIuc3R5bGUuZGlzcGxheSA9IGJsaW5rZXJEaXNwbGF5ZWQgPyAnbm9uZScgOiAnJzsKICBibGlu a2VyRGlzcGxheWVkID0gIWJsaW5rZXJEaXNwbGF5ZWQ7Cn0KPC9zY3JpcHQ+CjwvaGVhZD4KCjxi b2R5IGRpcj0nbHRyJyByb2xlPSdhcHBsaWNhdGlvbicgb25sb2FkPSd0ZXN0KCknPgoKPGRpdiBp ZD0nd29ya3NwYWNlJyB0YWJpbmRleD0nMScgc3R5bGU9J3dpZHRoOiA4MTBweDsgaGVpZ2h0OiA5 ODFweDsgdG9wOiAwcHg7Jz4KPC9kaXY+Cgo8L2JvZHk+CjwvaHRtbD4K 68965 2010-09-27 14:54:40 -0700 2010-10-02 03:23:32 -0700 smaller reduction svg-repaint.html text/html 802 jamesr PCFET0NUWVBFIGh0bWw+CjxodG1sPiAKPGhlYWQ+IAo8dGl0bGU+U1ZHIGZhaWxpbmcgdG8gcmVw YWludDwvdGl0bGU+IAo8L2hlYWQ+IAo8Ym9keT4KPHN2ZyB3aWR0aD0iMjAxcHgiIGhlaWdodD0i MjAxcHgiPgogIDxnPgogICAgICA8cGF0aCBmaWxsPSJyZWQiIGZpbGwtb3BhY2l0eT0iMSIgZD0i TSAwIDAgTCAwIDIwMCAyMDAgMjAwIDIwMCAwIFoiPjwvcGF0aD4KICAgICAgICAgIDxwYXRoIGlk PSJibGlua2VyIiBmaWxsPSJncmVlbiIgZmlsbC1vcGFjaXR5PSIxIiBkPSJNIDAwIDAwIEwgMDAg MjAwIDIwMCAyMDAgMjAwIDAwIFoiIHN0eWxlPSIiPjwvcGF0aD4KICAgICAgICAgICAgPC9nPgog ICAgICAgICAgICA8L3N2Zz4KICAgICAgICAgICAgPC9kaXY+CgogICAgICAgICAgICA8c2NyaXB0 IHR5cGU9J3RleHQvamF2YXNjcmlwdCc+CiAgICAgICAgICAgIHZhciBibGlua2VyID0gZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoJ2JsaW5rZXInKTsKCiAgICAgICAgICAgIHdpbmRvdy5zZXRUaW1l b3V0KGZ1bmN0aW9uICgpIHsKICAgICAgICAgICAgICAgICAgICAgIGJsaW5rZXIuc3R5bGUuZGlz cGxheSA9ICdub25lJzsKICAgICAgICAgICAgICAgICAgICAgICAgd2luZG93LnNldFRpbWVvdXQo ZnVuY3Rpb24gKCkgewogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJsaW5rZXIuc3R5 bGUuZGlzcGxheSA9ICcnOwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfSwgNTAp OwogICAgICAgICAgICAgICAgICAgICAgICB9LCA1MCk7Cjwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRt bD4KCg== 68989 2010-09-27 16:31:50 -0700 2010-10-02 03:23:32 -0700 Patch bug-46499-20100927163148.patch text/plain 9455 jamesr ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyYWVlMjdmMGE1MTY0MjNiYmUzZmQzYzMxYTdlYzZlMjQ2MTczODczLi40Y2Y1MmQ0 MTQzYjlkODkzYmRjMWI0MzI2MGE3YzU0NzMxODgzNTQzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDktMjcgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXBhaW50IHRlc3Qg Zm9yIGR5bmFtaWNhbGx5IGNoYW5naW5nIGFuIFNWRyBlbGVtZW50J3Mgc3R5bGUgYXR0cmlidXRl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjQ5OQor CisgICAgICAgICogZmFzdC9yZXBhaW50L3JlcGFpbnQtc3ZnLWFmdGVyLXN0eWxlLWNoYW5nZS1l eHBlY3RlZC5jaGVja3N1bTogQWRkZWQuCisgICAgICAgICogZmFzdC9yZXBhaW50L3JlcGFpbnQt c3ZnLWFmdGVyLXN0eWxlLWNoYW5nZS1leHBlY3RlZC5wbmc6IEFkZGVkLgorICAgICAgICAqIGZh c3QvcmVwYWludC9yZXBhaW50LXN2Zy1hZnRlci1zdHlsZS1jaGFuZ2UtZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L3JlcGFpbnQvcmVwYWludC1zdmctYWZ0ZXItc3R5bGUtY2hh bmdlLmh0bWw6IEFkZGVkLgorCiAyMDEwLTA5LTI3ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9yZXBhaW50L3JlcGFpbnQtc3ZnLWFmdGVyLXN0eWxlLWNoYW5nZS1leHBl Y3RlZC5jaGVja3N1bSBiL0xheW91dFRlc3RzL2Zhc3QvcmVwYWludC9yZXBhaW50LXN2Zy1hZnRl ci1zdHlsZS1jaGFuZ2UtZXhwZWN0ZWQuY2hlY2tzdW0KbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjliN2EyMjM2MjZi ZDg5NzZlMDBlZGQ5YmM2N2Q3YTBlYmNhY2Y4MAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvcmVwYWludC9yZXBhaW50LXN2Zy1hZnRlci1zdHlsZS1jaGFuZ2UtZXhwZWN0ZWQu Y2hlY2tzdW0KQEAgLTAsMCArMSBAQAorZjdiZThmNDc0NTIxYmE2MjhkZTYwNWU5YjRjNDBkZWYK XCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L3JlcGFpbnQvcmVwYWludC1zdmctYWZ0ZXItc3R5bGUtY2hhbmdlLWV4cGVjdGVkLnBuZyBiL0xh eW91dFRlc3RzL2Zhc3QvcmVwYWludC9yZXBhaW50LXN2Zy1hZnRlci1zdHlsZS1jaGFuZ2UtZXhw ZWN0ZWQucG5nCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjc2YWU4MmU4ZmRkNWM2NjFlYTY1MmIyODgyYTcwNDc5ZDE1 YjNlMzEKR0lUIGJpbmFyeSBwYXRjaApsaXRlcmFsIDI4MTAKemNtZUFTQE4/KG9sSHlgdVZCcSFp YTB5fnlVeyt2WVYyYT5pMCpaKT1oXmpMJWEyQG4/YVNXLUxeWStlMC1vcGswCnpFUktOel91STdW TGxAKkVHSmYkbl8ya2V8Xzg4LTAyOElpa192SUtFSGJeKEpHNilEcUZmYlRtRmdDdF5uT0oqVwp6 eng7I3h2JloqTThOTk1sIWxAS2ZeUVp7Y0ZkWXErKE98KXEtdzM2Ulh5ZWJ7KmNja3Q/bnEhe0lL bT52O05VYUwKcTchOEVjbHJXa0xNc3ZZdkUqTCghQWE2KyY/YGpAOWtzclZ8RXJYfTRwVVhPQGdl Q3ltd0ZWSVkKCmxpdGVyYWwgMApIY21WP2QwMDAwMQoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvcmVwYWludC9yZXBhaW50LXN2Zy1hZnRlci1zdHlsZS1jaGFuZ2UtZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvZmFzdC9yZXBhaW50L3JlcGFpbnQtc3ZnLWFmdGVyLXN0eWxlLWNoYW5n ZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMTBlNDQ4NzMyY2I2NTAzY2I3ZDRmYTk1YjU5MGZm ZmVlZmVhNmVhZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVwYWludC9y ZXBhaW50LXN2Zy1hZnRlci1zdHlsZS1jaGFuZ2UtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTEg QEAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJWaWV3IGF0ICgwLDApIHNp emUgODAweDYwMAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4MjIyCisgIFJlbmRlckJsb2NrIHtI VE1MfSBhdCAoMCwwKSBzaXplIDgwMHgyMjIKKyAgICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCw4 KSBzaXplIDc4NHgyMDYKKyAgICAgIFJlbmRlclNWR1Jvb3Qge3N2Z30gYXQgKDgsOCkgc2l6ZSAy MDB4MjAwCisgICAgICAgIFJlbmRlclNWR0NvbnRhaW5lciB7Z30gYXQgKDgsOCkgc2l6ZSAyMDB4 MjAwCisgICAgICAgICAgUmVuZGVyUGF0aCB7cGF0aH0gYXQgKDgsOCkgc2l6ZSAyMDB4MjAwIFtm aWxsPXtbdHlwZT1TT0xJRF0gW2NvbG9yPSNGRjAwMDBdfV0gW2RhdGE9Ik0wLjAwLDAuMDAgTDAu MDAsMjAwLjAwIEwyMDAuMDAsMjAwLjAwIEwyMDAuMDAsMC4wMCBaIl0KKyAgICAgICAgICBSZW5k ZXJQYXRoIHtwYXRofSBhdCAoOCw4KSBzaXplIDIwMHgyMDAgW2ZpbGw9e1t0eXBlPVNPTElEXSBb Y29sb3I9IzAwODAwMF19XSBbZGF0YT0iTTAuMDAsMC4wMCBMMC4wMCwyMDAuMDAgTDIwMC4wMCwy MDAuMDAgTDIwMC4wMCwwLjAwIFoiXQorICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDAp IHNpemUgMHgwCisgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAweDAKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVwYWludC9yZXBhaW50LXN2Zy1hZnRlci1zdHls ZS1jaGFuZ2UuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvcmVwYWludC9yZXBhaW50LXN2Zy1hZnRl ci1zdHlsZS1jaGFuZ2UuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42MWZmZjBmMDI0MTIzZGZmZWY3MDFiZWEw ZWRiZWJjYzYwYWNhZDRmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9yZXBh aW50L3JlcGFpbnQtc3ZnLWFmdGVyLXN0eWxlLWNoYW5nZS5odG1sCkBAIC0wLDAgKzEsMzUgQEAK KzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzx0aXRsZT5TVkcgZmFpbGluZyB0byBy ZXBhaW50PC90aXRsZT4KKzwvaGVhZD4KKzxib2R5PgorPHN2ZyB3aWR0aD0iMjAxcHgiIGhlaWdo dD0iMjAxcHgiPgorICAgIDxnPgorICAgICAgICA8cGF0aCBmaWxsPSJyZWQiIGZpbGwtb3BhY2l0 eT0iMSIgZD0iTSAwIDAgTCAwIDIwMCAyMDAgMjAwIDIwMCAwIFoiPjwvcGF0aD4KKyAgICAgICAg PHBhdGggaWQ9ImJsaW5rZXIiIGZpbGw9ImdyZWVuIiBmaWxsLW9wYWNpdHk9IjEiIGQ9Ik0gMDAg MDAgTCAwMCAyMDAgMjAwIDIwMCAyMDAgMDAgWiIgc3R5bGU9IiI+PC9wYXRoPgorICAgIDwvZz4K Kzwvc3ZnPgorPC9kaXY+CisKKzxzY3JpcHQgdHlwZT0ndGV4dC9qYXZhc2NyaXB0Jz4KK3ZhciBi bGlua2VyID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2JsaW5rZXInKTsKKworaWYgKHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICB3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIu d2FpdFVudGlsRG9uZSgpOworCit3aW5kb3cuc2V0VGltZW91dChmdW5jdGlvbiAoKSB7CisgICAg Ymxpbmtlci5zdHlsZS5kaXNwbGF5ID0gJ25vbmUnOworICAgIHdpbmRvdy5zZXRUaW1lb3V0KGZ1 bmN0aW9uICgpIHsKKyAgICAgICAgYmxpbmtlci5zdHlsZS5kaXNwbGF5ID0gJyc7CisgICAgICAg IGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICB3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworICAgIH0sIDUwKTsKK30sIDUwKTsKKwor CisKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgorCmRpZmYgLS1naXQgYS9XZWJDb3JlL0No YW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDU1NTc1MGFlZjM1YWIxMTgxOTQ1YWVl ZDQ2NjlhNzVjMTliNmVmNTUuLjk5ODA1Mzc2NGVhNzQxNjRhNmQ4OGE1YTIyNGU2MWY1OGQ3NmQz NjcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMjcgQEAKKzIwMTAtMDktMjcgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNo cm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBSZXZlcnQgcjYzMzA3LCBpdCBicm9rZSByZXBhaW50aW5nIGR5bmFtaWNhbGx5IGNoYW5n ZWQgU1ZHIGNvbnRlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ2NDk5CisKKyAgICAgICAgVGhpcyBwYXRjaCByZXZlcnRzIHI2MzMwNyBhbmQgYWRk cyBhIHJlZ3Jlc3Npb24gdGVzdCBmb3Igd2hhdCBicm9rZS4KKworICAgICAgICBUZXN0OiBmYXN0 L3JlcGFpbnQvcmVwYWludC1zdmctYWZ0ZXItc3R5bGUtY2hhbmdlLmh0bWwKKworICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJGb3JlaWduT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckZvcmVpZ25PYmplY3Q6OmxheW91dCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclBh dGguY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyUGF0aDo6bGF5b3V0KToKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyU1ZHQ29udGFpbmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlclNWR0NvbnRhaW5lcjo6bGF5b3V0KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyU1ZH SW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyU1ZHSW1hZ2U6OmxheW91dCk6Cisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlclNWR1Jvb3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyU1ZHUm9vdDo6bGF5b3V0KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyU1ZHVGV4 dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTVkdUZXh0OjpsYXlvdXQpOgorCiAyMDEw LTA5LTI3ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRm9y ZWlnbk9iamVjdC5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGb3JlaWduT2JqZWN0LmNw cAppbmRleCA0N2MwMzM0Yzg4MTkwNGY2N2Y2OTY2MGYyYWFhZDlkZTQ4OTBmYTJkLi44MzllOTYz NGI0OTFmNzc2NmZmYzM0ZjkwODIwZGJhNjA0ZTA5NmMzIDEwMDY0NAotLS0gYS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJGb3JlaWduT2JqZWN0LmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJGb3JlaWduT2JqZWN0LmNwcApAQCAtOTksNyArOTksNyBAQCB2b2lkIFJlbmRlckZvcmVp Z25PYmplY3Q6OmxheW91dCgpCiAgICAgQVNTRVJUKG5lZWRzTGF5b3V0KCkpOwogICAgIEFTU0VS VCghdmlldygpLT5sYXlvdXRTdGF0ZUVuYWJsZWQoKSk7IC8vIFJlbmRlclNWR1Jvb3QgZGlzYWJs ZXMgbGF5b3V0U3RhdGUgZm9yIHRoZSBTVkcgcmVuZGVyaW5nIHRyZWUuCiAKLSAgICBMYXlvdXRS ZXBhaW50ZXIgcmVwYWludGVyKCp0aGlzLCBtX2V2ZXJIYWRMYXlvdXQgJiYgY2hlY2tGb3JSZXBh aW50RHVyaW5nTGF5b3V0KCkpOworICAgIExheW91dFJlcGFpbnRlciByZXBhaW50ZXIoKnRoaXMs IGNoZWNrRm9yUmVwYWludER1cmluZ0xheW91dCgpKTsKICAgICBTVkdGb3JlaWduT2JqZWN0RWxl bWVudCogZm9yZWlnbiA9IHN0YXRpY19jYXN0PFNWR0ZvcmVpZ25PYmplY3RFbGVtZW50Kj4obm9k ZSgpKTsKIAogICAgIGJvb2wgdXBkYXRlQ2FjaGVkQm91bmRhcmllc0luUGFyZW50cyA9IGZhbHNl OwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGF0aC5jcHAgYi9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJQYXRoLmNwcAppbmRleCAwZjMxZGYxZDVhYzc1OGQyYTU2Yjc5MWRi ODRjYTdiNzYxMzc4MTdjLi5jYmUxOTAwY2RmOGE5ZWI3ZWE1MWRlNjU4Y2Y5NGM0OGE0NWU5MmJi IDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJQYXRoLmNwcAorKysgYi9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJQYXRoLmNwcApAQCAtOTgsNyArOTgsNyBAQCBib29sIFJlbmRl clBhdGg6OnN0cm9rZUNvbnRhaW5zKGNvbnN0IEZsb2F0UG9pbnQmIHBvaW50LCBib29sIHJlcXVp cmVzU3Ryb2tlKQogCiB2b2lkIFJlbmRlclBhdGg6OmxheW91dCgpCiB7Ci0gICAgTGF5b3V0UmVw YWludGVyIHJlcGFpbnRlcigqdGhpcywgbV9ldmVySGFkTGF5b3V0ICYmIGNoZWNrRm9yUmVwYWlu dER1cmluZ0xheW91dCgpKTsKKyAgICBMYXlvdXRSZXBhaW50ZXIgcmVwYWludGVyKCp0aGlzLCBj aGVja0ZvclJlcGFpbnREdXJpbmdMYXlvdXQoKSAmJiBzZWxmTmVlZHNMYXlvdXQoKSk7CiAgICAg U1ZHU3R5bGVkVHJhbnNmb3JtYWJsZUVsZW1lbnQqIGVsZW1lbnQgPSBzdGF0aWNfY2FzdDxTVkdT dHlsZWRUcmFuc2Zvcm1hYmxlRWxlbWVudCo+KG5vZGUoKSk7CiAKICAgICBib29sIHVwZGF0ZUNh Y2hlZEJvdW5kYXJpZXNJblBhcmVudHMgPSBmYWxzZTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclNWR0NvbnRhaW5lci5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJT VkdDb250YWluZXIuY3BwCmluZGV4IDhjOTkyNzAwODQzNWNmMjY2NWM4ZmZlODJlYjNkOWExMzk1 OWU4M2UuLmI1OTc0Y2E5NDQzOWM0ZGI3NTNkN2M1M2Y4Mzg3MWJiN2JmMDJmYWEgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR0NvbnRhaW5lci5jcHAKKysrIGIvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyU1ZHQ29udGFpbmVyLmNwcApAQCAtNTMsNyArNTMsNyBAQCB2b2lk IFJlbmRlclNWR0NvbnRhaW5lcjo6bGF5b3V0KCkKICAgICAvLyBBbGxvdyBSZW5kZXJTVkdWaWV3 cG9ydENvbnRhaW5lciB0byB1cGRhdGUgaXRzIHZpZXdwb3J0LgogICAgIGNhbGNWaWV3cG9ydCgp OwogCi0gICAgTGF5b3V0UmVwYWludGVyIHJlcGFpbnRlcigqdGhpcywgbV9ldmVySGFkTGF5b3V0 ICYmIGNoZWNrRm9yUmVwYWludER1cmluZ0xheW91dCgpKTsKKyAgICBMYXlvdXRSZXBhaW50ZXIg cmVwYWludGVyKCp0aGlzLCBjaGVja0ZvclJlcGFpbnREdXJpbmdMYXlvdXQoKSB8fCBzZWxmV2ls bFBhaW50KCkpOwogCiAgICAgLy8gQWxsb3cgUmVuZGVyU1ZHVHJhbnNmb3JtYWJsZUNvbnRhaW5l ciB0byB1cGRhdGUgaXRzIHRyYW5zZm9ybS4KICAgICBib29sIHVwZGF0ZWRUcmFuc2Zvcm0gPSBj YWxjdWxhdGVMb2NhbFRyYW5zZm9ybSgpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyU1ZHSW1hZ2UuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU1ZHSW1hZ2UuY3Bw CmluZGV4IDAwNTZmYTM3Y2VlYTQxZDVlOTc0MmZiMDZkOWI2OGZmYTQ3NDZjODcuLmE4OWE3Mzg1 ZTBjMTRkNGY2NjQ5YmYyZGRiODVjZmZhMjg0ZWE3NzYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclNWR0ltYWdlLmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJT VkdJbWFnZS5jcHAKQEAgLTYyLDcgKzYyLDcgQEAgdm9pZCBSZW5kZXJTVkdJbWFnZTo6bGF5b3V0 KCkKIHsKICAgICBBU1NFUlQobmVlZHNMYXlvdXQoKSk7CiAKLSAgICBMYXlvdXRSZXBhaW50ZXIg cmVwYWludGVyKCp0aGlzLCBtX2V2ZXJIYWRMYXlvdXQgJiYgY2hlY2tGb3JSZXBhaW50RHVyaW5n TGF5b3V0KCkpOworICAgIExheW91dFJlcGFpbnRlciByZXBhaW50ZXIoKnRoaXMsIGNoZWNrRm9y UmVwYWludER1cmluZ0xheW91dCgpKTsKICAgICBTVkdJbWFnZUVsZW1lbnQqIGltYWdlID0gc3Rh dGljX2Nhc3Q8U1ZHSW1hZ2VFbGVtZW50Kj4obm9kZSgpKTsKIAogICAgIGJvb2wgdXBkYXRlQ2Fj aGVkQm91bmRhcmllc0luUGFyZW50cyA9IGZhbHNlOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyU1ZHUm9vdC5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTVkdSb290 LmNwcAppbmRleCA5YzUyZDhjODY5N2FiZDcyMTc3NmU4MDVjODBmZjBhY2EyNmY5MDRhLi44MmIx MGQ1MTliOTAxZGEwMTc5YzUyNTI4MDk5ZGVmOWM1NmIyNWJhIDEwMDY0NAotLS0gYS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJTVkdSb290LmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJTVkdSb290LmNwcApAQCAtMTEyLDcgKzExMiw3IEBAIHZvaWQgUmVuZGVyU1ZHUm9vdDo6bGF5 b3V0KCkKICAgICB2aWV3KCktPmRpc2FibGVMYXlvdXRTdGF0ZSgpOwogCiAgICAgYm9vbCBuZWVk c0xheW91dCA9IHNlbGZOZWVkc0xheW91dCgpOwotICAgIExheW91dFJlcGFpbnRlciByZXBhaW50 ZXIoKnRoaXMsIG5lZWRzTGF5b3V0ICYmIG1fZXZlckhhZExheW91dCAmJiBjaGVja0ZvclJlcGFp bnREdXJpbmdMYXlvdXQoKSk7CisgICAgTGF5b3V0UmVwYWludGVyIHJlcGFpbnRlcigqdGhpcywg Y2hlY2tGb3JSZXBhaW50RHVyaW5nTGF5b3V0KCkgJiYgbmVlZHNMYXlvdXQpOwogCiAgICAgSW50 U2l6ZSBvbGRTaXplKHdpZHRoKCksIGhlaWdodCgpKTsKICAgICBjb21wdXRlTG9naWNhbFdpZHRo KCk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTVkdUZXh0LmNwcCBiL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR1RleHQuY3BwCmluZGV4IDgwNGJjOThkNjU0YTJhZmQw ZmIzNDY2YzljYWU3MzRhMWIwODcxY2YuLjkyMDkxYWYxOTVhOTAxY2FmOGMxODM2OGIwNGRjYWIx MzE1Y2M4MjggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR1RleHQuY3Bw CisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR1RleHQuY3BwCkBAIC03NCw3ICs3NCw3 IEBAIHZvaWQgUmVuZGVyU1ZHVGV4dDo6bWFwTG9jYWxUb0NvbnRhaW5lcihSZW5kZXJCb3hNb2Rl bE9iamVjdCogcmVwYWludENvbnRhaW5lciwKIHZvaWQgUmVuZGVyU1ZHVGV4dDo6bGF5b3V0KCkK IHsKICAgICBBU1NFUlQobmVlZHNMYXlvdXQoKSk7Ci0gICAgTGF5b3V0UmVwYWludGVyIHJlcGFp bnRlcigqdGhpcywgbV9ldmVySGFkTGF5b3V0ICYmIGNoZWNrRm9yUmVwYWludER1cmluZ0xheW91 dCgpKTsKKyAgICBMYXlvdXRSZXBhaW50ZXIgcmVwYWludGVyKCp0aGlzLCBjaGVja0ZvclJlcGFp bnREdXJpbmdMYXlvdXQoKSk7CiAKICAgICBib29sIHVwZGF0ZUNhY2hlZEJvdW5kYXJpZXNJblBh cmVudHMgPSBmYWxzZTsKICAgICBpZiAobV9uZWVkc1RyYW5zZm9ybVVwZGF0ZSkgewo= 69571 2010-10-02 03:23:32 -0700 2010-10-02 03:43:19 -0700 Patch FixSpeeed.diff text/plain 5004 zimmermann SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODk3NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjUgQEAKKzIwMTAtMTAtMDIgIE5pa29sYXMgWmltbWVybWFubiAgPG56aW1tZXJt YW5uQHJpbS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUkVHUkVTU0lPTig2MzMwNyk6IFNWRyBlbGVtZW50cyBmYWlsIHRvIHJlLXJlbmRlcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY0OTkKKwor ICAgICAgICBSZXZlcnQgSmFtZXMgd29ya2Fyb3VuZCwgdGhlIHRleHQgcGF0Y2ggZml4ZWQgdGhl IHJvb3Qgb2YgdGhlIHByb2JsZW0sIFJlbmRlclN0eWxlOjpkaWZmKCkgaGFuZGxlZCBTVkcgY2hh bmdlcyBpbmNvcnJlY3RseS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJGb3JlaWduT2Jq ZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZvcmVpZ25PYmplY3Q6OmxheW91dCk6 CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclBhdGguY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyUGF0aDo6bGF5b3V0KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyU1ZHQ29udGFp bmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclNWR0NvbnRhaW5lcjo6bGF5b3V0KToK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyU1ZHSW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyU1ZHSW1hZ2U6OmxheW91dCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclNW R1Jvb3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyU1ZHUm9vdDo6bGF5b3V0KToKKyAg ICAgICAgKiByZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1RleHQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyU1ZHVGV4dDo6bGF5b3V0KToKKwogMjAxMC0xMC0wMSAgTmlrb2xhcyBaaW1tZXJt YW5uICA8bnppbW1lcm1hbm5AcmltLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaXJrIFNj aHVsemUuCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGb3JlaWduT2JqZWN0LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGb3JlaWduT2JqZWN0LmNwcAko cmV2aXNpb24gNjg5NzQpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGb3JlaWduT2JqZWN0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTksNyArOTksNyBAQCB2b2lkIFJlbmRlckZvcmVpZ25P YmplY3Q6OmxheW91dCgpCiAgICAgQVNTRVJUKG5lZWRzTGF5b3V0KCkpOwogICAgIEFTU0VSVCgh dmlldygpLT5sYXlvdXRTdGF0ZUVuYWJsZWQoKSk7IC8vIFJlbmRlclNWR1Jvb3QgZGlzYWJsZXMg bGF5b3V0U3RhdGUgZm9yIHRoZSBTVkcgcmVuZGVyaW5nIHRyZWUuCiAKLSAgICBMYXlvdXRSZXBh aW50ZXIgcmVwYWludGVyKCp0aGlzLCBjaGVja0ZvclJlcGFpbnREdXJpbmdMYXlvdXQoKSk7Cisg ICAgTGF5b3V0UmVwYWludGVyIHJlcGFpbnRlcigqdGhpcywgbV9ldmVySGFkTGF5b3V0ICYmIGNo ZWNrRm9yUmVwYWludER1cmluZ0xheW91dCgpKTsKICAgICBTVkdGb3JlaWduT2JqZWN0RWxlbWVu dCogZm9yZWlnbiA9IHN0YXRpY19jYXN0PFNWR0ZvcmVpZ25PYmplY3RFbGVtZW50Kj4obm9kZSgp KTsKIAogICAgIGJvb2wgdXBkYXRlQ2FjaGVkQm91bmRhcmllc0luUGFyZW50cyA9IGZhbHNlOwpJ bmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGF0aC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyUGF0aC5jcHAJKHJldmlzaW9uIDY4OTc0KQorKysgV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyUGF0aC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk4LDcgKzk4LDcg QEAgYm9vbCBSZW5kZXJQYXRoOjpzdHJva2VDb250YWlucyhjb25zdCBGbAogCiB2b2lkIFJlbmRl clBhdGg6OmxheW91dCgpCiB7Ci0gICAgTGF5b3V0UmVwYWludGVyIHJlcGFpbnRlcigqdGhpcywg Y2hlY2tGb3JSZXBhaW50RHVyaW5nTGF5b3V0KCkgJiYgc2VsZk5lZWRzTGF5b3V0KCkpOworICAg IExheW91dFJlcGFpbnRlciByZXBhaW50ZXIoKnRoaXMsIG1fZXZlckhhZExheW91dCAmJiBjaGVj a0ZvclJlcGFpbnREdXJpbmdMYXlvdXQoKSk7CiAgICAgU1ZHU3R5bGVkVHJhbnNmb3JtYWJsZUVs ZW1lbnQqIGVsZW1lbnQgPSBzdGF0aWNfY2FzdDxTVkdTdHlsZWRUcmFuc2Zvcm1hYmxlRWxlbWVu dCo+KG5vZGUoKSk7CiAKICAgICBib29sIHVwZGF0ZUNhY2hlZEJvdW5kYXJpZXNJblBhcmVudHMg PSBmYWxzZTsKSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR0NvbnRhaW5lci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU1ZHQ29udGFpbmVyLmNwcAko cmV2aXNpb24gNjg5NzQpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTVkdDb250YWluZXIu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Myw3ICs1Myw3IEBAIHZvaWQgUmVuZGVyU1ZHQ29udGFp bmVyOjpsYXlvdXQoKQogICAgIC8vIEFsbG93IFJlbmRlclNWR1ZpZXdwb3J0Q29udGFpbmVyIHRv IHVwZGF0ZSBpdHMgdmlld3BvcnQuCiAgICAgY2FsY1ZpZXdwb3J0KCk7CiAKLSAgICBMYXlvdXRS ZXBhaW50ZXIgcmVwYWludGVyKCp0aGlzLCBjaGVja0ZvclJlcGFpbnREdXJpbmdMYXlvdXQoKSB8 fCBzZWxmV2lsbFBhaW50KCkpOworICAgIExheW91dFJlcGFpbnRlciByZXBhaW50ZXIoKnRoaXMs IG1fZXZlckhhZExheW91dCAmJiBjaGVja0ZvclJlcGFpbnREdXJpbmdMYXlvdXQoKSk7CiAKICAg ICAvLyBBbGxvdyBSZW5kZXJTVkdUcmFuc2Zvcm1hYmxlQ29udGFpbmVyIHRvIHVwZGF0ZSBpdHMg dHJhbnNmb3JtLgogICAgIGJvb2wgdXBkYXRlZFRyYW5zZm9ybSA9IGNhbGN1bGF0ZUxvY2FsVHJh bnNmb3JtKCk7CkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTVkdJbWFnZS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU1ZHSW1hZ2UuY3BwCShyZXZpc2lv biA2ODk3NCkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR0ltYWdlLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNjIsNyArNjIsNyBAQCB2b2lkIFJlbmRlclNWR0ltYWdlOjpsYXlvdXQoKQog ewogICAgIEFTU0VSVChuZWVkc0xheW91dCgpKTsKIAotICAgIExheW91dFJlcGFpbnRlciByZXBh aW50ZXIoKnRoaXMsIGNoZWNrRm9yUmVwYWludER1cmluZ0xheW91dCgpKTsKKyAgICBMYXlvdXRS ZXBhaW50ZXIgcmVwYWludGVyKCp0aGlzLCBtX2V2ZXJIYWRMYXlvdXQgJiYgY2hlY2tGb3JSZXBh aW50RHVyaW5nTGF5b3V0KCkpOwogICAgIFNWR0ltYWdlRWxlbWVudCogaW1hZ2UgPSBzdGF0aWNf Y2FzdDxTVkdJbWFnZUVsZW1lbnQqPihub2RlKCkpOwogCiAgICAgYm9vbCB1cGRhdGVDYWNoZWRC b3VuZGFyaWVzSW5QYXJlbnRzID0gZmFsc2U7CkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJTVkdSb290LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTVkdS b290LmNwcAkocmV2aXNpb24gNjg5NzQpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTVkdS b290LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEyLDcgKzExMiw3IEBAIHZvaWQgUmVuZGVyU1ZH Um9vdDo6bGF5b3V0KCkKICAgICB2aWV3KCktPmRpc2FibGVMYXlvdXRTdGF0ZSgpOwogCiAgICAg Ym9vbCBuZWVkc0xheW91dCA9IHNlbGZOZWVkc0xheW91dCgpOwotICAgIExheW91dFJlcGFpbnRl ciByZXBhaW50ZXIoKnRoaXMsIGNoZWNrRm9yUmVwYWludER1cmluZ0xheW91dCgpICYmIG5lZWRz TGF5b3V0KTsKKyAgICBMYXlvdXRSZXBhaW50ZXIgcmVwYWludGVyKCp0aGlzLCBuZWVkc0xheW91 dCAmJiBtX2V2ZXJIYWRMYXlvdXQgJiYgY2hlY2tGb3JSZXBhaW50RHVyaW5nTGF5b3V0KCkpOwog CiAgICAgSW50U2l6ZSBvbGRTaXplKHdpZHRoKCksIGhlaWdodCgpKTsKICAgICBjb21wdXRlTG9n aWNhbFdpZHRoKCk7CkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHVGV4dC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1RleHQuY3Bw CShyZXZpc2lvbiA2ODk3NikKKysrIFdlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdUZXh0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzUsNyArNzUsNyBAQCB2b2lkIFJlbmRlclNWR1RleHQ6 Om1hcExvY2FsVG9Db250YWluZXIoCiB2b2lkIFJlbmRlclNWR1RleHQ6OmxheW91dCgpCiB7CiAg ICAgQVNTRVJUKG5lZWRzTGF5b3V0KCkpOwotICAgIExheW91dFJlcGFpbnRlciByZXBhaW50ZXIo KnRoaXMsIGNoZWNrRm9yUmVwYWludER1cmluZ0xheW91dCgpKTsKKyAgICBMYXlvdXRSZXBhaW50 ZXIgcmVwYWludGVyKCp0aGlzLCBtX2V2ZXJIYWRMYXlvdXQgJiYgY2hlY2tGb3JSZXBhaW50RHVy aW5nTGF5b3V0KCkpOwogCiAgICAgYm9vbCB1cGRhdGVDYWNoZWRCb3VuZGFyaWVzSW5QYXJlbnRz ID0gZmFsc2U7CiAgICAgaWYgKG1fbmVlZHNUcmFuc2Zvcm1VcGRhdGUpIHsK