46465 2010-09-24 07:23:42 -0700 [Qt] QtTestBrowser defaultUrl does not work 2010-09-24 10:08:29 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P4 Normal --- 1 cshu cshu commit-queue kling ossy oldest_to_newest 284366 0 cshu 2010-09-24 07:23:42 -0700 QtTestBrowser is capable of loading a local index.html by default. However, it is broken now. 284375 1 68678 cshu 2010-09-24 07:41:57 -0700 Created attachment 68678 fix patch 284408 2 68678 ossy 2010-09-24 08:51:41 -0700 Comment on attachment 68678 fix patch LGTM, r=me 284410 3 cshu 2010-09-24 08:53:32 -0700 (In reply to comment #2) > (From update of attachment 68678 [details]) > LGTM, r=me thanks for the quick review! 284417 4 kling 2010-09-24 09:02:31 -0700 > [Qt] Fix the code to check file existence. In the future, please write more detailed ChangeLogs. Example: > [Qt] Fix loading of the default URL (~/index.html) in QtTestBrowser > > We were erroneously checking for the presence of a *directory* called index.html in the user's > home directory. Correct this by using QFile::exists() instead of QDir::exists(). 284422 5 68678 commit-queue 2010-09-24 09:10:53 -0700 Comment on attachment 68678 fix patch Clearing flags on attachment: 68678 Committed r68259: <http://trac.webkit.org/changeset/68259> 284423 6 commit-queue 2010-09-24 09:10:58 -0700 All reviewed patches have been landed. Closing bug. 284427 7 tonikitoo 2010-09-24 09:13:27 -0700 Hum I think this is kinda useless :-( Is anyone leaving an index.html file in the home root dir for testing? 284428 8 ossy 2010-09-24 09:21:48 -0700 (In reply to comment #4) > > [Qt] Fix the code to check file existence. > > In the future, please write more detailed ChangeLogs. > > Example: > > > [Qt] Fix loading of the default URL (~/index.html) in QtTestBrowser > > > > We were erroneously checking for the presence of a *directory* called index.html in the user's > > home directory. Correct this by using QFile::exists() instead of QDir::exists(). It is a very simple fix, it's trivial to understand what was wrong. I don't think if we needed so detailed changelog what you mentioned. But I agree detailed comments are always welcome. (In reply to comment #7) > Hum I think this is kinda useless :-( Is anyone leaving an index.html file in the home root dir for testing? Not at all. Previously I used this feature. :) It is good for lazy peoples. :) 284471 9 cshu 2010-09-24 10:08:29 -0700 > (In reply to comment #7) > > Hum I think this is kinda useless :-( Is anyone leaving an index.html file in the home root dir for testing? > Not at all. Previously I used this feature. :) > It is good for lazy peoples. :) Right. :) The test browser does not have bookmarks. And typing in the url eidtor is kind of painful, especially on the phone. 68678 2010-09-24 07:41:57 -0700 2010-09-24 09:10:53 -0700 fix patch 46465_1.patch text/plain 1333 cshu SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY4MjUyKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDktMjQgIENoYW5nIFNodSAgPGNoYW5n LnNodUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1F0XSBGaXggdGhlIGNvZGUgdG8gY2hlY2sgZmlsZSBleGlzdGVuY2UuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjQ2NQorCisgICAg ICAgICogUXRUZXN0QnJvd3Nlci9tYWluLmNwcDoKKyAgICAgICAgKG1haW4pOgorCiAyMDEwLTA5 LTIzICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgcm9sbGluZyBvdXQgcjY4MjMyLgpJbmRleDogV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci9t YWluLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL21haW4uY3Bw CShyZXZpc2lvbiA2ODI1MCkKKysrIFdlYktpdFRvb2xzL1F0VGVzdEJyb3dzZXIvbWFpbi5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTIzMyw5ICsyMzMsOSBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hh ciAqKmFyZ3YpCiAgICAgUVN0cmluZ0xpc3QgdXJscyA9IGFwcC51cmxzKCk7CiAKICAgICBpZiAo dXJscy5pc0VtcHR5KCkpIHsKLSAgICAgICAgUVN0cmluZyBkZWZhdWx0VXJsID0gUVN0cmluZygi ZmlsZTovLyUxLyUyIikuYXJnKFFEaXI6OmhvbWVQYXRoKCkpLmFyZyhRTGF0aW4xU3RyaW5nKCJp bmRleC5odG1sIikpOwotICAgICAgICBpZiAoUURpcihkZWZhdWx0VXJsKS5leGlzdHMoKSkKLSAg ICAgICAgICAgIHVybHMuYXBwZW5kKGRlZmF1bHRVcmwpOworICAgICAgICBRU3RyaW5nIGRlZmF1 bHRJbmRleEZpbGUgPSBRU3RyaW5nKCIlMS8lMiIpLmFyZyhRRGlyOjpob21lUGF0aCgpKS5hcmco UUxhdGluMVN0cmluZygiaW5kZXguaHRtbCIpKTsKKyAgICAgICAgaWYgKFFGaWxlKGRlZmF1bHRJ bmRleEZpbGUpLmV4aXN0cygpKQorICAgICAgICAgICAgdXJscy5hcHBlbmQoUVN0cmluZygiZmls ZTovLyIpICsgZGVmYXVsdEluZGV4RmlsZSk7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIHVy bHMuYXBwZW5kKCIiKTsKICAgICB9Cg==