46445 2010-09-23 20:51:26 -0700 [Chromium] Split webcore_html off webcore_remaining 2010-09-28 17:44:22 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 maruel webkit-unassigned commit-queue dglazkov tkent tony oldest_to_newest 284205 0 maruel 2010-09-23 20:51:26 -0700 webcore_remaining is still to large for certain 32 bits toolsets. 284206 1 68643 maruel 2010-09-23 20:54:32 -0700 Created attachment 68643 Patch 284207 2 68643 tony 2010-09-23 20:57:31 -0700 Comment on attachment 68643 Patch I take it the html directory has the most files? 284208 3 68643 tony 2010-09-23 20:58:24 -0700 Comment on attachment 68643 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68643&action=review > WebCore/WebCore.gyp/WebCore.gyp:1219 > - ['exclude', '(android|cairo|cf|cg|curl|gtk|haiku|linux|mac|opentype|platform|posix|qt|soup|svg|symbian|win|wx)/'], > + ['exclude', '(android|cairo|cf|cg|curl|gtk|haiku|html|linux|mac|opentype|platform|posix|qt|soup|svg|symbian|win|wx)/'], Nit: It might be a bit clearer to put html in a separate line with a comment about webcore_html. 284209 4 maruel 2010-09-23 21:03:45 -0700 There's rendering (135mb of .o) which will be the next one. There's bindings at 108mb but I'm not sure about the build ordering. For having html on its own line, I did the same for svg and integrated it in the big line. 284210 5 tony 2010-09-23 21:07:00 -0700 (In reply to comment #4) > For having html on its own line, I did the same for svg and integrated it in the big line. The comment is a bit confusing, but it's not a big deal either way. 284335 6 maruel 2010-09-24 06:10:34 -0700 The patch is broken on Windows, will update. Please do not commit. 286655 7 maruel 2010-09-28 17:23:16 -0700 Oh, the windows breakage was a fluke, the patch is good after all. Can someone c+ it? 286669 8 68643 commit-queue 2010-09-28 17:44:16 -0700 Comment on attachment 68643 Patch Clearing flags on attachment: 68643 Committed r68615: <http://trac.webkit.org/changeset/68615> 286670 9 commit-queue 2010-09-28 17:44:22 -0700 All reviewed patches have been landed. Closing bug. 68643 2010-09-23 20:54:32 -0700 2010-09-28 17:44:16 -0700 Patch bug-46445-20100923235431.patch text/plain 2240 maruel ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2FhNjhhZmM0OTNhNzkyYzJlMWIwN2UwMjVjNDkyZDU3MzViOTg1OS4uM2I0MzA3YThhYzI1MDAx ZjdlNTJmNjYzNzU1MjFkNTBhYTE4MDI3MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOS0yMyAgTWFy Yy1BbnRvaW5lIFJ1ZWwgIDxtYXJ1ZWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNwbGl0IHdlYmNvcmVfaHRtbCBvZmYgd2Vi Y29yZV9yZW1haW5pbmcuCisKKyAgICAgICAgd2ViY29yZV9yZW1haW5pbmcgaXMgc3RpbGwgdG9v IGxhcmdlIGZvciBjZXJ0YWluIDMyIGJpdHMgdG9vbHNldHMuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjQ0NQorCisgICAgICAgICogV2ViQ29yZS5n eXAvV2ViQ29yZS5neXA6CisKIDIwMTAtMDktMjMgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9XZWJD b3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwIGIvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3Jl Lmd5cAppbmRleCAyNzQ1Y2ZhZTU3YTQ2ZGFjNWFkMzRiMjkyZmU3YWNmMTdiZDUyZTYzLi40MjZh NDAxMjUzZjQ3ZTEyNWM3MWYxYjBkNTY3YjM1YzE3MTFmMWY1IDEwMDY0NAotLS0gYS9XZWJDb3Jl L1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCisrKyBiL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29y ZS5neXAKQEAgLTk3Myw2ICs5NzMsMjEgQEAKICAgICAgIF0sCiAgICAgfSwKICAgICB7CisgICAg ICAndGFyZ2V0X25hbWUnOiAnd2ViY29yZV9odG1sJywKKyAgICAgICd0eXBlJzogJzwobGlicmFy eSknLAorICAgICAgJ2RlcGVuZGVuY2llcyc6IFsKKyAgICAgICAgJ3dlYmNvcmVfcHJlcmVxdWlz aXRlcycsCisgICAgICBdLAorICAgICAgJ3NvdXJjZXMnOiBbCisgICAgICAgICc8QCh3ZWJjb3Jl X2ZpbGVzKScsCisgICAgICBdLAorICAgICAgJ3NvdXJjZXMvJzogWworICAgICAgICAjIFN0YXJ0 IGJ5IGV4Y2x1ZGluZyBldmVyeXRoaW5nIHRoZW4gaW5jbHVkZSBodG1sIGZpbGVzIG9ubHkuCisg ICAgICAgIFsnZXhjbHVkZScsICcuKiddLAorICAgICAgICBbJ2luY2x1ZGUnLCAnaHRtbC8nXSwK KyAgICAgIF0sCisgICAgfSwKKyAgICB7CiAgICAgICAndGFyZ2V0X25hbWUnOiAnd2ViY29yZV9z dmcnLAogICAgICAgJ3R5cGUnOiAnPChsaWJyYXJ5KScsCiAgICAgICAnZGVwZW5kZW5jaWVzJzog WwpAQCAtMTIwMSw3ICsxMjE2LDcgQEAKICAgICAgICAgIyBFeGNsdWRlIHRoaW5ncyB0aGF0IGRv bid0IGFwcGx5IHRvIHRoZSBDaHJvbWl1bSBwbGF0Zm9ybSBvbiB0aGUgYmFzaXMKICAgICAgICAg IyBvZiB0aGVpciBlbmNsb3NpbmcgZGlyZWN0b3JpZXMgYW5kIHRhZ3MgYXQgdGhlIGVuZHMgb2Yg dGhlaXIKICAgICAgICAgIyBmaWxlbmFtZXMuCi0gICAgICAgIFsnZXhjbHVkZScsICcoYW5kcm9p ZHxjYWlyb3xjZnxjZ3xjdXJsfGd0a3xoYWlrdXxsaW51eHxtYWN8b3BlbnR5cGV8cGxhdGZvcm18 cG9zaXh8cXR8c291cHxzdmd8c3ltYmlhbnx3aW58d3gpLyddLAorICAgICAgICBbJ2V4Y2x1ZGUn LCAnKGFuZHJvaWR8Y2Fpcm98Y2Z8Y2d8Y3VybHxndGt8aGFpa3V8aHRtbHxsaW51eHxtYWN8b3Bl bnR5cGV8cGxhdGZvcm18cG9zaXh8cXR8c291cHxzdmd8c3ltYmlhbnx3aW58d3gpLyddLAogICAg ICAgICBbJ2V4Y2x1ZGUnLCAnKD88IUNocm9taXVtKShBbmRyb2lkfENhaXJvfENGfENHfEN1cmx8 R3RrfExpbnV4fE1hY3xPcGVuVHlwZXxQT1NJWHxQb3NpeHxRdHxTYWZhcml8U291cHxTeW1iaWFu fFdpbnxXeClcXC4oY3BwfG1tPykkJ10sCiAKICAgICAgICAgIyBFeGNsdWRlIG1vc3Qgb2YgU1ZH IGV4Y2VwdCBjc3MgYW5kIGphdmFzY3JpcHQgYmluZGluZ3MuCkBAIC0xMzMxLDYgKzEzNDYsNyBA QAogICAgICAgJ3RhcmdldF9uYW1lJzogJ3dlYmNvcmUnLAogICAgICAgJ3R5cGUnOiAnbm9uZScs CiAgICAgICAnZGVwZW5kZW5jaWVzJzogWworICAgICAgICAnd2ViY29yZV9odG1sJywKICAgICAg ICAgJ3dlYmNvcmVfcGxhdGZvcm0nLAogICAgICAgICAnd2ViY29yZV9yZW1haW5pbmcnLAogICAg ICAgICAjIEV4cG9ydGVkLgo=