46434 2010-09-23 17:24:06 -0700 DOMWindow::revokeBlobURL erroneously uses ParsedURLString 2010-09-24 11:04:00 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 42959 1 ap jianli jianli oldest_to_newest 284134 0 ap 2010-09-23 17:24:06 -0700 The argument comes from the caller, there is absolutely no guarantee that it's in the form KURL expects. This causes assertion failures whenever it's not (e.g. revokeBlobURL("[foo bar]"); For absolute URLs, we should just pass a null base: KURL(KURL(), string). But if it can be relative, a proper base should be passed. 284165 1 68635 jianli 2010-09-23 18:20:50 -0700 Created attachment 68635 Proposed Patch 284546 2 jianli 2010-09-24 11:04:00 -0700 Committed as http://trac.webkit.org/changeset/68275. 68635 2010-09-23 18:20:50 -0700 2010-09-23 20:41:52 -0700 Proposed Patch 46434 text/plain 6336 jianli ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjNTAxN2Q5Li43MTU4NzFjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDkt MjMgIEppYW4gTGkgIDxqaWFubGlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERPTVdpbmRvdzo6cmV2b2tlQmxvYlVSTCBlcnJv bmVvdXNseSB1c2VzIFBhcnNlZFVSTFN0cmluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2NDM0CisKKyAgICAgICAgQWRkIGEgdGVzdC4gQWxzbyB1 cGRhdGUgU2tpcHBlZCBmaWxlcyBmb3IgdGhvc2Ugbm90LXN1cHBvcnRlZCBwbGF0Zm9ybXMuCisK KyAgICAgICAgKiBmYXN0L2ZpbGVzL3Jldm9rZS1ibG9iLXVybC1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGZhc3QvZmlsZXMvcmV2b2tlLWJsb2ItdXJsLmh0bWw6IEFkZGVkLgorICAg ICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVkOgorICAgICAgICAqIHBsYXRmb3JtL21hYy13azIv U2tpcHBlZDoKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorICAgICAgICAqIHBsYXRm b3JtL3dpbi9Ta2lwcGVkOgorCiAyMDEwLTA5LTIzICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9maWxlcy9yZXZva2UtYmxvYi11cmwtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvZmFzdC9maWxlcy9yZXZva2UtYmxvYi11cmwtZXhwZWN0ZWQudHh0Cm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjVjMjYxOTEKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL3Jldm9rZS1ibG9iLXVybC1leHBlY3RlZC50eHQKQEAg LTAsMCArMSwxMCBAQAorVGVzdCBjYWxsaW5nIHJldm9rZUJsb2JVUkwgd2l0aCBubyBhcmd1bWVu dC4KK1BBU1MKK1Rlc3QgY2FsbGluZyByZXZva2VCbG9iVVJMIHdpdGggZW1wdHkgVVJMLgorUEFT UworVGVzdCBjYWxsaW5nIHJldm9rZUJsb2JVUkwgd2l0aCBpbnZhbGlkIFVSTC4KK1BBU1MKK1Rl c3QgY2FsbGluZyByZXZva2VCbG9iVVJMIHdpdGggbm9uLWV4aXN0ZW50IFVSTC4KK1BBU1MKK0RP TkUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9maWxlcy9yZXZva2UtYmxvYi11cmwu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZmlsZXMvcmV2b2tlLWJsb2ItdXJsLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMTZhY2I1YwotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvZmlsZXMvcmV2b2tlLWJsb2ItdXJsLmh0bWwKQEAgLTAsMCArMSwz OCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KK2Z1bmN0aW9u IGxvZyhtZXNzYWdlKQoreworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjb25zb2xlJyku YXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUobWVzc2FnZSArICJcbiIpKTsKK30K KworZnVuY3Rpb24gdGVzdCgpCit7CisgICAgbG9nKCJUZXN0IGNhbGxpbmcgcmV2b2tlQmxvYlVS TCB3aXRoIG5vIGFyZ3VtZW50LiIpOworICAgIHZhciB1cmwgPSByZXZva2VCbG9iVVJMKCk7Cisg ICAgbG9nKHVybCA9PSB1bmRlZmluZWQgPyAiUEFTUyIgOiAiRkFJTCIpOworCisgICAgbG9nKCJU ZXN0IGNhbGxpbmcgcmV2b2tlQmxvYlVSTCB3aXRoIGVtcHR5IFVSTC4iKTsKKyAgICByZXZva2VC bG9iVVJMKCIiKTsKKyAgICBsb2coIlBBU1MiKTsKKworICAgIGxvZygiVGVzdCBjYWxsaW5nIHJl dm9rZUJsb2JVUkwgd2l0aCBpbnZhbGlkIFVSTC4iKTsKKyAgICByZXZva2VCbG9iVVJMKCJbZm9v IGJhcl0iKTsKKyAgICBsb2coIlBBU1MiKTsKKworICAgIGxvZygiVGVzdCBjYWxsaW5nIHJldm9r ZUJsb2JVUkwgd2l0aCBub24tZXhpc3RlbnQgVVJMLiIpOworICAgIHJldm9rZUJsb2JVUkwoImJs b2I6bm9uLWV4aXN0ZW50Iik7CisgICAgbG9nKCJQQVNTIik7CisKKyAgICBsb2coIkRPTkUiKTsK K30KKworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0Q29u dHJvbGxlci5kdW1wQXNUZXh0KCk7Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0i dGVzdCgpIj4KKzxwcmUgaWQ9J2NvbnNvbGUnPjwvcHJlPgorPC9ib2R5PgorPC9odG1sPgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9ndGsvU2tpcHBlZAppbmRleCA2OGM2YmI2Li45YTg5MWQ3IDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvU2tpcHBlZApAQCAtMzA0MywxMiArMzA0Myw4IEBAIGh0dHAvdGVzdHMvbG9jYWwvYmxv Yi9zZW5kLXNsaWNlZC1kYXRhLWJsb2IuaHRtbAogaHR0cC90ZXN0cy9sb2NhbC9mb3JtZGF0YS9z ZW5kLWZvcm0tZGF0YS5odG1sCiBodHRwL3Rlc3RzL2xvY2FsL2Zvcm1kYXRhL3NlbmQtZm9ybS1k YXRhLXdpdGgtc2xpY2VkLWZpbGUuaHRtbAogaHR0cC90ZXN0cy9sb2NhbC9mb3JtZGF0YS91cGxv YWQtZXZlbnRzLmh0bWwKLWZhc3QvZmlsZXMvcmVhZC1ibG9iLWFzeW5jLmh0bWwKLWZhc3QvZmls ZXMvcmVhZC1maWxlLWFzeW5jLmh0bWwKLWZhc3QvZmlsZXMvYXBwbHktYmxvYi11cmwtdG8taW1n Lmh0bWwKLWZhc3QvZmlsZXMvYXBwbHktYmxvYi11cmwtdG8teGhyLmh0bWwKLWZhc3QvZmlsZXMv Y3JlYXRlLWJsb2ItdXJsLWNyYXNoLmh0bWwKLWZhc3QvZmlsZXMvd29ya2VycworIyBGaWxlIEFQ SSBpcyBub3Qgc3VwcG9ydGVkIHlldAorZmFzdC9maWxlcwogaHR0cC90ZXN0cy9tZWRpYS92aWRl by1wbGF5LXN0YWxsLXNlZWsuaHRtbAogaHR0cC90ZXN0cy9tZWRpYS92aWRlby1wbGF5LXN0YWxs Lmh0bWwKIGh0dHAvdGVzdHMvbWVkaWEvdmlkZW8tc2Vla2FibGUtc3RhbGwuaHRtbApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjLXdrMi9Ta2lwcGVkCmluZGV4IDY5M2JhMDUuLjliYWRhMTUgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMtd2syL1NraXBwZWQKQEAgLTM1NiwxMiArMzU2LDcgQEAgZmFzdC9ldmVu dHMvd2luZG93LWV2ZW50cy1idWJibGUuaHRtbAogZmFzdC9ldmVudHMvd2luZG93LWV2ZW50cy1i dWJibGUyLmh0bWwKIGZhc3QvZXZlbnRzL3dpbmRvdy1ldmVudHMtY2FwdHVyZS5odG1sCiBmYXN0 L2V2ZW50cy96b29tLWRibGNsaWNrLmh0bWwKLWZhc3QvZmlsZXMvcmVhZC1ibG9iLWFzeW5jLmh0 bWwKLWZhc3QvZmlsZXMvcmVhZC1maWxlLWFzeW5jLmh0bWwKLWZhc3QvZmlsZXMvYXBwbHktYmxv Yi11cmwtdG8taW1nLmh0bWwKLWZhc3QvZmlsZXMvYXBwbHktYmxvYi11cmwtdG8teGhyLmh0bWwK LWZhc3QvZmlsZXMvY3JlYXRlLWJsb2ItdXJsLWNyYXNoLmh0bWwKLWZhc3QvZmlsZXMvd29ya2Vy cworZmFzdC9maWxlcwogZmFzdC9mb3Jtcy8yNTE1My5odG1sCiBmYXN0L2Zvcm1zL2FjY2Vzcy1r ZXkuaHRtbAogZmFzdC9mb3Jtcy9idXR0b24tZW50ZXItY2xpY2suaHRtbApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0 L1NraXBwZWQKaW5kZXggMWZiZDJhYy4uMDI3ZTNjMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vcXQvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVk CkBAIC03NjksMTIgKzc2OSw5IEBAIGh0dHAvdGVzdHMvc2VjdXJpdHkvaXNvbGF0ZWRXb3JsZC93 b3JsZC1yZXVzZS5odG1sCiAKICMgTWlzc2luZyBldmVudFNlbmRlci5iZWdpbkRyYWdXaXRoRmls ZXMoKQogZmFzdC9kb20vV2luZG93L3dpbmRvdy1wb3N0bWVzc2FnZS1jbG9uZS1mcmFtZXMuaHRt bAotZmFzdC9maWxlcy9yZWFkLWJsb2ItYXN5bmMuaHRtbAotZmFzdC9maWxlcy9yZWFkLWZpbGUt YXN5bmMuaHRtbAotZmFzdC9maWxlcy9hcHBseS1ibG9iLXVybC10by1pbWcuaHRtbAotZmFzdC9m aWxlcy9hcHBseS1ibG9iLXVybC10by14aHIuaHRtbAotZmFzdC9maWxlcy9jcmVhdGUtYmxvYi11 cmwtY3Jhc2guaHRtbAotZmFzdC9maWxlcy93b3JrZXJzCisKKyMgRmlsZSBBUEkgaXMgbm90IHN1 cHBvcnRlZCB5ZXQKK2Zhc3QvZmlsZXMKIAogIyBNaXNzaW5nIGxheW91dFRlc3RDb250cm9sbGVy LnNldEFsd2F5c0FjY2VwdENvb2tpZXMoKQogaHR0cC90ZXN0cy9wbHVnaW5zL3RoaXJkLXBhcnR5 LWNvb2tpZS1hY2NlcHQtcG9saWN5Lmh0bWwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL3dpbi9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQKaW5kZXgg N2Y1Yzk4Ny4uNzM4YTQwNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Nr aXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQKQEAgLTE5NSwxMiAr MTk1LDkgQEAgZmFzdC9mb3Jtcy9pbnB1dC1maWxlLXJlLXJlbmRlci5odG1sCiBodHRwL3Rlc3Rz L3NlY3VyaXR5L2NsaXBib2FyZC9jbGlwYm9hcmQtZmlsZS1hY2Nlc3MuaHRtbAogZmFzdC9ldmVu dHMvZHJhZy1maWxlLWNyYXNoLmh0bWwKIGZhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9zdG1lc3Nh Z2UtY2xvbmUuaHRtbAotZmFzdC9maWxlcy9yZWFkLWJsb2ItYXN5bmMuaHRtbAotZmFzdC9maWxl cy9yZWFkLWZpbGUtYXN5bmMuaHRtbAotZmFzdC9maWxlcy9hcHBseS1ibG9iLXVybC10by1pbWcu aHRtbAotZmFzdC9maWxlcy9hcHBseS1ibG9iLXVybC10by14aHIuaHRtbAotZmFzdC9maWxlcy9j cmVhdGUtYmxvYi11cmwtY3Jhc2guaHRtbAotZmFzdC9maWxlcy93b3JrZXJzCisKKyMgRmlsZSBB UEkgaXMgbm90IHN1cHBvcnRlZCB5ZXQKK2Zhc3QvZmlsZXMKIAogIyBOZWVkIHRvIGFkZCBmdW5j dGlvbmFsaXR5IHRvIER1bXBSZW5kZXJUcmVlIHRvIHRlc3QgSUROIDxyZGFyOi8vcHJvYmxlbS81 MzAxOTU0PgogZmFzdC9lbmNvZGluZy9pZG4tc2VjdXJpdHkuaHRtbApkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5YjU0Mzg5Li5mMjk3Y2Qy IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTA5LTIzICBKaWFuIExpICA8amlhbmxpQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBET01X aW5kb3c6OnJldm9rZUJsb2JVUkwgZXJyb25lb3VzbHkgdXNlcyBQYXJzZWRVUkxTdHJpbmcuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjQzNAorCisg ICAgICAgIFRlc3Q6IGZhc3QvZmlsZXMvcmV2b2tlLWJsb2ItdXJsLmh0bWwKKworICAgICAgICAq IHBhZ2UvRE9NV2luZG93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTVdpbmRvdzo6cmV2b2tl QmxvYlVSTCk6CisKIDIwMTAtMDktMjMgIE1hdHRoZXcgRGVsYW5leSAgPG1kZWxhbmV5QGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwIGIvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAKaW5k ZXggZjViYTI1Yy4uNjA1N2IzZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5j cHAKKysrIGIvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAKQEAgLTE2MDgsNyArMTYwOCw3IEBA IFN0cmluZyBET01XaW5kb3c6OmNyZWF0ZUJsb2JVUkwoQmxvYiogYmxvYikKIAogdm9pZCBET01X aW5kb3c6OnJldm9rZUJsb2JVUkwoY29uc3QgU3RyaW5nJiBibG9iVVJMU3RyaW5nKQogewotICAg IHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKS0+cmV2b2tlUHVibGljQmxvYlVSTChLVVJMKFBhcnNl ZFVSTFN0cmluZywgYmxvYlVSTFN0cmluZykpOworICAgIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQo KS0+cmV2b2tlUHVibGljQmxvYlVSTChLVVJMKEtVUkwoKSwgYmxvYlVSTFN0cmluZykpOwogfQog I2VuZGlmCiAK