46432 2010-09-23 17:03:06 -0700 WebKit2 API: Need way to know when a frame is removed from the hierarchy 2010-09-23 23:14:12 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 sam webkit-unassigned ossy webkit.review.bot oldest_to_newest 284114 0 sam 2010-09-23 17:03:06 -0700 WebKit2 API: Need way to know when a frame is removed from the hierarchy. 284115 1 sam 2010-09-23 17:03:21 -0700 <rdar://problem/8414062> 284117 2 68625 sam 2010-09-23 17:04:54 -0700 Created attachment 68625 Patch 284119 3 webkit.review.bot 2010-09-23 17:07:28 -0700 Attachment 68625 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/API/C/WKPage.h:106: Extra space between WKPageDidRemoveFrameFromHierarchyCallback and didRemoveFrameFromHierarchy [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:102: Extra space between WKBundlePageDidRemoveFrameFromHierarchyCallback and didRemoveFrameFromHierarchy [whitespace/declaration] [3] Total errors found: 2 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style. 284127 4 sam 2010-09-23 17:21:31 -0700 Landed in r68220. 284231 5 ossy 2010-09-23 22:55:04 -0700 (In reply to comment #4) > Landed in r68220. Man! You break Qt buildbot again and again. The bot was red for 5 hours and 12 patch stucked in Qt EWS because of this changeset. Please consider the redness of bots next time. I landed a buildfix in http://trac.webkit.org/changeset/68235. Next time I will think of if I should roll out the culprit changeset instead of fixing ... 284234 6 ossy 2010-09-23 23:14:12 -0700 To avoid breaking Qt bot, I suggest you should wait green Qt EWS status bubble before r+ -ing a patch. It doesn't take a long time, max 5-10 minutes if the queue is empty. 68625 2010-09-23 17:04:54 -0700 2010-09-23 17:09:22 -0700 Patch patch.diff text/plain 15370 sam SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODIxOCkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjggQEAKKzIwMTAtMDktMjMgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJLaXQy IEFQSTogTmVlZCB3YXkgdG8ga25vdyB3aGVuIGEgZnJhbWUgaXMgcmVtb3ZlZCBmcm9tIHRoZSBo aWVyYXJjaHkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg0MTQwNjI+CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjQzMgorCisgICAgICAgICogU2hh cmVkL0NvcmVJUENTdXBwb3J0L1dlYlBhZ2VQcm94eU1lc3NhZ2VLaW5kcy5oOgorICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViTG9hZGVy Q2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTG9hZGVyQ2xpZW50OjpkaWRSZW1vdmVG cmFtZUZyb21IaWVyYXJjaHkpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJMb2FkZXJDbGllbnQu aDoKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViUGFnZVByb3h5OjpkaWRSZWNlaXZlTWVzc2FnZSk6CisgICAgICAgIChXZWJLaXQ6Oldl YlBhZ2VQcm94eTo6ZGlkUmVtb3ZlRnJhbWVGcm9tSGllcmFyY2h5KToKKyAgICAgICAgKiBVSVBy b2Nlc3MvV2ViUGFnZVByb3h5Lmg6CisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRs ZS9BUEkvYy9XS0J1bmRsZVBhZ2UuaDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVu ZGxlL0luamVjdGVkQnVuZGxlUGFnZUxvYWRlckNsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6 OkluamVjdGVkQnVuZGxlUGFnZUxvYWRlckNsaWVudDo6ZGlkUmVtb3ZlRnJhbWVGcm9tSGllcmFy Y2h5KToKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxl UGFnZUxvYWRlckNsaWVudC5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQv V2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUxvYWRl ckNsaWVudDo6ZGV0YWNoZWRGcm9tUGFyZW50Mik6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1l TG9hZGVyQ2xpZW50OjpkaWRUcmFuc2ZlckNoaWxkRnJhbWVUb05ld0RvY3VtZW50KToKKwogMjAx MC0wOS0yMyAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3Zl IHRoZSBEcmF3aW5nQXJlYVByb3h5IHBhcmFtZXRlciB0bwpJbmRleDogV2ViS2l0Mi9TaGFyZWQv Q29yZUlQQ1N1cHBvcnQvV2ViUGFnZVByb3h5TWVzc2FnZUtpbmRzLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0Mi9TaGFyZWQvQ29yZUlQQ1N1cHBvcnQvV2ViUGFnZVByb3h5TWVzc2FnZUtpbmRzLmgJ KHJldmlzaW9uIDY4MjE4KQorKysgV2ViS2l0Mi9TaGFyZWQvQ29yZUlQQ1N1cHBvcnQvV2ViUGFn ZVByb3h5TWVzc2FnZUtpbmRzLmgJKHdvcmtpbmcgY29weSkKQEAgLTYwLDYgKzYwLDcgQEAgZW51 bSBLaW5kIHsKICAgICBEaWRSZWNlaXZlRXZlbnQsCiAgICAgRGlkUmVjZWl2ZVNlcnZlclJlZGly ZWN0Rm9yUHJvdmlzaW9uYWxMb2FkRm9yRnJhbWUsCiAgICAgRGlkUmVjZWl2ZVRpdGxlRm9yRnJh bWUsCisgICAgRGlkUmVtb3ZlRnJhbWVGcm9tSGllcmFyY2h5LAogICAgIERpZFJ1bkphdmFTY3Jp cHRJbk1haW5GcmFtZSwKICAgICBEaWRTZXRGcmFtZSwKICAgICBEaWRTdGFydFByb2dyZXNzLApJ bmRleDogV2ViS2l0Mi9VSVByb2Nlc3MvV2ViTG9hZGVyQ2xpZW50LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXQyL1VJUHJvY2Vzcy9XZWJMb2FkZXJDbGllbnQuY3BwCShyZXZpc2lvbiA2ODIxOCkK KysrIFdlYktpdDIvVUlQcm9jZXNzL1dlYkxvYWRlckNsaWVudC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTEyMyw2ICsxMjMsMTQgQEAgdm9pZCBXZWJMb2FkZXJDbGllbnQ6OmRpZEZpcnN0VmlzdWFs bHlObwogICAgIG1fcGFnZUxvYWRlckNsaWVudC5kaWRGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlv dXRGb3JGcmFtZSh0b1JlZihwYWdlKSwgdG9SZWYoZnJhbWUpLCB0b1JlZih1c2VyRGF0YSksIG1f cGFnZUxvYWRlckNsaWVudC5jbGllbnRJbmZvKTsKIH0KIAordm9pZCBXZWJMb2FkZXJDbGllbnQ6 OmRpZFJlbW92ZUZyYW1lRnJvbUhpZXJhcmNoeShXZWJQYWdlUHJveHkqIHBhZ2UsIFdlYkZyYW1l UHJveHkqIGZyYW1lLCBBUElPYmplY3QqIHVzZXJEYXRhKQoreworICAgIGlmICghbV9wYWdlTG9h ZGVyQ2xpZW50LmRpZFJlbW92ZUZyYW1lRnJvbUhpZXJhcmNoeSkKKyAgICAgICAgcmV0dXJuOwor CisgICAgbV9wYWdlTG9hZGVyQ2xpZW50LmRpZFJlbW92ZUZyYW1lRnJvbUhpZXJhcmNoeSh0b1Jl ZihwYWdlKSwgdG9SZWYoZnJhbWUpLCB0b1JlZih1c2VyRGF0YSksIG1fcGFnZUxvYWRlckNsaWVu dC5jbGllbnRJbmZvKTsKK30KKwogdm9pZCBXZWJMb2FkZXJDbGllbnQ6OmRpZFN0YXJ0UHJvZ3Jl c3MoV2ViUGFnZVByb3h5KiBwYWdlKQogewogICAgIGlmICghbV9wYWdlTG9hZGVyQ2xpZW50LmRp ZFN0YXJ0UHJvZ3Jlc3MpCkluZGV4OiBXZWJLaXQyL1VJUHJvY2Vzcy9XZWJMb2FkZXJDbGllbnQu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJLaXQyL1VJUHJvY2Vzcy9XZWJMb2FkZXJDbGllbnQuaAkocmV2 aXNpb24gNjgyMTgpCisrKyBXZWJLaXQyL1VJUHJvY2Vzcy9XZWJMb2FkZXJDbGllbnQuaAkod29y a2luZyBjb3B5KQpAQCAtNTAsNiArNTAsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBkaWRSZWNlaXZl VGl0bGVGb3JGcmFtZShXZWJQYWdlUHJveHkqLCBjb25zdCBTdHJpbmcmLCBXZWJGcmFtZVByb3h5 KiwgQVBJT2JqZWN0Kik7CiAgICAgdm9pZCBkaWRGaXJzdExheW91dEZvckZyYW1lKFdlYlBhZ2VQ cm94eSosIFdlYkZyYW1lUHJveHkqLCBBUElPYmplY3QqKTsKICAgICB2b2lkIGRpZEZpcnN0Vmlz dWFsbHlOb25FbXB0eUxheW91dEZvckZyYW1lKFdlYlBhZ2VQcm94eSosIFdlYkZyYW1lUHJveHkq LCBBUElPYmplY3QqKTsKKyAgICB2b2lkIGRpZFJlbW92ZUZyYW1lRnJvbUhpZXJhcmNoeShXZWJQ YWdlUHJveHkqLCBXZWJGcmFtZVByb3h5KiwgQVBJT2JqZWN0Kik7CiAKICAgICB2b2lkIGRpZFN0 YXJ0UHJvZ3Jlc3MoV2ViUGFnZVByb3h5Kik7CiAgICAgdm9pZCBkaWRDaGFuZ2VQcm9ncmVzcyhX ZWJQYWdlUHJveHkqKTsKSW5kZXg6IFdlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkocmV2aXNp b24gNjgyMTgpCisrKyBXZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC02ODUsNiArNjg1LDE4IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpkaWRSZWNlaXZl TWVzc2FnZShDb3IKICAgICAgICAgICAgIGRpZEZpcnN0VmlzdWFsbHlOb25FbXB0eUxheW91dEZv ckZyYW1lKHByb2Nlc3MoKS0+d2ViRnJhbWUoZnJhbWVJRCksIHVzZXJEYXRhLmdldCgpKTsKICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CisgICAgICAgIGNhc2UgV2ViUGFnZVByb3h5TWVz c2FnZTo6RGlkUmVtb3ZlRnJhbWVGcm9tSGllcmFyY2h5OiB7CisgICAgICAgICAgICB1aW50NjRf dCBmcmFtZUlEOworCisgICAgICAgICAgICBSZWZQdHI8QVBJT2JqZWN0PiB1c2VyRGF0YTsKKyAg ICAgICAgICAgIFdlYkNvbnRleHRVc2VyTWVzc2FnZURlY29kZXIgbWVzc2FnZURlY29kZXIodXNl ckRhdGEsIHBhZ2VOYW1lc3BhY2UoKS0+Y29udGV4dCgpKTsKKworICAgICAgICAgICAgaWYgKCFh cmd1bWVudHMtPmRlY29kZShDb3JlSVBDOjpPdXQoZnJhbWVJRCwgbWVzc2FnZURlY29kZXIpKSkK KyAgICAgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgICAgIGRpZFJlbW92ZUZyYW1lRnJv bUhpZXJhcmNoeShwcm9jZXNzKCktPndlYkZyYW1lKGZyYW1lSUQpLCB1c2VyRGF0YS5nZXQoKSk7 CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQogICAgICAgICBjYXNlIFdlYlBhZ2VQcm94 eU1lc3NhZ2U6OkRpZFN0YXJ0UHJvZ3Jlc3M6CiAgICAgICAgICAgICBkaWRTdGFydFByb2dyZXNz KCk7CiAgICAgICAgICAgICBicmVhazsKQEAgLTEwNjEsNiArMTA3MywxMSBAQCB2b2lkIFdlYlBh Z2VQcm94eTo6ZGlkRmlyc3RWaXN1YWxseU5vbkVtCiAgICAgbV9sb2FkZXJDbGllbnQuZGlkRmly c3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0Rm9yRnJhbWUodGhpcywgZnJhbWUsIHVzZXJEYXRhKTsK IH0KIAordm9pZCBXZWJQYWdlUHJveHk6OmRpZFJlbW92ZUZyYW1lRnJvbUhpZXJhcmNoeShXZWJG cmFtZVByb3h5KiBmcmFtZSwgQVBJT2JqZWN0KiB1c2VyRGF0YSkKK3sKKyAgICBtX2xvYWRlckNs aWVudC5kaWRSZW1vdmVGcmFtZUZyb21IaWVyYXJjaHkodGhpcywgZnJhbWUsIHVzZXJEYXRhKTsK K30KKwogLy8gUG9saWN5Q2xpZW50CiAKIHZvaWQgV2ViUGFnZVByb3h5OjpkZWNpZGVQb2xpY3lG b3JOYXZpZ2F0aW9uQWN0aW9uKFdlYkZyYW1lUHJveHkqIGZyYW1lLCBOYXZpZ2F0aW9uVHlwZSBu YXZpZ2F0aW9uVHlwZSwgV2ViRXZlbnQ6Ok1vZGlmaWVycyBtb2RpZmllcnMsIFdlYk1vdXNlRXZl bnQ6OkJ1dHRvbiBtb3VzZUJ1dHRvbiwgY29uc3QgU3RyaW5nJiB1cmwsIHVpbnQ2NF90IGxpc3Rl bmVySUQpCkluZGV4OiBXZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAkocmV2aXNpb24gNjgyMTgpCisr KyBXZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAkod29ya2luZyBjb3B5KQpAQCAtMjIy LDYgKzIyMiw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBkaWRSZWNlaXZlVGl0bGVGb3JGcmFtZShX ZWJGcmFtZVByb3h5KiwgY29uc3QgU3RyaW5nJiwgQVBJT2JqZWN0Kik7CiAgICAgdm9pZCBkaWRG aXJzdExheW91dEZvckZyYW1lKFdlYkZyYW1lUHJveHkqLCBBUElPYmplY3QqKTsKICAgICB2b2lk IGRpZEZpcnN0VmlzdWFsbHlOb25FbXB0eUxheW91dEZvckZyYW1lKFdlYkZyYW1lUHJveHkqLCBB UElPYmplY3QqKTsKKyAgICB2b2lkIGRpZFJlbW92ZUZyYW1lRnJvbUhpZXJhcmNoeShXZWJGcmFt ZVByb3h5KiwgQVBJT2JqZWN0Kik7CiAgICAgdm9pZCBkaWRTdGFydFByb2dyZXNzKCk7CiAgICAg dm9pZCBkaWRDaGFuZ2VQcm9ncmVzcyhkb3VibGUpOwogICAgIHZvaWQgZGlkRmluaXNoUHJvZ3Jl c3MoKTsKSW5kZXg6IFdlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5oCShyZXZpc2lvbiA2ODIxOCkKKysr IFdlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5oCSh3b3JraW5nIGNvcHkpCkBAIC03NSw2 ICs3NSw3IEBAIHR5cGVkZWYgdm9pZCAoKldLUGFnZURpZEZhaWxMb2FkV2l0aEVycm8KIHR5cGVk ZWYgdm9pZCAoKldLUGFnZURpZFJlY2VpdmVUaXRsZUZvckZyYW1lQ2FsbGJhY2spKFdLUGFnZVJl ZiBwYWdlLCBXS1N0cmluZ1JlZiB0aXRsZSwgV0tGcmFtZVJlZiBmcmFtZSwgV0tUeXBlUmVmIHVz ZXJEYXRhLCBjb25zdCB2b2lkICpjbGllbnRJbmZvKTsKIHR5cGVkZWYgdm9pZCAoKldLUGFnZURp ZEZpcnN0TGF5b3V0Rm9yRnJhbWUpKFdLUGFnZVJlZiBwYWdlLCBXS0ZyYW1lUmVmIGZyYW1lLCBX S1R5cGVSZWYgdXNlckRhdGEsIGNvbnN0IHZvaWQgKmNsaWVudEluZm8pOwogdHlwZWRlZiB2b2lk ICgqV0tQYWdlRGlkRmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0Rm9yRnJhbWUpKFdLUGFnZVJl ZiBwYWdlLCBXS0ZyYW1lUmVmIGZyYW1lLCBXS1R5cGVSZWYgdXNlckRhdGEsIGNvbnN0IHZvaWQg KmNsaWVudEluZm8pOwordHlwZWRlZiB2b2lkICgqV0tQYWdlRGlkUmVtb3ZlRnJhbWVGcm9tSGll cmFyY2h5Q2FsbGJhY2spKFdLUGFnZVJlZiBwYWdlLCBXS0ZyYW1lUmVmIGZyYW1lLCBXS1R5cGVS ZWYgdXNlckRhdGEsIGNvbnN0IHZvaWQgKmNsaWVudEluZm8pOwogCiAvLyBQcm9ncmVzcyBDbGll bnQKIHR5cGVkZWYgdm9pZCAoKldLUGFnZURpZFN0YXJ0UHJvZ3Jlc3NDYWxsYmFjaykoV0tQYWdl UmVmIHBhZ2UsIGNvbnN0IHZvaWQgKmNsaWVudEluZm8pOwpAQCAtMTAyLDYgKzEwMyw3IEBAIHN0 cnVjdCBXS1BhZ2VMb2FkZXJDbGllbnQgewogICAgIFdLUGFnZURpZFJlY2VpdmVUaXRsZUZvckZy YW1lQ2FsbGJhY2sgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGlkUmVjZWl2ZVRpdGxl Rm9yRnJhbWU7CiAgICAgV0tQYWdlRGlkRmlyc3RMYXlvdXRGb3JGcmFtZSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBkaWRGaXJzdExheW91dEZvckZyYW1lOwogICAgIFdL UGFnZURpZEZpcnN0VmlzdWFsbHlOb25FbXB0eUxheW91dEZvckZyYW1lICAgICAgICAgICAgICAg ICAgICAgICAgZGlkRmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0Rm9yRnJhbWU7CisgICAgV0tQ YWdlRGlkUmVtb3ZlRnJhbWVGcm9tSGllcmFyY2h5Q2FsbGJhY2sgICAgICAgICAgICAgICAgICAg ICAgICAgICBkaWRSZW1vdmVGcmFtZUZyb21IaWVyYXJjaHk7CiAKICAgICAvLyBGSVhNRTogTW92 ZSB0byBwcm9ncmVzcyBjbGllbnQuCiAgICAgV0tQYWdlRGlkU3RhcnRQcm9ncmVzc0NhbGxiYWNr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkaWRTdGFydFByb2dyZXNzOwpJ bmRleDogV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFn ZUxvYWRlckNsaWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVj dGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFnZUxvYWRlckNsaWVudC5jcHAJKHJldmlzaW9uIDY4 MjE4KQorKysgV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxl UGFnZUxvYWRlckNsaWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0Nyw2ICsxNDcsMTYgQEAg dm9pZCBJbmplY3RlZEJ1bmRsZVBhZ2VMb2FkZXJDbGllbnQ6OmRpZAogICAgIHVzZXJEYXRhID0g YWRvcHRSZWYodG9XSyh1c2VyRGF0YVRvUGFzcykpOwogfQogCit2b2lkIEluamVjdGVkQnVuZGxl UGFnZUxvYWRlckNsaWVudDo6ZGlkUmVtb3ZlRnJhbWVGcm9tSGllcmFyY2h5KFdlYlBhZ2UqIHBh Z2UgLCBXZWJGcmFtZSogZnJhbWUsIFJlZlB0cjxBUElPYmplY3Q+JiB1c2VyRGF0YSkKK3sKKyAg ICBpZiAoIW1fY2xpZW50LmRpZFJlbW92ZUZyYW1lRnJvbUhpZXJhcmNoeSkKKyAgICAgICAgcmV0 dXJuOworCisgICAgV0tUeXBlUmVmIHVzZXJEYXRhVG9QYXNzID0gMDsKKyAgICBtX2NsaWVudC5k aWRSZW1vdmVGcmFtZUZyb21IaWVyYXJjaHkodG9SZWYocGFnZSksIHRvUmVmKGZyYW1lKSwgJnVz ZXJEYXRhVG9QYXNzLCBtX2NsaWVudC5jbGllbnRJbmZvKTsKKyAgICB1c2VyRGF0YSA9IGFkb3B0 UmVmKHRvV0sodXNlckRhdGFUb1Bhc3MpKTsKK30KKwogdm9pZCBJbmplY3RlZEJ1bmRsZVBhZ2VM b2FkZXJDbGllbnQ6OmRpZENsZWFyV2luZG93T2JqZWN0Rm9yRnJhbWUoV2ViUGFnZSogcGFnZSwg V2ViRnJhbWUqIGZyYW1lLCBET01XcmFwcGVyV29ybGQqIHdvcmxkKQogewogICAgIGlmICghbV9j bGllbnQuZGlkQ2xlYXJXaW5kb3dPYmplY3RGb3JGcmFtZSkKSW5kZXg6IFdlYktpdDIvV2ViUHJv Y2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZVBhZ2VMb2FkZXJDbGllbnQuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5k bGVQYWdlTG9hZGVyQ2xpZW50LmgJKHJldmlzaW9uIDY4MjE4KQorKysgV2ViS2l0Mi9XZWJQcm9j ZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFnZUxvYWRlckNsaWVudC5oCSh3b3Jr aW5nIGNvcHkpCkBAIC01NSw2ICs1NSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGRpZFJlY2VpdmVU aXRsZUZvckZyYW1lKFdlYlBhZ2UqLCBjb25zdCBTdHJpbmcmLCBXZWJGcmFtZSosIFJlZlB0cjxB UElPYmplY3Q+JiB1c2VyRGF0YSk7CiAgICAgdm9pZCBkaWRGaXJzdExheW91dEZvckZyYW1lKFdl YlBhZ2UqLCBXZWJGcmFtZSosIFJlZlB0cjxBUElPYmplY3Q+JiB1c2VyRGF0YSk7CiAgICAgdm9p ZCBkaWRGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXRGb3JGcmFtZShXZWJQYWdlKiwgV2ViRnJh bWUqLCBSZWZQdHI8QVBJT2JqZWN0PiYgdXNlckRhdGEpOworICAgIHZvaWQgZGlkUmVtb3ZlRnJh bWVGcm9tSGllcmFyY2h5KFdlYlBhZ2UqLCBXZWJGcmFtZSosIFJlZlB0cjxBUElPYmplY3Q+JiB1 c2VyRGF0YSk7CiAKICAgICB2b2lkIGRpZENsZWFyV2luZG93T2JqZWN0Rm9yRnJhbWUoV2ViUGFn ZSosIFdlYkZyYW1lKiwgV2ViQ29yZTo6RE9NV3JhcHBlcldvcmxkKik7CiAgICAgdm9pZCBkaWRD YW5jZWxDbGllbnRSZWRpcmVjdEZvckZyYW1lKFdlYlBhZ2UqLCBXZWJGcmFtZSopOwpJbmRleDog V2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1 bmRsZVBhZ2UuaAkocmV2aXNpb24gNjgyMTgpCisrKyBXZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0 ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlLmgJKHdvcmtpbmcgY29weSkKQEAgLTc1LDYgKzc1 LDcgQEAgdHlwZWRlZiB2b2lkICgqV0tCdW5kbGVQYWdlRGlkRmFpbExvYWRXaQogdHlwZWRlZiB2 b2lkICgqV0tCdW5kbGVQYWdlRGlkUmVjZWl2ZVRpdGxlRm9yRnJhbWVDYWxsYmFjaykoV0tCdW5k bGVQYWdlUmVmIHBhZ2UsIFdLU3RyaW5nUmVmIHRpdGxlLCBXS0J1bmRsZUZyYW1lUmVmIGZyYW1l LCBXS1R5cGVSZWYqIHVzZXJEYXRhLCBjb25zdCB2b2lkICpjbGllbnRJbmZvKTsKIHR5cGVkZWYg dm9pZCAoKldLQnVuZGxlUGFnZURpZEZpcnN0TGF5b3V0Rm9yRnJhbWUpKFdLQnVuZGxlUGFnZVJl ZiBwYWdlLCBXS0J1bmRsZUZyYW1lUmVmIGZyYW1lLCBXS1R5cGVSZWYqIHVzZXJEYXRhLCBjb25z dCB2b2lkICpjbGllbnRJbmZvKTsKIHR5cGVkZWYgdm9pZCAoKldLQnVuZGxlUGFnZURpZEZpcnN0 VmlzdWFsbHlOb25FbXB0eUxheW91dEZvckZyYW1lKShXS0J1bmRsZVBhZ2VSZWYgcGFnZSwgV0tC dW5kbGVGcmFtZVJlZiBmcmFtZSwgV0tUeXBlUmVmKiB1c2VyRGF0YSwgY29uc3Qgdm9pZCAqY2xp ZW50SW5mbyk7Cit0eXBlZGVmIHZvaWQgKCpXS0J1bmRsZVBhZ2VEaWRSZW1vdmVGcmFtZUZyb21I aWVyYXJjaHlDYWxsYmFjaykoV0tCdW5kbGVQYWdlUmVmIHBhZ2UsIFdLQnVuZGxlRnJhbWVSZWYg ZnJhbWUsIFdLVHlwZVJlZiogdXNlckRhdGEsIGNvbnN0IHZvaWQgKmNsaWVudEluZm8pOwogLy8g RklYTUU6IFRoZXJlIGFyZSBubyBXS1BhZ2UgZXF1aXZpbGVudCBvZiB0aGVzZSBmdW5jdGlvbnMg eWV0LgogdHlwZWRlZiB2b2lkICgqV0tCdW5kbGVQYWdlRGlkQ2xlYXJXaW5kb3dPYmplY3RGb3JG cmFtZUNhbGxiYWNrKShXS0J1bmRsZVBhZ2VSZWYgcGFnZSwgV0tCdW5kbGVGcmFtZVJlZiBmcmFt ZSwgV0tCdW5kbGVTY3JpcHRXb3JsZFJlZiB3b3JsZCwgY29uc3Qgdm9pZCAqY2xpZW50SW5mbyk7 CiB0eXBlZGVmIHZvaWQgKCpXS0J1bmRsZVBhZ2VEaWRDYW5jZWxDbGllbnRSZWRpcmVjdEZvckZy YW1lQ2FsbGJhY2spKFdLQnVuZGxlUGFnZVJlZiBwYWdlLCBXS0J1bmRsZUZyYW1lUmVmIGZyYW1l LCBjb25zdCB2b2lkICpjbGllbnRJbmZvKTsKQEAgLTk4LDYgKzk5LDcgQEAgc3RydWN0IFdLQnVu ZGxlUGFnZUxvYWRlckNsaWVudCB7CiAgICAgV0tCdW5kbGVQYWdlRGlkUmVjZWl2ZVRpdGxlRm9y RnJhbWVDYWxsYmFjayAgICAgICAgICAgICAgICAgICAgICAgICBkaWRSZWNlaXZlVGl0bGVGb3JG cmFtZTsKICAgICBXS0J1bmRsZVBhZ2VEaWRGaXJzdExheW91dEZvckZyYW1lICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGRpZEZpcnN0TGF5b3V0Rm9yRnJhbWU7CiAgICAgV0tCdW5k bGVQYWdlRGlkRmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0Rm9yRnJhbWUgICAgICAgICAgICAg ICAgICBkaWRGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXRGb3JGcmFtZTsKKyAgICBXS0J1bmRs ZVBhZ2VEaWRSZW1vdmVGcmFtZUZyb21IaWVyYXJjaHlDYWxsYmFjayAgICAgICAgICAgICAgICAg ICAgIGRpZFJlbW92ZUZyYW1lRnJvbUhpZXJhcmNoeTsKIAogICAgIC8vIEZJWE1FOiBUaGVyZSBh cmUgbm8gV0tQYWdlIGVxdWl2aWxlbnQgb2YgdGhlc2UgZnVuY3Rpb25zIHlldC4KICAgICBXS0J1 bmRsZVBhZ2VEaWRDbGVhcldpbmRvd09iamVjdEZvckZyYW1lQ2FsbGJhY2sgICAgICAgICAgICAg ICAgICAgIGRpZENsZWFyV2luZG93T2JqZWN0Rm9yRnJhbWU7CkluZGV4OiBXZWJLaXQyL1dlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVu dC5jcHAJKHJldmlzaW9uIDY4MjE4KQorKysgV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBw b3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTE1LDcgKzEx NSwxNyBAQCB2b2lkIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpzZXRDb3BpZXNPblNjCiAKIHZvaWQg V2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRldGFjaGVkRnJvbVBhcmVudDIoKQogewotICAgIG5vdElt cGxlbWVudGVkKCk7CisgICAgV2ViUGFnZSogd2ViUGFnZSA9IG1fZnJhbWUtPnBhZ2UoKTsKKyAg ICBpZiAoIXdlYlBhZ2UpCisgICAgICAgIHJldHVybjsKKworICAgIFJlZlB0cjxBUElPYmplY3Q+ IHVzZXJEYXRhOworCisgICAgLy8gTm90aWZ5IHRoZSBidW5kbGUgY2xpZW50LgorICAgIHdlYlBh Z2UtPmluamVjdGVkQnVuZGxlTG9hZGVyQ2xpZW50KCkuZGlkUmVtb3ZlRnJhbWVGcm9tSGllcmFy Y2h5KHdlYlBhZ2UsIG1fZnJhbWUsIHVzZXJEYXRhKTsKKworICAgIC8vIE5vdGlmeSB0aGUgVUlQ cm9jZXNzLgorICAgIFdlYlByb2Nlc3M6OnNoYXJlZCgpLmNvbm5lY3Rpb24oKS0+c2VuZChXZWJQ YWdlUHJveHlNZXNzYWdlOjpEaWRSZW1vdmVGcmFtZUZyb21IaWVyYXJjaHksIHdlYlBhZ2UtPnBh Z2VJRCgpLCBDb3JlSVBDOjpJbihtX2ZyYW1lLT5mcmFtZUlEKCksIEluamVjdGVkQnVuZGxlVXNl ck1lc3NhZ2VFbmNvZGVyKHVzZXJEYXRhLmdldCgpKSkpOwogfQogCiB2b2lkIFdlYkZyYW1lTG9h ZGVyQ2xpZW50OjpkZXRhY2hlZEZyb21QYXJlbnQzKCkKQEAgLTk1NSw3ICs5NjUsNyBAQCBQYXNz UmVmUHRyPEZyYW1lPiBXZWJGcmFtZUxvYWRlckNsaWVudDo6CiB2b2lkIFdlYkZyYW1lTG9hZGVy Q2xpZW50OjpkaWRUcmFuc2ZlckNoaWxkRnJhbWVUb05ld0RvY3VtZW50KCkKIHsKICAgICBub3RJ bXBsZW1lbnRlZCgpOwotfSAgICAKK30KIAogUGFzc1JlZlB0cjxXaWRnZXQ+IFdlYkZyYW1lTG9h ZGVyQ2xpZW50OjpjcmVhdGVQbHVnaW4oY29uc3QgSW50U2l6ZSYsIEhUTUxQbHVnSW5FbGVtZW50 KiBwbHVnaW5FbGVtZW50LCBjb25zdCBLVVJMJiB1cmwsIGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBw YXJhbU5hbWVzLCBjb25zdCBWZWN0b3I8U3RyaW5nPiYgcGFyYW1WYWx1ZXMsIGNvbnN0IFN0cmlu ZyYgbWltZVR5cGUsIGJvb2wgbG9hZE1hbnVhbGx5KQogewpJbmRleDogV2ViS2l0VG9vbHMvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gNjgy MTgpCisrKyBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx OSBAQAorMjAxMC0wOS0yMyAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYktpdDIgQVBJOiBOZWVk IHdheSB0byBrbm93IHdoZW4gYSBmcmFtZSBpcyByZW1vdmVkIGZyb20gdGhlIGhpZXJhcmNoeQor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vODQxNDA2Mj4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2NDMyCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9t YWMvQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIubToKKyAgICAgICAgKGRpZFJlbW92ZUZyYW1lRnJv bUhpZXJhcmNoeSk6CisgICAgICAgICgtW0Jyb3dzZXJXaW5kb3dDb250cm9sbGVyIGF3YWtlRnJv bU5pYl0pOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0 ZWRCdW5kbGVQYWdlLmNwcDoKKyAgICAgICAgKFdUUjo6SW5qZWN0ZWRCdW5kbGVQYWdlOjpJbmpl Y3RlZEJ1bmRsZVBhZ2UpOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xs ZXIuY3BwOgorICAgICAgICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6aW5pdGlhbGl6ZSk6CisKIDIw MTAtMDktMjMgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBXZWJLaXRUb29scy9NaW5pQnJvd3Nlci9t YWMvQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9N aW5pQnJvd3Nlci9tYWMvQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIubQkocmV2aXNpb24gNjgxNjcp CisrKyBXZWJLaXRUb29scy9NaW5pQnJvd3Nlci9tYWMvQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIu bQkod29ya2luZyBjb3B5KQpAQCAtMzAwLDYgKzMwMCwxMSBAQCBzdGF0aWMgdm9pZCBkaWRGaXJz dFZpc3VhbGx5Tm9uRW1wdHlMYXlvCiAgICAgTE9HKEAiZGlkRmlyc3RWaXN1YWxseU5vbkVtcHR5 TGF5b3V0Rm9yRnJhbWUiKTsKIH0KIAorc3RhdGljIHZvaWQgZGlkUmVtb3ZlRnJhbWVGcm9tSGll cmFyY2h5KFdLUGFnZVJlZiBwYWdlLCBXS0ZyYW1lUmVmIGZyYW1lLCBXS1R5cGVSZWYgdXNlckRh dGEsIGNvbnN0IHZvaWQgKmNsaWVudEluZm8pCit7CisgICAgTE9HKEAiZGlkUmVtb3ZlRnJhbWVG cm9tSGllcmFyY2h5Iik7Cit9CisKIHN0YXRpYyB2b2lkIGRpZFN0YXJ0UHJvZ3Jlc3MoV0tQYWdl UmVmIHBhZ2UsIGNvbnN0IHZvaWQgKmNsaWVudEluZm8pCiB7CiAgICAgWyhCcm93c2VyV2luZG93 Q29udHJvbGxlciAqKWNsaWVudEluZm8gZGlkU3RhcnRQcm9ncmVzc107CkBAIC00OTYsNiArNTAx LDcgQEAgLSAodm9pZClhd2FrZUZyb21OaWIKICAgICAgICAgZGlkUmVjZWl2ZVRpdGxlRm9yRnJh bWUsCiAgICAgICAgIGRpZEZpcnN0TGF5b3V0Rm9yRnJhbWUsCiAgICAgICAgIGRpZEZpcnN0Vmlz dWFsbHlOb25FbXB0eUxheW91dEZvckZyYW1lLAorICAgICAgICBkaWRSZW1vdmVGcmFtZUZyb21I aWVyYXJjaHksCiAgICAgICAgIGRpZFN0YXJ0UHJvZ3Jlc3MsCiAgICAgICAgIGRpZENoYW5nZVBy b2dyZXNzLAogICAgICAgICBkaWRGaW5pc2hQcm9ncmVzcywKSW5kZXg6IFdlYktpdFRvb2xzL1dl YktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRv b2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiA2ODE2NykK KysrIFdlYktpdFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xODYsNiArMTg2LDcgQEAgdm9pZCBUZXN0Q29udHJvbGxlcjo6aW5pdGlh bGl6ZShpbnQgYXJnYwogICAgICAgICAwLAogICAgICAgICAwLAogICAgICAgICAwLAorICAgICAg ICAwLAogICAgICAgICAwCiAgICAgfTsKICAgICBXS1BhZ2VTZXRQYWdlTG9hZGVyQ2xpZW50KG1f bWFpbldlYlZpZXctPnBhZ2UoKSwgJnBhZ2VMb2FkZXJDbGllbnQpOwpJbmRleDogV2ViS2l0VG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZVBhZ2UuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5k bGUvSW5qZWN0ZWRCdW5kbGVQYWdlLmNwcAkocmV2aXNpb24gNjgxNjcpCisrKyBXZWJLaXRUb29s cy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFnZS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTE2OSw2ICsxNjksNyBAQCBJbmplY3RlZEJ1bmRsZVBhZ2U6Oklu amVjdGVkQnVuZGxlUGFnZShXCiAgICAgICAgIGRpZFJlY2VpdmVUaXRsZUZvckZyYW1lLAogICAg ICAgICAwLAogICAgICAgICAwLAorICAgICAgICAwLAogICAgICAgICBkaWRDbGVhcldpbmRvd0Zv ckZyYW1lLAogICAgICAgICBkaWRDYW5jZWxDbGllbnRSZWRpcmVjdEZvckZyYW1lLAogICAgICAg ICB3aWxsUGVyZm9ybUNsaWVudFJlZGlyZWN0Rm9yRnJhbWUsCg==