46423 2010-09-23 15:40:25 -0700 ~9.9% speedup when compiling interpreter with llvm-gcc-4.2 2010-09-23 16:12:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 35716 1 ddkilzer ddkilzer joepeck oliver oldest_to_newest 284044 0 68609 ddkilzer 2010-09-23 15:40:25 -0700 Created attachment 68609 Patch Reviewed by NOBODY (OOPS!). * interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Disable the gcc computed goto hacks added in r55564 when compiling with llvm-gcc-4.2. --- 2 files changed, 24 insertions(+), 12 deletions(-) 284045 1 ddkilzer 2010-09-23 15:42:22 -0700 rdar://problem/8460731 284046 2 ddkilzer 2010-09-23 15:45:27 -0700 Commit r55564 is Bug 35716. <http://trac.webkit.org/changeset/55564> 284067 3 ddkilzer 2010-09-23 16:12:23 -0700 Committed r68212: <http://trac.webkit.org/changeset/68212> 68609 2010-09-23 15:40:25 -0700 2010-09-23 15:42:33 -0700 Patch 20100923154023.patch text/plain 4454 ddkilzer ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBhM2I1YzgxNGIyODM4NTBjZDhkNWM2NzliZTg3ODk3YmVlYmI3ZjI3Li5k NTA2N2ZiMjMxY2U5YWMwYTYxZDA0YTQxM2M2ODlhZGFhNmMyMGZmIDEwMDY0NAotLS0gYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTAtMDktMjMgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNv bT4KKworICAgICAgICA8cmRhcjovL3Byb2JsZW0vODQ2MDczMT4gfjkuOSUgc3BlZWR1cCB3aGVu IGNvbXBpbGluZyBpbnRlcnByZXRlciB3aXRoIGxsdm0tZ2NjLTQuMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW50ZXJwcmV0ZXIvSW50ZXJwcmV0 ZXIuY3BwOgorICAgICAgICAoSlNDOjpJbnRlcnByZXRlcjo6cHJpdmF0ZUV4ZWN1dGUpOiBEaXNh YmxlIHRoZSBnY2MgY29tcHV0ZWQKKyAgICAgICAgZ290byBoYWNrcyBhZGRlZCBpbiByNTU1NjQg d2hlbiBjb21waWxpbmcgd2l0aCBsbHZtLWdjYy00LjIuCisKIDIwMTAtMDktMjEgIE9saXZlciBI dW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSUz1HYXZpbiBCYXJyYWNsb3VnaC4K ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcCBi L0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcAppbmRleCBkNDNlYjU3 NDIyOGVjMTk5MTkyMzQzZTNjOWVjYjY5MTg4YjdkMWQ5Li44MzgxNWUzNjgyMzE4YTYyM2I2NWQ0 MmIxOTliYjZkNTU5NGM3OTNmIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRl ci9JbnRlcnByZXRlci5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJw cmV0ZXIuY3BwCkBAIC02Nyw2ICs2Nyw4IEBACiAjaW5jbHVkZSAiSklULmgiCiAjZW5kaWYKIAor I2RlZmluZSBXVEZfVVNFX0dDQ19DT01QVVRFRF9HT1RPX1dPUktBUk9VTkQgKEVOQUJMRShDT01Q VVRFRF9HT1RPX0lOVEVSUFJFVEVSKSAmJiAhZGVmaW5lZChfX2xsdm1fXykpCisKIHVzaW5nIG5h bWVzcGFjZSBzdGQ7CiAKIG5hbWVzcGFjZSBKU0MgewpAQCAtMjQ3Myw3ICsyNDc1LDcgQEAgSlNW YWx1ZSBJbnRlcnByZXRlcjo6cHJpdmF0ZUV4ZWN1dGUoRXhlY3V0aW9uRmxhZyBmbGFnLCBSZWdp c3RlckZpbGUqIHJlZ2lzdGVyRmkKICAgICAgICAgdW5jYWNoZUdldEJ5SUQoY29kZUJsb2NrLCB2 UEMpOwogICAgICAgICBORVhUX0lOU1RSVUNUSU9OKCk7CiAgICAgfQotI2lmIEVOQUJMRShDT01Q VVRFRF9HT1RPX0lOVEVSUFJFVEVSKQorI2lmIFVTRShHQ0NfQ09NUFVURURfR09UT19XT1JLQVJP VU5EKQogICAgIGdvdG8gKigmJnNraXBfaWRfZ2V0dGVyX3Byb3RvKTsKICNlbmRpZgogICAgIERF RklORV9PUENPREUob3BfZ2V0X2J5X2lkX2dldHRlcl9wcm90bykgewpAQCAtMjUxNSwxMCArMjUx NywxMCBAQCBKU1ZhbHVlIEludGVycHJldGVyOjpwcml2YXRlRXhlY3V0ZShFeGVjdXRpb25GbGFn IGZsYWcsIFJlZ2lzdGVyRmlsZSogcmVnaXN0ZXJGaQogICAgICAgICB1bmNhY2hlR2V0QnlJRChj b2RlQmxvY2ssIHZQQyk7CiAgICAgICAgIE5FWFRfSU5TVFJVQ1RJT04oKTsKICAgICB9Ci0jaWYg RU5BQkxFKENPTVBVVEVEX0dPVE9fSU5URVJQUkVURVIpCisjaWYgVVNFKEdDQ19DT01QVVRFRF9H T1RPX1dPUktBUk9VTkQpCiAgICAgc2tpcF9pZF9nZXR0ZXJfcHJvdG86CiAjZW5kaWYKLSNpZiBF TkFCTEUoQ09NUFVURURfR09UT19JTlRFUlBSRVRFUikKKyNpZiBVU0UoR0NDX0NPTVBVVEVEX0dP VE9fV09SS0FST1VORCkKICAgICBnb3RvICooJiZza2lwX2lkX2N1c3RvbV9wcm90byk7CiAjZW5k aWYKICAgICBERUZJTkVfT1BDT0RFKG9wX2dldF9ieV9pZF9jdXN0b21fcHJvdG8pIHsKQEAgLTI1 NTcsNyArMjU1OSw3IEBAIEpTVmFsdWUgSW50ZXJwcmV0ZXI6OnByaXZhdGVFeGVjdXRlKEV4ZWN1 dGlvbkZsYWcgZmxhZywgUmVnaXN0ZXJGaWxlKiByZWdpc3RlckZpCiAgICAgICAgIHVuY2FjaGVH ZXRCeUlEKGNvZGVCbG9jaywgdlBDKTsKICAgICAgICAgTkVYVF9JTlNUUlVDVElPTigpOwogICAg IH0KLSNpZiBFTkFCTEUoQ09NUFVURURfR09UT19JTlRFUlBSRVRFUikKKyNpZiBVU0UoR0NDX0NP TVBVVEVEX0dPVE9fV09SS0FST1VORCkKICAgICBza2lwX2lkX2N1c3RvbV9wcm90bzoKICNlbmRp ZgogICAgIERFRklORV9PUENPREUob3BfZ2V0X2J5X2lkX3NlbGZfbGlzdCkgewpAQCAtMjY0OCw3 ICsyNjUwLDcgQEAgSlNWYWx1ZSBJbnRlcnByZXRlcjo6cHJpdmF0ZUV4ZWN1dGUoRXhlY3V0aW9u RmxhZyBmbGFnLCBSZWdpc3RlckZpbGUqIHJlZ2lzdGVyRmkKICAgICAgICAgdW5jYWNoZUdldEJ5 SUQoY29kZUJsb2NrLCB2UEMpOwogICAgICAgICBORVhUX0lOU1RSVUNUSU9OKCk7CiAgICAgfQot I2lmIEVOQUJMRShDT01QVVRFRF9HT1RPX0lOVEVSUFJFVEVSKQorI2lmIFVTRShHQ0NfQ09NUFVU RURfR09UT19XT1JLQVJPVU5EKQogICAgIGdvdG8gKigmJnNraXBfaWRfZ2V0dGVyX3NlbGYpOwog I2VuZGlmCiAgICAgREVGSU5FX09QQ09ERShvcF9nZXRfYnlfaWRfZ2V0dGVyX3NlbGYpIHsKQEAg LTI2ODgsMTAgKzI2OTAsMTAgQEAgSlNWYWx1ZSBJbnRlcnByZXRlcjo6cHJpdmF0ZUV4ZWN1dGUo RXhlY3V0aW9uRmxhZyBmbGFnLCBSZWdpc3RlckZpbGUqIHJlZ2lzdGVyRmkKICAgICAgICAgdW5j YWNoZUdldEJ5SUQoY29kZUJsb2NrLCB2UEMpOwogICAgICAgICBORVhUX0lOU1RSVUNUSU9OKCk7 CiAgICAgfQotI2lmIEVOQUJMRShDT01QVVRFRF9HT1RPX0lOVEVSUFJFVEVSKQorI2lmIFVTRShH Q0NfQ09NUFVURURfR09UT19XT1JLQVJPVU5EKQogICAgIHNraXBfaWRfZ2V0dGVyX3NlbGY6CiAj ZW5kaWYKLSNpZiBFTkFCTEUoQ09NUFVURURfR09UT19JTlRFUlBSRVRFUikKKyNpZiBVU0UoR0ND X0NPTVBVVEVEX0dPVE9fV09SS0FST1VORCkKICAgICBnb3RvICooJiZza2lwX2lkX2N1c3RvbV9z ZWxmKTsKICNlbmRpZgogICAgIERFRklORV9PUENPREUob3BfZ2V0X2J5X2lkX2N1c3RvbV9zZWxm KSB7CkBAIC0yNzI1LDcgKzI3MjcsNyBAQCBKU1ZhbHVlIEludGVycHJldGVyOjpwcml2YXRlRXhl Y3V0ZShFeGVjdXRpb25GbGFnIGZsYWcsIFJlZ2lzdGVyRmlsZSogcmVnaXN0ZXJGaQogICAgICAg ICB1bmNhY2hlR2V0QnlJRChjb2RlQmxvY2ssIHZQQyk7CiAgICAgICAgIE5FWFRfSU5TVFJVQ1RJ T04oKTsKICAgICB9Ci0jaWYgRU5BQkxFKENPTVBVVEVEX0dPVE9fSU5URVJQUkVURVIpCisjaWYg VVNFKEdDQ19DT01QVVRFRF9HT1RPX1dPUktBUk9VTkQpCiBza2lwX2lkX2N1c3RvbV9zZWxmOgog I2VuZGlmCiAgICAgREVGSU5FX09QQ09ERShvcF9nZXRfYnlfaWRfZ2VuZXJpYykgewpAQCAtMjc0 OCw3ICsyNzUwLDcgQEAgc2tpcF9pZF9jdXN0b21fc2VsZjoKICAgICAgICAgdlBDICs9IE9QQ09E RV9MRU5HVEgob3BfZ2V0X2J5X2lkX2dlbmVyaWMpOwogICAgICAgICBORVhUX0lOU1RSVUNUSU9O KCk7CiAgICAgfQotI2lmIEVOQUJMRShDT01QVVRFRF9HT1RPX0lOVEVSUFJFVEVSKQorI2lmIFVT RShHQ0NfQ09NUFVURURfR09UT19XT1JLQVJPVU5EKQogICAgIGdvdG8gKigmJnNraXBfaWRfZ2V0 dGVyX2NoYWluKTsKICNlbmRpZgogICAgIERFRklORV9PUENPREUob3BfZ2V0X2J5X2lkX2dldHRl cl9jaGFpbikgewpAQCAtMjgwMCwxMCArMjgwMiwxMCBAQCBza2lwX2lkX2N1c3RvbV9zZWxmOgog ICAgICAgICB1bmNhY2hlR2V0QnlJRChjb2RlQmxvY2ssIHZQQyk7CiAgICAgICAgIE5FWFRfSU5T VFJVQ1RJT04oKTsKICAgICB9Ci0jaWYgRU5BQkxFKENPTVBVVEVEX0dPVE9fSU5URVJQUkVURVIp CisjaWYgVVNFKEdDQ19DT01QVVRFRF9HT1RPX1dPUktBUk9VTkQpCiAgICAgc2tpcF9pZF9nZXR0 ZXJfY2hhaW46CiAjZW5kaWYKLSNpZiBFTkFCTEUoQ09NUFVURURfR09UT19JTlRFUlBSRVRFUikK KyNpZiBVU0UoR0NDX0NPTVBVVEVEX0dPVE9fV09SS0FST1VORCkKICAgICBnb3RvICooJiZza2lw X2lkX2N1c3RvbV9jaGFpbik7CiAjZW5kaWYKICAgICBERUZJTkVfT1BDT0RFKG9wX2dldF9ieV9p ZF9jdXN0b21fY2hhaW4pIHsKQEAgLTI4NTIsNyArMjg1NCw3IEBAIHNraXBfaWRfY3VzdG9tX3Nl bGY6CiAgICAgICAgIHVuY2FjaGVHZXRCeUlEKGNvZGVCbG9jaywgdlBDKTsKICAgICAgICAgTkVY VF9JTlNUUlVDVElPTigpOwogICAgIH0KLSNpZiBFTkFCTEUoQ09NUFVURURfR09UT19JTlRFUlBS RVRFUikKKyNpZiBVU0UoR0NDX0NPTVBVVEVEX0dPVE9fV09SS0FST1VORCkKICAgICBza2lwX2lk X2N1c3RvbV9jaGFpbjoKICNlbmRpZgogICAgIERFRklORV9PUENPREUob3BfZ2V0X2FycmF5X2xl bmd0aCkgewo=