46406 2010-09-23 14:18:55 -0700 Fix a condition check in ServerProcess, which becomes relevant when reading binary data. 2010-09-23 14:50:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov abarth dpranke levin tony oldest_to_newest 283941 0 dglazkov 2010-09-23 14:18:55 -0700 Fix a condition check in ServerProcess, which becomes relevant when reading binary data. 283946 1 68588 dglazkov 2010-09-23 14:23:24 -0700 Created attachment 68588 Patch 283950 2 levin 2010-09-23 14:26:51 -0700 Is a test possible? 283964 3 dpranke 2010-09-23 14:37:52 -0700 not easily. this is embedded pretty close to some code reading directly off of sockets, and there's no easy way to mock it at the moment. I need to revamp this code in the next few days and I will be adding a lot more unit testing at that point. I stepped through this with dglazkov, and the bug is real and the fix is the right one. 283978 4 68588 dglazkov 2010-09-23 14:50:16 -0700 Comment on attachment 68588 Patch Clearing flags on attachment: 68588 Committed r68201: <http://trac.webkit.org/changeset/68201> 283979 5 dglazkov 2010-09-23 14:50:22 -0700 All reviewed patches have been landed. Closing bug. 68588 2010-09-23 14:23:24 -0700 2010-09-23 14:50:16 -0700 Patch bug-46406-20100923142322.patch text/plain 1602 dglazkov ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmMTE0M2I4YjQ0M2RkYzQ2NjgxYTA5MzM3MGRkNWRlZmM3YTc2M2I1Li4zYjhhYjQy MmVkMWFiYTczZjEwY2VjMzA4ZGJhM2ZkMTQ4NzYyMDY5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMDktMjMgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYSBjb25k aXRpb24gY2hlY2sgaW4gU2VydmVyUHJvY2Vzcywgd2hpY2ggYmVjb21lcyByZWxldmFudCB3aGVu IHJlYWRpbmcgYmluYXJ5IGRhdGEuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00NjQwNgorCisgICAgICAgIFRoaXMgYnJlYWtzIHdoZW4gdGhlIG1ldGhv ZCBpcyBjYWxsZWQgd2l0aCBzcGVjaWZpZWQgc2l6ZSBvZiBkYXRhIChpbWFnZSBkYXRhKSwgYW5k IHRoZQorICAgICAgICBidWZmZXIgaGFzbid0IHlldCByZWFjaGVkIHRoaXMgc2l6ZS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvc2VydmVyX3Byb2Nlc3Mu cHk6IENoYW5nZWQgdG8gY2hlY2sgZm9yIHZhbHVlcyBvZgorICAgICAgICAgIGluZGV4IGxhcmdl ciB0aGFuIDAuCisKIDIwMTAtMDktMjEgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3NlcnZlcl9w cm9jZXNzLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC9zZXJ2ZXJfcHJvY2Vzcy5weQppbmRleCA4ZTBiYzExNWU0NjEwMzRmMmE4OTRjNWRkNjEyM2Nl NmQ1MTg2YmNjLi41YTBhNDBjZTY5MGZlNTM2OTYwMDE5YTQzY2NiYWM2YTQ5MzQyZTc5IDEwMDY0 NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3Nl cnZlcl9wcm9jZXNzLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvc2VydmVyX3Byb2Nlc3MucHkKQEAgLTE3OSw3ICsxNzksNyBAQCBjbGFzcyBT ZXJ2ZXJQcm9jZXNzOgogICAgICAgICAgICAgZWxpZiBzaXplID09IDA6CiAgICAgICAgICAgICAg ICAgaW5kZXggPSBzZWxmLl9vdXRwdXQuZmluZCgnXG4nKSArIDEKIAotICAgICAgICAgICAgaWYg aW5kZXggb3Igc2VsZi5jcmFzaGVkIG9yIHNlbGYudGltZWRfb3V0OgorICAgICAgICAgICAgaWYg aW5kZXggPiAwIG9yIHNlbGYuY3Jhc2hlZCBvciBzZWxmLnRpbWVkX291dDoKICAgICAgICAgICAg ICAgICBvdXRwdXQgPSBzZWxmLl9vdXRwdXRbMDppbmRleF0KICAgICAgICAgICAgICAgICBzZWxm Ll9vdXRwdXQgPSBzZWxmLl9vdXRwdXRbaW5kZXg6XQogICAgICAgICAgICAgICAgIHJldHVybiBv dXRwdXQK