46404 2010-09-23 14:06:08 -0700 Excessive Overhead in RegExp Entry Code 2010-09-23 15:23:38 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 msaboff msaboff commit-queue oldest_to_newest 283933 0 msaboff 2010-09-23 14:06:08 -0700 Profiling shows the result vector initialization in RegExpObject::match, etc., to be 13.5% of the v8 regexp benchmark. 283940 1 68586 msaboff 2010-09-23 14:17:47 -0700 Created attachment 68586 Patch that eliminates extraneous initialization of regexp results vector 283972 2 68586 ggaren 2010-09-23 14:40:41 -0700 Comment on attachment 68586 Patch that eliminates extraneous initialization of regexp results vector r=me 284024 3 68586 commit-queue 2010-09-23 15:23:33 -0700 Comment on attachment 68586 Patch that eliminates extraneous initialization of regexp results vector Clearing flags on attachment: 68586 Committed r68207: <http://trac.webkit.org/changeset/68207> 284025 4 commit-queue 2010-09-23 15:23:38 -0700 All reviewed patches have been landed. Closing bug. 68586 2010-09-23 14:17:47 -0700 2010-09-23 15:23:33 -0700 Patch that eliminates extraneous initialization of regexp results vector 46404.patch text/plain 3113 msaboff SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY4MTk1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDktMjMgIE1pY2hhZWwg U2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlZCBleHRyYW5lb3VzIHRydW5jYXRpb24gb2Ygb3Zl Y3RvciBvbiBlbnRyeSBhbmQgZXJyb3IgZXhpdC4KKyAgICAgICAgQ2hhbmdlZCB0aGUgaW5pdGlh bGl6YXRpb24gdG8gLTEgb2YgdmVjdG9yIHRvIG9ubHkgaW5pdGlhbGl6ZQorICAgICAgICB0aGUg c3RhcnQgaW5kZWNpZXMsIHdoaWNoIGlzIHN1ZmZpY2llbnQgZm9yIHRoZSBwYXR0ZXJuL3N1YnBh dHRlcm5zLgorICAgICAgICBDaGFuZ2VkIHRoZSBKSVQgY29kZSB0byBub3QgY2xlYXIgdGhlIGVu ZCBpbmRleCBmb3Igc3VicGF0dGVybnMKKyAgICAgICAgYXMgaXQgaXNuJ3QgbmVlZGVkLiAgVGhl c2UgY2hhbmdlcyBhcmUgd29ydGggfjIuNyUgb24gdjgtcmVnZXhwLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY0MDQKKworICAgICAgICAqIHJ1bnRp bWUvUmVnRXhwLmNwcDoKKyAgICAgICAgKEpTQzo6UmVnRXhwOjptYXRjaCk6CisgICAgICAgICog eWFyci9SZWdleEpJVC5jcHA6CisgICAgICAgIChKU0M6OllhcnI6OlJlZ2V4R2VuZXJhdG9yOjpn ZW5lcmF0ZVBhcmVudGhlc2VzU2luZ2xlKToKKwogMjAxMC0wOS0yMiAgT2xpdmVyIEh1bnQgIDxv bGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmIEdhcmVuLgpJbmRl eDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHAuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFT Y3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwLmNwcAkocmV2aXNpb24gNjgwOTkpCisrKyBKYXZhU2Ny aXB0Q29yZS9ydW50aW1lL1JlZ0V4cC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExNSw4ICsxMTUs NiBAQCBpbnQgUmVnRXhwOjptYXRjaChjb25zdCBVU3RyaW5nJiBzLCBpbnQgCiB7CiAgICAgaWYg KHN0YXJ0T2Zmc2V0IDwgMCkKICAgICAgICAgc3RhcnRPZmZzZXQgPSAwOwotICAgIGlmIChvdmVj dG9yKQotICAgICAgICBvdmVjdG9yLT5yZXNpemUoMCk7CiAgICAgCiAjaWYgRU5BQkxFKFJFR0VY UF9UUkFDSU5HKQogICAgIG1fcnRNYXRjaENhbGxDb3VudCsrOwpAQCAtMTQyLDcgKzE0MCwxMCBA QCBpbnQgUmVnRXhwOjptYXRjaChjb25zdCBVU3RyaW5nJiBzLCBpbnQgCiAgICAgICAgIH0KIAog ICAgICAgICBBU1NFUlQob2Zmc2V0VmVjdG9yKTsKLSAgICAgICAgZm9yIChpbnQgaiA9IDA7IGog PCBvZmZzZXRWZWN0b3JTaXplOyArK2opCisgICAgICAgIC8vIEluaXRpYWxpemUgb2Zmc2V0VmVj dG9yIHdpdGggdGhlIHJldHVybiB2YWx1ZSAoaW5kZXggMCkgYW5kIHRoZSAKKyAgICAgICAgLy8g Zmlyc3Qgc3VicGF0dGVybiBzdGFydCBpbmRpY2llcyAoZXZlbiBpbmRleCB2YWx1ZXMpIHNldCB0 byAtMS4KKyAgICAgICAgLy8gTm8gbmVlZCB0byBpbml0IHRoZSBzdWJwYXR0ZXJuIGVuZCBpbmRp Y2llcy4KKyAgICAgICAgZm9yICh1bnNpZ25lZCBqID0gMCwgaSA9IDA7IGkgPCBtX251bVN1YnBh dHRlcm5zICsgMTsgaiArPSAyLCBpKyspICAgICAgICAgICAgCiAgICAgICAgICAgICBvZmZzZXRW ZWN0b3Jbal0gPSAtMTsKIAogI2lmIEVOQUJMRShZQVJSX0pJVCkKQEAgLTE1Nyw4ICsxNTgsNiBA QCBpbnQgUmVnRXhwOjptYXRjaChjb25zdCBVU3RyaW5nJiBzLCBpbnQgCiAgICAgICAgICAgICBp ZiAocmVzdWx0ICE9IC0xKQogICAgICAgICAgICAgICAgIGZwcmludGYoc3RkZXJyLCAianNSZWdF eHBFeGVjdXRlIGZhaWxlZCB3aXRoIHJlc3VsdCAlZFxuIiwgcmVzdWx0KTsKICNlbmRpZgotICAg ICAgICAgICAgaWYgKG92ZWN0b3IpCi0gICAgICAgICAgICAgICAgb3ZlY3Rvci0+Y2xlYXIoKTsK ICAgICAgICAgfQogICAgICAgICAKICNpZiBFTkFCTEUoUkVHRVhQX1RSQUNJTkcpCkluZGV4OiBK YXZhU2NyaXB0Q29yZS95YXJyL1JlZ2V4SklULmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS95YXJyL1JlZ2V4SklULmNwcAkocmV2aXNpb24gNjgwOTkpCisrKyBKYXZhU2NyaXB0Q29y ZS95YXJyL1JlZ2V4SklULmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTg2LDEwICs5ODYsOCBAQCBj bGFzcyBSZWdleEdlbmVyYXRvciA6IHByaXZhdGUgTWFjcm9Bc3NlCiAgICAgICAgICAgICBwYXJl bnRoZXNlc1N0YXRlLnBsYW50SnVtcFRvQmFja3RyYWNrSWZFeGlzdHModGhpcyk7CiAgICAgICAg ICAgICAvLyBBIGZhaWx1cmUgV0lUSElOIHRoZSBwYXJlbnMganVtcHMgaGVyZQogICAgICAgICAg ICAgcGFyZW50aGVzZXNTdGF0ZS5saW5rQWx0ZXJuYXRpdmVCYWNrdHJhY2tzKHRoaXMpOwotICAg ICAgICAgICAgaWYgKHRlcm0uaW52ZXJ0T3JDYXB0dXJlKSB7CisgICAgICAgICAgICBpZiAodGVy bS5pbnZlcnRPckNhcHR1cmUpCiAgICAgICAgICAgICAgICAgc3RvcmUzMihJbW0zMigtMSksIEFk ZHJlc3Mob3V0cHV0LCAodGVybS5wYXJlbnRoZXNlcy5zdWJwYXR0ZXJuSWQgPDwgMSkgKiBzaXpl b2YoaW50KSkpOwotICAgICAgICAgICAgICAgIHN0b3JlMzIoSW1tMzIoLTEpLCBBZGRyZXNzKG91 dHB1dCwgKCh0ZXJtLnBhcmVudGhlc2VzLnN1YnBhdHRlcm5JZCA8PCAxKSArIDEpICogc2l6ZW9m KGludCkpKTsKLSAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgaWYgKHRlcm0ucXVhbnRpdHlU eXBlID09IFF1YW50aWZpZXJHcmVlZHkpCiAgICAgICAgICAgICAgICAgc3RvcmVUb0ZyYW1lKElt bTMyKDApLCBwYXJlbnRoZXNlc0ZyYW1lTG9jYXRpb24pOwo=