46402 2010-09-23 13:24:45 -0700 [Qt] QWebHapticFeedbackPlayer needs correct exposure through QWebKitPlatformPlugin 2010-09-23 15:16:34 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt P2 Normal --- 46345 1 ademar webkit-unassigned commit-queue oldest_to_newest 283905 0 ademar 2010-09-23 13:24:45 -0700 QWebHapticFeedbackPlayer is exported through QWebKitPlatformPlugin::createExtension(), which returns QObject *. (WebKit/qt/Api/qwebkitplatformplugin.h) Haptics support is limited in trunk. I'm not sure if we should remove or fix this code. (nevertheless, it's needed on the qtwebit-2.1 branch) Patch is on the way 283911 1 68580 ademar 2010-09-23 13:32:18 -0700 Created attachment 68580 patch 283948 2 ademar 2010-09-23 14:25:29 -0700 Changing the title of the bug because there are other fixes necessary. The patch will be updated as well. 283954 3 68591 ademar 2010-09-23 14:32:54 -0700 Created attachment 68591 patch #2 284000 4 68591 commit-queue 2010-09-23 15:09:00 -0700 Comment on attachment 68591 patch #2 Clearing flags on attachment: 68591 Committed r68204: <http://trac.webkit.org/changeset/68204> 284001 5 commit-queue 2010-09-23 15:09:05 -0700 All reviewed patches have been landed. Closing bug. 284013 6 ademar 2010-09-23 15:16:34 -0700 Revision r68204 cherry-picked into qtwebkit-2.1 with commit 005c88d <http://gitorious.org/webkit/qtwebkit/commit/005c88d> 68580 2010-09-23 13:32:18 -0700 2010-09-23 14:32:54 -0700 patch 0001-Make-QWebHapticFeedbackPlayer-inherit-QObject.patch text/plain 1760 ademar RnJvbSBjZmI0OTYxOWVmNWE5MmQzOGU0YjBiNzQ1MTRkOTg3OWFkYmRlODQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVtYXIgZGUgU291emEgUmVpcyBKciA8YWRlbWFyLnJlaXNA b3BlbmJvc3NhLm9yZz4KRGF0ZTogVGh1LCAyMyBTZXAgMjAxMCAxNzoyNDoxMCAtMDMwMApTdWJq ZWN0OiBbUEFUQ0hdIE1ha2UgUVdlYkhhcHRpY0ZlZWRiYWNrUGxheWVyIGluaGVyaXQgUU9iamVj dAoKW1F0XSBRV2ViSGFwdGljRmVlZGJhY2tQbGF5ZXIgbmVlZHMgdG8gaW5oZXJpdCBRT2JqZWN0 Cmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjQwMgotLS0KIFdlYktp dC9xdC9BcGkvcXdlYmtpdHBsYXRmb3JtcGx1Z2luLmggfCAgICA2ICsrKysrLQogV2ViS2l0L3F0 L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIDIgZmls ZXMgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9XZWJLaXQvcXQvQXBpL3F3ZWJraXRwbGF0Zm9ybXBsdWdpbi5oIGIvV2ViS2l0L3F0L0FwaS9x d2Via2l0cGxhdGZvcm1wbHVnaW4uaAppbmRleCBmYWE2OTg5Li5hODUxZDU2IDEwMDY0NAotLS0g YS9XZWJLaXQvcXQvQXBpL3F3ZWJraXRwbGF0Zm9ybXBsdWdpbi5oCisrKyBiL1dlYktpdC9xdC9B cGkvcXdlYmtpdHBsYXRmb3JtcGx1Z2luLmgKQEAgLTg0LDkgKzg0LDEzIEBAIFFfU0lHTkFMUzoK ICAgICB2b2lkIG5vdGlmaWNhdGlvbkNsaWNrZWQoKTsKIH07CiAKLWNsYXNzIFFXZWJIYXB0aWNG ZWVkYmFja1BsYXllcgorY2xhc3MgUVdlYkhhcHRpY0ZlZWRiYWNrUGxheWVyOiBwdWJsaWMgUU9i amVjdAogeworICAgIFFfT0JKRUNUCiBwdWJsaWM6CisgICAgUVdlYkhhcHRpY0ZlZWRiYWNrUGxh eWVyKCkge30KKyAgICB2aXJ0dWFsIH5RV2ViSGFwdGljRmVlZGJhY2tQbGF5ZXIoKSB7fQorCiAg ICAgZW51bSBIYXB0aWNTdHJlbmd0aCB7CiAgICAgICAgIE5vbmUsIFdlYWssIE1lZGl1bSwgU3Ry b25nCiAgICAgfTsKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQv Q2hhbmdlTG9nCmluZGV4IDA2YWExZTQuLmQ3YjQ5ZTQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEw LTA5LTIzICBBZGVtYXIgZGUgU291emEgUmVpcyBKciAgPGFkZW1hci5yZWlzQG9wZW5ib3NzYS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFr ZSBRV2ViSGFwdGljRmVlZGJhY2tQbGF5ZXIgaW5oZXJpdCBRT2JqZWN0CisKKyAgICAgICAgW1F0 XSBRV2ViSGFwdGljRmVlZGJhY2tQbGF5ZXIgbmVlZHMgdG8gaW5oZXJpdCBRT2JqZWN0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjQwMgorCisgICAg ICAgIFFXZWJIYXB0aWNGZWVkYmFja1BsYXllciBpcyBleHBvcnRlZCB0aHJvdWdoCisgICAgICAg IFFXZWJLaXRQbGF0Zm9ybVBsdWdpbjo6Y3JlYXRlRXh0ZW5zaW9uKCksIHdoaWNoIHJldHVybnMg UU9iamVjdCoKKworICAgICAgICAqIEFwaS9xd2Via2l0cGxhdGZvcm1wbHVnaW4uaDoKKwogMjAx MC0wOS0yMyAgVG9yIEFybmUgVmVzdGLDuCAgPHRvci5hcm5lLnZlc3Rib0Bub2tpYS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCi0tIAoxLjcuMi4zCgo= 68591 2010-09-23 14:32:54 -0700 2010-09-23 15:09:00 -0700 patch #2 0001-Fix-QWebHapticFeedbackPlayer-exposure-via-QWebKitPla.patch text/plain 3745 ademar RnJvbSA1YzUzYjQ4Yzk5YWZlODA2MWRhMDU5YTdkZjkxMWNjNDUzMTY0NDRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVtYXIgZGUgU291emEgUmVpcyBKciA8YWRlbWFyLnJlaXNA b3BlbmJvc3NhLm9yZz4KRGF0ZTogVGh1LCAyMyBTZXAgMjAxMCAxNzoyNDoxMCAtMDMwMApTdWJq ZWN0OiBbUEFUQ0hdIEZpeCBRV2ViSGFwdGljRmVlZGJhY2tQbGF5ZXIgZXhwb3N1cmUgdmlhIFFX ZWJLaXRQbGF0Zm9ybVBsdWdpbgoKW1F0XSBRV2ViSGFwdGljRmVlZGJhY2tQbGF5ZXIgbmVlZHMg Y29ycmVjdCBleHBvc3VyZSB0aHJvdWdoIFFXZWJLaXRQbGF0Zm9ybVBsdWdpbgpodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY0MDIKClFXZWJIYXB0aWNGZWVkYmFja1Bs YXllciBpcyBleHBvcnRlZCB0aHJvdWdoClFXZWJLaXRQbGF0Zm9ybVBsdWdpbjo6Y3JlYXRlRXh0 ZW5zaW9uKCksIGJ1dApjcmVhdGVIYXB0aWNGZWVkYmFja1BsYXllcigpIGFuZCB0aGUgY29ycmVj dAppbmhlcml0YWdlIGFyZSBtaXNzaW5nLgotLS0KIFdlYktpdC9xdC9BcGkvcXdlYmtpdHBsYXRm b3JtcGx1Z2luLmggICAgICAgICB8ICAgIDYgKysrKystCiBXZWJLaXQvcXQvQ2hhbmdlTG9nICAg ICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE5ICsrKysrKysrKysrKysrKysrKysKIFdlYktp dC9xdC9XZWJDb3JlU3VwcG9ydC9RdFBsYXRmb3JtUGx1Z2luLmNwcCB8ICAgIDYgKysrKysrCiBX ZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUXRQbGF0Zm9ybVBsdWdpbi5oICAgfCAgICAyICsrCiA0 IGZpbGVzIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvV2ViS2l0L3F0L0FwaS9xd2Via2l0cGxhdGZvcm1wbHVnaW4uaCBiL1dlYktpdC9xdC9B cGkvcXdlYmtpdHBsYXRmb3JtcGx1Z2luLmgKaW5kZXggZmFhNjk4OS4uYTg1MWQ1NiAxMDA2NDQK LS0tIGEvV2ViS2l0L3F0L0FwaS9xd2Via2l0cGxhdGZvcm1wbHVnaW4uaAorKysgYi9XZWJLaXQv cXQvQXBpL3F3ZWJraXRwbGF0Zm9ybXBsdWdpbi5oCkBAIC04NCw5ICs4NCwxMyBAQCBRX1NJR05B TFM6CiAgICAgdm9pZCBub3RpZmljYXRpb25DbGlja2VkKCk7CiB9OwogCi1jbGFzcyBRV2ViSGFw dGljRmVlZGJhY2tQbGF5ZXIKK2NsYXNzIFFXZWJIYXB0aWNGZWVkYmFja1BsYXllcjogcHVibGlj IFFPYmplY3QKIHsKKyAgICBRX09CSkVDVAogcHVibGljOgorICAgIFFXZWJIYXB0aWNGZWVkYmFj a1BsYXllcigpIHt9CisgICAgdmlydHVhbCB+UVdlYkhhcHRpY0ZlZWRiYWNrUGxheWVyKCkge30K KwogICAgIGVudW0gSGFwdGljU3RyZW5ndGggewogICAgICAgICBOb25lLCBXZWFrLCBNZWRpdW0s IFN0cm9uZwogICAgIH07CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvV2ViS2l0 L3F0L0NoYW5nZUxvZwppbmRleCAwNmFhMWU0Li4wYTBiZjIxIDEwMDY0NAotLS0gYS9XZWJLaXQv cXQvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAor MjAxMC0wOS0yMyAgQWRlbWFyIGRlIFNvdXphIFJlaXMgSnIgIDxhZGVtYXIucmVpc0BvcGVuYm9z c2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEZpeCBRV2ViSGFwdGljRmVlZGJhY2tQbGF5ZXIgZXhwb3N1cmUgdmlhIFFXZWJLaXRQbGF0Zm9y bVBsdWdpbgorCisgICAgICAgIFtRdF0gUVdlYkhhcHRpY0ZlZWRiYWNrUGxheWVyIG5lZWRzIGNv cnJlY3QgZXhwb3N1cmUgdGhyb3VnaCBRV2ViS2l0UGxhdGZvcm1QbHVnaW4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2NDAyCisKKyAgICAgICAgUVdl YkhhcHRpY0ZlZWRiYWNrUGxheWVyIGlzIGV4cG9ydGVkIHRocm91Z2gKKyAgICAgICAgUVdlYktp dFBsYXRmb3JtUGx1Z2luOjpjcmVhdGVFeHRlbnNpb24oKSwgYnV0CisgICAgICAgIGNyZWF0ZUhh cHRpY0ZlZWRiYWNrUGxheWVyKCkgYW5kIHRoZSBjb3JyZWN0CisgICAgICAgIGluaGVyaXRhZ2Ug YXJlIG1pc3NpbmcuCisKKyAgICAgICAgKiBBcGkvcXdlYmtpdHBsYXRmb3JtcGx1Z2luLmg6Cisg ICAgICAgICogV2ViQ29yZVN1cHBvcnQvUXRQbGF0Zm9ybVBsdWdpbi5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpRdFBsYXRmb3JtUGx1Z2luOjpjcmVhdGVIYXB0aWNGZWVkYmFja1BsYXllcik6Cisg ICAgICAgICogV2ViQ29yZVN1cHBvcnQvUXRQbGF0Zm9ybVBsdWdpbi5oOgorCiAyMDEwLTA5LTIz ICBUb3IgQXJuZSBWZXN0YsO4ICA8dG9yLmFybmUudmVzdGJvQG5va2lhLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9XZWJD b3JlU3VwcG9ydC9RdFBsYXRmb3JtUGx1Z2luLmNwcCBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9y dC9RdFBsYXRmb3JtUGx1Z2luLmNwcAppbmRleCA2ZGQ5MWExLi4xZjkxZDhjIDEwMDY0NAotLS0g YS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUXRQbGF0Zm9ybVBsdWdpbi5jcHAKKysrIGIvV2Vi S2l0L3F0L1dlYkNvcmVTdXBwb3J0L1F0UGxhdGZvcm1QbHVnaW4uY3BwCkBAIC0xMDEsNCArMTAx LDEwIEBAIFFXZWJOb3RpZmljYXRpb25QcmVzZW50ZXIqIFF0UGxhdGZvcm1QbHVnaW46OmNyZWF0 ZU5vdGlmaWNhdGlvblByZXNlbnRlcigpCiAgICAgcmV0dXJuIHAgPyBxb2JqZWN0X2Nhc3Q8UVdl Yk5vdGlmaWNhdGlvblByZXNlbnRlcio+KHAtPmNyZWF0ZUV4dGVuc2lvbihRV2ViS2l0UGxhdGZv cm1QbHVnaW46Ok5vdGlmaWNhdGlvbnMpKSA6IDA7CiB9CiAKK1FXZWJIYXB0aWNGZWVkYmFja1Bs YXllciogUXRQbGF0Zm9ybVBsdWdpbjo6Y3JlYXRlSGFwdGljRmVlZGJhY2tQbGF5ZXIoKQorewor ICAgIFFXZWJLaXRQbGF0Zm9ybVBsdWdpbiogcCA9IHBsdWdpbigpOworICAgIHJldHVybiBwID8g cW9iamVjdF9jYXN0PFFXZWJIYXB0aWNGZWVkYmFja1BsYXllcio+KHAtPmNyZWF0ZUV4dGVuc2lv bihRV2ViS2l0UGxhdGZvcm1QbHVnaW46OkhhcHRpY3MpKSA6IDA7Cit9CisKIH0KZGlmZiAtLWdp dCBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9RdFBsYXRmb3JtUGx1Z2luLmggYi9XZWJLaXQv cXQvV2ViQ29yZVN1cHBvcnQvUXRQbGF0Zm9ybVBsdWdpbi5oCmluZGV4IDliZGFiNzUuLmEzZTUw YzIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9RdFBsYXRmb3JtUGx1Z2lu LmgKKysrIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1F0UGxhdGZvcm1QbHVnaW4uaApAQCAt MjYsNiArMjYsNyBAQAogY2xhc3MgUVdlYlNlbGVjdE1ldGhvZDsKIGNsYXNzIFFXZWJLaXRQbGF0 Zm9ybVBsdWdpbjsKIGNsYXNzIFFXZWJOb3RpZmljYXRpb25QcmVzZW50ZXI7CitjbGFzcyBRV2Vi SGFwdGljRmVlZGJhY2tQbGF5ZXI7CiBjbGFzcyBRV2ViU2VsZWN0RGF0YTsKIAogbmFtZXNwYWNl IFdlYkNvcmUgewpAQCAtMzcsNiArMzgsNyBAQCBwdWJsaWM6CiAKICAgICBRV2ViU2VsZWN0TWV0 aG9kKiBjcmVhdGVTZWxlY3RJbnB1dE1ldGhvZCgpOwogICAgIFFXZWJOb3RpZmljYXRpb25QcmVz ZW50ZXIqIGNyZWF0ZU5vdGlmaWNhdGlvblByZXNlbnRlcigpOworICAgIFFXZWJIYXB0aWNGZWVk YmFja1BsYXllciogY3JlYXRlSGFwdGljRmVlZGJhY2tQbGF5ZXIoKTsKIAogICAgIFFXZWJLaXRQ bGF0Zm9ybVBsdWdpbiogcGx1Z2luKCk7CiAKLS0gCjEuNy4yLjMKCg==