46368 2010-09-23 10:14:22 -0700 It should be possible to conditionally define an entire group of messages 2010-09-23 10:28:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 283729 0 andersca 2010-09-23 10:14:22 -0700 It should be possible to conditionally define an entire group of messages 283733 1 68539 andersca 2010-09-23 10:15:23 -0700 Created attachment 68539 Patch 283740 2 68539 aroben 2010-09-23 10:23:02 -0700 Comment on attachment 68539 Patch You should test that the condition makes it into the output files, too, not just that we parse it correctly. ReceiverImplementationTest already does some things like that. 283742 3 andersca 2010-09-23 10:28:01 -0700 Committed r68159: <http://trac.webkit.org/changeset/68159> 68539 2010-09-23 10:15:23 -0700 2010-09-23 10:23:02 -0700 Patch bug-46368-20100923101522.patch text/plain 5204 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg YzM4Y2ZkYzJlNzIzNTM1OTlhOWI3ZWY1YzExNzBjMWYwNGVjZWIzZS4uMTc3ZGNmZmRlM2MyMDVi NDQ3NTY1MTkwODQxNDE3ZjRhNjlmMzc5NSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOSBAQAogMjAxMC0wOS0yMyAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IHNob3VsZCBiZSBwb3NzaWJsZSB0byBjb25k aXRpb25hbGx5IGRlZmluZSBhbiBlbnRpcmUgZ3JvdXAgb2YgbWVzc2FnZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2MzY4CisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdDIvbWVzc2FnZXMucHk6CisgICAgICAgIENoZWNrIGZvciBhIGNvbmRpdGlv biB3aGVuIHBhcnNpbmcgdGhlICJtZXNzYWdlcyAtPiAiIHN0cmluZyBhbmQgc2V0IGl0IGFzIHRo ZQorICAgICAgICBtZXNzYWdlIHJlY2VpdmVyIGNvbmRpdGlvbi4KKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0Mi9tZXNzYWdlc191bml0dGVzdC5weToKKyAgICAgICAgQWRkIHRlc3QuCisKKzIw MTAtMDktMjMgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAg ICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgogCiAgICAgICAgIE1lc3NhZ2UgYXV0b2dlbmVyYXRp b24gc2NyaXB0IHNob3VsZCBwYXJzZSBzeW5jIG1lc3NhZ2Ugc3ludGF4CmRpZmYgLS1naXQgYS9X ZWJLaXQyL1NjcmlwdHMvd2Via2l0Mi9tZXNzYWdlcy5weSBiL1dlYktpdDIvU2NyaXB0cy93ZWJr aXQyL21lc3NhZ2VzLnB5CmluZGV4IGFiM2YzODk5ZWEyNjJiZmU2OThhMzllYjE2OGM0ZDc4NTQy MTQ5MzQuLjU1OGU3MDJmNDJlODAwNmVmYjVjOWM2YjIzZjVhMTNmYjJlNWQ5ZGEgMTAwNjQ0Ci0t LSBhL1dlYktpdDIvU2NyaXB0cy93ZWJraXQyL21lc3NhZ2VzLnB5CisrKyBiL1dlYktpdDIvU2Ny aXB0cy93ZWJraXQyL21lc3NhZ2VzLnB5CkBAIC01MCw5ICs1MCwxMCBAQCBfbGljZW5zZV9oZWFk ZXIgPSAiIiIvKgogIiIiCiAKIGNsYXNzIE1lc3NhZ2VSZWNlaXZlcihvYmplY3QpOgotICAgIGRl ZiBfX2luaXRfXyhzZWxmLCBuYW1lLCBtZXNzYWdlcyk6CisgICAgZGVmIF9faW5pdF9fKHNlbGYs IG5hbWUsIG1lc3NhZ2VzLCBjb25kaXRpb24pOgogICAgICAgICBzZWxmLm5hbWUgPSBuYW1lCiAg ICAgICAgIHNlbGYubWVzc2FnZXMgPSBtZXNzYWdlcworICAgICAgICBzZWxmLmNvbmRpdGlvbiA9 IGNvbmRpdGlvbgogCiAgICAgZGVmIGl0ZXJwYXJhbWV0ZXJzKHNlbGYpOgogICAgICAgICByZXR1 cm4gKHBhcmFtZXRlciBmb3IgbWVzc2FnZSBpbiBzZWxmLm1lc3NhZ2VzIGZvciBwYXJhbWV0ZXIg aW4gbWVzc2FnZS5wYXJhbWV0ZXJzKQpAQCAtNjIsOSArNjMsMTMgQEAgY2xhc3MgTWVzc2FnZVJl Y2VpdmVyKG9iamVjdCk6CiAgICAgICAgIGRlc3RpbmF0aW9uID0gTm9uZQogICAgICAgICBtZXNz YWdlcyA9IFtdCiAgICAgICAgIGNvbmRpdGlvbiA9IE5vbmUKKyAgICAgICAgbWFzdGVyX2NvbmRp dGlvbiA9IE5vbmUKICAgICAgICAgZm9yIGxpbmUgaW4gZmlsZToKICAgICAgICAgICAgIG1hdGNo ID0gcmUuc2VhcmNoKHInbWVzc2FnZXMgLT4gKFtBLVphLXpfMC05XSspIHsnLCBsaW5lKQogICAg ICAgICAgICAgaWYgbWF0Y2g6CisgICAgICAgICAgICAgICAgaWYgY29uZGl0aW9uOgorICAgICAg ICAgICAgICAgICAgICBtYXN0ZXJfY29uZGl0aW9uID0gY29uZGl0aW9uCisgICAgICAgICAgICAg ICAgICAgIGNvbmRpdGlvbiA9IE5vbmUKICAgICAgICAgICAgICAgICBkZXN0aW5hdGlvbiA9IG1h dGNoLmdyb3VwKDEpCiAgICAgICAgICAgICAgICAgY29udGludWUKICAgICAgICAgICAgIGlmIGxp bmUuc3RhcnRzd2l0aCgnIycpOgpAQCAtOTEsNyArOTYsNyBAQCBjbGFzcyBNZXNzYWdlUmVjZWl2 ZXIob2JqZWN0KToKICAgICAgICAgICAgICAgICAgICAgcmVwbHlfcGFyYW1ldGVycyA9IE5vbmUK IAogICAgICAgICAgICAgICAgIG1lc3NhZ2VzLmFwcGVuZChNZXNzYWdlKG5hbWUsIHBhcmFtZXRl cnMsIHJlcGx5X3BhcmFtZXRlcnMsIGRlbGF5ZWQsIGNvbmRpdGlvbikpCi0gICAgICAgIHJldHVy biBNZXNzYWdlUmVjZWl2ZXIoZGVzdGluYXRpb24sIG1lc3NhZ2VzKQorICAgICAgICByZXR1cm4g TWVzc2FnZVJlY2VpdmVyKGRlc3RpbmF0aW9uLCBtZXNzYWdlcywgbWFzdGVyX2NvbmRpdGlvbikK IAogCiBjbGFzcyBNZXNzYWdlKG9iamVjdCk6CkBAIC0yMzIsNiArMjM3LDkgQEAgZGVmIGdlbmVy YXRlX21lc3NhZ2VzX2hlYWRlcihmaWxlKToKICAgICByZXN1bHQuYXBwZW5kKCcjaWZuZGVmICVz XG4nICUgaGVhZGVyX2d1YXJkKQogICAgIHJlc3VsdC5hcHBlbmQoJyNkZWZpbmUgJXNcblxuJyAl IGhlYWRlcl9ndWFyZCkKIAorICAgIGlmIHJlY2VpdmVyLmNvbmRpdGlvbjoKKyAgICAgICAgcmVz dWx0LmFwcGVuZCgnI2lmICVzXG5cbicgJSByZWNlaXZlci5jb25kaXRpb24pCisKICAgICByZXN1 bHQgKz0gWycjaW5jbHVkZSAlc1xuJyAlIGhlYWRlciBmb3IgaGVhZGVyIGluIHNvcnRlZChoZWFk ZXJzKV0KICAgICByZXN1bHQuYXBwZW5kKCdcbicpCiAKQEAgLTI1MCw3ICsyNTgsMTEgQEAgZGVm IGdlbmVyYXRlX21lc3NhZ2VzX2hlYWRlcihmaWxlKToKICAgICByZXN1bHQuYXBwZW5kKCd9O1xu JykKICAgICByZXN1bHQuYXBwZW5kKCdcbn0gLy8gbmFtZXNwYWNlIENvcmVJUENcbicpCiAKKyAg ICBpZiByZWNlaXZlci5jb25kaXRpb246CisgICAgICAgIHJlc3VsdC5hcHBlbmQoJ1xuI2VuZGlm IC8vICVzXG4nICUgcmVjZWl2ZXIuY29uZGl0aW9uKQorCiAgICAgcmVzdWx0LmFwcGVuZCgnXG4j ZW5kaWYgLy8gJXNcbicgJSBoZWFkZXJfZ3VhcmQpCisKICAgICByZXR1cm4gJycuam9pbihyZXN1 bHQpCiAKIApAQCAtMzAxLDYgKzMxMyw5IEBAIGRlZiBnZW5lcmF0ZV9tZXNzYWdlX2hhbmRsZXIo ZmlsZSk6CiAgICAgcmVzdWx0LmFwcGVuZChfbGljZW5zZV9oZWFkZXIpCiAgICAgcmVzdWx0LmFw cGVuZCgnXG4nKQogCisgICAgaWYgcmVjZWl2ZXIuY29uZGl0aW9uOgorICAgICAgICByZXN1bHQu YXBwZW5kKCcjaWYgJXNcblxuJyAlIHJlY2VpdmVyLmNvbmRpdGlvbikKKwogICAgIHJlc3VsdC5h cHBlbmQoJyNpbmNsdWRlICIlcy5oIlxuXG4nICUgcmVjZWl2ZXIubmFtZSkKICAgICByZXN1bHQg Kz0gWycjaW5jbHVkZSAlc1xuJyAlIGhlYWRlciBmb3IgaGVhZGVyIGluIHNvcnRlZChoZWFkZXJz KV0KICAgICByZXN1bHQuYXBwZW5kKCdcbicpCkBAIC0zMTcsNCArMzMyLDcgQEAgZGVmIGdlbmVy YXRlX21lc3NhZ2VfaGFuZGxlcihmaWxlKToKIAogICAgIHJlc3VsdC5hcHBlbmQoJ1xufSAvLyBu YW1lc3BhY2UgV2ViS2l0XG4nKQogCisgICAgaWYgcmVjZWl2ZXIuY29uZGl0aW9uOgorICAgICAg ICByZXN1bHQuYXBwZW5kKCdcbiNlbmRpZiAvLyAlc1xuJyAlIHJlY2VpdmVyLmNvbmRpdGlvbikK KwogICAgIHJldHVybiAnJy5qb2luKHJlc3VsdCkKZGlmZiAtLWdpdCBhL1dlYktpdDIvU2NyaXB0 cy93ZWJraXQyL21lc3NhZ2VzX3VuaXR0ZXN0LnB5IGIvV2ViS2l0Mi9TY3JpcHRzL3dlYmtpdDIv bWVzc2FnZXNfdW5pdHRlc3QucHkKaW5kZXggMGRmZWE1MmFhOTNmNDY3ZTYxODE1NWRjZDYwOGVj YWQ4MDBmNDhjOC4uOGZjM2Q5MzM0MjUxMTg3ODFkNjJlYzM2ZDhiNmM3YjQ4MjczOTQ4NiAxMDA2 NDQKLS0tIGEvV2ViS2l0Mi9TY3JpcHRzL3dlYmtpdDIvbWVzc2FnZXNfdW5pdHRlc3QucHkKKysr IGIvV2ViS2l0Mi9TY3JpcHRzL3dlYmtpdDIvbWVzc2FnZXNfdW5pdHRlc3QucHkKQEAgLTQ3LDYg KzQ3LDggQEAgX21lc3NhZ2VzX2ZpbGVfY29udGVudHMgPSAiIiIjIENvcHlyaWdodCAoQykgMjAx MCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQKICMgT1IgVE9SVCAoSU5DTFVESU5HIE5F R0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UK ICMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBP RiBTVUNIIERBTUFHRS4KIAorI2lmIEVOQUJMRShXRUJLSVQyKQorCiBtZXNzYWdlcyAtPiBXZWJQ YWdlIHsKICAgICBMb2FkVVJMKFdURjo6U3RyaW5nIHVybCkKICNpZiBFTkFCTEUoVE9VQ0hfRVZF TlRTKQpAQCAtNjEsMTAgKzYzLDEzIEBAIG1lc3NhZ2VzIC0+IFdlYlBhZ2UgewogICAgIEdldFBs dWdpbnMoYm9vbCByZWZyZXNoKSAtPiAoVmVjdG9yPFdlYkNvcmU6OlBsdWdpbkluZm8+IHBsdWdp bnMpCiAgICAgR2V0UGx1Z2luUHJvY2Vzc0Nvbm5lY3Rpb24oV1RGOjpTdHJpbmcgcGx1Z2luUGF0 aCkgLT4gKENvcmVJUEM6OkNvbm5lY3Rpb246OkhhbmRsZSBjb25uZWN0aW9uSGFuZGxlKSBkZWxh eWVkCiB9CisKKyNlbmRpZgogIiIiCiAKIF9leHBlY3RlZF9yZXN1bHRzID0gewogICAgICduYW1l JzogJ1dlYlBhZ2UnLAorICAgICdjb25kaXRpb24nOiAnRU5BQkxFKFdFQktJVDIpJywKICAgICAn bWVzc2FnZXMnOiAoCiAgICAgICAgIHsKICAgICAgICAgICAgICduYW1lJzogJ0xvYWRVUkwnLApA QCAtMTY5LDYgKzE3NCw3IEBAIGNsYXNzIFBhcnNpbmdUZXN0KE1lc3NhZ2VzVGVzdCk6CiAgICAg ZGVmIHRlc3RfcmVjZWl2ZXIoc2VsZik6CiAgICAgICAgICIiIlJlY2VpdmVyIHNob3VsZCBiZSBw YXJzZWQgYXMgZXhwZWN0ZWQiIiIKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoc2VsZi5yZWNl aXZlci5uYW1lLCBfZXhwZWN0ZWRfcmVzdWx0c1snbmFtZSddKQorICAgICAgICBzZWxmLmFzc2Vy dEVxdWFscyhzZWxmLnJlY2VpdmVyLmNvbmRpdGlvbiwgX2V4cGVjdGVkX3Jlc3VsdHNbJ2NvbmRp dGlvbiddKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhsZW4oc2VsZi5yZWNlaXZlci5tZXNz YWdlcyksIGxlbihfZXhwZWN0ZWRfcmVzdWx0c1snbWVzc2FnZXMnXSkpCiAgICAgICAgIGZvciBp bmRleCwgbWVzc2FnZSBpbiBlbnVtZXJhdGUoc2VsZi5yZWNlaXZlci5tZXNzYWdlcyk6CiAgICAg ICAgICAgICBzZWxmLmNoZWNrX21lc3NhZ2UobWVzc2FnZSwgX2V4cGVjdGVkX3Jlc3VsdHNbJ21l c3NhZ2VzJ11baW5kZXhdKQo=