46364 2010-09-23 09:49:31 -0700 Add synchronous loading for network resources to ResourceHandleWin 2010-09-23 13:17:22 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 43712 1 paroga paroga abarth aroben commit-queue eric webkit.review.bot oldest_to_newest 283710 0 paroga 2010-09-23 09:49:31 -0700 see patch 283714 1 68534 paroga 2010-09-23 09:54:47 -0700 Created attachment 68534 Patch 283718 2 webkit.review.bot 2010-09-23 09:57:24 -0700 Attachment 68534 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/network/win/ResourceHandleWin.cpp:503: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 283768 3 68534 aroben 2010-09-23 10:43:02 -0700 Comment on attachment 68534 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68534&action=review > WebCore/platform/network/win/ResourceHandleWin.cpp:504 > + if (d->m_loadSynchronously) > + while (onRequestComplete()) { > + // Loop until finished. > + } > + I would have expected onRequestComplete to return false when the request is not complete, and true when it is complete. 283789 4 68534 commit-queue 2010-09-23 11:08:44 -0700 Comment on attachment 68534 Patch Clearing flags on attachment: 68534 Committed r68167: <http://trac.webkit.org/changeset/68167> 283790 5 commit-queue 2010-09-23 11:08:48 -0700 All reviewed patches have been landed. Closing bug. 283891 6 webkit.review.bot 2010-09-23 13:17:22 -0700 http://trac.webkit.org/changeset/68167 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/68163 http://trac.webkit.org/changeset/68164 http://trac.webkit.org/changeset/68165 http://trac.webkit.org/changeset/68166 http://trac.webkit.org/changeset/68167 http://trac.webkit.org/changeset/68168 http://trac.webkit.org/changeset/68169 68534 2010-09-23 09:54:47 -0700 2010-09-23 11:08:44 -0700 Patch bug-46364.patch text/plain 4000 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OGU4MWRlMy4uMWZlZTVjMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wOS0yMyAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgc3luY2hyb25vdXMgbG9hZGluZyBmb3IgbmV0d29yayBy ZXNvdXJjZXMgdG8gUmVzb3VyY2VIYW5kbGVXaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2MzY0CisKKyAgICAgICAgVXNlIHJldHVybiB2YWx1ZSBv ZiBvblJlcXVlc3RDb21wbGV0ZSgpIHRvIGluZGljYXRlIHRoYXQgYW4gYWRkaXRpb25hbAorICAg ICAgICBjYWxsIHRvIGl0IGlzIHJlcXVpcmVkIGZvciByZWNlaXZpbmcgcmVtYWluaW5nIG5ldHdv cmsgZGF0YS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VIYW5kbGUuaDoK KyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3dpbi9SZXNvdXJjZUhhbmRsZVdpbi5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6b25SZXF1ZXN0Q29tcGxldGUpOgorICAg ICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OnN0YXJ0KToKKwogMjAxMC0wOS0yMyAgTWFy aW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQ2hyaXMgRmxlaXphY2guCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvUmVzb3VyY2VIYW5kbGUuaCBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZUhh bmRsZS5oCmluZGV4IDdiMjg1NzAuLjYzNjFhN2EgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9SZXNvdXJjZUhhbmRsZS5oCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9SZXNvdXJjZUhhbmRsZS5oCkBAIC0xNzMsNyArMTczLDcgQEAgcHVibGljOgogICAgIHZvaWQg ZmlsZUxvYWRUaW1lcihUaW1lcjxSZXNvdXJjZUhhbmRsZT4qKTsKICAgICB2b2lkIG9uSGFuZGxl Q3JlYXRlZChMUEFSQU0pOwogICAgIHZvaWQgb25SZWRpcmVjdCgpOwotICAgIHZvaWQgb25SZXF1 ZXN0Q29tcGxldGUoTFBBUkFNKTsKKyAgICBib29sIG9uUmVxdWVzdENvbXBsZXRlKCk7CiAgICAg c3RhdGljIHZvaWQgQ0FMTEJBQ0sgaW50ZXJuZXRTdGF0dXNDYWxsYmFjayhISU5URVJORVQsIERX T1JEX1BUUiwgRFdPUkQsIExQVk9JRCwgRFdPUkQpOwogICAgIGZyaWVuZCB2b2lkIF9fc3RkY2Fs bCB0cmFuc2ZlckpvYlN0YXR1c0NhbGxiYWNrKEhJTlRFUk5FVCwgRFdPUkRfUFRSLCBEV09SRCwg TFBWT0lELCBEV09SRCk7CiAgICAgZnJpZW5kIExSRVNVTFQgX19zdGRjYWxsIFJlc291cmNlSGFu ZGxlV25kUHJvYyhIV05ELCB1bnNpZ25lZCBtZXNzYWdlLCBXUEFSQU0sIExQQVJBTSk7CmRpZmYg LS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvd2luL1Jlc291cmNlSGFuZGxlV2luLmNw cCBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay93aW4vUmVzb3VyY2VIYW5kbGVXaW4uY3BwCmlu ZGV4IGUxMDljMGQuLjljZWViYTggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay93aW4vUmVzb3VyY2VIYW5kbGVXaW4uY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay93aW4vUmVzb3VyY2VIYW5kbGVXaW4uY3BwCkBAIC0zMjEsNyArMzIxLDcgQEAgdm9pZCBSZXNv dXJjZUhhbmRsZTo6b25SZWRpcmVjdCgpCiAgICAgICAgIHJlc291cmNlSGFuZGxlQ2xpZW50LT53 aWxsU2VuZFJlcXVlc3QodGhpcywgbmV3UmVxdWVzdCwgcmVzcG9uc2UpOwogfQogCi12b2lkIFJl c291cmNlSGFuZGxlOjpvblJlcXVlc3RDb21wbGV0ZShMUEFSQU0gbFBhcmFtKQorYm9vbCBSZXNv dXJjZUhhbmRsZTo6b25SZXF1ZXN0Q29tcGxldGUoKQogewogICAgIGlmIChkLT5tX2J5dGVzUmVt YWluaW5nVG9Xcml0ZSkgewogICAgICAgICBEV09SRCBieXRlc1dyaXR0ZW47CkBAIC0zMzEsMTQg KzMzMSwxNCBAQCB2b2lkIFJlc291cmNlSGFuZGxlOjpvblJlcXVlc3RDb21wbGV0ZShMUEFSQU0g bFBhcmFtKQogICAgICAgICAgICAgICAgICAgICAgICAgICAmYnl0ZXNXcml0dGVuKTsKICAgICAg ICAgZC0+bV9ieXRlc1JlbWFpbmluZ1RvV3JpdGUgLT0gYnl0ZXNXcml0dGVuOwogICAgICAgICBp ZiAoZC0+bV9ieXRlc1JlbWFpbmluZ1RvV3JpdGUpCi0gICAgICAgICAgICByZXR1cm47CisgICAg ICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgZC0+bV9mb3JtRGF0YS5jbGVhcigpOwogICAg IH0KIAogICAgIGlmICghZC0+bV9zZW50RW5kUmVxdWVzdCkgewogICAgICAgICBIdHRwRW5kUmVx dWVzdFcoZC0+bV9yZXF1ZXN0SGFuZGxlLCAwLCAwLCByZWludGVycHJldF9jYXN0PERXT1JEX1BU Uj4odGhpcykpOwogICAgICAgICBkLT5tX3NlbnRFbmRSZXF1ZXN0ID0gdHJ1ZTsKLSAgICAgICAg cmV0dXJuOworICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKICAgICBISU5URVJORVQgaGFu ZGxlID0gKHJlcXVlc3QoKS5odHRwTWV0aG9kKCkgPT0gIlBPU1QiKSA/IGQtPm1fc2Vjb25kYXJ5 SGFuZGxlIDogZC0+bV9yZXNvdXJjZUhhbmRsZTsKQEAgLTM1MSw3ICszNTEsNyBAQCB2b2lkIFJl c291cmNlSGFuZGxlOjpvblJlcXVlc3RDb21wbGV0ZShMUEFSQU0gbFBhcmFtKQogICAgIGJ1ZmZl cnMuZHdCdWZmZXJMZW5ndGggPSBidWZmZXJTaXplOwogCiAgICAgQk9PTCBvayA9IEZBTFNFOwot ICAgIHdoaWxlICgob2sgPSBJbnRlcm5ldFJlYWRGaWxlRXhBKGhhbmRsZSwgJmJ1ZmZlcnMsIElS Rl9OT19XQUlULCAoRFdPUkRfUFRSKXRoaXMpKSAmJiBidWZmZXJzLmR3QnVmZmVyTGVuZ3RoKSB7 CisgICAgd2hpbGUgKChvayA9IEludGVybmV0UmVhZEZpbGVFeEEoZC0+bV9yZXF1ZXN0SGFuZGxl LCAmYnVmZmVycywgZC0+bV9sb2FkU3luY2hyb25vdXNseSA/IDAgOiBJUkZfTk9fV0FJVCwgcmVp bnRlcnByZXRfY2FzdDxEV09SRF9QVFI+KHRoaXMpKSkgJiYgYnVmZmVycy5kd0J1ZmZlckxlbmd0 aCkgewogICAgICAgICBpZiAoIWhhc1JlY2VpdmVkUmVzcG9uc2UoKSkgewogICAgICAgICAgICAg c2V0SGFzUmVjZWl2ZWRSZXNwb25zZSgpOwogICAgICAgICAgICAgUmVzb3VyY2VSZXNwb25zZSBy ZXNwb25zZTsKQEAgLTM4MiwxMyArMzgyLDEzIEBAIHZvaWQgUmVzb3VyY2VIYW5kbGU6Om9uUmVx dWVzdENvbXBsZXRlKExQQVJBTSBsUGFyYW0pCiAgICAgfQogCiAgICAgaWYgKCFvayAmJiBHZXRM YXN0RXJyb3IoKSA9PSBFUlJPUl9JT19QRU5ESU5HKQotICAgICAgICByZXR1cm47CisgICAgICAg IHJldHVybiB0cnVlOwogCiAgICAgY2xpZW50KCktPmRpZEZpbmlzaExvYWRpbmcodGhpcywgMCk7 CiAgICAgSW50ZXJuZXRDbG9zZUhhbmRsZShkLT5tX3JlcXVlc3RIYW5kbGUpOwogICAgIEludGVy bmV0Q2xvc2VIYW5kbGUoZC0+bV9jb25uZWN0SGFuZGxlKTsKICAgICBkZXJlZigpOyAvLyBiYWxh bmNlcyByZWYgaW4gc3RhcnQKLSAgICByZXR1cm47CisgICAgcmV0dXJuIGZhbHNlOwogfQogCiBz dGF0aWMgdm9pZCBfX3N0ZGNhbGwgdHJhbnNmZXJKb2JTdGF0dXNDYWxsYmFjayhISU5URVJORVQg aW50ZXJuZXRIYW5kbGUsCkBAIC00OTcsNiArNDk3LDExIEBAIGJvb2wgUmVzb3VyY2VIYW5kbGU6 OnN0YXJ0KE5ldHdvcmtpbmdDb250ZXh0KiBjb250ZXh0KQogCiAgICAgcmVmKCk7IC8vIGJhbGFu Y2VkIGJ5IGRlcmVmIGluIG9uUmVxdWVzdENvbXBsZXRlCiAKKyAgICBpZiAoZC0+bV9sb2FkU3lu Y2hyb25vdXNseSkKKyAgICAgICAgd2hpbGUgKG9uUmVxdWVzdENvbXBsZXRlKCkpIHsKKyAgICAg ICAgICAgIC8vIExvb3AgdW50aWwgZmluaXNoZWQuCisgICAgICAgIH0KKwogICAgIHJldHVybiB0 cnVlOwogfQogCg==