46357 2010-09-23 08:33:43 -0700 Fix warnings regarding print format in 64 bits 2012-09-25 13:04:20 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 lucas.de.marchi lucas.de.marchi abarth barbieri bfulgham dumi eric ismail kenneth laszlo.gombos ossy tonikitoo webkit.review.bot oldest_to_newest 283661 0 lucas.de.marchi 2010-09-23 08:33:43 -0700 Fix warnings regarding print format in 64 bits 283662 1 68524 lucas.de.marchi 2010-09-23 08:35:25 -0700 Created attachment 68524 Patch 283722 2 ossy 2010-09-23 10:03:35 -0700 It is a good idea to use format specifier macros. I absolutely support using them, and would be happy if we can get rid of previously #ifdef ... # else ... #endif ugly hacks. Some of them were made by myself, because I can't find many occurrences of these macros. 283743 3 68524 ossy 2010-09-23 10:28:40 -0700 Comment on attachment 68524 Patch I think it is a good and necessary direction, r=me. 283779 4 68524 lucas.de.marchi 2010-09-23 10:53:03 -0700 Comment on attachment 68524 Patch Clearing flags on attachment: 68524 Committed r68164: <http://trac.webkit.org/changeset/68164> 283780 5 lucas.de.marchi 2010-09-23 10:53:13 -0700 All reviewed patches have been landed. Closing bug. 283888 6 webkit.review.bot 2010-09-23 13:16:50 -0700 http://trac.webkit.org/changeset/68164 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/68163 http://trac.webkit.org/changeset/68164 http://trac.webkit.org/changeset/68165 http://trac.webkit.org/changeset/68166 http://trac.webkit.org/changeset/68167 http://trac.webkit.org/changeset/68168 http://trac.webkit.org/changeset/68169 284342 7 ismail 2010-09-24 06:35:33 -0700 This broke Windows CE compilation, inttypes.h does not exist on Windows CE. 284372 8 ossy 2010-09-24 07:37:10 -0700 (In reply to comment #7) > This broke Windows CE compilation, inttypes.h does not exist on Windows CE. New bug to track this fail: https://bugs.webkit.org/show_bug.cgi?id=46463 288816 9 bfulgham 2010-10-03 23:12:34 -0700 This change also broke the WinCairo build of windows. 288820 10 ossy 2010-10-03 23:55:25 -0700 (In reply to comment #9) > This change also broke the WinCairo build of windows. Sorry for breakage. :( Next time I will check the newest WinCairo buildbot. The new bot would be useful. Thanks for the fix landed in http://trac.webkit.org/changeset/68998 727897 11 laszlo.gombos 2012-09-25 13:04:20 -0700 *** Bug 38809 has been marked as a duplicate of this bug. *** 68524 2010-09-23 08:35:25 -0700 2010-09-23 10:53:02 -0700 Patch bug-46357-20100923123523.patch text/plain 1925 lucas.de.marchi ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmRiMTZhZjA3NGUzNWFhNjU4MTllNjcwOTdjMGY4NDU2ODA5ZGJiZi4uMDAxZTc2OTg5YzcwMzZk YzE2Y2YzMzBlNGUzNjI5YjZkNWI2NjBkZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOS0yMyAgTHVj YXMgRGUgTWFyY2hpICA8bHVjYXMuZGVtYXJjaGlAcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHdhcm5pbmdzIHJlZ2Fy ZGluZyBwcmludCBmb3JtYXQgaW4gNjQgYml0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDYzNTcKKworICAgICAgICBVc2UgaW50dHlwZXMuaCBpbiBv cmRlciB0byBoYXZlIHBvcnRhYmxlIHByaW50IGZvcm1hdHMgYWNyb3NzIDMyIGFuZAorICAgICAg ICA2NCBiaXRzLgorCisgICAgICAgICogcGxhdGZvcm0vc3FsL1NRTGl0ZUZpbGVTeXN0ZW0uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6U1FMaXRlRmlsZVN5c3RlbTo6Z2V0RmlsZU5hbWVGb3JOZXdE YXRhYmFzZSk6CisKIDIwMTAtMDktMjMgIEFuZHJlaSBQb3Blc2N1ICA8YW5kcmVpcEBnb29nbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZUZpbGVTeXN0ZW0uY3BwIGIvV2ViQ29yZS9wbGF0Zm9y bS9zcWwvU1FMaXRlRmlsZVN5c3RlbS5jcHAKaW5kZXggYzk1ODNlYjk4YWExMTNiYzk3MmUxNzdi YzU4OWUwM2ZmZjI2NWVjZS4uZDQ4N2I5NTMxODg5OWU0ZGI5N2ViOGE5OTc4NTY2ZmEyYjBjNWQw MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9zcWwvU1FMaXRlRmlsZVN5c3RlbS5jcHAK KysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9zcWwvU1FMaXRlRmlsZVN5c3RlbS5jcHAKQEAgLTI4LDEy ICsyOCwxNCBAQAogICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQ T1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCisjZGVmaW5lIF9fU1REQ19GT1JNQVRf TUFDUk9TCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiU1FMaXRlRmlsZVN5c3RlbS5o IgogCiAjaW5jbHVkZSAiRmlsZVN5c3RlbS5oIgogI2luY2x1ZGUgIlNRTGl0ZURhdGFiYXNlLmgi CiAjaW5jbHVkZSAiU1FMaXRlU3RhdGVtZW50LmgiCisjaW5jbHVkZSA8aW50dHlwZXMuaD4KICNp bmNsdWRlIDxzcWxpdGUzLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTczLDEwICs3NSwx MCBAQCBTdHJpbmcgU1FMaXRlRmlsZVN5c3RlbTo6Z2V0RmlsZU5hbWVGb3JOZXdEYXRhYmFzZShj b25zdCBTdHJpbmcmIGRiRGlyLCBjb25zdCBTdAogICAgIFN0cmluZyBmaWxlTmFtZTsKICAgICBk byB7CiAgICAgICAgICsrc2VxOwotICAgICAgICBmaWxlTmFtZSA9IHBhdGhCeUFwcGVuZGluZ0Nv bXBvbmVudChkYkRpciwgU3RyaW5nOjpmb3JtYXQoIiUwMTZsbHguZGIiLCBzZXEpKTsKKyAgICAg ICAgZmlsZU5hbWUgPSBwYXRoQnlBcHBlbmRpbmdDb21wb25lbnQoZGJEaXIsIFN0cmluZzo6Zm9y bWF0KCIlMDE2IlBSSXg2NCIuZGIiLCBzZXEpKTsKICAgICB9IHdoaWxlIChmaWxlRXhpc3RzKGZp bGVOYW1lKSk7CiAKLSAgICByZXR1cm4gU3RyaW5nOjpmb3JtYXQoIiUwMTZsbHguZGIiLCBzZXEp OworICAgIHJldHVybiBTdHJpbmc6OmZvcm1hdCgiJTAxNiJQUkl4NjQiLmRiIiwgc2VxKTsKIH0K IAogU3RyaW5nIFNRTGl0ZUZpbGVTeXN0ZW06OmFwcGVuZERhdGFiYXNlRmlsZU5hbWVUb1BhdGgo Y29uc3QgU3RyaW5nJiBwYXRoLCBjb25zdCBTdHJpbmcmIGZpbGVOYW1lKQo=