46355 2010-09-23 08:22:02 -0700 Fix usage of enum as if it was a define 2010-09-23 15:46:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 lucas.de.marchi lucas.de.marchi barbieri commit-queue darin kenneth ossy tonikitoo zoltan oldest_to_newest 283656 0 lucas.de.marchi 2010-09-23 08:22:02 -0700 Fix usage of enum as if it was a define 283657 1 68522 lucas.de.marchi 2010-09-23 08:29:04 -0700 Created attachment 68522 Patch 283726 2 ossy 2010-09-23 10:08:51 -0700 Here is a related bug: https://bugs.webkit.org/show_bug.cgi?id=45246 Zoltan, Darin, could you check it? 283800 3 68522 darin 2010-09-23 11:41:09 -0700 Comment on attachment 68522 Patch I am not sure we need two code paths here. The person who originally made this patch was trying to preserve the faster simpler code path for platforms like Mac OS X where the default for a mutex is a normal mutex, but I think we can take the extra hit of always calling pthread_mutexattr_init on all platforms. So lets just get rid of the #if and keep only the #else part. Unless someone has evidence that the code is too slow when written that way. 283810 4 lucas.de.marchi 2010-09-23 11:53:05 -0700 (In reply to comment #3) > (From update of attachment 68522 [details]) > I am not sure we need two code paths here. The person who originally made this patch was trying to preserve the faster simpler code path for platforms like Mac OS X where the default for a mutex is a normal mutex, but I think we can take the extra hit of always calling pthread_mutexattr_init on all platforms. So lets just get rid of the #if and keep only the #else part. > > Unless someone has evidence that the code is too slow when written that way. Humn... Yes, I agree. I'll upload a new patch soon. 283823 5 68559 lucas.de.marchi 2010-09-23 12:06:32 -0700 Created attachment 68559 Patch 284048 6 68559 commit-queue 2010-09-23 15:46:17 -0700 Comment on attachment 68559 Patch Clearing flags on attachment: 68559 Committed r68209: <http://trac.webkit.org/changeset/68209> 284049 7 commit-queue 2010-09-23 15:46:23 -0700 All reviewed patches have been landed. Closing bug. 68522 2010-09-23 08:29:04 -0700 2010-09-23 12:06:21 -0700 Patch bug-46355.patch text/plain 1603 lucas.de.marchi ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBiMWI4ZjE5Li40YTQ1NWM0IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTAtMDktMjMgIEx1Y2FzIERlIE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hpQHByb2Z1c2lv bi5tb2JpPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEZpeCB1c2FnZSBvZiBlbnVtIGFzIGlmIGl0IHdhcyBhIGRlZmluZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDYzNTUKKworICAgICAgICBwdGhyZWFk LmggZGVmaW5lcyBQVEhSRUFEX01VVEVYX0RFRkFVTFQgYW5kIFBUSFJFQURfTVVURVhfTk9STUFM IGFzIGFuCisgICAgICAgIGVudW0uICBIZW5jZSwgaXQgY2Fubm90IGJlIHVzZWQgYnkgdGhlIHBy ZXByb2Nlc3NvciB3aGljaCBhbHdheXMKKyAgICAgICAgZXZhbHV0ZXMgdGhhdCBjb25kaXRpb24g YXMgdHJ1ZS4gVGhpcyB3YXMgZ2l2aW5nIGEgd2FybmluZyB3aGVuCisgICAgICAgIGNvbXBpbGlu ZyB3aXRoIGdjYyBhbmQgIi1XdW5kZWYiIGZsYWcuCisKKyAgICAgICAgKiB3dGYvVGhyZWFkaW5n UHRocmVhZHMuY3BwOiBDaGVjayBhdCBydW50aW1lIGluc3RlYWQgb2YgdXNpbmcgdGhlCisgICAg ICAgIHByZXByb2Nlc3Nvci4KKyAgICAgICAgKFdURjo6TXV0ZXg6Ok11dGV4KToKKwogMjAxMC0w OS0yMyAgSXNtYWlsIET2bm1leiAgPGlzbWFpbEBuYW10cmFjLm9yZz4KIAogICAgICAgICBVbnJl dmlld2VkLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ1B0aHJlYWRz LmNwcCBiL0phdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHAKaW5kZXggOTgy ODZkMy4uMjhkNWI3NyAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ1B0 aHJlYWRzLmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nUHRocmVhZHMuY3Bw CkBAIC0yNDEsMTEgKzI0MSwxMCBAQCBUaHJlYWRJZGVudGlmaWVyIGN1cnJlbnRUaHJlYWQoKQog CiBNdXRleDo6TXV0ZXgoKQogewotI2lmIFBUSFJFQURfTVVURVhfTk9STUFMID09IFBUSFJFQURf TVVURVhfREVGQVVMVAotCi0gICAgcHRocmVhZF9tdXRleF9pbml0KCZtX211dGV4LCAwKTsKLQot I2Vsc2UKKyAgICBpZiAoUFRIUkVBRF9NVVRFWF9OT1JNQUwgPT0gUFRIUkVBRF9NVVRFWF9ERUZB VUxUKSB7CisgICAgICAgIHB0aHJlYWRfbXV0ZXhfaW5pdCgmbV9tdXRleCwgMCk7CisgICAgICAg IHJldHVybjsKKyAgICB9CiAKICAgICBwdGhyZWFkX211dGV4YXR0cl90IGF0dHI7CiAgICAgcHRo cmVhZF9tdXRleGF0dHJfaW5pdCgmYXR0cik7CkBAIC0yNTQsOCArMjUzLDYgQEAgTXV0ZXg6Ok11 dGV4KCkKICAgICBwdGhyZWFkX211dGV4X2luaXQoJm1fbXV0ZXgsICZhdHRyKTsKIAogICAgIHB0 aHJlYWRfbXV0ZXhhdHRyX2Rlc3Ryb3koJmF0dHIpOwotCi0jZW5kaWYKIH0KIAogTXV0ZXg6On5N dXRleCgpCg== 68559 2010-09-23 12:06:32 -0700 2010-09-23 15:46:17 -0700 Patch bug-46355-20100923160626.patch text/plain 1896 lucas.de.marchi ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA2NGY2Zjk3MTY5ZGZhNzQwMjY5YTk4OTE0ZmIzZTVlMDY2NGI4NWE3Li5k ODQxNTQ0ZDExZmM0Y2Q3OWM1ODkwN2ViYTFkMzAwNDlkNzA3MDUzIDEwMDY0NAotLS0gYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjMgQEAKKzIwMTAtMDktMjMgIEx1Y2FzIERlIE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hp QHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZpeCB1c2FnZSBvZiBlbnVtIGFzIGlmIGl0IHdhcyBhIGRlZmluZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDYzNTUKKworICAgICAg ICBwdGhyZWFkLmggZGVmaW5lcyBQVEhSRUFEX01VVEVYX0RFRkFVTFQgYW5kIFBUSFJFQURfTVVU RVhfTk9STUFMIGFzIGFuCisgICAgICAgIGVudW0uICBIZW5jZSwgaXQgY2Fubm90IGJlIHVzZWQg YnkgdGhlIHByZXByb2Nlc3NvciB3aGljaCBhbHdheXMKKyAgICAgICAgZXZhbHVhdGVzIHRoYXQg Y29uZGl0aW9uIGFzIHRydWUuIFRoaXMgd2FzIGdpdmluZyBhIHdhcm5pbmcgd2hlbgorICAgICAg ICBjb21waWxpbmcgd2l0aCBnY2MgYW5kICItV3VuZGVmIiBmbGFnLgorCisgICAgICAgIFRoZSBz ZWNvbmQgcGF0aCwgd2hlbiBQVEhSRUFEX01VVEVYX0RFRkFVTFQgaXMgbm90IHRoZSBzYW1lIG9m CisgICAgICAgIFBUSFJFQURfTVVURVhfTk9STUFMLCBpcyBub3Qgc2xvdy4gU28sIGxldCdzIGVs aW1pbmF0ZSB0aGUgZmlyc3QgcGF0aAorICAgICAgICBhbmQgZ2V0IHJpZCBvZiB0aGF0ICNpZi4K KworICAgICAgICAqIHd0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHA6IEFsd2F5cyBjYWxsIHB0aHJl YWRfbXV0ZXhhdHRyX2luaXQoKSB0bworICAgICAgICBzZXQgbXV0ZXggdHlwZSB0byBQVEhSRUFE X01VVEVYX05PUk1BTC4KKyAgICAgICAgKFdURjo6TXV0ZXg6Ok11dGV4KToKKwogMjAxMC0wOS0y MiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEdlb2ZmIEdhcmVuLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ1B0 aHJlYWRzLmNwcCBiL0phdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHAKaW5k ZXggOTgyODZkMzA0NjU3MWMzYzg2ZmVjYTUxZjE4YzU2YTVjMzk1MjMxNC4uMDAxN2E2ZjdhY2Mz YTgwNzdhYjRiNDhiZWU1MjE0MmU1YzUyNGU3OCAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUv d3RmL1RocmVhZGluZ1B0aHJlYWRzLmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFk aW5nUHRocmVhZHMuY3BwCkBAIC0yNDEsMTIgKzI0MSw2IEBAIFRocmVhZElkZW50aWZpZXIgY3Vy cmVudFRocmVhZCgpCiAKIE11dGV4OjpNdXRleCgpCiB7Ci0jaWYgUFRIUkVBRF9NVVRFWF9OT1JN QUwgPT0gUFRIUkVBRF9NVVRFWF9ERUZBVUxUCi0KLSAgICBwdGhyZWFkX211dGV4X2luaXQoJm1f bXV0ZXgsIDApOwotCi0jZWxzZQotCiAgICAgcHRocmVhZF9tdXRleGF0dHJfdCBhdHRyOwogICAg IHB0aHJlYWRfbXV0ZXhhdHRyX2luaXQoJmF0dHIpOwogICAgIHB0aHJlYWRfbXV0ZXhhdHRyX3Nl dHR5cGUoJmF0dHIsIFBUSFJFQURfTVVURVhfTk9STUFMKTsKQEAgLTI1NCw4ICsyNDgsNiBAQCBN dXRleDo6TXV0ZXgoKQogICAgIHB0aHJlYWRfbXV0ZXhfaW5pdCgmbV9tdXRleCwgJmF0dHIpOwog CiAgICAgcHRocmVhZF9tdXRleGF0dHJfZGVzdHJveSgmYXR0cik7Ci0KLSNlbmRpZgogfQogCiBN dXRleDo6fk11dGV4KCkK