<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>4635</bug_id>
          
          <creation_ts>2005-08-24 23:03:23 -0700</creation_ts>
          <short_desc>internal.cpp win portability fixes</short_desc>
          <delta_ts>2005-09-04 01:44:00 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>420+</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows XP</op_sys>
          <bug_status>VERIFIED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Krzysztof Kowalczyk">kkowalczyk</reporter>
          <assigned_to name="Darin Adler">darin</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>17370</commentid>
    <comment_count>0</comment_count>
    <who name="Krzysztof Kowalczyk">kkowalczyk</who>
    <bug_when>2005-08-24 23:03:23 -0700</bug_when>
    <thetext>define win versions of locking routines</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>17371</commentid>
    <comment_count>1</comment_count>
      <attachid>3562</attachid>
    <who name="Krzysztof Kowalczyk">kkowalczyk</who>
    <bug_when>2005-08-24 23:03:38 -0700</bug_when>
    <thetext>Created attachment 3562
internal.cpp</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>18575</commentid>
    <comment_count>2</comment_count>
      <attachid>3562</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2005-09-03 17:07:18 -0700</bug_when>
    <thetext>Comment on attachment 3562
internal.cpp

I don&apos;t think we need the multithreading implementation at all on WIN32. That&apos;s
really specific to the use on Mac OS X where we use the JavaScriptCore from
multiple processes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>18592</commentid>
    <comment_count>3</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2005-09-03 18:16:14 -0700</bug_when>
    <thetext>These problems should all be fixed, but I haven&apos;t tried compiling on Windows. Krzysztof, please let me 
know if any of the changes don&apos;t work.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>3562</attachid>
            <date>2005-08-24 23:03:38 -0700</date>
            <delta_ts>2005-09-03 17:07:18 -0700</delta_ts>
            <desc>internal.cpp</desc>
            <filename>internal_cpp_diff.txt</filename>
            <type>text/plain</type>
            <size>2184</size>
            <attacher name="Krzysztof Kowalczyk">kkowalczyk</attacher>
            
              <data encoding="base64">SW5kZXg6IGtqcy9pbnRlcm5hbC5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3ZzL3Jvb3Qv
SmF2YVNjcmlwdENvcmUva2pzL2ludGVybmFsLmNwcCx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEu
NjQNCmRpZmYgLXUgLXIxLjY0IGludGVybmFsLmNwcA0KLS0tIGtqcy9pbnRlcm5hbC5jcHAJMTYg
QXVnIDIwMDUgMDA6NDc6MjUgLTAwMDAJMS42NA0KKysrIGtqcy9pbnRlcm5hbC5jcHAJMjUgQXVn
IDIwMDUgMDY6MDQ6MjcgLTAwMDANCkBAIC0yNSw5ICsyNSw2IEBADQogI2luY2x1ZGUgPHN0ZGlv
Lmg+DQogI2luY2x1ZGUgPG1hdGguaD4NCiAjaW5jbHVkZSA8YXNzZXJ0Lmg+DQotI2lmbmRlZiBO
REVCVUcNCi0jaW5jbHVkZSA8c3RyaW5ncy5oPiAgICAgIC8vIGZvciBzdHJkdXANCi0jZW5kaWYN
CiANCiAjaW5jbHVkZSAiYXJyYXlfb2JqZWN0LmgiDQogI2luY2x1ZGUgImJvb2xfb2JqZWN0Lmgi
DQpAQCAtNDksNiArNDYsMTEgQEANCiAjaW5jbHVkZSAicmVnZXhwX29iamVjdC5oIg0KICNpbmNs
dWRlICJzdHJpbmdfb2JqZWN0LmgiDQogDQorI2lmIFdJTjMyDQorI2luY2x1ZGUgPGZsb2F0Lmg+
DQorI2RlZmluZSBjb3B5c2lnbiBfY29weXNpZ24NCisjZW5kaWYNCisNCiAjZGVmaW5lIEkxOE5f
Tk9PUChzKSBzDQogDQogZXh0ZXJuIGludCBranN5eXBhcnNlKCk7DQpAQCAtNzMsMjQgKzc1LDQ5
IEBADQogDQogI2VuZGlmIC8vIEFQUExFX0NIQU5HRVMNCiANCisjaWYgV0lOMzINCisjaW5jbHVk
ZSA8d2luZG93cy5oPg0KK3N0YXRpYyBDUklUSUNBTF9TRUNUSU9OIGludGVycHJldGVyTG9jazsN
CitzdGF0aWMgTE9ORyBjcml0U2VjSW5pdGVkID0gMDsNCisjZWxzZQ0KIHN0YXRpYyBwdGhyZWFk
X29uY2VfdCBpbnRlcnByZXRlckxvY2tPbmNlID0gUFRIUkVBRF9PTkNFX0lOSVQ7DQogc3RhdGlj
IHB0aHJlYWRfbXV0ZXhfdCBpbnRlcnByZXRlckxvY2s7DQorI2VuZGlmDQorDQogc3RhdGljIGlu
dCBpbnRlcnByZXRlckxvY2tDb3VudCA9IDA7DQogDQogc3RhdGljIHZvaWQgaW5pdGlhbGl6ZUlu
dGVycHJldGVyTG9jaygpDQogew0KKyNpZiBXSU4zMg0KKyAgSW5pdGlhbGl6ZUNyaXRpY2FsU2Vj
dGlvbigmaW50ZXJwcmV0ZXJMb2NrKTsNCisjZWxzZQ0KICAgcHRocmVhZF9tdXRleGF0dHJfdCBh
dHRyOw0KIA0KICAgcHRocmVhZF9tdXRleGF0dHJfaW5pdCgmYXR0cik7DQogICBwdGhyZWFkX211
dGV4YXR0cl9zZXR0eXBlICgmYXR0ciwgUFRIUkVBRF9NVVRFWF9SRUNVUlNJVkUpOw0KIA0KICAg
cHRocmVhZF9tdXRleF9pbml0KCZpbnRlcnByZXRlckxvY2ssICZhdHRyKTsNCisjZW5kaWYNCiB9
DQogDQogc3RhdGljIGlubGluZSB2b2lkIGxvY2tJbnRlcnByZXRlcigpDQogew0KKyNpZiBXSU4z
Mg0KKyAgLy8gZmlyc3QgY29tcGFyaXNvbiBzbyB0aGF0IHdlIGRvbid0IG92ZXJmbG93IHRoZSBu
dW1iZXINCisgIGlmICgwID09IGludGVycHJldGVyTG9ja0NvdW50KQ0KKyAgew0KKyAgICBMT05H
IGluaXRDb3VudCA9IEludGVybG9ja2VkSW5jcmVtZW50KCZjcml0U2VjSW5pdGVkKTsNCisgICAg
aWYgKDEgPT0gaW5pdENvdW50KQ0KKyAgICB7DQorICAgICAgICAvLyBpbml0aWFsaXplIHRoZSBm
aXJzdCB0aW1lIHdlJ3JlIGhlcmUNCisgICAgICAgIGluaXRpYWxpemVJbnRlcnByZXRlckxvY2so
KTsNCisgICAgfQ0KKyAgRW50ZXJDcml0aWNhbFNlY3Rpb24oJmludGVycHJldGVyTG9jayk7DQor
ICB9DQorI2Vsc2UNCiAgIHB0aHJlYWRfb25jZSgmaW50ZXJwcmV0ZXJMb2NrT25jZSwgaW5pdGlh
bGl6ZUludGVycHJldGVyTG9jayk7DQogICBwdGhyZWFkX211dGV4X2xvY2soJmludGVycHJldGVy
TG9jayk7DQorI2VuZGlmDQogICBpbnRlcnByZXRlckxvY2tDb3VudCsrOw0KICAgQ29sbGVjdG9y
OjpyZWdpc3RlclRocmVhZCgpOw0KIH0NCkBAIC05OCw3ICsxMjUsMTEgQEANCiBzdGF0aWMgaW5s
aW5lIHZvaWQgdW5sb2NrSW50ZXJwcmV0ZXIoKQ0KIHsNCiAgIGludGVycHJldGVyTG9ja0NvdW50
LS07DQorI2lmIFdJTjMyDQorICBMZWF2ZUNyaXRpY2FsU2VjdGlvbigmaW50ZXJwcmV0ZXJMb2Nr
KTsNCisjZWxzZQ0KICAgcHRocmVhZF9tdXRleF91bmxvY2soJmludGVycHJldGVyTG9jayk7DQor
I2VuZGlmDQogfQ0KIA0KIA0K
</data>
<flag name="review"
          id="498"
          type_id="1"
          status="-"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>