46346 2010-09-23 06:14:12 -0700 Web Inspector: [REGRESSION] Keyboard-Navigating the dom in the inspector doesn't highlight that dom node in the window anymore 2010-09-23 08:21:01 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P1 Normal --- 0 spamfaenger webkit-unassigned bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr podivilov rik timothy yurys oldest_to_newest 283592 0 spamfaenger 2010-09-23 06:14:12 -0700 Instead it only listens to the mouse hovering above a dom node - which is verry annoying if you want to precisely navigate to an element while looking at the dom to see if you have the right one. 283594 1 pfeldman 2010-09-23 06:27:51 -0700 So highlight should be visible for the element that has been selected / hovered last. I.e. traversing elements using keyboard should highlight the currently selected one, not falling back to the hovered element in 2 sec. Moving the mouse afterwards should highlight hovered element. 283612 2 68513 podivilov 2010-09-23 06:57:04 -0700 Created attachment 68513 Proposed patch. 283615 3 68513 pfeldman 2010-09-23 07:06:46 -0700 Comment on attachment 68513 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=68513&action=review > WebCore/inspector/front-end/treeoutline.js:797 > + this.select(false, true); false -> this. 283618 4 podivilov 2010-09-23 07:18:14 -0700 (In reply to comment #3) > (From update of attachment 68513 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=68513&action=review > > > WebCore/inspector/front-end/treeoutline.js:797 > > + this.select(false, true); > > false -> this. onselect and select functions have different signatures: onselect: function(treeElement, selectedByUser) TreeElement.prototype.select = function(supressOnSelect, selectedByUser) So select method has boolean supressOnSelect as it's first parameter. 283653 5 68513 commit-queue 2010-09-23 08:20:56 -0700 Comment on attachment 68513 Proposed patch. Clearing flags on attachment: 68513 Committed r68140: <http://trac.webkit.org/changeset/68140> 283654 6 commit-queue 2010-09-23 08:21:01 -0700 All reviewed patches have been landed. Closing bug. 68513 2010-09-23 06:57:04 -0700 2010-09-23 08:20:55 -0700 Proposed patch. patch text/plain 2822 podivilov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzFjZmZiNi4uZjMxOTc1ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wOS0yMyAgUGF2ZWwgUG9kaXZp bG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBoaWdobGlnaHQgRE9NIG5vZGVz IHdoZW4gbmF2aWdhdGluZyB0aGUgRE9NIHdpdGgga2V5Ym9hcmQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2MzQ2CisKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuRWxlbWVudHNUcmVlRWxlbWVudC5wcm90b3R5cGUub25zZWxlY3QpOgorICAgICAgICAqIGlu c3BlY3Rvci9mcm9udC1lbmQvdHJlZW91dGxpbmUuanM6CisgICAgICAgIChUcmVlT3V0bGluZS5w cm90b3R5cGUuX3RyZWVLZXlEb3duKToKKyAgICAgICAgKFRyZWVFbGVtZW50LnByb3RvdHlwZS5z ZWxlY3RPbk1vdXNlRG93bik6CisgICAgICAgIChUcmVlRWxlbWVudC5wcm90b3R5cGUuc2VsZWN0 KToKKwogMjAxMC0wOS0yMiAgTHVrZSBNYWNwaGVyc29uICA8bWFjcGhlcnNvbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzIGIv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKaW5kZXgg NTEwOWNlNy4uMTQ3OWM5YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0VsZW1lbnRzVHJlZU91dGxpbmUuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0VsZW1lbnRzVHJlZU91dGxpbmUuanMKQEAgLTYzNywxMCArNjM3LDEyIEBAIFdlYkluc3BlY3Rv ci5FbGVtZW50c1RyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHRoaXMubGlz dEl0ZW1FbGVtZW50LnNjcm9sbEludG9WaWV3SWZOZWVkZWQoZmFsc2UpOwogICAgIH0sCiAKLSAg ICBvbnNlbGVjdDogZnVuY3Rpb24oKQorICAgIG9uc2VsZWN0OiBmdW5jdGlvbih0cmVlRWxlbWVu dCwgc2VsZWN0ZWRCeVVzZXIpCiAgICAgewogICAgICAgICB0aGlzLnRyZWVPdXRsaW5lLnN1cHBy ZXNzUmV2ZWFsQW5kU2VsZWN0ID0gdHJ1ZTsKICAgICAgICAgdGhpcy50cmVlT3V0bGluZS5mb2N1 c2VkRE9NTm9kZSA9IHRoaXMucmVwcmVzZW50ZWRPYmplY3Q7CisgICAgICAgIGlmIChzZWxlY3Rl ZEJ5VXNlcikKKyAgICAgICAgICAgIFdlYkluc3BlY3Rvci5oaWdobGlnaHRET01Ob2RlKHRoaXMu cmVwcmVzZW50ZWRPYmplY3QuaWQpOwogICAgICAgICB0aGlzLnVwZGF0ZVNlbGVjdGlvbigpOwog ICAgICAgICB0aGlzLnRyZWVPdXRsaW5lLnN1cHByZXNzUmV2ZWFsQW5kU2VsZWN0ID0gZmFsc2U7 CiAgICAgfSwKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC90cmVlb3V0 bGluZS5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC90cmVlb3V0bGluZS5qcwppbmRl eCBjMmEzZmU3Li5lMmY4NzljIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvdHJlZW91dGxpbmUuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3RyZWVv dXRsaW5lLmpzCkBAIC0zOTksNyArMzk5LDcgQEAgVHJlZU91dGxpbmUucHJvdG90eXBlLl90cmVl S2V5RG93biA9IGZ1bmN0aW9uKGV2ZW50KQogCiAgICAgaWYgKG5leHRTZWxlY3RlZEVsZW1lbnQp IHsKICAgICAgICAgbmV4dFNlbGVjdGVkRWxlbWVudC5yZXZlYWwoKTsKLSAgICAgICAgbmV4dFNl bGVjdGVkRWxlbWVudC5zZWxlY3QoKTsKKyAgICAgICAgbmV4dFNlbGVjdGVkRWxlbWVudC5zZWxl Y3QoZmFsc2UsIHRydWUpOwogICAgIH0KIAogICAgIGlmIChoYW5kbGVkKSB7CkBAIC03OTQsMTAg Kzc5NCwxMCBAQCBUcmVlRWxlbWVudC5wcm90b3R5cGUucmV2ZWFsZWQgPSBmdW5jdGlvbigpCiAK IFRyZWVFbGVtZW50LnByb3RvdHlwZS5zZWxlY3RPbk1vdXNlRG93biA9IGZ1bmN0aW9uKGV2ZW50 KQogewotICAgIHRoaXMuc2VsZWN0KCk7CisgICAgdGhpcy5zZWxlY3QoZmFsc2UsIHRydWUpOwog fQogCi1UcmVlRWxlbWVudC5wcm90b3R5cGUuc2VsZWN0ID0gZnVuY3Rpb24oc3VwcmVzc09uU2Vs ZWN0KQorVHJlZUVsZW1lbnQucHJvdG90eXBlLnNlbGVjdCA9IGZ1bmN0aW9uKHN1cHJlc3NPblNl bGVjdCwgc2VsZWN0ZWRCeVVzZXIpCiB7CiAgICAgaWYgKCF0aGlzLnRyZWVPdXRsaW5lIHx8ICF0 aGlzLnNlbGVjdGFibGUgfHwgdGhpcy5zZWxlY3RlZCkKICAgICAgICAgcmV0dXJuOwpAQCAtODEy LDcgKzgxMiw3IEBAIFRyZWVFbGVtZW50LnByb3RvdHlwZS5zZWxlY3QgPSBmdW5jdGlvbihzdXBy ZXNzT25TZWxlY3QpCiAgICAgICAgIHRoaXMuX2xpc3RJdGVtTm9kZS5hZGRTdHlsZUNsYXNzKCJz ZWxlY3RlZCIpOwogCiAgICAgaWYgKHRoaXMub25zZWxlY3QgJiYgIXN1cHJlc3NPblNlbGVjdCkK LSAgICAgICAgdGhpcy5vbnNlbGVjdCh0aGlzKTsKKyAgICAgICAgdGhpcy5vbnNlbGVjdCh0aGlz LCBzZWxlY3RlZEJ5VXNlcik7CiB9CiAKIFRyZWVFbGVtZW50LnByb3RvdHlwZS5kZXNlbGVjdCA9 IGZ1bmN0aW9uKHN1cHJlc3NPbkRlc2VsZWN0KQo=