46342 2010-09-22 23:10:21 -0700 Tweak some status messages that Eric thought were confusing 2010-09-26 22:14:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth eric oldest_to_newest 283535 0 abarth 2010-09-22 23:10:21 -0700 Tweak some status messages that Eric thought were confusing 283536 1 68504 abarth 2010-09-22 23:11:03 -0700 Created attachment 68504 Patch 283539 2 68504 eric 2010-09-23 00:08:39 -0700 Comment on attachment 68504 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68504&action=review > WebKitTools/Scripts/webkitpy/tool/commands/queues.py:227 > + self._update_status("Downloaded %s" % patch_text, patch) LIES! I would just say "Processing patch" or "starting patch" or just remove it. 283541 3 abarth 2010-09-23 00:24:16 -0700 Committed r68125: <http://trac.webkit.org/changeset/68125> 285313 4 68504 abarth 2010-09-26 22:14:19 -0700 Comment on attachment 68504 Patch This landed. Removing from review queue. 68504 2010-09-22 23:11:03 -0700 2010-09-26 22:14:19 -0700 Patch bug-46342-20100922231101.patch text/plain 4335 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY4MTIzKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDktMjIgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUd2VhayBzb21lIHN0YXR1cyBtZXNzYWdlcyB0aGF0IEVyaWMgdGhvdWdodCB3ZXJl IGNvbmZ1c2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDYzNDIKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1 ZXMucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlc191 bml0dGVzdC5weToKKwogMjAxMC0wOS0yMiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5CShyZXZp c2lvbiA2ODEyMikKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5k cy9xdWV1ZXMucHkJKHdvcmtpbmcgY29weSkKQEAgLTIyNCw3ICsyMjQsNyBAQCBjbGFzcyBDb21t aXRRdWV1ZShBYnN0cmFjdFBhdGNoUXVldWUsIFN0CiAKICAgICBkZWYgc2hvdWxkX3Byb2NlZWRf d2l0aF93b3JrX2l0ZW0oc2VsZiwgcGF0Y2gpOgogICAgICAgICBwYXRjaF90ZXh0ID0gInJvbGxv dXQgcGF0Y2giIGlmIHBhdGNoLmlzX3JvbGxvdXQoKSBlbHNlICJwYXRjaCIKLSAgICAgICAgc2Vs Zi5fdXBkYXRlX3N0YXR1cygiTGFuZGluZyAlcyIgJSBwYXRjaF90ZXh0LCBwYXRjaCkKKyAgICAg ICAgc2VsZi5fdXBkYXRlX3N0YXR1cygiRG93bmxvYWRlZCAlcyIgJSBwYXRjaF90ZXh0LCBwYXRj aCkKICAgICAgICAgcmV0dXJuIFRydWUKIAogICAgIGRlZiBwcm9jZXNzX3dvcmtfaXRlbShzZWxm LCBwYXRjaCk6CkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFu ZHMvcXVldWVzX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXNfdW5pdHRlc3QucHkJKHJldmlzaW9uIDY4MTIy KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlc191 bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMTk0LDcgKzE5NCw3IEBAIGNsYXNzIENvbW1p dFF1ZXVlVGVzdChRdWV1ZXNUZXN0KToKICAgICBkZWYgdGVzdF9jb21taXRfcXVldWUoc2VsZik6 CiAgICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9IHsKICAgICAgICAgICAgICJiZWdpbl93b3JrX3F1 ZXVlIjogc2VsZi5fZGVmYXVsdF9iZWdpbl93b3JrX3F1ZXVlX3N0ZGVycigiY29tbWl0LXF1ZXVl IiwgTW9ja1NDTS5mYWtlX2NoZWNrb3V0X3Jvb3QpLAotICAgICAgICAgICAgInNob3VsZF9wcm9j ZWVkX3dpdGhfd29ya19pdGVtIjogIk1PQ0s6IHVwZGF0ZV9zdGF0dXM6IGNvbW1pdC1xdWV1ZSBM YW5kaW5nIHBhdGNoXG4iLAorICAgICAgICAgICAgInNob3VsZF9wcm9jZWVkX3dpdGhfd29ya19p dGVtIjogIk1PQ0s6IHVwZGF0ZV9zdGF0dXM6IGNvbW1pdC1xdWV1ZSBEb3dubG9hZGVkIHBhdGNo XG4iLAogICAgICAgICAgICAgIm5leHRfd29ya19pdGVtIjogIiIsCiAgICAgICAgICAgICAicHJv Y2Vzc193b3JrX2l0ZW0iOiAiIiJNT0NLOiB1cGRhdGVfc3RhdHVzOiBjb21taXQtcXVldWUgQXBw bGllZCBwYXRjaAogTU9DSzogdXBkYXRlX3N0YXR1czogY29tbWl0LXF1ZXVlIEJ1aWx0IHBhdGNo CkBAIC0yMTAsNyArMjEwLDcgQEAgTU9DSzogdXBkYXRlX3N0YXR1czogY29tbWl0LXF1ZXVlIFBh c3MKICAgICBkZWYgdGVzdF9jb21taXRfcXVldWVfZmFpbHVyZShzZWxmKToKICAgICAgICAgZXhw ZWN0ZWRfc3RkZXJyID0gewogICAgICAgICAgICAgImJlZ2luX3dvcmtfcXVldWUiOiBzZWxmLl9k ZWZhdWx0X2JlZ2luX3dvcmtfcXVldWVfc3RkZXJyKCJjb21taXQtcXVldWUiLCBNb2NrU0NNLmZh a2VfY2hlY2tvdXRfcm9vdCksCi0gICAgICAgICAgICAic2hvdWxkX3Byb2NlZWRfd2l0aF93b3Jr X2l0ZW0iOiAiTU9DSzogdXBkYXRlX3N0YXR1czogY29tbWl0LXF1ZXVlIExhbmRpbmcgcGF0Y2hc biIsCisgICAgICAgICAgICAic2hvdWxkX3Byb2NlZWRfd2l0aF93b3JrX2l0ZW0iOiAiTU9DSzog dXBkYXRlX3N0YXR1czogY29tbWl0LXF1ZXVlIERvd25sb2FkZWQgcGF0Y2hcbiIsCiAgICAgICAg ICAgICAibmV4dF93b3JrX2l0ZW0iOiAiIiwKICAgICAgICAgICAgICJwcm9jZXNzX3dvcmtfaXRl bSI6ICIiIk1PQ0s6IHVwZGF0ZV9zdGF0dXM6IGNvbW1pdC1xdWV1ZSBQYXRjaCBkb2VzIG5vdCBh cHBseQogTU9DSyBzZXR0aW5nIGZsYWcgJ2NvbW1pdC1xdWV1ZScgdG8gJy0nIG9uIGF0dGFjaG1l bnQgJzE5Nycgd2l0aCBjb21tZW50ICdSZWplY3RpbmcgcGF0Y2ggMTk3IGZyb20gY29tbWl0LXF1 ZXVlLicgYW5kIGFkZGl0aW9uYWwgY29tbWVudCAnTU9DSyBzY3JpcHQgZXJyb3InCkBAIC0yMzIs NyArMjMyLDcgQEAgTU9DSzogdXBkYXRlX3N0YXR1czogY29tbWl0LXF1ZXVlIEZhaWwKICAgICAg ICAgdG9vbC5idWlsZGJvdC5saWdodF90cmVlX29uX2ZpcmUoKQogICAgICAgICBleHBlY3RlZF9z dGRlcnIgPSB7CiAgICAgICAgICAgICAiYmVnaW5fd29ya19xdWV1ZSI6IHNlbGYuX2RlZmF1bHRf YmVnaW5fd29ya19xdWV1ZV9zdGRlcnIoImNvbW1pdC1xdWV1ZSIsIE1vY2tTQ00uZmFrZV9jaGVj a291dF9yb290KSwKLSAgICAgICAgICAgICJzaG91bGRfcHJvY2VlZF93aXRoX3dvcmtfaXRlbSI6 ICJNT0NLOiB1cGRhdGVfc3RhdHVzOiBjb21taXQtcXVldWUgTGFuZGluZyBwYXRjaFxuIiwKKyAg ICAgICAgICAgICJzaG91bGRfcHJvY2VlZF93aXRoX3dvcmtfaXRlbSI6ICJNT0NLOiB1cGRhdGVf c3RhdHVzOiBjb21taXQtcXVldWUgRG93bmxvYWRlZCBwYXRjaFxuIiwKICAgICAgICAgICAgICJu ZXh0X3dvcmtfaXRlbSI6ICIiLAogICAgICAgICAgICAgInByb2Nlc3Nfd29ya19pdGVtIjogIiIi TU9DSyBydW5fYW5kX3Rocm93X2lmX2ZhaWw6IFsnZWNobycsICctLXN0YXR1cy1ob3N0PWV4YW1w bGUuY29tJywgJ2FwcGx5LWF0dGFjaG1lbnQnLCAnLS1mb3JjZS1jbGVhbicsICctLW5vbi1pbnRl cmFjdGl2ZScsICctLXF1aWV0JywgMTk3XQogTU9DSzogdXBkYXRlX3N0YXR1czogY29tbWl0LXF1 ZXVlIEFwcGxpZWQgcGF0Y2gKQEAgLTI1NSw3ICsyNTUsNyBAQCBNT0NLOiB1cGRhdGVfc3RhdHVz OiBjb21taXQtcXVldWUgUGFzcwogICAgICAgICByb2xsb3V0X3BhdGNoID0gTW9ja1JvbGxvdXRQ YXRjaCgpCiAgICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9IHsKICAgICAgICAgICAgICJiZWdpbl93 b3JrX3F1ZXVlIjogc2VsZi5fZGVmYXVsdF9iZWdpbl93b3JrX3F1ZXVlX3N0ZGVycigiY29tbWl0 LXF1ZXVlIiwgTW9ja1NDTS5mYWtlX2NoZWNrb3V0X3Jvb3QpLAotICAgICAgICAgICAgInNob3Vs ZF9wcm9jZWVkX3dpdGhfd29ya19pdGVtIjogIk1PQ0s6IHVwZGF0ZV9zdGF0dXM6IGNvbW1pdC1x dWV1ZSBMYW5kaW5nIHJvbGxvdXQgcGF0Y2hcbiIsCisgICAgICAgICAgICAic2hvdWxkX3Byb2Nl ZWRfd2l0aF93b3JrX2l0ZW0iOiAiTU9DSzogdXBkYXRlX3N0YXR1czogY29tbWl0LXF1ZXVlIERv d25sb2FkZWQgcm9sbG91dCBwYXRjaFxuIiwKICAgICAgICAgICAgICJuZXh0X3dvcmtfaXRlbSI6 ICIiLAogICAgICAgICAgICAgInByb2Nlc3Nfd29ya19pdGVtIjogIiIiTU9DSyBydW5fYW5kX3Ro cm93X2lmX2ZhaWw6IFsnZWNobycsICctLXN0YXR1cy1ob3N0PWV4YW1wbGUuY29tJywgJ2FwcGx5 LWF0dGFjaG1lbnQnLCAnLS1mb3JjZS1jbGVhbicsICctLW5vbi1pbnRlcmFjdGl2ZScsICctLXF1 aWV0JywgMTk3XQogTU9DSzogdXBkYXRlX3N0YXR1czogY29tbWl0LXF1ZXVlIEFwcGxpZWQgcGF0 Y2gK