46331 2010-09-22 18:39:29 -0700 minor cleanup of rebaseline-chromium-webkit-tests and gpu test_expectations 2010-09-23 14:56:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth eric levin ojan tony oldest_to_newest 283450 0 dpranke 2010-09-22 18:39:29 -0700 minor cleanup of rebaseline-chromium-webkit-tests and gpu test_expectations 283451 1 68491 dpranke 2010-09-22 18:41:26 -0700 Created attachment 68491 Patch 283476 2 68491 abarth 2010-09-22 19:49:09 -0700 Comment on attachment 68491 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68491&action=review This seems like patches. I'd just landed the test_expectation.txt part without review. > WebKitTools/ChangeLog:7 > + the tool to breat on a git checkout, but that needs to be tracked breat => break > WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:592 > - # self._scm.add(path) > + self._scm.add(path) Seems like we need a test for whatever this does. 283483 3 dpranke 2010-09-22 20:11:08 -0700 I'll just fix the code over in https://bugs.webkit.org/show_bug.cgi?id=46332 and land the expectation change separately, then. I will add a test for that :) 283983 4 dpranke 2010-09-23 14:56:27 -0700 Committed r68202: <http://trac.webkit.org/changeset/68202> 68491 2010-09-22 18:41:26 -0700 2010-09-22 19:49:09 -0700 Patch bug-46331-20100922184125.patch text/plain 3104 dpranke ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiOGY5ODk3ZTZhMjI3ZmMyMDU4YzZlM2FhODlmMTI2YzAyZjY0MzYyLi40ZjRjMDNj ZjJhNmVjNWQxZTEzODhmYWZjNzMxYTgwZTM0ZjBkNWQ4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMDktMjIgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIHRoZSBjb21t ZW50cyB0byBtb3JlIGFjY3VyYXRlbHkgcmVmbGVjdCB3aGljaCB0ZXN0cyB3ZSBleHBlY3QKKyAg ICAgICAgdG8gcnVuIGFuZCBwYXNzLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00NjMzMQorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0tZ3B1 L3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMC0wOS0yMiAgS2ludWtvIFlhc3VkYSAgPGtp bnVrb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdGVtcG9yYXJpbHkgZGlz YWJsaW5nIHRoZSBuZXcgZmlsZXN5c3RlbSB0ZXN0IG9uIGNocm9taXVtLgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0tZ3B1L3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBi L0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLWdwdS90ZXN0X2V4cGVjdGF0aW9ucy50eHQK aW5kZXggZmRkOTViMDgxOWI5YTQ5M2Q0N2Y2YjRmMDFhOTc2MmNjNGIxMmQ0Yi4uMmQ0MzdjNmY2 NThiOWYzNDY1YjRjYmUwYWYwNWE5YTVlMWExMjE5OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vY2hyb21pdW0tZ3B1L3Rlc3RfZXhwZWN0YXRpb25zLnR4dAorKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1ncHUvdGVzdF9leHBlY3RhdGlvbnMudHh0CkBAIC0zLDgg KzMsOCBAQAogLy8gV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC9jaHJvbWl1bV9ncHUucHkKIC8vCiAvLyBXZSBza2lwIG1vc3Qgb2YgdGhlIHRlc3RzIGluIHRo ZSByZXBvc2l0b3J5IGJlY2F1c2UgdGhleSBkb24ndCB0cmlnZ2VyCi0vLyB0aGUgYWNjZWxlcmF0 ZWQgY29kZSBwYXRocy4gV2UgYWN0dWFsbHkgb25seSBydW4gdGhlIGNhbnZhcyBhbmQKLS8vIGNv bXBvc2l0aW5nIHRlc3RzLgorLy8gdGhlIGFjY2VsZXJhdGVkIGNvZGUgcGF0aHMuIFdlIGFjdHVh bGx5IG9ubHkgcnVuIHNvbWUgb2YgdGhlIGNhbnZhcyBhbmQKKy8vIGNvbXBvc2l0aW5nIHRlc3Rz IChhcyBsaXN0ZWQgYmVsb3cpLgogV09OVEZJWCBTS0lQIDogYWNjZXNzaWJpbGl0eSA9IFBBU1Mg RkFJTAogV09OVEZJWCBTS0lQIDogYW5pbWF0aW9ucyA9IFBBU1MgRkFJTAogV09OVEZJWCBTS0lQ IDogY2FudmFzID0gUEFTUyBGQUlMCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cg Yi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggMjBiOGEwNDMwNGUwZWI0YzBjMTA2NTVhMjJm YzUzMGM1ZTFmMGZhYy4uOGJmMmIyYWI4Y2ZmZjI1ODZlYzJkN2IxMDVlMDg1OTY4ODFjMmQwMCAx MDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTA5LTIyICBEaXJrIFByYW5rZSAgPGRwcmFua2VA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE1pbm9yIGNsZWFudXAgLSB1bmNvbW1lbnQgYSBsaW5lIEkgYWNjaWRlbnRhbGx5IGNv bW1lbnRlZCBvdXQgaW4gcjY4MDg1LgorICAgICAgICBOb3Qgc3VyZSBpZiB0aGlzIGFjdHVhbGx5 IGNoYW5nZXMgYW55dGhpbmcgdXNlZnVsLCBhcyBpdCBzaG91bGQgY2F1c2UKKyAgICAgICAgdGhl IHRvb2wgdG8gYnJlYXQgb24gYSBnaXQgY2hlY2tvdXQsIGJ1dCB0aGF0IG5lZWRzIHRvIGJlIHRy YWNrZWQKKyAgICAgICAgYXMgYSBzZXBhcmF0ZSBpc3N1ZS4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDYzMzEKKworICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3JlYmFzZWxpbmVfY2hyb21pdW1fd2Via2l0X3Rlc3RzLnB5 OgorCiAyMDEwLTA5LTIyICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1Ad2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9yZWJhc2VsaW5lX2Nocm9taXVtX3dl YmtpdF90ZXN0cy5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3JlYmFzZWxpbmVfY2hyb21pdW1fd2Via2l0X3Rlc3RzLnB5CmluZGV4IGU1N2NlYjIxNzAwZTVh ZmI3ZjVlYzAzMzE1ZDI4NDI0MWJiODZmZWQuLmRhODRmNDY3NGVkZDU1MzhmZGFmYTY1ODMzMWM1 YTRhODMxMmM5NTAgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3JlYmFzZWxpbmVfY2hyb21pdW1fd2Via2l0X3Rlc3RzLnB5CisrKyBiL1dlYktp dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3JlYmFzZWxpbmVfY2hyb21pdW1f d2Via2l0X3Rlc3RzLnB5CkBAIC01ODksNyArNTg5LDcgQEAgY2xhc3MgUmViYXNlbGluZXIob2Jq ZWN0KToKICAgICAgICAgICAgICMgT3IgaXMgbmV3X2V4cGVjdGF0aW9ucyBhbHdheXMgYSBieXRl IGFycmF5PwogICAgICAgICAgICAgd2l0aCBvcGVuKHBhdGgsICJ3IikgYXMgZmlsZToKICAgICAg ICAgICAgICAgICBmaWxlLndyaXRlKG5ld19leHBlY3RhdGlvbnMpCi0gICAgICAgICAgICAjIHNl bGYuX3NjbS5hZGQocGF0aCkKKyAgICAgICAgICAgIHNlbGYuX3NjbS5hZGQocGF0aCkKICAgICAg ICAgZWxzZToKICAgICAgICAgICAgIF9sb2cuaW5mbygnTm8gdGVzdCB3YXMgcmViYXNlbGluZWQg c28gbm90aGluZyB0byByZW1vdmUuJykKIAo=