46326 2010-09-22 17:53:09 -0700 Crash when trying to create a NodeIterator rooted at a document-less DocumentType node 2019-02-06 09:02:51 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 42959 1 ap ap cdumez darin oldest_to_newest 283410 0 68481 ap 2010-09-22 17:53:09 -0700 Created attachment 68481 test case (will crash) At some point, someone went over WebCore to fix all issues like this. Either we added new ones, or this just fell through cracks. 283894 1 68577 ap 2010-09-23 13:18:52 -0700 Created attachment 68577 proposed fix 283930 2 68577 darin 2010-09-23 14:03:03 -0700 Comment on attachment 68577 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=68577&action=review Since you’re a committer I’ll let you set the commit-queue flag yourself if you decide you don’t want to fix the minor typos and such I mentioned above. > WebCore/ChangeLog:11 > + attach/detach may not be always paired. Tiny grammatical nitpick: "may not always be paired" is better phrasing. > WebCore/dom/Document.cpp:3217 > + // The node iterator can be detached wihtout having been atatched if its root node didn't have a document Typo: "wihtout". Typo: "atatched". > LayoutTests/fast/dom/node-iterator-with-doctype-root.html:31 > +iter Did you put this line in intentionally? If so, what purpose does it serve? Would a comment make that clearer? Would some logging after the fact be helpful? 283935 3 ap 2010-09-23 14:10:38 -0700 > Did you put this line in intentionally? I think I was beginning to write some other subtest, but then decided that it wasn't relevant. This line has no effect, so I removed it. Committed <http://trac.webkit.org/changeset/68195>. 1502857 4 lforschler 2019-02-06 09:02:51 -0800 Mass moving XML DOM bugs to the "DOM" Component. 68481 2010-09-22 17:53:09 -0700 2010-09-22 17:53:09 -0700 test case (will crash) node-iterator-with-null-filter.html text/html 140 ap PHNjcmlwdD4KdmFyIGR0ID0gZG9jdW1lbnQuaW1wbGVtZW50YXRpb24uY3JlYXRlRG9jdW1lbnRU eXBlKCJhIiwgIiIsICIiKTsKYWxlcnQoZG9jdW1lbnQuY3JlYXRlTm9kZUl0ZXJhdG9yKGR0LCAw LCBudWxsLCB0cnVlKSk7Cjwvc2NyaXB0Pgo= 68577 2010-09-23 13:18:52 -0700 2010-09-23 14:05:46 -0700 proposed fix NodeIterator.txt text/plain 6831 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODE4NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDktMjMgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2MzI2CisgICAgICAgIENy YXNoIHdoZW4gdHJ5aW5nIHRvIGNyZWF0ZSBhIE5vZGVJdGVyYXRvciByb290ZWQgYXQgYSBkb2N1 bWVudC1sZXNzIERvY3VtZW50VHlwZSBub2RlCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vbm9k ZS1pdGVyYXRvci13aXRoLWRvY3R5cGUtcm9vdC5odG1sCisKKyAgICAgICAgKiBkb20vRG9jdW1l bnQuY3BwOiAoV2ViQ29yZTo6RG9jdW1lbnQ6OmRldGFjaE5vZGVJdGVyYXRvcik6IEFkZGVkIGEg Y29tbWVudCBleHBsYWluaW5nIHRoYXQKKyAgICAgICAgYXR0YWNoL2RldGFjaCBtYXkgbm90IGJl IGFsd2F5cyBwYWlyZWQuCisKKyAgICAgICAgKiBkb20vTm9kZUl0ZXJhdG9yLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6Ok5vZGVJdGVyYXRvcjo6Tm9kZUl0ZXJhdG9yKTogRG9uJ3QgdHJ5IHRvIHJl Z2lzdGVyIHdpdGggdGhlIGRvY3VtZW50IGlmIHRoZXJlIGlzIG5vbmUuCisgICAgICAgIChXZWJD b3JlOjpOb2RlSXRlcmF0b3I6On5Ob2RlSXRlcmF0b3IpOiBEaXR0by4KKyAgICAgICAgKFdlYkNv cmU6Ok5vZGVJdGVyYXRvcjo6ZGV0YWNoKTogRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpOb2Rl SXRlcmF0b3I6OnVwZGF0ZUZvck5vZGVSZW1vdmFsKTogVGhlcmUgc2hvdWxkIGJlIGEgZG9jdW1l bnQgaWYgd2UncmUgZ2V0dGluZyBhCisgICAgICAgIG5vdGlmaWNhdGlvbi4KKwogMjAxMC0wOS0y MyAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBBZGFtIFJvYmVuLgpJbmRleDogV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkocmV2aXNpb24gNjgxNjcpCisrKyBX ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyMTQsNiArMzIxNCw4 IEBAIHZvaWQgRG9jdW1lbnQ6OmF0dGFjaE5vZGVJdGVyYXRvcihOb2RlSXQKIAogdm9pZCBEb2N1 bWVudDo6ZGV0YWNoTm9kZUl0ZXJhdG9yKE5vZGVJdGVyYXRvciogbmkpCiB7CisgICAgLy8gVGhl IG5vZGUgaXRlcmF0b3IgY2FuIGJlIGRldGFjaGVkIHdpaHRvdXQgaGF2aW5nIGJlZW4gYXRhdGNo ZWQgaWYgaXRzIHJvb3Qgbm9kZSBkaWRuJ3QgaGF2ZSBhIGRvY3VtZW50CisgICAgLy8gd2hlbiB0 aGUgaXRlcmF0b3Igd2FzIGNyZWF0ZWQsIGJ1dCBoYXMgaXQgbm93LgogICAgIG1fbm9kZUl0ZXJh dG9ycy5yZW1vdmUobmkpOwogfQogCkluZGV4OiBXZWJDb3JlL2RvbS9Ob2RlSXRlcmF0b3IuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL05vZGVJdGVyYXRvci5jcHAJKHJldmlzaW9uIDY4 MTY3KQorKysgV2ViQ29yZS9kb20vTm9kZUl0ZXJhdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NzYsMTIgKzc2LDE2IEBAIE5vZGVJdGVyYXRvcjo6Tm9kZUl0ZXJhdG9yKFBhc3NSZWZQdHI8Tm8K ICAgICAsIG1fcmVmZXJlbmNlTm9kZShyb290KCksIHRydWUpCiAgICAgLCBtX2RldGFjaGVkKGZh bHNlKQogewotICAgIHJvb3QoKS0+ZG9jdW1lbnQoKS0+YXR0YWNoTm9kZUl0ZXJhdG9yKHRoaXMp OworICAgIC8vIERvY3VtZW50IHR5cGUgbm9kZXMgbWF5IGhhdmUgYSBudWxsIGRvY3VtZW50LiBC dXQgc2luY2UgdGhleSBjYW4ndCBoYXZlIGNoaWxkcmVuLCB0aGVyZSBpcyBubyBuZWVkIHRvIGxp c3RlbiBmb3IgbW9kaWZpY2F0aW9ucyB0byB0aGVzZS4KKyAgICBBU1NFUlQocm9vdCgpLT5kb2N1 bWVudCgpIHx8IHJvb3QoKS0+bm9kZVR5cGUoKSA9PSBOb2RlOjpET0NVTUVOVF9UWVBFX05PREUp OworICAgIGlmIChEb2N1bWVudCogb3duZXJEb2N1bWVudCA9IHJvb3QoKS0+ZG9jdW1lbnQoKSkK KyAgICAgICAgb3duZXJEb2N1bWVudC0+YXR0YWNoTm9kZUl0ZXJhdG9yKHRoaXMpOwogfQogCiBO b2RlSXRlcmF0b3I6On5Ob2RlSXRlcmF0b3IoKQogewotICAgIHJvb3QoKS0+ZG9jdW1lbnQoKS0+ ZGV0YWNoTm9kZUl0ZXJhdG9yKHRoaXMpOworICAgIGlmIChEb2N1bWVudCogb3duZXJEb2N1bWVu dCA9IHJvb3QoKS0+ZG9jdW1lbnQoKSkKKyAgICAgICAgb3duZXJEb2N1bWVudC0+ZGV0YWNoTm9k ZUl0ZXJhdG9yKHRoaXMpOwogfQogCiBQYXNzUmVmUHRyPE5vZGU+IE5vZGVJdGVyYXRvcjo6bmV4 dE5vZGUoU2NyaXB0U3RhdGUqIHN0YXRlLCBFeGNlcHRpb25Db2RlJiBlYykKQEAgLTE0NCw3ICsx NDgsOCBAQCBQYXNzUmVmUHRyPE5vZGU+IE5vZGVJdGVyYXRvcjo6cHJldmlvdXNOCiAKIHZvaWQg Tm9kZUl0ZXJhdG9yOjpkZXRhY2goKQogewotICAgIHJvb3QoKS0+ZG9jdW1lbnQoKS0+ZGV0YWNo Tm9kZUl0ZXJhdG9yKHRoaXMpOworICAgIGlmIChEb2N1bWVudCogb3duZXJEb2N1bWVudCA9IHJv b3QoKS0+ZG9jdW1lbnQoKSkKKyAgICAgICAgb3duZXJEb2N1bWVudC0+ZGV0YWNoTm9kZUl0ZXJh dG9yKHRoaXMpOwogICAgIG1fZGV0YWNoZWQgPSB0cnVlOwogICAgIG1fcmVmZXJlbmNlTm9kZS5u b2RlLmNsZWFyKCk7CiB9CkBAIC0xNTksNiArMTY0LDcgQEAgdm9pZCBOb2RlSXRlcmF0b3I6OnVw ZGF0ZUZvck5vZGVSZW1vdmFsKAogewogICAgIEFTU0VSVCghbV9kZXRhY2hlZCk7CiAgICAgQVNT RVJUKHJlbW92ZWROb2RlKTsKKyAgICBBU1NFUlQocm9vdCgpLT5kb2N1bWVudCgpKTsKICAgICBB U1NFUlQocm9vdCgpLT5kb2N1bWVudCgpID09IHJlbW92ZWROb2RlLT5kb2N1bWVudCgpKTsKIAog ICAgIC8vIEl0ZXJhdG9yIGlzIG5vdCBhZmZlY3RlZCBpZiB0aGUgcmVtb3ZlZCBub2RlIGlzIHRo ZSByZWZlcmVuY2Ugbm9kZSBhbmQgaXMgdGhlIHJvb3QuCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2ODE4 NSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEz IEBACisyMDEwLTA5LTIzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjMyNgorICAgICAgICBDcmFzaCB3aGVuIHRy eWluZyB0byBjcmVhdGUgYSBOb2RlSXRlcmF0b3Igcm9vdGVkIGF0IGEgZG9jdW1lbnQtbGVzcyBE b2N1bWVudFR5cGUgbm9kZQorCisgICAgICAgICogZmFzdC9kb20vbm9kZS1pdGVyYXRvci13aXRo LWRvY3R5cGUtcm9vdC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL25v ZGUtaXRlcmF0b3Itd2l0aC1kb2N0eXBlLXJvb3QuaHRtbDogQWRkZWQuCisKIDIwMTAtMDktMjMg IEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgU2ltb24gRnJhc2VyCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9ub2RlLWl0ZXJh dG9yLXdpdGgtZG9jdHlwZS1yb290LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9ub2RlLWl0ZXJhdG9yLXdpdGgtZG9jdHlwZS1yb290LWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL25vZGUtaXRlcmF0b3Itd2l0 aC1kb2N0eXBlLXJvb3QtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE3IEBA CitOb2RlSXRlcmF0b3Igcm9vdGVkIGF0IGEgRG9jdW1lbnRUeXBlIG5vZGUgbm90IHlldCBhc3Nv Y2lhdGVkIHdpdGggYSBkb2N1bWVudDoKK1BBU1MgaXRlci5yZWZlcmVuY2VOb2RlLm93bmVyRG9j dW1lbnQgaXMgbnVsbAorUEFTUyBpdGVyLm5leHROb2RlKCkgaXMgZHQKK1BBU1MgaXRlci5uZXh0 Tm9kZSgpIGlzIG51bGwKK1BBU1MgaXRlci5wcmV2aW91c05vZGUoKSBpcyBkdAorUEFTUyBpdGVy LnByZXZpb3VzTm9kZSgpIGlzIG51bGwKKworTm9kZUl0ZXJhdG9yIHJvb3RlZCBhdCBhIERvY3Vt ZW50VHlwZSBub2RlIHRoYXQgYmVjb21lcyB1c2VkIGJ5IGEgZG9jdW1lbnQgYWZ0ZXIgdGhlIGl0 ZXJhdG9yIGhhcyBiZWVuIGNyZWF0ZWQ6CitQQVNTIGl0ZXIubmV4dE5vZGUoKSBpcyBkdAorUEFT UyBpdGVyLnByZXZpb3VzTm9kZSgpIGlzIGR0CisuLmFuZCBhZnRlciByZW1vdmluZyBpdCBmcm9t IHRoZSBkb2N1bWVudDoKK1BBU1MgaXRlci5uZXh0Tm9kZSgpIGlzIGR0CitQQVNTIGl0ZXIucHJl dmlvdXNOb2RlKCkgaXMgZHQKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVT VCBDT01QTEVURQorCgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9u b2RlLWl0ZXJhdG9yLXdpdGgtZG9jdHlwZS1yb290LWV4cGVjdGVkLnR4dApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFk ZGVkOiBzdm46bWltZS10eXBlCiAgICsgdGV4dC9wbGFpbgpBZGRlZDogc3ZuOmVvbC1zdHlsZQog ICArIG5hdGl2ZQoKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL25vZGUtaXRlcmF0b3Itd2l0 aC1kb2N0eXBlLXJvb3QuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9u b2RlLWl0ZXJhdG9yLXdpdGgtZG9jdHlwZS1yb290Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9mYXN0L2RvbS9ub2RlLWl0ZXJhdG9yLXdpdGgtZG9jdHlwZS1yb290Lmh0bWwJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsMzcgQEAKKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0 eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2Ny aXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVh ZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48 L2Rpdj4KKzxzY3JpcHQ+Cit2YXIgZHQgPSBkb2N1bWVudC5pbXBsZW1lbnRhdGlvbi5jcmVhdGVE b2N1bWVudFR5cGUoImZvbyIsICIiLCAiIik7Cit2YXIgaXRlciA9IGRvY3VtZW50LmNyZWF0ZU5v ZGVJdGVyYXRvcihkdCwgTm9kZUZpbHRlci5TSE9XX0FMTCwgbnVsbCwgdHJ1ZSk7CitkZWJ1Zygi Tm9kZUl0ZXJhdG9yIHJvb3RlZCBhdCBhIERvY3VtZW50VHlwZSBub2RlIG5vdCB5ZXQgYXNzb2Np YXRlZCB3aXRoIGEgZG9jdW1lbnQ6Iik7CitzaG91bGRCZSgnaXRlci5yZWZlcmVuY2VOb2RlLm93 bmVyRG9jdW1lbnQnLCAnbnVsbCcpOworc2hvdWxkQmUoJ2l0ZXIubmV4dE5vZGUoKScsICdkdCcp Oworc2hvdWxkQmUoJ2l0ZXIubmV4dE5vZGUoKScsICdudWxsJyk7CitzaG91bGRCZSgnaXRlci5w cmV2aW91c05vZGUoKScsICdkdCcpOworc2hvdWxkQmUoJ2l0ZXIucHJldmlvdXNOb2RlKCknLCAn bnVsbCcpOworaXRlci5kZXRhY2goKTsKKworaXRlciA9IGRvY3VtZW50LmNyZWF0ZU5vZGVJdGVy YXRvcihkdCwgTm9kZUZpbHRlci5TSE9XX0FMTCwgbnVsbCwgdHJ1ZSk7Cit2YXIgZCA9IGRvY3Vt ZW50LmltcGxlbWVudGF0aW9uLmNyZWF0ZURvY3VtZW50KG51bGwsICJkb2MiLCBkdCk7CitkZWJ1 ZygiXG5Ob2RlSXRlcmF0b3Igcm9vdGVkIGF0IGEgRG9jdW1lbnRUeXBlIG5vZGUgdGhhdCBiZWNv bWVzIHVzZWQgYnkgYSBkb2N1bWVudCBhZnRlciB0aGUgaXRlcmF0b3IgaGFzIGJlZW4gY3JlYXRl ZDoiKTsKK3Nob3VsZEJlKCdpdGVyLm5leHROb2RlKCknLCAnZHQnKTsKK3Nob3VsZEJlKCdpdGVy LnByZXZpb3VzTm9kZSgpJywgJ2R0Jyk7CitkZWJ1ZygiLi5hbmQgYWZ0ZXIgcmVtb3ZpbmcgaXQg ZnJvbSB0aGUgZG9jdW1lbnQ6Iik7CitkLnJlbW92ZUNoaWxkKGR0KTsKK3Nob3VsZEJlKCdpdGVy Lm5leHROb2RlKCknLCAnZHQnKTsKK3Nob3VsZEJlKCdpdGVyLnByZXZpb3VzTm9kZSgpJywgJ2R0 Jyk7CitpdGVyLmRldGFjaCgpOworCitpdGVyCisKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0 cnVlOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9z dC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBM YXlvdXRUZXN0cy9mYXN0L2RvbS9ub2RlLWl0ZXJhdG9yLXdpdGgtZG9jdHlwZS1yb290Lmh0bWwK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpBZGRlZDogc3ZuOm1pbWUtdHlwZQogICArIHRleHQvaHRtbAoK