46321 2010-09-22 16:57:23 -0700 [BREWMP] Enable touch events 2010-09-22 22:15:49 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 skyul webkit-unassigned commit-queue maniagoon oldest_to_newest 283371 0 skyul 2010-09-22 16:57:23 -0700 Enable TOUCH_EVENTS by porting PlatformTouchEvent and PlatformTouchPoint. Brew MP does not support multi touch, so enable only single touch for now. NOTE: In Brew MP 1.1.0.xxx, there are multi touch events: EVT_POINTER_MT_DOWN, EVT_POINTER_MT_MOVE and EVT_POINTER_MT_UP. Unfortunately, this version is not yet available to the public. 283373 1 68473 skyul 2010-09-22 17:00:08 -0700 Created attachment 68473 Patch 283489 2 68473 abarth 2010-09-22 20:47:58 -0700 Comment on attachment 68473 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68473&action=review > WebCore/platform/brew/PlatformTouchPointBrew.cpp:37 > + , m_pos(windowPos) { } These braces should be on separate lines. 283521 3 68473 commit-queue 2010-09-22 22:15:45 -0700 Comment on attachment 68473 Patch Clearing flags on attachment: 68473 Committed r68123: <http://trac.webkit.org/changeset/68123> 283522 4 commit-queue 2010-09-22 22:15:49 -0700 All reviewed patches have been landed. Closing bug. 68473 2010-09-22 17:00:08 -0700 2010-09-22 22:15:45 -0700 Patch touch.patch text/plain 7260 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODA5OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMDktMjIgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbQlJFV01QXSBFbmFibGUgdG91Y2ggZXZlbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjMyMQorCisgICAgICAgIEVuYWJsZSBUT1VDSF9FVkVO VFMgYnkgcG9ydGluZyBQbGF0Zm9ybVRvdWNoRXZlbnQgYW5kIFBsYXRmb3JtVG91Y2hQb2ludC4K KyAgICAgICAgQnJldyBNUCBkb2VzIG5vdCBzdXBwb3J0IG11bHRpIHRvdWNoLCBzbyBlbmFibGUg b25seSBzaW5nbGUgdG91Y2ggZm9yIG5vdy4KKworICAgICAgICAqIHBsYXRmb3JtL1BsYXRmb3Jt VG91Y2hFdmVudC5oOgorICAgICAgICAqIHBsYXRmb3JtL1BsYXRmb3JtVG91Y2hQb2ludC5oOgor ICAgICAgICAqIHBsYXRmb3JtL2JyZXcvUGxhdGZvcm1Ub3VjaEV2ZW50QnJldy5jcHA6IEFkZGVk LgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1Ub3VjaEV2ZW50OjpQbGF0Zm9ybVRvdWNoRXZl bnQpOgorICAgICAgICAqIHBsYXRmb3JtL2JyZXcvUGxhdGZvcm1Ub3VjaFBvaW50QnJldy5jcHA6 IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1Ub3VjaFBvaW50OjpQbGF0Zm9ybVRv dWNoUG9pbnQpOgorCiAyMDEwLTA5LTIyICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBXZWJDb3JlL3Bs YXRmb3JtL1BsYXRmb3JtVG91Y2hFdmVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZv cm0vUGxhdGZvcm1Ub3VjaEV2ZW50LmgJKHJldmlzaW9uIDY4MDU3KQorKysgV2ViQ29yZS9wbGF0 Zm9ybS9QbGF0Zm9ybVRvdWNoRXZlbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMzUsNiArMzUsMTIg QEAgUVRfRU5EX05BTUVTUEFDRQogI2luY2x1ZGUgIkludFBvaW50LmgiCiAjZW5kaWYKIAorI2lm IFBMQVRGT1JNKEJSRVdNUCkKK3R5cGVkZWYgdW5zaWduZWQgc2hvcnQgICAgdWludDE2OwordHlw ZWRlZiB1bnNpZ25lZCBsb25nIGludCB1aW50MzI7CisjZGVmaW5lIEFFRUV2ZW50IHVpbnQxNgor I2VuZGlmCisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogZW51bSBUb3VjaEV2ZW50VHlwZSB7CkBA IC01Nyw2ICs2Myw4IEBAIHB1YmxpYzoKICAgICBQbGF0Zm9ybVRvdWNoRXZlbnQoUVRvdWNoRXZl bnQqKTsKICNlbGlmIFBMQVRGT1JNKEFORFJPSUQpCiAgICAgUGxhdGZvcm1Ub3VjaEV2ZW50KGNv bnN0IEludFBvaW50JiB3aW5kb3dQb3MsIFRvdWNoRXZlbnRUeXBlLCBQbGF0Zm9ybVRvdWNoUG9p bnQ6OlN0YXRlLCBpbnQgbWV0YVN0YXRlKTsKKyNlbGlmIFBMQVRGT1JNKEJSRVdNUCkKKyAgICBQ bGF0Zm9ybVRvdWNoRXZlbnQoQUVFRXZlbnQsIHVpbnQxNiB3UGFyYW0sIHVpbnQzMiBkd1BhcmFt KTsKICNlbmRpZgogCiAgICAgVG91Y2hFdmVudFR5cGUgdHlwZSgpIGNvbnN0IHsgcmV0dXJuIG1f dHlwZTsgfQpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9QbGF0Zm9ybVRvdWNoUG9pbnQuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtVG91Y2hQb2ludC5oCShyZXZpc2lv biA2ODA1NykKKysrIFdlYkNvcmUvcGxhdGZvcm0vUGxhdGZvcm1Ub3VjaFBvaW50LmgJKHdvcmtp bmcgY29weSkKQEAgLTQ4LDYgKzQ4LDggQEAgcHVibGljOgogICAgIFBsYXRmb3JtVG91Y2hQb2lu dCgpIHt9OwogI2VsaWYgUExBVEZPUk0oQU5EUk9JRCkKICAgICBQbGF0Zm9ybVRvdWNoUG9pbnQo Y29uc3QgSW50UG9pbnQmIHdpbmRvd1BvcywgU3RhdGUpOworI2VsaWYgUExBVEZPUk0oQlJFV01Q KQorICAgIFBsYXRmb3JtVG91Y2hQb2ludChpbnQgaWQsIGNvbnN0IEludFBvaW50JiB3aW5kb3dQ b3MsIFN0YXRlKTsKICNlbmRpZgogCiAgICAgdW5zaWduZWQgaWQoKSBjb25zdCB7IHJldHVybiBt X2lkOyB9CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2JyZXcvUGxhdGZvcm1Ub3VjaEV2ZW50QnJl dy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9icmV3L1BsYXRmb3JtVG91Y2hF dmVudEJyZXcuY3BwCShyZXZpc2lvbiAwKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9icmV3L1BsYXRm b3JtVG91Y2hFdmVudEJyZXcuY3BwCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDc2IEBACisvKgor ICogQ29weXJpZ2h0IDIwMTAsIENvbXBhbnkgMTAwLCBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQu CisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jt cywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlk ZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6CisgKiAgKiBSZWRp c3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdo dAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2lu ZyBkaXNjbGFpbWVyLgorICogICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3Qg cmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9m IGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRv Y3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0 cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJ R0hUIEhPTERFUlMgYGBBUyBJUycnIEFORCBBTlkKKyAqIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJS QU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFCisgKiBJTVBMSUVEIFdB UlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIK KyAqIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuICBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJ R0hUIE9XTkVSIE9SCisgKiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJ TkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwKKyAqIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVO VElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyAqIFBST0NVUkVN RU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBP UgorICogUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBB TkQgT04gQU5ZIFRIRU9SWQorICogT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBT VFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RI RVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09G VFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0Uu CisgKi8KKworI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIlBsYXRmb3JtVG91Y2hFdmVu dC5oIgorCisjaW5jbHVkZSA8QUVFRXZlbnQuaD4KKyNpbmNsdWRlIDxBRUVQb2ludGVySGVscGVy cy5oPgorI2luY2x1ZGUgPEFFRVZDb2Rlcy5oPgorCisjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykK KworbmFtZXNwYWNlIFdlYkNvcmUgeworCitQbGF0Zm9ybVRvdWNoRXZlbnQ6OlBsYXRmb3JtVG91 Y2hFdmVudChBRUVFdmVudCBldmVudCwgdWludDE2IHdQYXJhbSwgdWludDMyIGR3UGFyYW0pCisg ICAgOiBtX21ldGFLZXkoZmFsc2UpCit7CisgICAgUGxhdGZvcm1Ub3VjaFBvaW50OjpTdGF0ZSBz dGF0ZTsKKworICAgIHN3aXRjaCAoZXZlbnQpIHsKKyAgICBjYXNlIEVWVF9QT0lOVEVSX0RPV046 CisgICAgICAgIG1fdHlwZSA9IFRvdWNoU3RhcnQ7CisgICAgICAgIHN0YXRlID0gUGxhdGZvcm1U b3VjaFBvaW50OjpUb3VjaFByZXNzZWQ7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgRVZUX1BP SU5URVJfVVA6CisgICAgICAgIG1fdHlwZSA9IFRvdWNoRW5kOworICAgICAgICBzdGF0ZSA9IFBs YXRmb3JtVG91Y2hQb2ludDo6VG91Y2hSZWxlYXNlZDsKKyAgICAgICAgYnJlYWs7CisgICAgY2Fz ZSBFVlRfUE9JTlRFUl9NT1ZFOgorICAgIGNhc2UgRVZUX1BPSU5URVJfU1RBTEVfTU9WRToKKyAg ICAgICAgbV90eXBlID0gVG91Y2hNb3ZlOworICAgICAgICBzdGF0ZSA9IFBsYXRmb3JtVG91Y2hQ b2ludDo6VG91Y2hNb3ZlZDsKKyAgICAgICAgYnJlYWs7CisgICAgZGVmYXVsdDoKKyAgICAgICAg QVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgfQorCisgICAgY2hhciogZHdQYXJhbVN0ciA9IHJl aW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KGR3UGFyYW0pOworICAgIGludCB4LCB5OworICAgIEFFRV9Q T0lOVEVSX0dFVF9YWShkd1BhcmFtU3RyLCAmeCwgJnkpOworICAgIEludFBvaW50IHdpbmRvd1Bv cyA9IEludFBvaW50KHgsIHkpOworCisgICAgaW50IGlkID0gQUVFX1BPSU5URVJfR0VUX1BUUklE KGR3UGFyYW1TdHIpOworICAgIG1fdG91Y2hQb2ludHMuYXBwZW5kKFBsYXRmb3JtVG91Y2hQb2lu dChpZCwgd2luZG93UG9zLCBzdGF0ZSkpOworCisgICAgdWludDMyIGtleU1vZGlmaWVycyA9IEFF RV9QT0lOVEVSX0dFVF9LRVlfTU9ESUZJRVJTKGR3UGFyYW1TdHIpOworICAgIG1fYWx0S2V5ICAg PSBrZXlNb2RpZmllcnMgJiAoS0JfTEFMVCB8IEtCX1JBTFQpOworICAgIG1fc2hpZnRLZXkgPSBr ZXlNb2RpZmllcnMgJiAoS0JfTFNISUZUIHwgS0JfUlNISUZUKTsKKyAgICBtX2N0cmxLZXkgID0g a2V5TW9kaWZpZXJzICYgKEtCX0xDVFJMIHwgS0JfUkNUUkwpOworfQorCit9CisKKyNlbmRpZgpJ bmRleDogV2ViQ29yZS9wbGF0Zm9ybS9icmV3L1BsYXRmb3JtVG91Y2hQb2ludEJyZXcuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vYnJldy9QbGF0Zm9ybVRvdWNoUG9pbnRCcmV3 LmNwcAkocmV2aXNpb24gMCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vYnJldy9QbGF0Zm9ybVRvdWNo UG9pbnRCcmV3LmNwcAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0MSBAQAorLyoKKyAqIENvcHly aWdodCAyMDEwLCBDb21wYW55IDEwMCwgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICoKKyAq IFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGgg b3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQg dGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisgKiBhcmUgbWV0OgorICogICogUmVkaXN0cmlidXRp b25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAg IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xh aW1lci4KKyAqICAqIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVj ZSB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRp b25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisgKiAgICBkb2N1bWVudGF0 aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9u LgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xE RVJTIGBgQVMgSVMnJyBBTkQgQU5ZCisgKiBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywg SU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRQorICogSU1QTElFRCBXQVJSQU5USUVT IE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSCisgKiBQVVJQ T1NFIEFSRSBESVNDTEFJTUVELiAgSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlSSUdIVCBPV05F UiBPUgorICogQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1Qs IElOQ0lERU5UQUwsIFNQRUNJQUwsCisgKiBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFN QUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCisgKiBQUk9DVVJFTUVOVCBPRiBT VUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwgT1IKKyAqIFBS T0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFO WSBUSEVPUlkKKyAqIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJ QUJJTElUWSwgT1IgVE9SVAorICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkg QVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisgKiBPRiBUSElTIFNPRlRXQVJFLCBF VkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICovCisK KyNpbmNsdWRlICJjb25maWcuaCIKKyNpbmNsdWRlICJQbGF0Zm9ybVRvdWNoUG9pbnQuaCIKKwor I2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCisKK25hbWVzcGFjZSBXZWJDb3JlIHsKKworUGxhdGZv cm1Ub3VjaFBvaW50OjpQbGF0Zm9ybVRvdWNoUG9pbnQoaW50IGlkLCBjb25zdCBJbnRQb2ludCYg d2luZG93UG9zLCBTdGF0ZSBzdGF0ZSkKKyAgICA6IG1faWQoaWQpCisgICAgLCBtX3N0YXRlKHN0 YXRlKQorICAgICwgbV9zY3JlZW5Qb3Mod2luZG93UG9zKQorICAgICwgbV9wb3Mod2luZG93UG9z KSB7IH0KKworfQorCisjZW5kaWYK