46307 2010-09-22 14:05:37 -0700 Create one time initialization block for WebView's initWithFrame 2010-09-23 06:37:18 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P5 Trivial --- 45362 1 mdelaney7 mdelaney7 aroben commit-queue oldest_to_newest 283239 0 mdelaney7 2010-09-22 14:05:37 -0700 There is a block of one time initialization code in WebView.cpp's initWithFrame that doesn't need to to be run for each new WebView and could be wrapped in a one time run block. 283264 1 68446 mdelaney7 2010-09-22 14:50:15 -0700 Created attachment 68446 Patch 283267 2 68446 aroben 2010-09-22 14:53:06 -0700 Comment on attachment 68446 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68446&action=review > WebKit/win/WebView.cpp:2564 > + static bool didOneTimeInitialization = false; No need for the " = false". That happens automatically. 283269 3 68447 mdelaney7 2010-09-22 14:58:05 -0700 Created attachment 68447 update per comments Addressed comment. 283270 4 68447 aroben 2010-09-22 14:59:07 -0700 Comment on attachment 68447 update per comments Going to wait for the EWS bot to look at this before I cq+ it. 283573 5 68446 eric 2010-09-23 03:18:56 -0700 Comment on attachment 68446 Patch Cleared Adam Roben's review+ from obsolete attachment 68446 so that this bug does not appear in http://webkit.org/pending-commit. 283597 6 68447 commit-queue 2010-09-23 06:37:13 -0700 Comment on attachment 68447 update per comments Clearing flags on attachment: 68447 Committed r68133: <http://trac.webkit.org/changeset/68133> 283598 7 commit-queue 2010-09-23 06:37:18 -0700 All reviewed patches have been landed. Closing bug. 68446 2010-09-22 14:50:15 -0700 2010-09-23 03:18:56 -0700 Patch bug-46307-20100922145014.patch text/plain 1671 mdelaney7 SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiA2ODA4NCkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDktMjIgIE1hdHRoZXcgRGVsYW5leSAgPG1k ZWxhbmV5QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDcmVhdGUgb25lIHRpbWUgaW5pdGlhbGl6YXRpb24gYmxvY2sgZm9yIFdlYlZp ZXcncyBpbml0V2l0aEZyYW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00NjMwNworCisgICAgICAgICogV2ViVmlldy5jcHA6IEFkZGVkIG9uZSB0aW1l IGluaXRpYWxpemF0aW9uIGJsb2NrIGZvciB3ZWJ2aWV3IGNvZGUKKyAgICAgICAgdGhhdCBuZWVk cyBvbmx5IGJlIHJ1biBvbmNlIGFuZCBub3QgZm9yIGVhY2ggd2Vidmlldy4gVGhpcyBpcyBqdXN0 IGFzCisgICAgICAgIHRoZSBtYWMgdmVyc2lvbiBXZWJWaWV3Lm1tIGRvZXMuCisKIDIwMTAtMDkt MjIgIEJhbGF6cyBLZWxlbWVuICA8a2JAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFJldmll d2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpJbmRleDogV2ViS2l0L3dpbi9XZWJW aWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvd2luL1dlYlZpZXcuY3BwCShyZXZpc2lvbiA2 Nzc1OSkKKysrIFdlYktpdC93aW4vV2ViVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI1NjEs MTIgKzI1NjEsMTcgQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBXZWJWaWV3Ojppbml0Vwog ICAgIHNoYXJlZFByZWZlcmVuY2VzLT53aWxsQWRkVG9XZWJWaWV3KCk7CiAgICAgbV9wcmVmZXJl bmNlcyA9IHNoYXJlZFByZWZlcmVuY2VzOwogCi0gICAgSW5pdGlhbGl6ZUxvZ2dpbmdDaGFubmVs c0lmTmVjZXNzYXJ5KCk7CisgICAgc3RhdGljIGJvb2wgZGlkT25lVGltZUluaXRpYWxpemF0aW9u ID0gZmFsc2U7CisgICAgaWYgKCFkaWRPbmVUaW1lSW5pdGlhbGl6YXRpb24pIHsKKyAgICAgICAg SW5pdGlhbGl6ZUxvZ2dpbmdDaGFubmVsc0lmTmVjZXNzYXJ5KCk7CiAjaWYgRU5BQkxFKERBVEFC QVNFKQotICAgIFdlYktpdEluaXRpYWxpemVXZWJEYXRhYmFzZXNJZk5lY2Vzc2FyeSgpOworICAg ICAgICBXZWJLaXRJbml0aWFsaXplV2ViRGF0YWJhc2VzSWZOZWNlc3NhcnkoKTsKICNlbmRpZgot ICAgIFdlYktpdFNldEFwcGxpY2F0aW9uQ2FjaGVQYXRoSWZOZWNlc3NhcnkoKTsKLSAgICBXZWJQ bGF0Zm9ybVN0cmF0ZWdpZXM6OmluaXRpYWxpemUoKTsKKyAgICAgICAgV2ViS2l0U2V0QXBwbGlj YXRpb25DYWNoZVBhdGhJZk5lY2Vzc2FyeSgpOworICAgICAgICBXZWJQbGF0Zm9ybVN0cmF0ZWdp ZXM6OmluaXRpYWxpemUoKTsKKworICAgICAgICBkaWRPbmVUaW1lSW5pdGlhbGl6YXRpb24gPSB0 cnVlOworICAgICB9CiAKICNpZiBVU0UoU0FGQVJJX1RIRU1FKQogICAgIEJPT0wgc2hvdWxkUGFp bnROYXRpdmVDb250cm9sczsK 68447 2010-09-22 14:58:05 -0700 2010-09-23 06:37:13 -0700 update per comments oneTimeBlockwoFalse.patch text/plain 1663 mdelaney7 SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiA2ODA4NCkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDktMjIgIE1hdHRoZXcgRGVsYW5leSAgPG1k ZWxhbmV5QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDcmVhdGUgb25lIHRpbWUgaW5pdGlhbGl6YXRpb24gYmxvY2sgZm9yIFdlYlZp ZXcncyBpbml0V2l0aEZyYW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00NjMwNworCisgICAgICAgICogV2ViVmlldy5jcHA6IEFkZGVkIG9uZSB0aW1l IGluaXRpYWxpemF0aW9uIGJsb2NrIGZvciB3ZWJ2aWV3IGNvZGUKKyAgICAgICAgdGhhdCBuZWVk cyBvbmx5IGJlIHJ1biBvbmNlIGFuZCBub3QgZm9yIGVhY2ggd2Vidmlldy4gVGhpcyBpcyBqdXN0 IGFzCisgICAgICAgIHRoZSBtYWMgdmVyc2lvbiBXZWJWaWV3Lm1tIGRvZXMuCisKIDIwMTAtMDkt MjIgIEJhbGF6cyBLZWxlbWVuICA8a2JAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFJldmll d2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpJbmRleDogV2ViS2l0L3dpbi9XZWJW aWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvd2luL1dlYlZpZXcuY3BwCShyZXZpc2lvbiA2 Nzc1OSkKKysrIFdlYktpdC93aW4vV2ViVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI1NjEs MTIgKzI1NjEsMTcgQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBXZWJWaWV3Ojppbml0Vwog ICAgIHNoYXJlZFByZWZlcmVuY2VzLT53aWxsQWRkVG9XZWJWaWV3KCk7CiAgICAgbV9wcmVmZXJl bmNlcyA9IHNoYXJlZFByZWZlcmVuY2VzOwogCi0gICAgSW5pdGlhbGl6ZUxvZ2dpbmdDaGFubmVs c0lmTmVjZXNzYXJ5KCk7CisgICAgc3RhdGljIGJvb2wgZGlkT25lVGltZUluaXRpYWxpemF0aW9u OworICAgIGlmICghZGlkT25lVGltZUluaXRpYWxpemF0aW9uKSB7CisgICAgICAgIEluaXRpYWxp emVMb2dnaW5nQ2hhbm5lbHNJZk5lY2Vzc2FyeSgpOwogI2lmIEVOQUJMRShEQVRBQkFTRSkKLSAg ICBXZWJLaXRJbml0aWFsaXplV2ViRGF0YWJhc2VzSWZOZWNlc3NhcnkoKTsKKyAgICAgICAgV2Vi S2l0SW5pdGlhbGl6ZVdlYkRhdGFiYXNlc0lmTmVjZXNzYXJ5KCk7CiAjZW5kaWYKLSAgICBXZWJL aXRTZXRBcHBsaWNhdGlvbkNhY2hlUGF0aElmTmVjZXNzYXJ5KCk7Ci0gICAgV2ViUGxhdGZvcm1T dHJhdGVnaWVzOjppbml0aWFsaXplKCk7CisgICAgICAgIFdlYktpdFNldEFwcGxpY2F0aW9uQ2Fj aGVQYXRoSWZOZWNlc3NhcnkoKTsKKyAgICAgICAgV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjppbml0 aWFsaXplKCk7CisKKyAgICAgICAgZGlkT25lVGltZUluaXRpYWxpemF0aW9uID0gdHJ1ZTsKKyAg ICAgfQogCiAjaWYgVVNFKFNBRkFSSV9USEVNRSkKICAgICBCT09MIHNob3VsZFBhaW50TmF0aXZl Q29udHJvbHM7Cg==