46298 2010-09-22 13:18:13 -0700 Add logicalWidth/Height getters and setters to RenderBox 2010-09-22 13:27:39 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 46123 1 hyatt hyatt oldest_to_newest 283192 0 hyatt 2010-09-22 13:18:13 -0700 Add logicalWidth/Height getters and setters to RenderBox. 283196 1 68428 hyatt 2010-09-22 13:22:43 -0700 Created attachment 68428 Patch 283200 2 68428 mitz 2010-09-22 13:24:42 -0700 Comment on attachment 68428 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68428&action=review > WebCore/rendering/RenderBox.cpp:90 > + if (style()->isVerticalBlockFlow()) > + return width(); > + return height(); Maybe now it’s too late to say this, but how about return style()->isVerticalBlockFlow() ? width() : height(); instead? 283201 3 hyatt 2010-09-22 13:26:56 -0700 (In reply to comment #2) > (From update of attachment 68428 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=68428&action=review > > > WebCore/rendering/RenderBox.cpp:90 > > + if (style()->isVerticalBlockFlow()) > > + return width(); > > + return height(); > > Maybe now it’s too late to say this, but how about > return style()->isVerticalBlockFlow() ? width() : height(); > instead? Not too late. :) 283202 4 hyatt 2010-09-22 13:27:39 -0700 Fixed in r68077. 68428 2010-09-22 13:22:43 -0700 2010-09-22 13:24:42 -0700 Patch patch.txt text/plain 2542 hyatt SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODA3NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDktMjIgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjI5OCwgYWRkIGxvZ2ljYWxXaWR0 aC9IZWlnaHQgZ2V0dGVycy9zZXR0ZXJzIHRvIFJlbmRlckJveC4KKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94Ojpsb2dpY2Fs V2lkdGgpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94Ojpsb2dpY2FsSGVpZ2h0KToKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6c2V0TG9naWNhbFdpZHRoKToKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlckJveDo6c2V0TG9naWNhbEhlaWdodCk6CisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckJveC5oOgorCiAyMDEwLTA5LTIyICBMdWl6IEFnb3N0aW5pICA8bHVpei5hZ29zdGlu aUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpJbmRl eDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCShyZXZpc2lvbiA2Nzk2NCkKKysrIFdlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJveC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgzLDYgKzgzLDM2IEBAIFJl bmRlckJveDo6flJlbmRlckJveCgpCiB7CiB9CiAKK2ludCBSZW5kZXJCb3g6OmxvZ2ljYWxXaWR0 aCgpIGNvbnN0Cit7CisgICAgaWYgKHN0eWxlKCktPmlzVmVydGljYWxCbG9ja0Zsb3coKSkKKyAg ICAgICAgcmV0dXJuIHdpZHRoKCk7CisgICAgcmV0dXJuIGhlaWdodCgpOworfQorCitpbnQgUmVu ZGVyQm94Ojpsb2dpY2FsSGVpZ2h0KCkgY29uc3QKK3sKKyAgICBpZiAoc3R5bGUoKS0+aXNWZXJ0 aWNhbEJsb2NrRmxvdygpKQorICAgICAgICByZXR1cm4gaGVpZ2h0KCk7CisgICAgcmV0dXJuIHdp ZHRoKCk7Cit9CisKK3ZvaWQgUmVuZGVyQm94OjpzZXRMb2dpY2FsV2lkdGgoaW50IHNpemUpCit7 CisgICAgaWYgKHN0eWxlKCktPmlzVmVydGljYWxCbG9ja0Zsb3coKSkKKyAgICAgICAgc2V0V2lk dGgoc2l6ZSk7CisgICAgZWxzZQorICAgICAgICBzZXRIZWlnaHQoc2l6ZSk7Cit9CisKK3ZvaWQg UmVuZGVyQm94OjpzZXRMb2dpY2FsSGVpZ2h0KGludCBzaXplKQoreworICAgIGlmIChzdHlsZSgp LT5pc1ZlcnRpY2FsQmxvY2tGbG93KCkpCisgICAgICAgIHNldEhlaWdodChzaXplKTsKKyAgICBl bHNlCisgICAgICAgIHNldFdpZHRoKHNpemUpOworfQorCiBpbnQgUmVuZGVyQm94OjptYXJnaW5C ZWZvcmUoKSBjb25zdAogewogICAgIHN3aXRjaCAoc3R5bGUoKS0+YmxvY2tGbG93KCkpIHsKSW5k ZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJveC5oCShyZXZpc2lvbiA2Nzk2NCkKKysrIFdlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJveC5oCSh3b3JraW5nIGNvcHkpCkBAIC00NCwxMSArNDQsMTYgQEAgcHVibGlj OgogICAgIGludCB5KCkgY29uc3QgeyByZXR1cm4gbV9mcmFtZVJlY3QueSgpOyB9CiAgICAgaW50 IHdpZHRoKCkgY29uc3QgeyByZXR1cm4gbV9mcmFtZVJlY3Qud2lkdGgoKTsgfQogICAgIGludCBo ZWlnaHQoKSBjb25zdCB7IHJldHVybiBtX2ZyYW1lUmVjdC5oZWlnaHQoKTsgfQotICAgIAorCiAg ICAgdm9pZCBzZXRYKGludCB4KSB7IG1fZnJhbWVSZWN0LnNldFgoeCk7IH0KICAgICB2b2lkIHNl dFkoaW50IHkpIHsgbV9mcmFtZVJlY3Quc2V0WSh5KTsgfQogICAgIHZvaWQgc2V0V2lkdGgoaW50 IHdpZHRoKSB7IG1fZnJhbWVSZWN0LnNldFdpZHRoKHdpZHRoKTsgfQogICAgIHZvaWQgc2V0SGVp Z2h0KGludCBoZWlnaHQpIHsgbV9mcmFtZVJlY3Quc2V0SGVpZ2h0KGhlaWdodCk7IH0KKworICAg IGludCBsb2dpY2FsV2lkdGgoKSBjb25zdDsKKyAgICBpbnQgbG9naWNhbEhlaWdodCgpIGNvbnN0 OworICAgIHZvaWQgc2V0TG9naWNhbFdpZHRoKGludCk7CisgICAgdm9pZCBzZXRMb2dpY2FsSGVp Z2h0KGludCk7CiAgICAgCiAgICAgSW50UG9pbnQgbG9jYXRpb24oKSBjb25zdCB7IHJldHVybiBt X2ZyYW1lUmVjdC5sb2NhdGlvbigpOyB9CiAgICAgSW50U2l6ZSBsb2NhdGlvbk9mZnNldCgpIGNv bnN0IHsgcmV0dXJuIEludFNpemUoeCgpLCB5KCkpOyB9Cg==