<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>46289</bug_id>
          
          <creation_ts>2010-09-22 12:08:40 -0700</creation_ts>
          <short_desc>Move plug-in creation to WebPage::createPlugin</short_desc>
          <delta_ts>2010-09-22 12:14:00 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Anders Carlsson">andersca</reporter>
          <assigned_to name="Anders Carlsson">andersca</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>283133</commentid>
    <comment_count>0</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2010-09-22 12:08:40 -0700</bug_when>
    <thetext>Move plug-in creation to WebPage::createPlugin</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>283134</commentid>
    <comment_count>1</comment_count>
      <attachid>68412</attachid>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2010-09-22 12:10:04 -0700</bug_when>
    <thetext>Created attachment 68412
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>283141</commentid>
    <comment_count>2</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2010-09-22 12:14:00 -0700</bug_when>
    <thetext>Committed r68065: &lt;http://trac.webkit.org/changeset/68065&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>68412</attachid>
            <date>2010-09-22 12:10:04 -0700</date>
            <delta_ts>2010-09-22 12:12:13 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-46289-20100922121003.patch</filename>
            <type>text/plain</type>
            <size>6246</size>
            <attacher name="Anders Carlsson">andersca</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg
NzY5YWM5MDU5YzJmNWMxMGUxNzE5NDI4ZjA3YzVlNGUzNTQ4YzBlYy4uYTQwZjkxMWY4OGMxMzhl
YjY4OGExZDQzNThlM2YyOTgyZWNmZGExMSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK
KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxMC0wOS0yMiAgQW5k
ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgcGx1Zy1pbiBjcmVhdGlvbiB0byBXZWJQ
YWdlOjpjcmVhdGVQbHVnaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTQ2Mjg5CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dl
YkZyYW1lTG9hZGVyQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWVMb2FkZXJD
bGllbnQ6OmNyZWF0ZVBsdWdpbik6CisgICAgICAgIENhbGwgV2ViUGFnZTo6Y3JlYXRlUGx1Z2lu
LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAo
V2ViS2l0OjpXZWJQYWdlOjpjcmVhdGVQbHVnaW4pOgorICAgICAgICBDcmVhdGUgdGhlIHBsdWct
aW4uCisKKzIwMTAtMDktMjIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4K
KwogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KIAogICAgICAgICBSYW5kb20gcGx1
Zy1pbiBjbGVhbnVwcwpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBw
b3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcCBiL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3Jl
U3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAKaW5kZXggZjJhMWYxNzFiYjAzZDVkNTli
Yjc3YzdlMjAyMGZlNjMxN2Y3NjhmYS4uY2VlZGY0NzVhMjdiYTQzOGVkOWIwM2ExNGU5NmUyMGIz
NjNlODE0YyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dl
YkZyYW1lTG9hZGVyQ2xpZW50LmNwcAorKysgYi9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1
cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCkBAIC0yOSw3ICsyOSw2IEBACiAjaW5jbHVk
ZSAiTm90SW1wbGVtZW50ZWQuaCIKIAogI2luY2x1ZGUgIkluamVjdGVkQnVuZGxlVXNlck1lc3Nh
Z2VDb2RlcnMuaCIKLSNpbmNsdWRlICJOZXRzY2FwZVBsdWdpbi5oIgogI2luY2x1ZGUgIlBsYXRm
b3JtQ2VydGlmaWNhdGVJbmZvLmgiCiAjaW5jbHVkZSAiUGx1Z2luVmlldy5oIgogI2luY2x1ZGUg
IldlYkNvcmVBcmd1bWVudENvZGVycy5oIgpAQCAtOTYyLDMwICs5NjEsMTYgQEAgUGFzc1JlZlB0
cjxXaWRnZXQ+IFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpjcmVhdGVQbHVnaW4oY29uc3QgSW50U2l6
ZSYsIEhUTUxQbHVnSW4KIHsKICAgICBBU1NFUlQocGFyYW1OYW1lcy5zaXplKCkgPT0gcGFyYW1W
YWx1ZXMuc2l6ZSgpKTsKICAgICAKLSAgICBTdHJpbmcgcGx1Z2luUGF0aDsKLQotICAgIC8vIEZJ
WE1FOiBJbiB0aGUgZnV0dXJlLCB0aGlzIHNob3VsZCByZXR1cm4gYSByZWFsIENvcmVJUEMgY29u
bmVjdGlvbiB0byB0aGUgcGx1Zy1pbiBob3N0LCBidXQgZm9yIG5vdyB3ZSBqdXN0Ci0gICAgLy8g
cmV0dXJuIHRoZSBwYXRoIGFuZCBsb2FkIHRoZSBwbHVnLWluIGluIHRoZSB3ZWIgcHJvY2Vzcy4K
LSAgICBpZiAoIVdlYlByb2Nlc3M6OnNoYXJlZCgpLmNvbm5lY3Rpb24oKS0+c2VuZFN5bmMoV2Vi
UHJvY2Vzc1Byb3h5TWVzc2FnZTo6R2V0UGx1Z2luSG9zdENvbm5lY3Rpb24sIDAsIAotICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBDb3JlSVBDOjpJ
bihtaW1lVHlwZSwgdXJsLnN0cmluZygpKSwgCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIENvcmVJUEM6Ok91dChwbHVnaW5QYXRoKSwgCi0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIENvcmVJUEM6
OkNvbm5lY3Rpb246Ok5vVGltZW91dCkpCi0gICAgICAgIHJldHVybiAwOwotCi0gICAgaWYgKHBs
dWdpblBhdGguaXNOdWxsKCkpCi0gICAgICAgIHJldHVybiAwOwotCi0gICAgUmVmUHRyPE5ldHNj
YXBlUGx1Z2luTW9kdWxlPiBwbHVnaW5Nb2R1bGUgPSBOZXRzY2FwZVBsdWdpbk1vZHVsZTo6Z2V0
T3JDcmVhdGUocGx1Z2luUGF0aCk7Ci0gICAgaWYgKCFwbHVnaW5Nb2R1bGUpCi0gICAgICAgIHJl
dHVybiAwOwotCisgICAgV2ViUGFnZSogd2ViUGFnZSA9IG1fZnJhbWUtPnBhZ2UoKTsKKyAgICBB
U1NFUlQod2ViUGFnZSk7CisgICAgCiAgICAgUGx1Z2luOjpQYXJhbWV0ZXJzIHBhcmFtZXRlcnM7
CiAgICAgcGFyYW1ldGVycy51cmwgPSB1cmw7CiAgICAgcGFyYW1ldGVycy5uYW1lcyA9IHBhcmFt
TmFtZXM7CiAgICAgcGFyYW1ldGVycy52YWx1ZXMgPSBwYXJhbVZhbHVlczsKICAgICBwYXJhbWV0
ZXJzLm1pbWVUeXBlID0gbWltZVR5cGU7CiAgICAgcGFyYW1ldGVycy5sb2FkTWFudWFsbHkgPSBs
b2FkTWFudWFsbHk7Ci0gICAgCisKICAgICAvLyA8cmRhcjovL3Byb2JsZW0vODQ0MDkwMz46IEFw
cGxlQ29ubmVjdCBoYXMgYSBidWcgd2hlcmUgaXQgZG9lcyBub3QKICAgICAvLyB1bmRlcnN0YW5k
IHRoZSBwYXJhbWV0ZXIgbmFtZXMgc3BlY2lmaWVkIGluIHRoZSA8b2JqZWN0PiBlbGVtZW50IHRo
YXQKICAgICAvLyBlbWJlZHMgaXRzIHBsdWctaW4uIFRoaXMgaGFjayB3b3JrcyBhcm91bmQgdGhl
IGlzc3VlIGJ5IGNvbnZlcnRpbmcgdGhlCkBAIC05OTgsNyArOTgzLDEwIEBAIFBhc3NSZWZQdHI8
V2lkZ2V0PiBXZWJGcmFtZUxvYWRlckNsaWVudDo6Y3JlYXRlUGx1Z2luKGNvbnN0IEludFNpemUm
LCBIVE1MUGx1Z0luCiAgICAgICAgICAgICBwYXJhbWV0ZXJzLm5hbWVzW2ldID0gcGFyYW1OYW1l
c1tpXS5sb3dlcigpOwogICAgIH0KIAotICAgIFJlZlB0cjxQbHVnaW4+IHBsdWdpbiA9IE5ldHNj
YXBlUGx1Z2luOjpjcmVhdGUocGx1Z2luTW9kdWxlLnJlbGVhc2UoKSk7CisgICAgUmVmUHRyPFBs
dWdpbj4gcGx1Z2luID0gd2ViUGFnZS0+Y3JlYXRlUGx1Z2luKHBhcmFtZXRlcnMpOworICAgIGlm
ICghcGx1Z2luKQorICAgICAgICByZXR1cm4gMDsKKyAgICAKICAgICByZXR1cm4gUGx1Z2luVmll
dzo6Y3JlYXRlKHBsdWdpbkVsZW1lbnQsIHBsdWdpbi5yZWxlYXNlKCksIHBhcmFtZXRlcnMpOwog
fQogCmRpZmYgLS1naXQgYS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBi
L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IDUzZmI5Njc0NWY4
ZDBhZWJkZmE4MzA0OGE4NzA3ZGQ0OWRlODU0YzIuLjI4NmNkYWI5Njg4OTEyOWQ2M2NmNWFlNTA3
OGU3YmFiM2YzZGVkNmQgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dl
YlBhZ2UuY3BwCisrKyBiL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBA
IC0yOSw2ICsyOSw3IEBACiAjaW5jbHVkZSAiRHJhd2luZ0FyZWEuaCIKICNpbmNsdWRlICJJbmpl
Y3RlZEJ1bmRsZS5oIgogI2luY2x1ZGUgIk1lc3NhZ2VJRC5oIgorI2luY2x1ZGUgIk5ldHNjYXBl
UGx1Z2luLmgiCiAjaW5jbHVkZSAiUGx1Z2luVmlldy5oIgogI2luY2x1ZGUgIldlYkJhY2tGb3J3
YXJkQ29udHJvbGxlckNsaWVudC5oIgogI2luY2x1ZGUgIldlYkJhY2tGb3J3YXJkTGlzdFByb3h5
LmgiCkBAIC00Myw2ICs0NCw3IEBACiAjaW5jbHVkZSAiV2ViSW5zcGVjdG9yQ2xpZW50LmgiCiAj
aW5jbHVkZSAiV2ViUGFnZU1lc3NhZ2VLaW5kcy5oIgogI2luY2x1ZGUgIldlYlBhZ2VQcm94eU1l
c3NhZ2VLaW5kcy5oIgorI2luY2x1ZGUgIldlYlByb2Nlc3NQcm94eU1lc3NhZ2VLaW5kcy5oIgog
I2luY2x1ZGUgIldlYlByZWZlcmVuY2VzU3RvcmUuaCIKICNpbmNsdWRlICJXZWJQcm9jZXNzLmgi
CiAjaW5jbHVkZSA8V2ViQ29yZS9FdmVudEhhbmRsZXIuaD4KQEAgLTE2OCw2ICsxNzAsMjggQEAg
dm9pZCBXZWJQYWdlOjppbml0aWFsaXplSW5qZWN0ZWRCdW5kbGVVSUNsaWVudChXS0J1bmRsZVBh
Z2VVSUNsaWVudCogY2xpZW50KQogICAgIG1fdWlDbGllbnQuaW5pdGlhbGl6ZShjbGllbnQpOwog
fQogCitQYXNzUmVmUHRyPFBsdWdpbj4gV2ViUGFnZTo6Y3JlYXRlUGx1Z2luKGNvbnN0IFBsdWdp
bjo6UGFyYW1ldGVycyYgcGFyYW1ldGVycykKK3sKKyAgICBTdHJpbmcgcGx1Z2luUGF0aDsKKwor
ICAgIC8vIEZJWE1FOiBJbiB0aGUgZnV0dXJlLCB0aGlzIHNob3VsZCByZXR1cm4gYSByZWFsIENv
cmVJUEMgY29ubmVjdGlvbiB0byB0aGUgcGx1Zy1pbiBob3N0LCBidXQgZm9yIG5vdyB3ZSBqdXN0
CisgICAgLy8gcmV0dXJuIHRoZSBwYXRoIGFuZCBsb2FkIHRoZSBwbHVnLWluIGluIHRoZSB3ZWIg
cHJvY2Vzcy4KKyAgICBpZiAoIVdlYlByb2Nlc3M6OnNoYXJlZCgpLmNvbm5lY3Rpb24oKS0+c2Vu
ZFN5bmMoV2ViUHJvY2Vzc1Byb3h5TWVzc2FnZTo6R2V0UGx1Z2luSG9zdENvbm5lY3Rpb24sIDAs
IAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBD
b3JlSVBDOjpJbihwYXJhbWV0ZXJzLm1pbWVUeXBlLCBwYXJhbWV0ZXJzLnVybC5zdHJpbmcoKSks
IAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBD
b3JlSVBDOjpPdXQocGx1Z2luUGF0aCksIAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBDb3JlSVBDOjpDb25uZWN0aW9uOjpOb1RpbWVvdXQpKQor
ICAgICAgICByZXR1cm4gMDsKKworICAgIGlmIChwbHVnaW5QYXRoLmlzTnVsbCgpKQorICAgICAg
ICByZXR1cm4gMDsKKworICAgIFJlZlB0cjxOZXRzY2FwZVBsdWdpbk1vZHVsZT4gcGx1Z2luTW9k
dWxlID0gTmV0c2NhcGVQbHVnaW5Nb2R1bGU6OmdldE9yQ3JlYXRlKHBsdWdpblBhdGgpOworICAg
IGlmICghcGx1Z2luTW9kdWxlKQorICAgICAgICByZXR1cm4gMDsKKworICAgIHJldHVybiBOZXRz
Y2FwZVBsdWdpbjo6Y3JlYXRlKHBsdWdpbk1vZHVsZS5yZWxlYXNlKCkpOworfQorCiBTdHJpbmcg
V2ViUGFnZTo6cmVuZGVyVHJlZUV4dGVybmFsUmVwcmVzZW50YXRpb24oKSBjb25zdAogewogICAg
IHJldHVybiBleHRlcm5hbFJlcHJlc2VudGF0aW9uKG1fbWFpbkZyYW1lLT5jb3JlRnJhbWUoKSwg
UmVuZGVyQXNUZXh0QmVoYXZpb3JOb3JtYWwpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9XZWJQcm9j
ZXNzL1dlYlBhZ2UvV2ViUGFnZS5oIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn
ZS5oCmluZGV4IGI5MWI1ZGM2NjkyNWQ2ZGMxNmRlNTM0YTgyY2U5YzdiZDlmM2FkOTIuLmRkOTMw
OGQ2ZjczNjg5N2QxNzNlNTQ2NGUxYzljY2Q5MjRkYWQ5NzkgMTAwNjQ0Ci0tLSBhL1dlYktpdDIv
V2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaAorKysgYi9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi
UGFnZS9XZWJQYWdlLmgKQEAgLTMyLDYgKzMyLDcgQEAKICNpbmNsdWRlICJJbmplY3RlZEJ1bmRs
ZVBhZ2VGb3JtQ2xpZW50LmgiCiAjaW5jbHVkZSAiSW5qZWN0ZWRCdW5kbGVQYWdlTG9hZGVyQ2xp
ZW50LmgiCiAjaW5jbHVkZSAiSW5qZWN0ZWRCdW5kbGVQYWdlVUlDbGllbnQuaCIKKyNpbmNsdWRl
ICJQbHVnaW4uaCIKICNpbmNsdWRlICJXZWJFZGl0Q29tbWFuZC5oIgogI2luY2x1ZGUgPFdlYkNv
cmUvRnJhbWVMb2FkZXJUeXBlcy5oPgogI2luY2x1ZGUgPFdlYkNvcmUvSW50UmVjdC5oPgpAQCAt
MTIxLDYgKzEyMiw3IEBAIHB1YmxpYzoKICAgICBJbmplY3RlZEJ1bmRsZVBhZ2VVSUNsaWVudCYg
aW5qZWN0ZWRCdW5kbGVVSUNsaWVudCgpIHsgcmV0dXJuIG1fdWlDbGllbnQ7IH0KIAogICAgIFdl
YkZyYW1lKiBtYWluRnJhbWUoKSBjb25zdCB7IHJldHVybiBtX21haW5GcmFtZS5nZXQoKTsgfQor
ICAgIFBhc3NSZWZQdHI8UGx1Z2luPiBjcmVhdGVQbHVnaW4oY29uc3QgUGx1Z2luOjpQYXJhbWV0
ZXJzJik7CiAKICAgICBTdHJpbmcgcmVuZGVyVHJlZUV4dGVybmFsUmVwcmVzZW50YXRpb24oKSBj
b25zdDsKICAgICB2b2lkIGV4ZWN1dGVFZGl0aW5nQ29tbWFuZChjb25zdCBTdHJpbmcmIGNvbW1h
bmROYW1lLCBjb25zdCBTdHJpbmcmIGFyZ3VtZW50KTsK
</data>
<flag name="review"
          id="57927"
          type_id="1"
          status="+"
          setter="aroben"
    />
          </attachment>
      

    </bug>

</bugzilla>