46284 2010-09-22 11:50:18 -0700 [GTK] Replace instances of g_timeout_add() with g_idle_add() in testatk.c 2010-09-22 18:48:56 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 mario webkit-unassigned commit-queue mrobinson xan.lopez oldest_to_newest 283106 0 mario 2010-09-22 11:50:18 -0700 Inside WebKit/gtk/tests/testatk.c, there are still some places where the following kind of lines g_timeout_add(100, (GSourceFunc)bail_out, loop); ...should be replaced by a call to g_idle_add: g_idle_add((GSourceFunc)bail_out, loop); This is a trivial-yet-needed bug that needs obvious fixing (and further care when adding new tests <- note to myself :-/) 283167 1 68419 mario 2010-09-22 12:41:30 -0700 Created attachment 68419 Patch proposal This should be straightforward I guess... 283170 2 68419 mrobinson 2010-09-22 12:45:10 -0700 Comment on attachment 68419 Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=68419&action=review > WebKit/gtk/ChangeLog:8 > + Use g_idle_add() whenever g_timeout_add() was being used You should explain here why this conversion is a good thing. In the future, other programmers will see this commit and wonder what the explanation was. We should be able to concisely describe to people why we prefer this style. 283198 3 68430 mario 2010-09-22 13:24:12 -0700 Created attachment 68430 Patch proposal (In reply to comment #2) > (From update of attachment 68419 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=68419&action=review > > > WebKit/gtk/ChangeLog:8 > > + Use g_idle_add() whenever g_timeout_add() was being used > > You should explain here why this conversion is a good thing. In the future, other programmers will see this commit and wonder what the explanation was. We should be able to concisely describe to people why we prefer this style. 283204 4 68430 mrobinson 2010-09-22 13:28:35 -0700 Comment on attachment 68430 Patch proposal Great description! Thanks. 283453 5 68430 commit-queue 2010-09-22 18:48:51 -0700 Comment on attachment 68430 Patch proposal Clearing flags on attachment: 68430 Committed r68111: <http://trac.webkit.org/changeset/68111> 283454 6 commit-queue 2010-09-22 18:48:56 -0700 All reviewed patches have been landed. Closing bug. 68419 2010-09-22 12:41:30 -0700 2010-09-22 13:24:12 -0700 Patch proposal 0001-2010-09-22-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 3584 mario RnJvbSAzZmI1MDRhNmFjOWViYTRkODBjZjIwMjYzY2U5YThkZjBlODc1YTBkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBXZWQsIDIyIFNlcCAyMDEwIDIxOjMyOjA3ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMC0wOS0yMiAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBbR1RLXSBSZXBs YWNlIGluc3RhbmNlcyBvZiBnX3RpbWVvdXRfYWRkKCkgd2l0aCBnX2lkbGVfYWRkKCkgaW4gdGVz dGF0ay5jCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2 Mjg0CgogICAgICAgIFVzZSBnX2lkbGVfYWRkKCkgd2hlbmV2ZXIgZ190aW1lb3V0X2FkZCgpIHdh cyBiZWluZyB1c2VkCgogICAgICAgICogdGVzdHMvdGVzdGF0ay5jOgogICAgICAgICh0ZXN0V2Vr aXRBdGtUZXh0U2VsZWN0aW9ucyk6CiAgICAgICAgKHRlc3RXZWJraXRBdGtHZXRFeHRlbnRzKToK ICAgICAgICAodGVzdFdlYmtpdEF0a0xpc3RzT2ZJdGVtcyk6CiAgICAgICAgKG1haW4pOgotLS0K IFdlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysKIFdlYktp dC9ndGsvdGVzdHMvdGVzdGF0ay5jIHwgICAxMCArKysrKy0tLS0tCiAyIGZpbGVzIGNoYW5nZWQs IDIwIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCAxNmY0MDYzLi40YTA5MmVk IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9XZWJLaXQvZ3RrL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEwLTA5LTIyICBNYXJpbyBTYW5jaGV6IFByYWRhICA8 bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbR1RLXSBSZXBsYWNlIGluc3RhbmNlcyBvZiBnX3RpbWVvdXRfYWRkKCkg d2l0aCBnX2lkbGVfYWRkKCkgaW4gdGVzdGF0ay5jCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjI4NAorCisgICAgICAgIFVzZSBnX2lkbGVfYWRkKCkg d2hlbmV2ZXIgZ190aW1lb3V0X2FkZCgpIHdhcyBiZWluZyB1c2VkCisKKyAgICAgICAgKiB0ZXN0 cy90ZXN0YXRrLmM6CisgICAgICAgICh0ZXN0V2VraXRBdGtUZXh0U2VsZWN0aW9ucyk6CisgICAg ICAgICh0ZXN0V2Via2l0QXRrR2V0RXh0ZW50cyk6CisgICAgICAgICh0ZXN0V2Via2l0QXRrTGlz dHNPZkl0ZW1zKToKKyAgICAgICAgKG1haW4pOgorCiAyMDEwLTA5LTE3ICBEYXJpbiBBZGxlciAg PGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZm IC0tZ2l0IGEvV2ViS2l0L2d0ay90ZXN0cy90ZXN0YXRrLmMgYi9XZWJLaXQvZ3RrL3Rlc3RzL3Rl c3RhdGsuYwppbmRleCA5Y2E3YzA1Li5mNTVhZmFiIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3Rl c3RzL3Rlc3RhdGsuYworKysgYi9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RhdGsuYwpAQCAtNzYxLDcg Kzc2MSw3IEBAIHN0YXRpYyB2b2lkIHRlc3RXZWtpdEF0a1RleHRTZWxlY3Rpb25zKHZvaWQpCiAg ICAgd2Via2l0X3dlYl92aWV3X2xvYWRfc3RyaW5nKHdlYlZpZXcsIHRleHRGb3JTZWxlY3Rpb25z LCBOVUxMLCBOVUxMLCBOVUxMKTsKICAgICBsb29wID0gZ19tYWluX2xvb3BfbmV3KE5VTEwsIFRS VUUpOwogCi0gICAgZ190aW1lb3V0X2FkZCgxMDAsIChHU291cmNlRnVuYyliYWlsX291dCwgbG9v cCk7CisgICAgZ19pZGxlX2FkZCgoR1NvdXJjZUZ1bmMpYmFpbF9vdXQsIGxvb3ApOwogICAgIGdf bWFpbl9sb29wX3J1bihsb29wKTsKIAogICAgIG9iaiA9IGd0a193aWRnZXRfZ2V0X2FjY2Vzc2li bGUoR1RLX1dJREdFVCh3ZWJWaWV3KSk7CkBAIC04NTksNyArODU5LDcgQEAgc3RhdGljIHZvaWQg dGVzdFdla2l0QXRrVGV4dFNlbGVjdGlvbnModm9pZCkKICAgICBnX29iamVjdF91bnJlZih3ZWJW aWV3KTsKIH0KIAotc3RhdGljIHZvaWQgdGVzdF93ZWJraXRfYXRrX2dldF9leHRlbnRzKHZvaWQp CitzdGF0aWMgdm9pZCB0ZXN0V2Via2l0QXRrR2V0RXh0ZW50cyh2b2lkKQogewogICAgIFdlYktp dFdlYlZpZXcqIHdlYlZpZXc7CiAgICAgQXRrT2JqZWN0KiBvYmo7CkBAIC04NzIsNyArODcyLDcg QEAgc3RhdGljIHZvaWQgdGVzdF93ZWJraXRfYXRrX2dldF9leHRlbnRzKHZvaWQpCiAgICAgd2Vi a2l0X3dlYl92aWV3X2xvYWRfc3RyaW5nKHdlYlZpZXcsIGNlbnRlcmVkQ29udGVudHMsIE5VTEws IE5VTEwsIE5VTEwpOwogICAgIGxvb3AgPSBnX21haW5fbG9vcF9uZXcoTlVMTCwgVFJVRSk7CiAK LSAgICBnX3RpbWVvdXRfYWRkKDEwMCwgKEdTb3VyY2VGdW5jKWJhaWxfb3V0LCBsb29wKTsKKyAg ICBnX2lkbGVfYWRkKChHU291cmNlRnVuYyliYWlsX291dCwgbG9vcCk7CiAgICAgZ19tYWluX2xv b3BfcnVuKGxvb3ApOwogCiAgICAgb2JqID0gZ3RrX3dpZGdldF9nZXRfYWNjZXNzaWJsZShHVEtf V0lER0VUKHdlYlZpZXcpKTsKQEAgLTk4MCw3ICs5ODAsNyBAQCBzdGF0aWMgdm9pZCB0ZXN0V2Vi a2l0QXRrTGlzdHNPZkl0ZW1zKHZvaWQpCiAgICAgd2Via2l0X3dlYl92aWV3X2xvYWRfc3RyaW5n KHdlYlZpZXcsIGxpc3RzT2ZJdGVtcywgTlVMTCwgTlVMTCwgTlVMTCk7CiAgICAgbG9vcCA9IGdf bWFpbl9sb29wX25ldyhOVUxMLCBUUlVFKTsKIAotICAgIGdfdGltZW91dF9hZGQoMTAwLCAoR1Nv dXJjZUZ1bmMpYmFpbF9vdXQsIGxvb3ApOworICAgIGdfaWRsZV9hZGQoKEdTb3VyY2VGdW5jKWJh aWxfb3V0LCBsb29wKTsKICAgICBnX21haW5fbG9vcF9ydW4obG9vcCk7CiAKICAgICBvYmogPSBn dGtfd2lkZ2V0X2dldF9hY2Nlc3NpYmxlKEdUS19XSURHRVQod2ViVmlldykpOwpAQCAtMTA1NCw3 ICsxMDU0LDcgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogICAgIGdfdGVzdF9h ZGRfZnVuYygiL3dlYmtpdC9hdGsvZ2V0SGVhZGVyc0luVGFibGUiLCB0ZXN0V2Via2l0QXRrR2V0 SGVhZGVyc0luVGFibGUpOwogICAgIGdfdGVzdF9hZGRfZnVuYygiL3dlYmtpdC9hdGsvdGV4dEF0 dHJpYnV0ZXMiLCB0ZXN0V2Via2l0QXRrVGV4dEF0dHJpYnV0ZXMpOwogICAgIGdfdGVzdF9hZGRf ZnVuYygiL3dlYmtpdC9hdGsvdGV4dFNlbGVjdGlvbnMiLCB0ZXN0V2VraXRBdGtUZXh0U2VsZWN0 aW9ucyk7Ci0gICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L2F0ay9nZXRfZXh0ZW50cyIsIHRl c3Rfd2Via2l0X2F0a19nZXRfZXh0ZW50cyk7CisgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0 L2F0ay9nZXRFeHRlbnRzIiwgdGVzdFdlYmtpdEF0a0dldEV4dGVudHMpOwogICAgIGdfdGVzdF9h ZGRfZnVuYygiL3dlYmtpdC9hdGsvbGlzdHNPZkl0ZW1zIiwgdGVzdFdlYmtpdEF0a0xpc3RzT2ZJ dGVtcyk7CiAgICAgcmV0dXJuIGdfdGVzdF9ydW4gKCk7CiB9Ci0tIAoxLjcuMC40Cgo= 68430 2010-09-22 13:24:12 -0700 2010-09-22 18:48:51 -0700 Patch proposal 0001-2010-09-22-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 4138 mario RnJvbSBkNThjYWNjZmZjZTUzM2FkMWY4MWY3N2RiZDhjZjIwM2MwNmIxNGYwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBXZWQsIDIyIFNlcCAyMDEwIDIyOjIyOjQwICswMjAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMC0wOS0yMiAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBbR1RLXSBSZXBs YWNlIGluc3RhbmNlcyBvZiBnX3RpbWVvdXRfYWRkKCkgd2l0aCBnX2lkbGVfYWRkKCkgaW4gdGVz dGF0ay5jCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2 Mjg0CgogICAgICAgIFVzZSBnX2lkbGVfYWRkKCkgd2hlbmV2ZXIgZ190aW1lb3V0X2FkZCgpIHdh cyBiZWluZyB1c2VkLgoKICAgICAgICBUaGlzIGlzIGRlc2lyZWQgYmVjYXVzZSBpdCdzIGJldHRl ciB0byByZWx5IG9uIHRoZSBtYWluIGxvb3AgdG8KICAgICAgICBkZWNpZGUgd2hlbiBpdCdzIGEg Z29vZCBtb21lbnQgdG8gZXhlY3V0ZSB0aGUgdGFzayAod2hlbiBpZGxlKQogICAgICAgIHRoYW4g bWFudWFsbHkgc2V0dGluZyBhIHRpbWVvdXQsIHdoaWNoIGFsc28gc2V0cyBhIG1pbmltdW0gYW1v dW50CiAgICAgICAgb2YgdGltZSBuZWVkZWQgdG8gZ2V0IHRoZSBmdW5jdGlvbiBleGVjdXRlZC4K CiAgICAgICAgKiB0ZXN0cy90ZXN0YXRrLmM6CiAgICAgICAgKHRlc3RXZWtpdEF0a1RleHRTZWxl Y3Rpb25zKToKICAgICAgICAodGVzdFdlYmtpdEF0a0dldEV4dGVudHMpOgogICAgICAgICh0ZXN0 V2Via2l0QXRrTGlzdHNPZkl0ZW1zKToKICAgICAgICAobWFpbik6Ci0tLQogV2ViS2l0L2d0ay9D aGFuZ2VMb2cgICAgICAgfCAgIDIwICsrKysrKysrKysrKysrKysrKysrCiBXZWJLaXQvZ3RrL3Rl c3RzL3Rlc3RhdGsuYyB8ICAgMTAgKysrKystLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNl cnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdl TG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggMTZmNDA2My4uMzU5ZGMwZSAxMDA2NDQK LS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyMyBAQAorMjAxMC0wOS0yMiAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6 QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgW0dUS10gUmVwbGFjZSBpbnN0YW5jZXMgb2YgZ190aW1lb3V0X2FkZCgpIHdpdGggZ19p ZGxlX2FkZCgpIGluIHRlc3RhdGsuYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDYyODQKKworICAgICAgICBVc2UgZ19pZGxlX2FkZCgpIHdoZW5ldmVy IGdfdGltZW91dF9hZGQoKSB3YXMgYmVpbmcgdXNlZC4KKworICAgICAgICBUaGlzIGlzIGRlc2ly ZWQgYmVjYXVzZSBpdCdzIGJldHRlciB0byByZWx5IG9uIHRoZSBtYWluIGxvb3AgdG8KKyAgICAg ICAgZGVjaWRlIHdoZW4gaXQncyBhIGdvb2QgbW9tZW50IHRvIGV4ZWN1dGUgdGhlIHRhc2sgKHdo ZW4gaWRsZSkKKyAgICAgICAgdGhhbiBtYW51YWxseSBzZXR0aW5nIGEgdGltZW91dCwgd2hpY2gg YWxzbyBzZXRzIGEgbWluaW11bSBhbW91bnQKKyAgICAgICAgb2YgdGltZSBuZWVkZWQgdG8gZ2V0 IHRoZSBmdW5jdGlvbiBleGVjdXRlZC4KKworICAgICAgICAqIHRlc3RzL3Rlc3RhdGsuYzoKKyAg ICAgICAgKHRlc3RXZWtpdEF0a1RleHRTZWxlY3Rpb25zKToKKyAgICAgICAgKHRlc3RXZWJraXRB dGtHZXRFeHRlbnRzKToKKyAgICAgICAgKHRlc3RXZWJraXRBdGtMaXN0c09mSXRlbXMpOgorICAg ICAgICAobWFpbik6CisKIDIwMTAtMDktMTcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9XZWJLaXQv Z3RrL3Rlc3RzL3Rlc3RhdGsuYyBiL1dlYktpdC9ndGsvdGVzdHMvdGVzdGF0ay5jCmluZGV4IDlj YTdjMDUuLmY1NWFmYWIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvdGVzdHMvdGVzdGF0ay5jCisr KyBiL1dlYktpdC9ndGsvdGVzdHMvdGVzdGF0ay5jCkBAIC03NjEsNyArNzYxLDcgQEAgc3RhdGlj IHZvaWQgdGVzdFdla2l0QXRrVGV4dFNlbGVjdGlvbnModm9pZCkKICAgICB3ZWJraXRfd2ViX3Zp ZXdfbG9hZF9zdHJpbmcod2ViVmlldywgdGV4dEZvclNlbGVjdGlvbnMsIE5VTEwsIE5VTEwsIE5V TEwpOwogICAgIGxvb3AgPSBnX21haW5fbG9vcF9uZXcoTlVMTCwgVFJVRSk7CiAKLSAgICBnX3Rp bWVvdXRfYWRkKDEwMCwgKEdTb3VyY2VGdW5jKWJhaWxfb3V0LCBsb29wKTsKKyAgICBnX2lkbGVf YWRkKChHU291cmNlRnVuYyliYWlsX291dCwgbG9vcCk7CiAgICAgZ19tYWluX2xvb3BfcnVuKGxv b3ApOwogCiAgICAgb2JqID0gZ3RrX3dpZGdldF9nZXRfYWNjZXNzaWJsZShHVEtfV0lER0VUKHdl YlZpZXcpKTsKQEAgLTg1OSw3ICs4NTksNyBAQCBzdGF0aWMgdm9pZCB0ZXN0V2VraXRBdGtUZXh0 U2VsZWN0aW9ucyh2b2lkKQogICAgIGdfb2JqZWN0X3VucmVmKHdlYlZpZXcpOwogfQogCi1zdGF0 aWMgdm9pZCB0ZXN0X3dlYmtpdF9hdGtfZ2V0X2V4dGVudHModm9pZCkKK3N0YXRpYyB2b2lkIHRl c3RXZWJraXRBdGtHZXRFeHRlbnRzKHZvaWQpCiB7CiAgICAgV2ViS2l0V2ViVmlldyogd2ViVmll dzsKICAgICBBdGtPYmplY3QqIG9iajsKQEAgLTg3Miw3ICs4NzIsNyBAQCBzdGF0aWMgdm9pZCB0 ZXN0X3dlYmtpdF9hdGtfZ2V0X2V4dGVudHModm9pZCkKICAgICB3ZWJraXRfd2ViX3ZpZXdfbG9h ZF9zdHJpbmcod2ViVmlldywgY2VudGVyZWRDb250ZW50cywgTlVMTCwgTlVMTCwgTlVMTCk7CiAg ICAgbG9vcCA9IGdfbWFpbl9sb29wX25ldyhOVUxMLCBUUlVFKTsKIAotICAgIGdfdGltZW91dF9h ZGQoMTAwLCAoR1NvdXJjZUZ1bmMpYmFpbF9vdXQsIGxvb3ApOworICAgIGdfaWRsZV9hZGQoKEdT b3VyY2VGdW5jKWJhaWxfb3V0LCBsb29wKTsKICAgICBnX21haW5fbG9vcF9ydW4obG9vcCk7CiAK ICAgICBvYmogPSBndGtfd2lkZ2V0X2dldF9hY2Nlc3NpYmxlKEdUS19XSURHRVQod2ViVmlldykp OwpAQCAtOTgwLDcgKzk4MCw3IEBAIHN0YXRpYyB2b2lkIHRlc3RXZWJraXRBdGtMaXN0c09mSXRl bXModm9pZCkKICAgICB3ZWJraXRfd2ViX3ZpZXdfbG9hZF9zdHJpbmcod2ViVmlldywgbGlzdHNP Zkl0ZW1zLCBOVUxMLCBOVUxMLCBOVUxMKTsKICAgICBsb29wID0gZ19tYWluX2xvb3BfbmV3KE5V TEwsIFRSVUUpOwogCi0gICAgZ190aW1lb3V0X2FkZCgxMDAsIChHU291cmNlRnVuYyliYWlsX291 dCwgbG9vcCk7CisgICAgZ19pZGxlX2FkZCgoR1NvdXJjZUZ1bmMpYmFpbF9vdXQsIGxvb3ApOwog ICAgIGdfbWFpbl9sb29wX3J1bihsb29wKTsKIAogICAgIG9iaiA9IGd0a193aWRnZXRfZ2V0X2Fj Y2Vzc2libGUoR1RLX1dJREdFVCh3ZWJWaWV3KSk7CkBAIC0xMDU0LDcgKzEwNTQsNyBAQCBpbnQg bWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiAgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0 L2F0ay9nZXRIZWFkZXJzSW5UYWJsZSIsIHRlc3RXZWJraXRBdGtHZXRIZWFkZXJzSW5UYWJsZSk7 CiAgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L2F0ay90ZXh0QXR0cmlidXRlcyIsIHRlc3RX ZWJraXRBdGtUZXh0QXR0cmlidXRlcyk7CiAgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L2F0 ay90ZXh0U2VsZWN0aW9ucyIsIHRlc3RXZWtpdEF0a1RleHRTZWxlY3Rpb25zKTsKLSAgICBnX3Rl c3RfYWRkX2Z1bmMoIi93ZWJraXQvYXRrL2dldF9leHRlbnRzIiwgdGVzdF93ZWJraXRfYXRrX2dl dF9leHRlbnRzKTsKKyAgICBnX3Rlc3RfYWRkX2Z1bmMoIi93ZWJraXQvYXRrL2dldEV4dGVudHMi LCB0ZXN0V2Via2l0QXRrR2V0RXh0ZW50cyk7CiAgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0 L2F0ay9saXN0c09mSXRlbXMiLCB0ZXN0V2Via2l0QXRrTGlzdHNPZkl0ZW1zKTsKICAgICByZXR1 cm4gZ190ZXN0X3J1biAoKTsKIH0KLS0gCjEuNy4wLjQKCg==