46281 2010-09-22 11:14:41 -0700 [chromium] add baselines for xmlhttprequest tests for chromium 2010-09-22 17:45:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony fishd levin oldest_to_newest 283072 0 tony 2010-09-22 11:14:41 -0700 [chromium] add baselines for xmlhttprequest tests for chromium 283076 1 68400 tony 2010-09-22 11:15:52 -0700 Created attachment 68400 Patch 283081 2 tony 2010-09-22 11:22:21 -0700 We switched from lighttpd to apache on mac & linux, so these 3 tests should pass. http/tests/xmlhttprequest/methods-lower-case.html passes with no changes. http/tests/xmlhttprequest/methods-async.html and http/tests/xmlhttprequest/methods.html differ by the following lines: -DELETE(null): DELETE(0 bytes), Content-Type: null +DELETE(null): DELETE(null bytes), Content-Type: null -WKFOOBAR(null): WKFOOBAR(0 bytes), Content-Type: null +WKFOOBAR(null): WKFOOBAR(null bytes), Content-Type: null -SEARCH(null): SEARCH(0 bytes), Content-Type: null +SEARCH(null): SEARCH(null bytes), Content-Type: null Upon further inspection, it seems that CF adds a Content-Length: 0 header to these requests. Here's a test case that echoes the request headers: http://ponderer.org/tests/xhrtest.html In Safari, there's a Content-Length parameter, but Chromium doesn't have one. I traced through the ResourceHandleMac code and up until the point where we pass the request on to CF, ResourceRequest doesn't have a Content-Length header so I don't think any code in WebCore is adding it. This patch just rebaselines the test, but if you want, I can also try to change our networking stack to match CF. 283315 3 levin 2010-09-22 15:54:00 -0700 (In reply to comment #2) > We switched from lighttpd to apache on mac & linux, so these 3 tests should pass. http/tests/xmlhttprequest/methods-lower-case.html passes with no changes. > > http/tests/xmlhttprequest/methods-async.html and http/tests/xmlhttprequest/methods.html differ by the following lines: > > -DELETE(null): DELETE(0 bytes), Content-Type: null > +DELETE(null): DELETE(null bytes), Content-Type: null > -WKFOOBAR(null): WKFOOBAR(0 bytes), Content-Type: null > +WKFOOBAR(null): WKFOOBAR(null bytes), Content-Type: null > -SEARCH(null): SEARCH(0 bytes), Content-Type: null > +SEARCH(null): SEARCH(null bytes), Content-Type: null > > Upon further inspection, it seems that CF adds a Content-Length: 0 header to these requests. Here's a test case that echoes the request headers: > http://ponderer.org/tests/xhrtest.html > > In Safari, there's a Content-Length parameter, but Chromium doesn't have one. I traced through the ResourceHandleMac code and up until the point where we pass the request on to CF, ResourceRequest doesn't have a Content-Length header so I don't think any code in WebCore is adding it. > > This patch just rebaselines the test, but if you want, I can also try to change our networking stack to match CF. Is it possible to try out FF and IE and see what they do for the test? If they do what Safari does, then it seems taht chromium should follow suit. If not, then a difference may be fine here. 283350 4 tony 2010-09-22 16:26:07 -0700 In IE9: DELETE sends a content-length of 0. wkfoobar and search don't send a request at all (there's no request in the F12 developer tools). I guess IE9 has a whitelist of HTTP actions? In Firefox 3.6 Linux: No content-length sent for DELETE, WKFOOBAR, or SEARCH. 283361 5 tony 2010-09-22 16:34:23 -0700 Opera on Windows always sends Content-Length: 0. 283386 6 68400 levin 2010-09-22 17:28:23 -0700 Comment on attachment 68400 Patch OK,browsers are inconsistent on this minor point and we're consistent with one of the many behaviors, so this seems fine. 283396 7 tony 2010-09-22 17:45:39 -0700 Committed r68104: <http://trac.webkit.org/changeset/68104> 68400 2010-09-22 11:15:52 -0700 2010-09-22 17:28:22 -0700 Patch bug-46281-20100922111554.patch text/plain 5630 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4MmRkOTE5ODBmZjBhN2Y4OTEyMzNlMDk2Y2Y1NWFmNjY2ZWJiM2YyLi5lNjRhMjU2 MDNkMWE0NzdiN2E2NTU2ZmJiNTQ2OTkwMGI0ODUzMjNjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMDktMjIgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIGFkZCBiYXNl bGluZXMgZm9yIHhtbGh0dHByZXF1ZXN0IHRlc3RzIGZvciBjaHJvbWl1bQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDYyODEKKworICAgICAgICAqIHBs YXRmb3JtL2Nocm9taXVtL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvbWV0aG9kcy1hc3luYy1l eHBlY3RlZC50eHQ6IEFsbG93IG5vIGNvbnRlbnQtbGVuZ3RoIGZvciBub24tZ2V0L3Bvc3QgcmVx dWVzdHMKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9odHRwL3Rlc3RzL3htbGh0dHByZXF1 ZXN0L21ldGhvZHMtZXhwZWN0ZWQudHh0OiBBbGxvdyBubyBjb250ZW50LWxlbmd0aCBmb3Igbm9u LWdldC9wb3N0IHJlcXVlc3RzCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBl Y3RhdGlvbnMudHh0OiBFbmFibGUgMyB0ZXN0cyBvbiBsaW51eCArIG1hYworCiAyMDEwLTA5LTIy ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QWxleGV5IFByb3NrdXJ5YWtvdi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2No cm9taXVtL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvbWV0aG9kcy1hc3luYy1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9odHRwL3Rlc3RzL3htbGh0dHByZXF1 ZXN0L21ldGhvZHMtYXN5bmMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjJkMmU2YTc2MWMzZjZm ODFmOTE5NzYzNmVkMDMzOGQwMGJmZWE2NzQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9jaHJvbWl1bS9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L21ldGhvZHMtYXN5 bmMtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMjMgQEAKK1Rlc3RzIGZvciBidWcgMzgxMiAtIEdF VCBhbmQgUE9TVCBzaG91bGQgbm90IGJlIHRoZSBvbmx5IEhUVFAgbWV0aG9kcyBpbXBsZW1lbnRl ZCBpbiBYTUxIdHRwUmVxdWVzdC4KKworR0VUKCIiKTogR0VUKG51bGwgYnl0ZXMpLCBDb250ZW50 LVR5cGU6IG51bGwKK0dFVChudWxsKTogR0VUKG51bGwgYnl0ZXMpLCBDb250ZW50LVR5cGU6IG51 bGwKK0dFVCgiMTIzIik6IEdFVChudWxsIGJ5dGVzKSwgQ29udGVudC1UeXBlOiBudWxsCitQT1NU KCIiKTogUE9TVCgwIGJ5dGVzKSwgQ29udGVudC1UeXBlOiBhcHBsaWNhdGlvbi94bWwKK1BPU1Qo bnVsbCk6IFBPU1QoMCBieXRlcyksIENvbnRlbnQtVHlwZTogbnVsbAorUE9TVCgiMTIzIik6IFBP U1QoMyBieXRlcyksIENvbnRlbnQtVHlwZTogYXBwbGljYXRpb24veG1sCitQVVQoIiIpOiBQVVQo MCBieXRlcyksIENvbnRlbnQtVHlwZTogYXBwbGljYXRpb24veG1sCitQVVQobnVsbCk6IFBVVCgw IGJ5dGVzKSwgQ29udGVudC1UeXBlOiBudWxsCitQVVQoIjEyMyIpOiBQVVQoMyBieXRlcyksIENv bnRlbnQtVHlwZTogYXBwbGljYXRpb24veG1sCitERUxFVEUoIiIpOiBERUxFVEUoMCBieXRlcyks IENvbnRlbnQtVHlwZTogYXBwbGljYXRpb24veG1sCitERUxFVEUobnVsbCk6IERFTEVURShudWxs IGJ5dGVzKSwgQ29udGVudC1UeXBlOiBudWxsCitERUxFVEUoIjEyMyIpOiBERUxFVEUoMyBieXRl cyksIENvbnRlbnQtVHlwZTogYXBwbGljYXRpb24veG1sCitIRUFEKCIiKTogSEVBRCgwIGJ5dGVz KSwgQ29udGVudC1UeXBlOiBudWxsCitIRUFEKG51bGwpOiBIRUFEKDAgYnl0ZXMpLCBDb250ZW50 LVR5cGU6IG51bGwKK0hFQUQoIjEyMyIpOiBIRUFEKDAgYnl0ZXMpLCBDb250ZW50LVR5cGU6IG51 bGwKK1dLRk9PQkFSKCIiKTogV0tGT09CQVIoMCBieXRlcyksIENvbnRlbnQtVHlwZTogYXBwbGlj YXRpb24veG1sCitXS0ZPT0JBUihudWxsKTogV0tGT09CQVIobnVsbCBieXRlcyksIENvbnRlbnQt VHlwZTogbnVsbAorV0tGT09CQVIoIjEyMyIpOiBXS0ZPT0JBUigzIGJ5dGVzKSwgQ29udGVudC1U eXBlOiBhcHBsaWNhdGlvbi94bWwKK1NFQVJDSCgiIik6IFNFQVJDSCgwIGJ5dGVzKSwgQ29udGVu dC1UeXBlOiBhcHBsaWNhdGlvbi94bWwKK1NFQVJDSChudWxsKTogU0VBUkNIKG51bGwgYnl0ZXMp LCBDb250ZW50LVR5cGU6IG51bGwKK1NFQVJDSCgiMTIzIik6IFNFQVJDSCgzIGJ5dGVzKSwgQ29u dGVudC1UeXBlOiBhcHBsaWNhdGlvbi94bWwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvbWV0aG9kcy1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9odHRwL3Rlc3RzL3htbGh0dHByZXF1 ZXN0L21ldGhvZHMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjJkMmU2YTc2MWMzZjZmODFmOTE5 NzYzNmVkMDMzOGQwMGJmZWE2NzQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9jaHJvbWl1bS9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L21ldGhvZHMtZXhwZWN0ZWQu dHh0CkBAIC0wLDAgKzEsMjMgQEAKK1Rlc3RzIGZvciBidWcgMzgxMiAtIEdFVCBhbmQgUE9TVCBz aG91bGQgbm90IGJlIHRoZSBvbmx5IEhUVFAgbWV0aG9kcyBpbXBsZW1lbnRlZCBpbiBYTUxIdHRw UmVxdWVzdC4KKworR0VUKCIiKTogR0VUKG51bGwgYnl0ZXMpLCBDb250ZW50LVR5cGU6IG51bGwK K0dFVChudWxsKTogR0VUKG51bGwgYnl0ZXMpLCBDb250ZW50LVR5cGU6IG51bGwKK0dFVCgiMTIz Iik6IEdFVChudWxsIGJ5dGVzKSwgQ29udGVudC1UeXBlOiBudWxsCitQT1NUKCIiKTogUE9TVCgw IGJ5dGVzKSwgQ29udGVudC1UeXBlOiBhcHBsaWNhdGlvbi94bWwKK1BPU1QobnVsbCk6IFBPU1Qo MCBieXRlcyksIENvbnRlbnQtVHlwZTogbnVsbAorUE9TVCgiMTIzIik6IFBPU1QoMyBieXRlcyks IENvbnRlbnQtVHlwZTogYXBwbGljYXRpb24veG1sCitQVVQoIiIpOiBQVVQoMCBieXRlcyksIENv bnRlbnQtVHlwZTogYXBwbGljYXRpb24veG1sCitQVVQobnVsbCk6IFBVVCgwIGJ5dGVzKSwgQ29u dGVudC1UeXBlOiBudWxsCitQVVQoIjEyMyIpOiBQVVQoMyBieXRlcyksIENvbnRlbnQtVHlwZTog YXBwbGljYXRpb24veG1sCitERUxFVEUoIiIpOiBERUxFVEUoMCBieXRlcyksIENvbnRlbnQtVHlw ZTogYXBwbGljYXRpb24veG1sCitERUxFVEUobnVsbCk6IERFTEVURShudWxsIGJ5dGVzKSwgQ29u dGVudC1UeXBlOiBudWxsCitERUxFVEUoIjEyMyIpOiBERUxFVEUoMyBieXRlcyksIENvbnRlbnQt VHlwZTogYXBwbGljYXRpb24veG1sCitIRUFEKCIiKTogSEVBRCgwIGJ5dGVzKSwgQ29udGVudC1U eXBlOiBudWxsCitIRUFEKG51bGwpOiBIRUFEKDAgYnl0ZXMpLCBDb250ZW50LVR5cGU6IG51bGwK K0hFQUQoIjEyMyIpOiBIRUFEKDAgYnl0ZXMpLCBDb250ZW50LVR5cGU6IG51bGwKK1dLRk9PQkFS KCIiKTogV0tGT09CQVIoMCBieXRlcyksIENvbnRlbnQtVHlwZTogYXBwbGljYXRpb24veG1sCitX S0ZPT0JBUihudWxsKTogV0tGT09CQVIobnVsbCBieXRlcyksIENvbnRlbnQtVHlwZTogbnVsbAor V0tGT09CQVIoIjEyMyIpOiBXS0ZPT0JBUigzIGJ5dGVzKSwgQ29udGVudC1UeXBlOiBhcHBsaWNh dGlvbi94bWwKK1NFQVJDSCgiIik6IFNFQVJDSCgwIGJ5dGVzKSwgQ29udGVudC1UeXBlOiBhcHBs aWNhdGlvbi94bWwKK1NFQVJDSChudWxsKTogU0VBUkNIKG51bGwgYnl0ZXMpLCBDb250ZW50LVR5 cGU6IG51bGwKK1NFQVJDSCgiMTIzIik6IFNFQVJDSCgzIGJ5dGVzKSwgQ29udGVudC1UeXBlOiBh cHBsaWNhdGlvbi94bWwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVt L3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rl c3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCA1OTA3MTkxMzA4NjlmZDQ0NjcwNTA1ZjlhNDE5ZTQx NzNiNTZmMTY5Li5hMmNmZDM1ZDAxNjJmMDM0ZjA3Y2Y1YmJlMGFhNzI4NmM0ODVlODg5IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50 eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMu dHh0CkBAIC01NDIsMTQgKzU0MiwxMiBAQCBCVUcyMDQwNCA6IGVkaXRpbmcvZXhlY0NvbW1hbmQv Y29weS13aXRob3V0LXNlbGVjdGlvbi5odG1sID0gRkFJTAogLy8gKE5vdGUgdGhhdCBsaWdodHRw ZCBpcyBvbmx5IHVzZWQgb24gV2luZG93cyBhdCB0aGlzIHBvaW50LikKIAogLy8gTGlnaHRUUEQg ZG9lc24ndCBhY2NlcHQgdW5rbm93biBIVFRQIG1ldGhvZHMKLUJVRzMwNTM2IFNLSVAgOiBodHRw L3Rlc3RzL3htbGh0dHByZXF1ZXN0L21ldGhvZHMtbG93ZXItY2FzZS5odG1sID0gVElNRU9VVCBD UkFTSAotQlVHMzA1MzYgTElOVVggTUFDIDogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9tZXRo b2RzLWFzeW5jLmh0bWwgPSBURVhUCi1CVUczMDUzNiBXSU4gICAgICAgOiBodHRwL3Rlc3RzL3ht bGh0dHByZXF1ZXN0L21ldGhvZHMtYXN5bmMuaHRtbCA9IFRJTUVPVVQKK0JVRzMwNTM2IFdJTiBT S0lQIDogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9tZXRob2RzLWxvd2VyLWNhc2UuaHRtbCA9 IFRJTUVPVVQgQ1JBU0gKK0JVRzMwNTM2IFdJTiA6IGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qv bWV0aG9kcy1hc3luYy5odG1sID0gVElNRU9VVAogQlVHMzA1MzYgV0lOIFNMT1cgOiBodHRwL3Rl c3RzL3htbGh0dHByZXF1ZXN0L2FjY2Vzcy1jb250cm9sLWJhc2ljLWFsbG93LXByZWZsaWdodC1j YWNoZS1pbnZhbGlkYXRpb24tYnktbWV0aG9kLmh0bWwgPSBGQUlMCiAvLyBMaWdodFRQRCBkb2Vz bid0IGFjY2VwdCB1bmtub3duIEhUVFAgbWV0aG9kcyBhbmQgcGFzc2VzIENHSXMgYSBDb250ZW50 LVR5cGUKIC8vIGV2ZW4gd2hlbiBhIHJlcXVlc3QgZGlkbid0IHNlbmQgdGhlIGhlYWRlci4KIEJV RzMwNTM2IFdJTiBTTE9XIDogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9tZXRob2RzLmh0bWwg PSBGQUlMCi1CVUczMDUzNiBNQUMgTElOVVggOiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L21l dGhvZHMuaHRtbCA9IEZBSUwKIC8vIFdlYmtpdCA1MDY2Nzo1MDY5NiAoTGlnaHR0cGQgcmVsYXRl ZD8pCiBCVUczMDUzNiBXSU4gOiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1 ZXN0LXNldHJlcXVlc3RoZWFkZXItbm8tdmFsdWUuaHRtbCA9IFRFWFQKIAo=