46272 2010-09-22 10:05:54 -0700 Web Inspector: Tree views can be collapsed/hidden using the keyboard arrows 2012-01-03 12:54:30 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Minor --- 0 rowan apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik webkitx yurys oldest_to_newest 283007 0 rowan 2010-09-22 10:05:54 -0700 Many of the inspector panes appear to use tree views in the left-hand navigation to displays lists of items - for example, Resources has the list of resources; Profiles has a list of recorded profiles; Storage has multiple groups of databases, cookies etc; and Audits has a list of results. If one of these items is selected and has focus, using the left arrow on the keyboard appears to collapse the treeview and hide all the items. This appears to be the behaviour in both Safari 5.0.2 and the WebKit nightlies on OS X. For example: 1) Go to the Resources view 2) Click on first item in the Resources list - the document. 3) Hit the left arrow Expected result: Probably nothing should happen. Actual result: the Resources list appears to be emptied. Using the right arrow, the tree can be expanded again while it has focus; if the tree view lose focus while collapsed, there appears to be no way to restore it. 527865 1 120727 apavlov 2011-12-29 02:50:55 -0800 Created attachment 120727 Patch 527893 2 apavlov 2011-12-29 05:29:15 -0800 Committed r103797: <http://trac.webkit.org/changeset/103797> 528950 3 webkitx 2012-01-03 12:13:30 -0800 I'm sure this behaviour is standard for tree views and for people with accessibility issues. 528971 4 rowan 2012-01-03 12:54:30 -0800 Re: comment #3: this is absolutely standard behaviour for true tree views, for example those used in the redesigned Resources sidebar. However the inspector also sometimes uses tree views to lay out content with headers, for example the Audits results list; these views weren't collapsable using the mouse as that wasn't an intended interaction, but were using the keyboard (usually accidentally!). apavlov: Thanks for the patch, works a treat! 120727 2011-12-29 02:50:55 -0800 2011-12-29 05:26:50 -0800 Patch bug-46272-20111229145053.patch text/plain 5051 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzNzkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmI3NzkxZjY4MWUzMWQ3 OTJhM2E5OGQyNGY4OTRkMzU0YWUwOGU2MS4uYTU4ZWNhNTM3ZjkxOWIyYzViZGVkYjZiYjdlZDJj NTlmZWUxYzZmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDExLTEyLTI5ICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogVHJlZSB2aWV3cyBjYW4gYmUgY29sbGFwc2VkL2hpZGRlbiB1c2luZyB0aGUga2V5Ym9h cmQgYXJyb3dzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00NjI3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdlYkluc3BlY3Rvci5TaWRlYmFyU2VjdGlvblRyZWVFbGVtZW50IHdoaWNoIGlzIG5vdCBzZWxl Y3RhYmxlIGhhcyBhbHNvIGJlZW4gbWFkZSBub24tY29sbGFwc2libGUKKyAgICAgICAgYW5kIGV4 cGFuZGVkIGJ5IGRlZmF1bHQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0F1ZGl0 c1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkF1ZGl0c1BhbmVsKToKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuUHJvZmlsZXNQYW5lbC5wcm90b3R5cGUuX3JlZ2lzdGVyUHJvZmlsZVR5cGUpOgorICAg ICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU2lkZWJhclRyZWVFbGVtZW50LmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLlNpZGViYXJTZWN0aW9uVHJlZUVsZW1lbnQpOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlNpZGViYXJTZWN0aW9uVHJlZUVsZW1lbnQucHJvdG90eXBlLnNlbGVjdGFibGUu ZmFsc2UuY29sbGFwc2UpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQ YW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVsKToKKwogMjAxMS0x Mi0yOCAgQW5kcmVhcyBLbGluZyAgPGF3ZXNvbWVrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAg UmVkdWNlIG1lbW9yeSB1c2VkIGJ5IE5hbWVkTm9kZU1hcC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQXVkaXRzUGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0F1ZGl0c1BhbmVsLmpzCmluZGV4IDhlNTFhMzJhMmYzNDUw M2YxYWY4ODc3NDA4ZTU5MmQwZmUzZGNmYzQuLmNjMTk1NWJiMTgwMjE5MTEzMDNkNDZkYTAzNmNh ODA1ZjY2YjA3N2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvQXVkaXRzUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9BdWRpdHNQYW5lbC5qcwpAQCAtNDIsNyArNDIsNiBAQCBXZWJJbnNwZWN0b3IuQXVkaXRzUGFu ZWwgPSBmdW5jdGlvbigpCiAgICAgdGhpcy5hdWRpdHNUcmVlRWxlbWVudCA9IG5ldyBXZWJJbnNw ZWN0b3IuU2lkZWJhclNlY3Rpb25UcmVlRWxlbWVudCgiIiwge30sIHRydWUpOwogICAgIHRoaXMu c2lkZWJhclRyZWUuYXBwZW5kQ2hpbGQodGhpcy5hdWRpdHNUcmVlRWxlbWVudCk7CiAgICAgdGhp cy5hdWRpdHNUcmVlRWxlbWVudC5saXN0SXRlbUVsZW1lbnQuYWRkU3R5bGVDbGFzcygiaGlkZGVu Iik7Ci0gICAgdGhpcy5hdWRpdHNUcmVlRWxlbWVudC5leHBhbmQoKTsKIAogICAgIHRoaXMuYXVk aXRzSXRlbVRyZWVFbGVtZW50ID0gbmV3IFdlYkluc3BlY3Rvci5BdWRpdHNTaWRlYmFyVHJlZUVs ZW1lbnQoKTsKICAgICB0aGlzLmF1ZGl0c1RyZWVFbGVtZW50LmFwcGVuZENoaWxkKHRoaXMuYXVk aXRzSXRlbVRyZWVFbGVtZW50KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvUHJvZmlsZXNQYW5lbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvUHJvZmlsZXNQYW5lbC5qcwppbmRleCA2ZTE0YjlkMWVkMzIxZTZhZWI5YmE5Njdj YzY2OGM2NTZjOGEyNTNlLi4yNGRiZDM0YTY3YTRmYmU0ZDU1MDU0MjEwMDdkYTY0MDI0Y2EyOTY2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVz UGFuZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9maWxl c1BhbmVsLmpzCkBAIC0yNzMsNyArMjczLDcgQEAgV2ViSW5zcGVjdG9yLlByb2ZpbGVzUGFuZWwu cHJvdG90eXBlID0gewogICAgIHsKICAgICAgICAgdGhpcy5fcHJvZmlsZVR5cGVzQnlJZE1hcFtw cm9maWxlVHlwZS5pZF0gPSBwcm9maWxlVHlwZTsKICAgICAgICAgdGhpcy5fbGF1bmNoZXJWaWV3 LmFkZFByb2ZpbGVUeXBlKHByb2ZpbGVUeXBlKTsKLSAgICAgICAgcHJvZmlsZVR5cGUudHJlZUVs ZW1lbnQgPSBuZXcgV2ViSW5zcGVjdG9yLlByb2ZpbGVUeXBlVHJlZUVsZW1lbnQocHJvZmlsZVR5 cGUudHJlZUl0ZW1UaXRsZSk7CisgICAgICAgIHByb2ZpbGVUeXBlLnRyZWVFbGVtZW50ID0gbmV3 IFdlYkluc3BlY3Rvci5TaWRlYmFyU2VjdGlvblRyZWVFbGVtZW50KHByb2ZpbGVUeXBlLnRyZWVJ dGVtVGl0bGUsIG51bGwsIHRydWUpOwogICAgICAgICBwcm9maWxlVHlwZS50cmVlRWxlbWVudC5o aWRkZW4gPSB0cnVlOwogICAgICAgICB0aGlzLnNpZGViYXJUcmVlLmFwcGVuZENoaWxkKHByb2Zp bGVUeXBlLnRyZWVFbGVtZW50KTsKICAgICB9LApAQCAtOTA1LDIxICs5MDUsNiBAQCBXZWJJbnNw ZWN0b3IuUHJvZmlsZXJEaXNwYXRjaGVyLnByb3RvdHlwZSA9IHsKICAgICB9CiB9CiAKLVdlYklu c3BlY3Rvci5Qcm9maWxlVHlwZVRyZWVFbGVtZW50ID0gZnVuY3Rpb24odGl0bGUpCi17Ci0gICAg V2ViSW5zcGVjdG9yLlNpZGViYXJTZWN0aW9uVHJlZUVsZW1lbnQuY2FsbCh0aGlzLCB0aXRsZSwg bnVsbCwgdHJ1ZSk7Ci0gICAgdGhpcy5leHBhbmQoKTsKLX0KLQotV2ViSW5zcGVjdG9yLlByb2Zp bGVUeXBlVHJlZUVsZW1lbnQucHJvdG90eXBlID0gewotICAgIGNvbGxhcHNlOiBmdW5jdGlvbigp Ci0gICAgewotICAgICAgICAvLyBTaG91bGQgbm90IGNvbGxhcHNlLgotICAgIH0KLX0KLQotV2Vi SW5zcGVjdG9yLlByb2ZpbGVUeXBlVHJlZUVsZW1lbnQucHJvdG90eXBlLl9fcHJvdG9fXyA9IFdl Ykluc3BlY3Rvci5TaWRlYmFyU2VjdGlvblRyZWVFbGVtZW50LnByb3RvdHlwZTsKLQogV2ViSW5z cGVjdG9yLlByb2ZpbGVTaWRlYmFyVHJlZUVsZW1lbnQgPSBmdW5jdGlvbihwcm9maWxlLCB0aXRs ZUZvcm1hdCwgY2xhc3NOYW1lKQogewogICAgIHRoaXMucHJvZmlsZSA9IHByb2ZpbGU7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NpZGViYXJUcmVlRWxl bWVudC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2lkZWJhclRyZWVF bGVtZW50LmpzCmluZGV4IDIxMTMyNTgwYTNhZjA0ZWRjNGQwNGM3MjRjNTQwNjJiZmU5OGExZTcu LjQyN2NkYzU5NTk2YWQyMzc4YmE5MjQ1ZDYxOTk3MTFmZGI1ZWRjY2YgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2lkZWJhclRyZWVFbGVtZW50LmpzCisr KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2lkZWJhclRyZWVFbGVtZW50 LmpzCkBAIC0zMCwxMSArMzAsMTcgQEAKIFdlYkluc3BlY3Rvci5TaWRlYmFyU2VjdGlvblRyZWVF bGVtZW50ID0gZnVuY3Rpb24odGl0bGUsIHJlcHJlc2VudGVkT2JqZWN0LCBoYXNDaGlsZHJlbikK IHsKICAgICBUcmVlRWxlbWVudC5jYWxsKHRoaXMsIHRpdGxlLmVzY2FwZUhUTUwoKSwgcmVwcmVz ZW50ZWRPYmplY3QgfHwge30sIGhhc0NoaWxkcmVuKTsKKyAgICB0aGlzLmV4cGFuZCgpOwogfQog CiBXZWJJbnNwZWN0b3IuU2lkZWJhclNlY3Rpb25UcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7CiAg ICAgc2VsZWN0YWJsZTogZmFsc2UsCiAKKyAgICBjb2xsYXBzZTogZnVuY3Rpb24oKQorICAgIHsK KyAgICAgICAgLy8gU2hvdWxkIG5vdCBjb2xsYXBzZSBhcyBpdCBpcyBub3Qgc2VsZWN0YWJsZS4K KyAgICB9LAorCiAgICAgZ2V0IHNtYWxsQ2hpbGRyZW4oKQogICAgIHsKICAgICAgICAgcmV0dXJu IHRoaXMuX3NtYWxsQ2hpbGRyZW47CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKaW5kZXggMDNkOTJlNDBiY2ViYmMyZDJjNWY0OWE3 NjdmNjQ4MDhmNWI4ZmY3YS4uOTk0N2I5NmZmZDNiYTNhODQxY2VmZTAwNWMwODA2NWUyODcyZmNk ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGlu ZVBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxp bmVQYW5lbC5qcwpAQCAtNTEsNyArNTEsNiBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbCA9 IGZ1bmN0aW9uKCkKICAgICB0aGlzLl9jb250YWluZXJFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIo InNjcm9sbCIsIHRoaXMuX29uU2Nyb2xsLmJpbmQodGhpcyksIGZhbHNlKTsKIAogICAgIHZhciBp dGVtc1RyZWVFbGVtZW50ID0gbmV3IFdlYkluc3BlY3Rvci5TaWRlYmFyU2VjdGlvblRyZWVFbGVt ZW50KFdlYkluc3BlY3Rvci5VSVN0cmluZygiUkVDT1JEUyIpLCB7fSwgdHJ1ZSk7Ci0gICAgaXRl bXNUcmVlRWxlbWVudC5leHBhbmRlZCA9IHRydWU7CiAgICAgdGhpcy5zaWRlYmFyVHJlZS5hcHBl bmRDaGlsZChpdGVtc1RyZWVFbGVtZW50KTsKIAogICAgIHRoaXMuX3NpZGViYXJMaXN0RWxlbWVu dCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwo=