46260 2010-09-22 06:32:31 -0700 Reduce the number of BOL checks in YARR Interpreter 2010-09-23 01:40:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pvarga webkit-unassigned barraclough commit-queue ggaren msaboff oldest_to_newest 282899 0 pvarga 2010-09-22 06:32:31 -0700 The "Yarr JIT code checks BOL (^) each time through loop when in subexpression" (https://bugs.webkit.org/show_bug.cgi?id=45787) optimization slows down the YARR Interpreter. The reason of the slow-down is the modification extends the tree which is generated by the regex parser. The Interpreter doesn't perform the BOL optimization therefore it does some unnecessary matches. The optimization should be implemented in the YARR Interpreter as well. 282900 1 68363 pvarga 2010-09-22 06:37:35 -0700 Created attachment 68363 proposed patch performance results: ref mod regexp-dna: - 283.3ms +/- 0.1% 282.5ms +/- 2.2% v8-regexp: 1.51x as fast 2426.7ms +/- 0.1% 1611.1ms +/- 0.7% 283128 2 68363 barraclough 2010-09-22 12:05:14 -0700 Comment on attachment 68363 proposed patch Looks great! 283553 3 68363 commit-queue 2010-09-23 01:40:22 -0700 Comment on attachment 68363 proposed patch Clearing flags on attachment: 68363 Committed r68127: <http://trac.webkit.org/changeset/68127> 283554 4 commit-queue 2010-09-23 01:40:27 -0700 All reviewed patches have been landed. Closing bug. 68363 2010-09-22 06:37:35 -0700 2010-09-23 01:40:22 -0700 proposed patch 0001-BOL-optimization-interpreter.patch text/plain 6881 pvarga RnJvbSAzOTYwZDQ5ZmYyMmNlY2Q3MjVlMjIzM2FmZTU3MmIxMThiNjAyN2IzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBWYXJnYSA8cHZhcmdhQGluZi51LXN6ZWdlZC5odT4K RGF0ZTogV2VkLCAyMiBTZXAgMjAxMCAxNTozNTo1MCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIEJP TCBvcHRpbWl6YXRpb24gaW50ZXJwcmV0ZXIKCi0tLQogSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n ICAgICAgICAgICAgICAgICB8ICAgMjUgKysrKysrKysrKysrKysrKysrKysrKysrKwogSmF2YVNj cmlwdENvcmUveWFyci9SZWdleEludGVycHJldGVyLmNwcCB8ICAgMTkgKysrKysrKysrKysrLS0t LS0tLQogSmF2YVNjcmlwdENvcmUveWFyci9SZWdleEludGVycHJldGVyLmggICB8ICAgMTEgKysr KysrKysrLS0KIDMgZmlsZXMgY2hhbmdlZCwgNDYgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKaW5kZXggYTNiNWM4MS4uMTUxMjY2OCAxMDA2NDQKLS0tIGEvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDI4IEBACisyMDEwLTA5LTIyICBQZXRlciBWYXJnYSAgPHB2YXJnYUBpbmYudS1zemVnZWQuaHU+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVkdWNl IHRoZSBudW1iZXIgb2YgQk9MIGNoZWNrcyBpbiBZQVJSIEludGVycHJldGVyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjI2MAorCisgICAgICAgIEV4 dGVuZCB0aGUgWUFSUiBJbnRlcnByZXRlciB3aXRoIGFuIG9wdGltaXphdGlvbiB3aGljaCByZWR1 Y2VzIHRoZSBudW1iZXIgb2YKKyAgICAgICAgQk9MIGFzc2VydGlvbiBjaGVja3MuIElmIGEgIlR5 cGVCb2R5QWx0ZXJuYXRpdmUiIGJ5dGVUZXJtIGlzIGZvbGxvd2VkIGJ5IGEKKyAgICAgICAgIlR5 cGVBc3NlcnRpb25CT0wiIGJ5dGVUZXJtIGl0IHdpbGwgYmUgY2hlY2tlZCBqdXN0IG9uZSB0aW1l LgorCisgICAgICAgICogeWFyci9SZWdleEludGVycHJldGVyLmNwcDoKKyAgICAgICAgKEpTQzo6 WWFycjo6SW50ZXJwcmV0ZXI6Om1hdGNoRGlzanVuY3Rpb24pOgorICAgICAgICAoSlNDOjpZYXJy OjpCeXRlQ29tcGlsZXI6OmNvbXBpbGUpOgorICAgICAgICAoSlNDOjpZYXJyOjpCeXRlQ29tcGls ZXI6OnJlZ2V4QmVnaW4pOgorICAgICAgICAoSlNDOjpZYXJyOjpCeXRlQ29tcGlsZXI6OmFsdGVy bmF0aXZlQm9keURpc2p1bmN0aW9uKToKKyAgICAgICAgKEpTQzo6WWFycjo6Qnl0ZUNvbXBpbGVy OjplbWl0RGlzanVuY3Rpb24pOgorICAgICAgICAqIHlhcnIvUmVnZXhJbnRlcnByZXRlci5oOgor ICAgICAgICAoSlNDOjpZYXJyOjpCeXRlVGVybTo6Qm9keUFsdGVybmF0aXZlQmVnaW4pOgorICAg ICAgICAoSlNDOjpZYXJyOjpCeXRlVGVybTo6Qm9keUFsdGVybmF0aXZlRGlzanVuY3Rpb24pOgor ICAgICAgICAoSlNDOjpZYXJyOjpCeXRlVGVybTo6Qm9keUFsdGVybmF0aXZlRW5kKToKKyAgICAg ICAgKEpTQzo6WWFycjo6Qnl0ZVRlcm06OkFsdGVybmF0aXZlQmVnaW4pOgorICAgICAgICAoSlND OjpZYXJyOjpCeXRlVGVybTo6QWx0ZXJuYXRpdmVEaXNqdW5jdGlvbik6CisgICAgICAgIChKU0M6 OllhcnI6OkJ5dGVUZXJtOjpBbHRlcm5hdGl2ZUVuZCk6CisKIDIwMTAtMDktMjEgIE9saXZlciBI dW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSUz1HYXZpbiBCYXJyYWNsb3VnaC4K ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3lhcnIvUmVnZXhJbnRlcnByZXRlci5jcHAgYi9K YXZhU2NyaXB0Q29yZS95YXJyL1JlZ2V4SW50ZXJwcmV0ZXIuY3BwCmluZGV4IGQ1MGM2YzguLjE3 ZmZkOGYgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3lhcnIvUmVnZXhJbnRlcnByZXRlci5j cHAKKysrIGIvSmF2YVNjcmlwdENvcmUveWFyci9SZWdleEludGVycHJldGVyLmNwcApAQCAtMTEw Niw2ICsxMTA2LDEwIEBAIHB1YmxpYzoKIAogICAgICAgICAgICAgaW5wdXQubmV4dCgpOwogICAg ICAgICAgICAgY29udGV4dC0+bWF0Y2hCZWdpbiA9IGlucHV0LmdldFBvcygpOworCisgICAgICAg ICAgICBpZiAoY3VycmVudFRlcm0oKS5hbHRlcm5hdGl2ZS5vbmNlVGhyb3VnaCkKKyAgICAgICAg ICAgICAgICBjb250ZXh0LT50ZXJtICs9IGN1cnJlbnRUZXJtKCkuYWx0ZXJuYXRpdmUubmV4dDsK KwogICAgICAgICAgICAgTUFUQ0hfTkVYVCgpOwogICAgICAgICB9CiAgICAgICAgIGNhc2UgQnl0 ZVRlcm06OlR5cGVCb2R5QWx0ZXJuYXRpdmVFbmQ6CkBAIC0xMjU3LDcgKzEyNjEsNyBAQCBwdWJs aWM6CiAKICAgICBQYXNzT3duUHRyPEJ5dGVjb2RlUGF0dGVybj4gY29tcGlsZShCdW1wUG9pbnRl ckFsbG9jYXRvciogYWxsb2NhdG9yKQogICAgIHsKLSAgICAgICAgcmVnZXhCZWdpbihtX3BhdHRl cm4ubV9udW1TdWJwYXR0ZXJucywgbV9wYXR0ZXJuLm1fYm9keS0+bV9jYWxsRnJhbWVTaXplKTsK KyAgICAgICAgcmVnZXhCZWdpbihtX3BhdHRlcm4ubV9udW1TdWJwYXR0ZXJucywgbV9wYXR0ZXJu Lm1fYm9keS0+bV9jYWxsRnJhbWVTaXplLCBtX3BhdHRlcm4ubV9ib2R5LT5tX2FsdGVybmF0aXZl c1swXS0+b25jZVRocm91Z2goKSk7CiAgICAgICAgIGVtaXREaXNqdW5jdGlvbihtX3BhdHRlcm4u bV9ib2R5KTsKICAgICAgICAgcmVnZXhFbmQoKTsKIApAQCAtMTQ2MiwxMCArMTQ2NiwxMCBAQCBw dWJsaWM6CiAgICAgICAgIH0KICAgICB9CiAKLSAgICB2b2lkIHJlZ2V4QmVnaW4odW5zaWduZWQg bnVtU3VicGF0dGVybnMsIHVuc2lnbmVkIGNhbGxGcmFtZVNpemUpCisgICAgdm9pZCByZWdleEJl Z2luKHVuc2lnbmVkIG51bVN1YnBhdHRlcm5zLCB1bnNpZ25lZCBjYWxsRnJhbWVTaXplLCBib29s IG9uY2VUaHJvdWdoKQogICAgIHsKICAgICAgICAgbV9ib2R5RGlzanVuY3Rpb24gPSBhZG9wdFB0 cihuZXcgQnl0ZURpc2p1bmN0aW9uKG51bVN1YnBhdHRlcm5zLCBjYWxsRnJhbWVTaXplKSk7Ci0g ICAgICAgIG1fYm9keURpc2p1bmN0aW9uLT50ZXJtcy5hcHBlbmQoQnl0ZVRlcm06OkJvZHlBbHRl cm5hdGl2ZUJlZ2luKCkpOworICAgICAgICBtX2JvZHlEaXNqdW5jdGlvbi0+dGVybXMuYXBwZW5k KEJ5dGVUZXJtOjpCb2R5QWx0ZXJuYXRpdmVCZWdpbihvbmNlVGhyb3VnaCkpOwogICAgICAgICBt X2JvZHlEaXNqdW5jdGlvbi0+dGVybXNbMF0uZnJhbWVMb2NhdGlvbiA9IDA7CiAgICAgICAgIG1f Y3VycmVudEFsdGVybmF0aXZlSW5kZXggPSAwOwogICAgIH0KQEAgLTE0NzUsMTEgKzE0NzksMTEg QEAgcHVibGljOgogICAgICAgICBjbG9zZUJvZHlBbHRlcm5hdGl2ZSgpOwogICAgIH0KIAotICAg IHZvaWQgYWx0ZXJuYXRpdmVCb2R5RGlzanVuY3Rpb24oKQorICAgIHZvaWQgYWx0ZXJuYXRpdmVC b2R5RGlzanVuY3Rpb24oYm9vbCBvbmNlVGhyb3VnaCkKICAgICB7CiAgICAgICAgIGludCBuZXdB bHRlcm5hdGl2ZUluZGV4ID0gbV9ib2R5RGlzanVuY3Rpb24tPnRlcm1zLnNpemUoKTsKICAgICAg ICAgbV9ib2R5RGlzanVuY3Rpb24tPnRlcm1zW21fY3VycmVudEFsdGVybmF0aXZlSW5kZXhdLmFs dGVybmF0aXZlLm5leHQgPSBuZXdBbHRlcm5hdGl2ZUluZGV4IC0gbV9jdXJyZW50QWx0ZXJuYXRp dmVJbmRleDsKLSAgICAgICAgbV9ib2R5RGlzanVuY3Rpb24tPnRlcm1zLmFwcGVuZChCeXRlVGVy bTo6Qm9keUFsdGVybmF0aXZlRGlzanVuY3Rpb24oKSk7CisgICAgICAgIG1fYm9keURpc2p1bmN0 aW9uLT50ZXJtcy5hcHBlbmQoQnl0ZVRlcm06OkJvZHlBbHRlcm5hdGl2ZURpc2p1bmN0aW9uKG9u Y2VUaHJvdWdoKSk7CiAKICAgICAgICAgbV9jdXJyZW50QWx0ZXJuYXRpdmVJbmRleCA9IG5ld0Fs dGVybmF0aXZlSW5kZXg7CiAgICAgfQpAQCAtMTQ5OCwxNCArMTUwMiwxNSBAQCBwdWJsaWM6CiAg ICAgICAgIGZvciAodW5zaWduZWQgYWx0ID0gMDsgYWx0IDwgZGlzanVuY3Rpb24tPm1fYWx0ZXJu YXRpdmVzLnNpemUoKTsgKythbHQpIHsKICAgICAgICAgICAgIHVuc2lnbmVkIGN1cnJlbnRDb3Vu dEFscmVhZHlDaGVja2VkID0gaW5wdXRDb3VudEFscmVhZHlDaGVja2VkOwogCisgICAgICAgICAg ICBQYXR0ZXJuQWx0ZXJuYXRpdmUqIGFsdGVybmF0aXZlID0gZGlzanVuY3Rpb24tPm1fYWx0ZXJu YXRpdmVzW2FsdF07CisKICAgICAgICAgICAgIGlmIChhbHQpIHsKICAgICAgICAgICAgICAgICBp ZiAoZGlzanVuY3Rpb24gPT0gbV9wYXR0ZXJuLm1fYm9keSkKLSAgICAgICAgICAgICAgICAgICAg YWx0ZXJuYXRpdmVCb2R5RGlzanVuY3Rpb24oKTsKKyAgICAgICAgICAgICAgICAgICAgYWx0ZXJu YXRpdmVCb2R5RGlzanVuY3Rpb24oYWx0ZXJuYXRpdmUtPm9uY2VUaHJvdWdoKCkpOwogICAgICAg ICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICAgICAgYWx0ZXJuYXRpdmVEaXNqdW5jdGlv bigpOwogICAgICAgICAgICAgfQogCi0gICAgICAgICAgICBQYXR0ZXJuQWx0ZXJuYXRpdmUqIGFs dGVybmF0aXZlID0gZGlzanVuY3Rpb24tPm1fYWx0ZXJuYXRpdmVzW2FsdF07CiAgICAgICAgICAg ICB1bnNpZ25lZCBtaW5pbXVtU2l6ZSA9IGFsdGVybmF0aXZlLT5tX21pbmltdW1TaXplOwogCiAg ICAgICAgICAgICBBU1NFUlQobWluaW11bVNpemUgPj0gcGFyZW50aGVzZXNJbnB1dENvdW50QWxy ZWFkeUNoZWNrZWQpOwpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUveWFyci9SZWdleEludGVy cHJldGVyLmggYi9KYXZhU2NyaXB0Q29yZS95YXJyL1JlZ2V4SW50ZXJwcmV0ZXIuaAppbmRleCA0 ZGE5Y2M1Li4zN2YxN2ZlIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS95YXJyL1JlZ2V4SW50 ZXJwcmV0ZXIuaAorKysgYi9KYXZhU2NyaXB0Q29yZS95YXJyL1JlZ2V4SW50ZXJwcmV0ZXIuaApA QCAtOTQsNiArOTQsNyBAQCBzdHJ1Y3QgQnl0ZVRlcm0gewogICAgICAgICBzdHJ1Y3QgewogICAg ICAgICAgICAgaW50IG5leHQ7CiAgICAgICAgICAgICBpbnQgZW5kOworICAgICAgICAgICAgYm9v bCBvbmNlVGhyb3VnaDsKICAgICAgICAgfSBhbHRlcm5hdGl2ZTsKICAgICAgICAgdW5zaWduZWQg Y2hlY2tJbnB1dENvdW50OwogICAgIH07CkBAIC0yMTUsMTkgKzIxNiwyMSBAQCBzdHJ1Y3QgQnl0 ZVRlcm0gewogICAgICAgICByZXR1cm4gQnl0ZVRlcm0oVHlwZUJhY2tSZWZlcmVuY2UsIHN1YnBh dHRlcm5JZCwgZmFsc2UsIGlucHV0UG9zKTsKICAgICB9CiAKLSAgICBzdGF0aWMgQnl0ZVRlcm0g Qm9keUFsdGVybmF0aXZlQmVnaW4oKQorICAgIHN0YXRpYyBCeXRlVGVybSBCb2R5QWx0ZXJuYXRp dmVCZWdpbihib29sIG9uY2VUaHJvdWdoKQogICAgIHsKICAgICAgICAgQnl0ZVRlcm0gdGVybShU eXBlQm9keUFsdGVybmF0aXZlQmVnaW4pOwogICAgICAgICB0ZXJtLmFsdGVybmF0aXZlLm5leHQg PSAwOwogICAgICAgICB0ZXJtLmFsdGVybmF0aXZlLmVuZCA9IDA7CisgICAgICAgIHRlcm0uYWx0 ZXJuYXRpdmUub25jZVRocm91Z2ggPSBvbmNlVGhyb3VnaDsKICAgICAgICAgcmV0dXJuIHRlcm07 CiAgICAgfQogCi0gICAgc3RhdGljIEJ5dGVUZXJtIEJvZHlBbHRlcm5hdGl2ZURpc2p1bmN0aW9u KCkKKyAgICBzdGF0aWMgQnl0ZVRlcm0gQm9keUFsdGVybmF0aXZlRGlzanVuY3Rpb24oYm9vbCBv bmNlVGhyb3VnaCkKICAgICB7CiAgICAgICAgIEJ5dGVUZXJtIHRlcm0oVHlwZUJvZHlBbHRlcm5h dGl2ZURpc2p1bmN0aW9uKTsKICAgICAgICAgdGVybS5hbHRlcm5hdGl2ZS5uZXh0ID0gMDsKICAg ICAgICAgdGVybS5hbHRlcm5hdGl2ZS5lbmQgPSAwOworICAgICAgICB0ZXJtLmFsdGVybmF0aXZl Lm9uY2VUaHJvdWdoID0gb25jZVRocm91Z2g7CiAgICAgICAgIHJldHVybiB0ZXJtOwogICAgIH0K IApAQCAtMjM2LDYgKzIzOSw3IEBAIHN0cnVjdCBCeXRlVGVybSB7CiAgICAgICAgIEJ5dGVUZXJt IHRlcm0oVHlwZUJvZHlBbHRlcm5hdGl2ZUVuZCk7CiAgICAgICAgIHRlcm0uYWx0ZXJuYXRpdmUu bmV4dCA9IDA7CiAgICAgICAgIHRlcm0uYWx0ZXJuYXRpdmUuZW5kID0gMDsKKyAgICAgICAgdGVy bS5hbHRlcm5hdGl2ZS5vbmNlVGhyb3VnaCA9IGZhbHNlOwogICAgICAgICByZXR1cm4gdGVybTsK ICAgICB9CiAKQEAgLTI0NCw2ICsyNDgsNyBAQCBzdHJ1Y3QgQnl0ZVRlcm0gewogICAgICAgICBC eXRlVGVybSB0ZXJtKFR5cGVBbHRlcm5hdGl2ZUJlZ2luKTsKICAgICAgICAgdGVybS5hbHRlcm5h dGl2ZS5uZXh0ID0gMDsKICAgICAgICAgdGVybS5hbHRlcm5hdGl2ZS5lbmQgPSAwOworICAgICAg ICB0ZXJtLmFsdGVybmF0aXZlLm9uY2VUaHJvdWdoID0gZmFsc2U7CiAgICAgICAgIHJldHVybiB0 ZXJtOwogICAgIH0KIApAQCAtMjUyLDYgKzI1Nyw3IEBAIHN0cnVjdCBCeXRlVGVybSB7CiAgICAg ICAgIEJ5dGVUZXJtIHRlcm0oVHlwZUFsdGVybmF0aXZlRGlzanVuY3Rpb24pOwogICAgICAgICB0 ZXJtLmFsdGVybmF0aXZlLm5leHQgPSAwOwogICAgICAgICB0ZXJtLmFsdGVybmF0aXZlLmVuZCA9 IDA7CisgICAgICAgIHRlcm0uYWx0ZXJuYXRpdmUub25jZVRocm91Z2ggPSBmYWxzZTsKICAgICAg ICAgcmV0dXJuIHRlcm07CiAgICAgfQogCkBAIC0yNjAsNiArMjY2LDcgQEAgc3RydWN0IEJ5dGVU ZXJtIHsKICAgICAgICAgQnl0ZVRlcm0gdGVybShUeXBlQWx0ZXJuYXRpdmVFbmQpOwogICAgICAg ICB0ZXJtLmFsdGVybmF0aXZlLm5leHQgPSAwOwogICAgICAgICB0ZXJtLmFsdGVybmF0aXZlLmVu ZCA9IDA7CisgICAgICAgIHRlcm0uYWx0ZXJuYXRpdmUub25jZVRocm91Z2ggPSBmYWxzZTsKICAg ICAgICAgcmV0dXJuIHRlcm07CiAgICAgfQogCi0tIAoxLjcuMi4yCgo=