46237 2010-09-21 18:33:59 -0700 Crash due to bad cast in AXObjectCacheChromium.cpp 2010-09-22 01:59:09 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P1 Major --- 0 ctguil webkit-unassigned atwilson commit-queue dglazkov webkit.review.bot oldest_to_newest 282716 0 ctguil 2010-09-21 18:33:59 -0700 Chromium bug: http://code.google.com/p/chromium/issues/detail?id=56473 toChromeClientChromium in WebCore\accessibility\chromium\AXObjectCacheChromium.cpp is incorrectly casting a WebCore::SVGImageChromeClient to a WebCore::ChromeClientChromium This crashes when AXObjectCache::postPlatformNotification tries to call virtual method postAccessibilityNotification on a ChromeClientChromium. 282736 1 68327 ctguil 2010-09-21 19:25:11 -0700 Created attachment 68327 Move accessibility functions from ChromeClientChromium to ChromeClient 282739 2 webkit.review.bot 2010-09-21 19:30:29 -0700 Attachment 68327 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/page/ChromeClient.h:50: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 282790 3 68327 cfleizach 2010-09-21 23:57:51 -0700 Comment on attachment 68327 Move accessibility functions from ChromeClientChromium to ChromeClient r=me 282846 4 68327 commit-queue 2010-09-22 01:59:05 -0700 Comment on attachment 68327 Move accessibility functions from ChromeClientChromium to ChromeClient Clearing flags on attachment: 68327 Committed r68031: <http://trac.webkit.org/changeset/68031> 282847 5 commit-queue 2010-09-22 01:59:09 -0700 All reviewed patches have been landed. Closing bug. 68327 2010-09-21 19:25:11 -0700 2010-09-22 01:59:04 -0700 Move accessibility functions from ChromeClientChromium to ChromeClient MyPatch.txt text/plain 4707 ctguil SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODAwNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDktMjEgIENocmlzIEd1aWxsb3J5ICAgPGNocmlzLmd1aWxs b3J5QGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ3Jhc2ggZHVlIHRvIGJhZCBjYXN0IGluIEFYT2JqZWN0Q2FjaGVDaHJvbWl1bS5j cHAuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjIz NworCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9jaHJvbWl1bS9BWE9iamVjdENhY2hlQ2hyb21p dW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6cG9zdFBsYXRmb3JtTm90 aWZpY2F0aW9uKToKKyAgICAgICAgKiBwYWdlL0Nocm9tZUNsaWVudC5oOgorICAgICAgICAoV2Vi Q29yZTo6Q2hyb21lQ2xpZW50Ojpwb3N0QWNjZXNzaWJpbGl0eU5vdGlmaWNhdGlvbik6CisgICAg ICAgIChXZWJDb3JlOjpDaHJvbWVDbGllbnQ6OmRpZENoYW5nZUFjY2Vzc2liaWxpdHlPYmplY3RT dGF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWVDbGllbnQ6OmRpZENoYW5nZUFjY2Vzc2li aWxpdHlPYmplY3RDaGlsZHJlbik6CisgICAgICAgICogcGFnZS9jaHJvbWl1bS9DaHJvbWVDbGll bnRDaHJvbWl1bS5oOgorCiAyMDEwLTA5LTIxICBBbmRyZXcgV2lsc29uICA8YXR3aWxzb25AY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI2Nzk4Mi4KSW5k ZXg6IFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9jaHJvbWl1bS9BWE9iamVjdENhY2hlQ2hyb21pdW0u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9jaHJvbWl1bS9BWE9iamVj dENhY2hlQ2hyb21pdW0uY3BwCShyZXZpc2lvbiA2ODAwNykKKysrIFdlYkNvcmUvYWNjZXNzaWJp bGl0eS9jaHJvbWl1bS9BWE9iamVjdENhY2hlQ2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yOCwyMCArMjgsMTEgQEAKICNpbmNsdWRlICJBWE9iamVjdENhY2hlLmgiCiAjaW5jbHVkZSAi QWNjZXNzaWJpbGl0eU9iamVjdC5oIgogI2luY2x1ZGUgIkNocm9tZS5oIgotI2luY2x1ZGUgIkNo cm9tZUNsaWVudENocm9taXVtLmgiCisjaW5jbHVkZSAiQ2hyb21lQ2xpZW50LmgiCiAjaW5jbHVk ZSAiRnJhbWVWaWV3LmgiCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotc3RhdGljIENocm9tZUNs aWVudENocm9taXVtKiB0b0Nocm9tZUNsaWVudENocm9taXVtKEZyYW1lVmlldyogdmlldykKLXsK LSAgICBQYWdlKiBwYWdlID0gdmlldy0+ZnJhbWUoKSA/IHZpZXctPmZyYW1lKCktPnBhZ2UoKSA6 IDA7Ci0gICAgaWYgKCFwYWdlKQotICAgICAgICByZXR1cm4gMDsKLQotICAgIHJldHVybiBzdGF0 aWNfY2FzdDxDaHJvbWVDbGllbnRDaHJvbWl1bSo+KHBhZ2UtPmNocm9tZSgpLT5jbGllbnQoKSk7 Ci19Ci0KIHZvaWQgQVhPYmplY3RDYWNoZTo6ZGV0YWNoV3JhcHBlcihBY2Nlc3NpYmlsaXR5T2Jq ZWN0KiBvYmopCiB7CiAgICAgLy8gSW4gQ2hyb21pdW0sIEFjY2Vzc2liaWxpdHlPYmplY3RzIGFy ZSB3cmFwcGVkIGxhemlseS4KQEAgLTU2LDEwICs0NywxMCBAQCB2b2lkIEFYT2JqZWN0Q2FjaGU6 OmF0dGFjaFdyYXBwZXIoQWNjZXNzCiAKIHZvaWQgQVhPYmplY3RDYWNoZTo6cG9zdFBsYXRmb3Jt Tm90aWZpY2F0aW9uKEFjY2Vzc2liaWxpdHlPYmplY3QqIG9iaiwgQVhOb3RpZmljYXRpb24gbm90 aWZpY2F0aW9uKQogewotICAgIGlmICghb2JqIHx8ICFvYmotPmRvY3VtZW50KCkgfHwgIW9iai0+ ZG9jdW1lbnRGcmFtZVZpZXcoKSkKKyAgICBpZiAoIW9iaiB8fCAhb2JqLT5kb2N1bWVudCgpIHx8 ICFvYmotPmRvY3VtZW50RnJhbWVWaWV3KCkgfHwgIW9iai0+ZG9jdW1lbnRGcmFtZVZpZXcoKS0+ ZnJhbWUoKSB8fCAhb2JqLT5kb2N1bWVudEZyYW1lVmlldygpLT5mcmFtZSgpLT5wYWdlKCkpCiAg ICAgICAgIHJldHVybjsKIAotICAgIENocm9tZUNsaWVudENocm9taXVtKiBjbGllbnQgPSB0b0No cm9tZUNsaWVudENocm9taXVtKG9iai0+ZG9jdW1lbnRGcmFtZVZpZXcoKSk7CisgICAgQ2hyb21l Q2xpZW50KiBjbGllbnQgPSBvYmotPmRvY3VtZW50RnJhbWVWaWV3KCktPmZyYW1lKCktPnBhZ2Uo KS0+Y2hyb21lKCktPmNsaWVudCgpOwogICAgIGlmICghY2xpZW50KQogICAgICAgICByZXR1cm47 CiAKSW5kZXg6IFdlYkNvcmUvcGFnZS9DaHJvbWVDbGllbnQuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3BhZ2UvQ2hyb21lQ2xpZW50LmgJKHJldmlzaW9uIDY3OTE1KQorKysgV2ViQ29yZS9wYWdl L0Nocm9tZUNsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMSw2ICsyMSw3IEBACiAjaWZuZGVm IENocm9tZUNsaWVudF9oCiAjZGVmaW5lIENocm9tZUNsaWVudF9oCiAKKyNpbmNsdWRlICJBWE9i amVjdENhY2hlLmgiCiAjaW5jbHVkZSAiQ29uc29sZS5oIgogI2luY2x1ZGUgIkN1cnNvci5oIgog I2luY2x1ZGUgIkZvY3VzRGlyZWN0aW9uLmgiCkBAIC00Niw2ICs0Nyw3IEBAIGNsYXNzIE5TUmVz cG9uZGVyOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKKyAgICBjbGFzcyBBY2Nlc3NpYmlsaXR5 T2JqZWN0OwogICAgIGNsYXNzIEVsZW1lbnQ7CiAgICAgY2xhc3MgRmlsZUNob29zZXI7CiAgICAg Y2xhc3MgRmxvYXRSZWN0OwpAQCAtMjY4LDYgKzI3MCwxMCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAgICAgICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxQb3B1cE1lbnU+IGNyZWF0ZVBvcHVwTWVudShQ b3B1cE1lbnVDbGllbnQqKSBjb25zdCA9IDA7CiAgICAgICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxT ZWFyY2hQb3B1cE1lbnU+IGNyZWF0ZVNlYXJjaFBvcHVwTWVudShQb3B1cE1lbnVDbGllbnQqKSBj b25zdCA9IDA7CiAKKyAgICAgICAgdmlydHVhbCB2b2lkIHBvc3RBY2Nlc3NpYmlsaXR5Tm90aWZp Y2F0aW9uKEFjY2Vzc2liaWxpdHlPYmplY3QqLCBBWE9iamVjdENhY2hlOjpBWE5vdGlmaWNhdGlv bikgeyB9CisgICAgICAgIHZpcnR1YWwgdm9pZCBkaWRDaGFuZ2VBY2Nlc3NpYmlsaXR5T2JqZWN0 U3RhdGUoQWNjZXNzaWJpbGl0eU9iamVjdCopIHsgfQorICAgICAgICB2aXJ0dWFsIHZvaWQgZGlk Q2hhbmdlQWNjZXNzaWJpbGl0eU9iamVjdENoaWxkcmVuKEFjY2Vzc2liaWxpdHlPYmplY3QqKSB7 IH0KKwogICAgIHByb3RlY3RlZDoKICAgICAgICAgdmlydHVhbCB+Q2hyb21lQ2xpZW50KCkgeyB9 CiAgICAgfTsKSW5kZXg6IFdlYkNvcmUvcGFnZS9jaHJvbWl1bS9DaHJvbWVDbGllbnRDaHJvbWl1 bS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9jaHJvbWl1bS9DaHJvbWVDbGllbnRDaHJv bWl1bS5oCShyZXZpc2lvbiA2ODAwNykKKysrIFdlYkNvcmUvcGFnZS9jaHJvbWl1bS9DaHJvbWVD bGllbnRDaHJvbWl1bS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMSwxMiArMzEsMTAgQEAKICNpZm5k ZWYgQ2hyb21lQ2xpZW50Q2hyb21pdW1faAogI2RlZmluZSBDaHJvbWVDbGllbnRDaHJvbWl1bV9o CiAKLSNpbmNsdWRlICJBWE9iamVjdENhY2hlLmgiCiAjaW5jbHVkZSAiQ2hyb21lQ2xpZW50Lmgi CiAjaW5jbHVkZSA8d3RmL0ZvcndhcmQuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewotY2xhc3Mg QWNjZXNzaWJpbGl0eU9iamVjdDsKIGNsYXNzIEludFJlY3Q7CiBjbGFzcyBQb3B1cENvbnRhaW5l cjsKIApAQCAtNTMsMTUgKzUxLDYgQEAgcHVibGljOgogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAKICAgICAvLyBOb3RpZmllcyB0aGUgY2xpZW50IGEgcG9wdXAgd2FzIGNsb3NlZC4KICAg ICB2aXJ0dWFsIHZvaWQgcG9wdXBDbG9zZWQoUG9wdXBDb250YWluZXIqIHBvcHVwQ29udGFpbmVy KSA9IDA7Ci0KLSAgICAvLyBOb3RpZmllcyBlbWJlZGRlciB0aGF0IHRoZSBzdGF0ZSBvZiBhbiBh Y2Nlc3NpYmlsaXR5IG9iamVjdCBoYXMgY2hhbmdlZC4KLSAgICB2aXJ0dWFsIHZvaWQgZGlkQ2hh bmdlQWNjZXNzaWJpbGl0eU9iamVjdFN0YXRlKEFjY2Vzc2liaWxpdHlPYmplY3QqKSA9IDA7Ci0g ICAgCi0gICAgLy8gTm90aWZpZWQgZW1iZWRkZXIgdGhhdCB0aGUgY2hpbGRyZW4gb2YgYW4gYWNj ZXNzaWJpbGl0eSBvYmplY3QgaGFzIGNoYW5nZWQuCi0gICAgdmlydHVhbCB2b2lkIGRpZENoYW5n ZUFjY2Vzc2liaWxpdHlPYmplY3RDaGlsZHJlbihBY2Nlc3NpYmlsaXR5T2JqZWN0KikgPSAwOwot ICAgIAotICAgIC8vIE5vdGlmaWVzIGVtYmVkZGVyIGFib3V0IGFuIGFjY2Vzc2liaWxpdHkgbm90 aWZpY2F0aW9uLgotICAgIHZpcnR1YWwgdm9pZCBwb3N0QWNjZXNzaWJpbGl0eU5vdGlmaWNhdGlv bihBY2Nlc3NpYmlsaXR5T2JqZWN0KiwgQVhPYmplY3RDYWNoZTo6QVhOb3RpZmljYXRpb24pID0g MDsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK