46230 2010-09-21 16:35:29 -0700 [chromium] REGRESSION(r67905): DRT test shell ALWAYS crashes on Mac 2010-09-21 17:38:46 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All OS X 10.6 RESOLVED FIXED P1 Major --- 1 rniwa dpranke abarth dpranke eric ojan tkent tony oldest_to_newest 282632 0 rniwa 2010-09-21 16:35:29 -0700 chromium DRT crashes for all tests on Mac with the error "--pixel-tests with --test-shell requires a file name." See http://build.webkit.org/builders/Chromium%20Mac%20Release%20(Tests)/builds/2160/steps/layout-test/logs/stdio for how this bug is affecting the cr-mac bot. 282642 1 rniwa 2010-09-21 16:46:24 -0700 The root cause seems to be http://trac.webkit.org/changeset/67905. 282658 2 68311 dpranke 2010-09-21 17:04:46 -0700 Created attachment 68311 Patch 282661 3 dpranke 2010-09-21 17:07:18 -0700 Committed r67993: <http://trac.webkit.org/changeset/67993> 282668 4 68311 tony 2010-09-21 17:12:42 -0700 Comment on attachment 68311 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68311&action=review Removing the review flag since this was checked in, however: > WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py:418 > + driver_args.append('--pixel-tests' % image_path) This can't be right. 282690 5 dpranke 2010-09-21 17:33:22 -0700 Committed r67999: <http://trac.webkit.org/changeset/67999> 282697 6 dpranke 2010-09-21 17:38:17 -0700 (In reply to comment #4) > (From update of attachment 68311 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=68311&action=review > > Removing the review flag since this was checked in, however: > > > WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py:418 > > + driver_args.append('--pixel-tests' % image_path) > > This can't be right. True, it wasn't :( 282699 7 dpranke 2010-09-21 17:38:46 -0700 I think r67999 is the right fix. I will watch the bots to find out. 68311 2010-09-21 17:04:46 -0700 2010-09-21 17:12:42 -0700 Patch bug-46230-20100921170445.patch text/plain 1659 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhYWRhMDQ1NWY1YmYwOTA3OWViNDk2Y2Q0Zjg4ZmUzNjVhZmM4OWIxLi44Mzk2MTU5 NWE1Y2U1Y2IxOGUzNDI2OWZmNTc3MmEwMjExMDY4OGYxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTYgQEAK IAogICAgICAgICBVbnJldmlld2VkLCBidWlsZCBmaXguCiAKKyAgICAgICAgRml4IGJyZWFrYWdl IG9mIENocm9taXVtIE1hYyBEUlQgcG9ydCBjYXVzZWQgYnkgcjY3OTA1LgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjIzMAorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHk6CisKKzIwMTAtMDkt MjEgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVW5yZXZp ZXdlZCwgYnVpbGQgZml4LgorCiAgICAgICAgIEFkZCBtaXNzaW5nIGltcG9ydCBvZiAndGVtcGZp bGUnLgogCiAgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJv bWl1bS5weToKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvd2Via2l0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC93ZWJraXQucHkKaW5kZXggZWI4ZWU1ZjVlOThjNzVmMGE2YTQwNjNlMTU5 NWM4YTg5MGE3N2RmYy4uNDcxZGY3MDExMTc0YjdjZDRhYTRlZjFiYWQ1YWUwNDdiZmIzNmI0MiAx MDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC93ZWJraXQucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC93ZWJraXQucHkKQEAgLTQxMCwxMiArNDEwLDE3IEBAIGNsYXNzIFdlYktpdERyaXZl cihiYXNlLkRyaXZlcik6CiAKICAgICBkZWYgX2RyaXZlcl9hcmdzKHNlbGYpOgogICAgICAgICBk cml2ZXJfYXJncyA9IFtdCi0gICAgICAgIGlmIHNlbGYuX2ltYWdlX3BhdGg6Ci0gICAgICAgICAg ICBkcml2ZXJfYXJncy5hcHBlbmQoJy0tcGl4ZWwtdGVzdHMnKQogCi0gICAgICAgICMgVGhlc2Ug YXJlIHVzZWQgYnkgdGhlIENocm9taXVtIERSVCBwb3J0CiAgICAgICAgIGlmIHNlbGYuX29wdGlv bnMudXNlX2RydDoKKyAgICAgICAgICAgICMgVGhlc2UgYXJlIHVzZWQgYnkgdGhlIENocm9taXVt IERSVCBwb3J0CiAgICAgICAgICAgICBkcml2ZXJfYXJncy5hcHBlbmQoJy0tdGVzdC1zaGVsbCcp CisgICAgICAgICAgICBpZiBzZWxmLl9pbWFnZV9wYXRoOgorICAgICAgICAgICAgICAgIGRyaXZl cl9hcmdzLmFwcGVuZCgnLS1waXhlbC10ZXN0cycgJSBpbWFnZV9wYXRoKQorICAgICAgICBlbHNl OgorICAgICAgICAgICAgIyBSZWd1bGFyIERSVCBwb3J0cy4KKyAgICAgICAgICAgIGlmIHNlbGYu X2ltYWdlX3BhdGg6CisgICAgICAgICAgICAgICAgZHJpdmVyX2FyZ3MuYXBwZW5kKCctLXBpeGVs LXRlc3RzJykKKwogICAgICAgICByZXR1cm4gZHJpdmVyX2FyZ3MKIAogICAgIGRlZiBzdGFydChz ZWxmKToK